Re: [Audacity-quality] Theming problems with Mixer board and pan sliders

[Cliff Scott <flyer185@gm...>]

> On Jun 22, 2017, at 3:58 PM, James Crook <crookj@...> wrote:
> 
> On 6/22/2017 9:18 PM, Cliff Scott wrote:
>>> On Jun 22, 2017, at 2:14 PM, James Crook <crookj@...> wrote:
>>> 
>>> On 6/22/2017 6:15 PM, Paul Licameli wrote:
>>>> On Thu, Jun 22, 2017 at 12:24 PM, Cliff Scott <flyer185@...> wrote:
>>>> 
>>>>> Just did a build and on my Mac the Mixer Board looks much better in Hi
>>>>> Contrast, but I noticed that the edit mouse cursor (vertical line with
>>>>> crosses top and bottom), which is normally black continues to be black and
>>>>> therefore is invisible unless it crosses an item that causes it to change
>>>>> shape then it can be seen for a moment until it get past that item. Seems
>>>>> as if the edit cursor color should change to have a contrasting color to
>>>>> the background or a white outline to make it visible. The other themes are
>>>>> ok, though the Dark theme doesn't have a lot of cursor contrast.
>>>>> 
>>>>> Cliff
>>>>> 
>>>> And I add, that on Mac, that minor problem of the background of 'L' and 'R'
>>>> remains.
>>>> 
>>>> PRL
>>> The lack of cursor outlines (on Mac) and the L & R issue (on Mac) should now be fixed in HEAD.  Working fine for me now on Mac.
>>> 
>>> --James.
>>> 
>> Much better! Would it be possible to make the white outline thinner? It's quite useable as it is, but I notice that the normal Mac mouse arrow cursor is also outlined by the OS and it is a little thinner which helps with placement accuracy.
> Chances are this is because we are using 16x16 cursors on mac, and 'nowadays' we could actually use the 32x32 cursors that we use on Windows!
> 
> 
> Perhaps give it a try and report back?
> 
> In \Images\Cursors.h we have this at the top of the file:
> 
> // Mac only supports 16x16 pixel cursors.
> #ifdef __WXMAC__
> #define CURSORS_SIZE16
> #else
> #define CURSORS_SIZE32
> #endif
> 
> 
> 
> Try making mac 32 as well?
> 

Did that and I like it. Much cleaner looking.

Don't know why I didn't notice it before, but we have a problem with the color of the edit cursor when clicking on a wave form. The playback cursor is fine, but click on the waveform which should leave a edit cursor, but in Hi Contrast it is invisible. In the other themes the playback and edit cursors appear to be the same color so shouldn't that be the same in this case?

Cliff

Re: [Audacity-quality] Theming problems with Mixer board and pan sliders

[James Crook <crookj@in...>]

On 6/22/2017 9:18 PM, Cliff Scott wrote:
>> On Jun 22, 2017, at 2:14 PM, James Crook <crookj@...> wrote:
>>
>> On 6/22/2017 6:15 PM, Paul Licameli wrote:
>>> On Thu, Jun 22, 2017 at 12:24 PM, Cliff Scott <flyer185@...> wrote:
>>>
>>>> Just did a build and on my Mac the Mixer Board looks much better in Hi
>>>> Contrast, but I noticed that the edit mouse cursor (vertical line with
>>>> crosses top and bottom), which is normally black continues to be black and
>>>> therefore is invisible unless it crosses an item that causes it to change
>>>> shape then it can be seen for a moment until it get past that item. Seems
>>>> as if the edit cursor color should change to have a contrasting color to
>>>> the background or a white outline to make it visible. The other themes are
>>>> ok, though the Dark theme doesn't have a lot of cursor contrast.
>>>>
>>>> Cliff
>>>>
>>> And I add, that on Mac, that minor problem of the background of 'L' and 'R'
>>> remains.
>>>
>>> PRL
>> The lack of cursor outlines (on Mac) and the L & R issue (on Mac) should now be fixed in HEAD.  Working fine for me now on Mac.
>>
>> --James.
>>
> Much better! Would it be possible to make the white outline thinner? It's quite useable as it is, but I notice that the normal Mac mouse arrow cursor is also outlined by the OS and it is a little thinner which helps with placement accuracy.
Chances are this is because we are using 16x16 cursors on mac, and 
'nowadays' we could actually use the 32x32 cursors that we use on Windows!


Perhaps give it a try and report back?

In \Images\Cursors.h we have this at the top of the file:

// Mac only supports 16x16 pixel cursors.
#ifdef __WXMAC__
#define CURSORS_SIZE16
#else
#define CURSORS_SIZE32
#endif



Try making mac 32 as well?


>
> Cliff
>
>
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> Audacity-quality mailing list
> Audacity-quality@...
> https://lists.sourceforge.net/lists/listinfo/audacity-quality
>
>

Re: [Audacity-quality] Images changes

[James Crook <crookj@in...>]

On 6/22/2017 8:24 PM, Paul Licameli wrote:
> I am contemplating some changes to images.
>
> First, as noted elsewhere, the expanded highlight image, though not yet
> used, is wrong in Classic and I thought I might just copy the Light version.
>
> Secondly, I may want to define highlighted versions of the slider thumbs.
> There are two of those per theme, one for vertical and one for horizontal.
> So, eight small new images.
>
> Would James rather do this, being more adept at image editing and with more
> precise ideas about what is consistent with the intent of each theme?
I would like to do not much more than what we feel we HAVE to do to the 
themes to release 2.2.0.

I feel there is a lot of potential optional additional change to themes, 
e.g. new hover for all hoverable things up-and-down versions (and 
possibly selected/unselected too), preparation for Multibuttons, 
including of the mac cursors in ImageCache, including the help icon into 
the ImageCache to decrinkle it, making the grabbers in the theme 
actually usable, making the docking marker themable... and so on.   If 
we have highlighted slider thumbs I would like to have the possibility 
of them being bigger when highlighted.

Theme tweaking takes a tremendous amount of time, especially when done 
incrementally in many little steps.  I really want to batch things up, 
and have a clear list of what we want to add.  Then we can also look at 
rearranging the ImageCache a second time, to make the order more logical.

Once 2.2.0 is out I am hoping we will find someone new to take ownership 
of the Hi-Contrast theme.  My problem is that I find it eye-popping 
rather than helpful, and so I am not a good judge of what works well for 
people who would benefit from the theme.  I also suspect that needs will 
vary greatly from one person to another, especially around differences 
in colour vision.

I would like to add a simple mechanism so that when we add new images 
and colours to Light or Dark themes, Classic and Hi-Contrast will use 
those, IF they don't define them themselves.  That way we will not be 
breaking Classic and Hi-Contrast each time we add a new image.  At the 
moment each change takes '4 times as long' as it has to be done in 4 themes.

I also have some plans for procedural generation of derived images. For 
example, the trim and silence icons should reflect the colours of the 
wave.  Some images are rotated versions of others (but note that because 
of shadows, rotated slider thumb isn't).  The general idea is that we 
can 'leave out' the procedurally generated images, and they will be 
added automatically, but if we want a custom image there, we can.



If I've not put you off doing some highlighting for 2.2.0, then can you 
add/modify the images you need?

--James.

Re: [Audacity-quality] HiliteButtonExpand.png in Classic theme looks wrong

[Paul Licameli <paul.licameli@gm...>]

On Thu, Jun 22, 2017 at 3:24 PM, James Crook <crookj@...> wrote:

> On 6/22/2017 5:07 PM, Paul Licameli wrote:
>
>> This image looks like it was intended for Dark or High Contrast.
>>
>> It is not used for anything, yet.  But if I make highlighting of track
>> control panel buttons a reality, then it will be.
>>
>> Shall I copy the file from Light theme and fix it myself?  Or does James
>> have other ideas for the proper image?
>>
> I would like the highlighted version (in each theme) to be 'like' the
> highlight for the transport toolbar buttons (in each theme).
>
> Are you planning to replace Mute and Solo by AButtons?  If so I think it
> may be a bigger task than you anticipate to make the change, and perhaps
> best postponed till after 2.2.0 is out.
>

No!

Since the substitute "buttons" of TrackPanel are used for five things
(close, minimize, and menu too), I thought maybe the better thing to do
would be the opposite -- make MixerTrackCluster paint its mute and solo the
same way, and use shared routines.

But I don't mean that for 2.2.0 either!

PRL



>
> N.B.  MixerBoard does not currently use a different image for hover - it
> just re-uses the up version.
> We should think about modifying AButton so it can highlight a button that
> is down as well as one that is up.
>
> --James.
>
>
> ------------------------------------------------------------
> ------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> Audacity-quality mailing list
> Audacity-quality@...
> https://lists.sourceforge.net/lists/listinfo/audacity-quality
>

Re: [Audacity-quality] Theming problems with Mixer board and pan sliders

[Cliff Scott <flyer185@gm...>]

> On Jun 22, 2017, at 2:14 PM, James Crook <crookj@...> wrote:
> 
> On 6/22/2017 6:15 PM, Paul Licameli wrote:
>> On Thu, Jun 22, 2017 at 12:24 PM, Cliff Scott <flyer185@...> wrote:
>> 
>>> Just did a build and on my Mac the Mixer Board looks much better in Hi
>>> Contrast, but I noticed that the edit mouse cursor (vertical line with
>>> crosses top and bottom), which is normally black continues to be black and
>>> therefore is invisible unless it crosses an item that causes it to change
>>> shape then it can be seen for a moment until it get past that item. Seems
>>> as if the edit cursor color should change to have a contrasting color to
>>> the background or a white outline to make it visible. The other themes are
>>> ok, though the Dark theme doesn't have a lot of cursor contrast.
>>> 
>>> Cliff
>>> 
>> And I add, that on Mac, that minor problem of the background of 'L' and 'R'
>> remains.
>> 
>> PRL
> 
> The lack of cursor outlines (on Mac) and the L & R issue (on Mac) should now be fixed in HEAD.  Working fine for me now on Mac.
> 
> --James.
> 

Much better! Would it be possible to make the white outline thinner? It's quite useable as it is, but I notice that the normal Mac mouse arrow cursor is also outlined by the OS and it is a little thinner which helps with placement accuracy.

Cliff

[Audacity-quality] Images changes

[Paul Licameli <paul.licameli@gm...>]

I am contemplating some changes to images.

First, as noted elsewhere, the expanded highlight image, though not yet
used, is wrong in Classic and I thought I might just copy the Light version.

Secondly, I may want to define highlighted versions of the slider thumbs.
There are two of those per theme, one for vertical and one for horizontal.
So, eight small new images.

Would James rather do this, being more adept at image editing and with more
precise ideas about what is consistent with the intent of each theme?

PRL

Re: [Audacity-quality] HiliteButtonExpand.png in Classic theme looks wrong

[James Crook <crookj@in...>]

On 6/22/2017 5:07 PM, Paul Licameli wrote:
> This image looks like it was intended for Dark or High Contrast.
>
> It is not used for anything, yet.  But if I make highlighting of track
> control panel buttons a reality, then it will be.
>
> Shall I copy the file from Light theme and fix it myself?  Or does James
> have other ideas for the proper image?
I would like the highlighted version (in each theme) to be 'like' the 
highlight for the transport toolbar buttons (in each theme).

Are you planning to replace Mute and Solo by AButtons?  If so I think it 
may be a bigger task than you anticipate to make the change, and perhaps 
best postponed till after 2.2.0 is out.

N.B.  MixerBoard does not currently use a different image for hover - it 
just re-uses the up version.
We should think about modifying AButton so it can highlight a button 
that is down as well as one that is up.

--James.

Re: [Audacity-quality] Theming problems with Mixer board and pan sliders

[James Crook <crookj@in...>]

On 6/22/2017 6:15 PM, Paul Licameli wrote:
> On Thu, Jun 22, 2017 at 12:24 PM, Cliff Scott <flyer185@...> wrote:
>
>> Just did a build and on my Mac the Mixer Board looks much better in Hi
>> Contrast, but I noticed that the edit mouse cursor (vertical line with
>> crosses top and bottom), which is normally black continues to be black and
>> therefore is invisible unless it crosses an item that causes it to change
>> shape then it can be seen for a moment until it get past that item. Seems
>> as if the edit cursor color should change to have a contrasting color to
>> the background or a white outline to make it visible. The other themes are
>> ok, though the Dark theme doesn't have a lot of cursor contrast.
>>
>> Cliff
>>
> And I add, that on Mac, that minor problem of the background of 'L' and 'R'
> remains.
>
> PRL

The lack of cursor outlines (on Mac) and the L & R issue (on Mac) should 
now be fixed in HEAD.  Working fine for me now on Mac.

--James.

Re: [Audacity-quality] Theming problems with Mixer board and pan sliders

[Cliff Scott <flyer185@gm...>]

> On Jun 22, 2017, at 12:15 PM, Paul Licameli <paul.licameli@...> wrote:
> 
> 
> 
> On Thu, Jun 22, 2017 at 12:24 PM, Cliff Scott <flyer185@... <mailto:flyer185@...>> wrote:
> Just did a build and on my Mac the Mixer Board looks much better in Hi Contrast, but I noticed that the edit mouse cursor (vertical line with crosses top and bottom), which is normally black continues to be black and therefore is invisible unless it crosses an item that causes it to change shape then it can be seen for a moment until it get past that item. Seems as if the edit cursor color should change to have a contrasting color to the background or a white outline to make it visible. The other themes are ok, though the Dark theme doesn't have a lot of cursor contrast.
> 
> Cliff
> 
> And I add, that on Mac, that minor problem of the background of 'L' and 'R' remains.
> 
> PRL

Yes, the L & R in the TCP with black backgrounds are very hard to read.

Also the buttons on the mixer bar have problems with contrast, again in Hi Contrast. Click on the Mute and the background goes very light and the lettering becomes almost invisible. Same for Solo.

Is it the designed behavior that turning off Mute turns on Solo in the case of only one track? Seems strange to me. While Mute off does imply Solo, the Solo was not on until the Mute is turned off then it stays on when ever Mute is off. Not a big problem, but seems kind of funky. To be consistent the Solo should be on initially when only one track is present, Stereo or Mono, and then go off when Mute is pressed.

Cliff
> 
>  
> > On Jun 22, 2017, at 10:57 AM, James Crook <crookj@... <mailto:crookj@...>> wrote:
> >
> > On 6/22/2017 4:42 PM, Paul Licameli wrote:
> >> On Thu, Jun 22, 2017 at 11:17 AM, James Crook <crookj@... <mailto:crookj@...>> wrote:
> >>
> >>> Fixed?
> >>>
> >> It looks good to me now on Mac.
> >>
> >> And right on your heels, I have fixed the unrelated mixer board problem, of
> >> duplication of stereo tracks.
> >
> > Cool.
> > Could you look at http://bugzilla.audacityteam.org/show_bug.cgi?id=1665 <http://bugzilla.audacityteam.org/show_bug.cgi?id=1665>; ?  It's a P1, and I'm not sure you know/knew about it.
> > --James.
> >
> >
> >>
> >>
> >>> Latest HEAD now themes MixerBoard OK for me on Mac, and should likewise be
> >>> OK on Linux too.  i.e. after commit:
> >>> https://github.com/audacity/audacity/commit/389e286c78cecf8e232716f4704cf7 <https://github.com/audacity/audacity/commit/389e286c78cecf8e232716f4704cf7>;
> >>> 081aa5a885
> >>>
> >>> The ASSERT was a helpful clue as to why a font colour was not 'taking' in
> >>> mute/solo buttons.  Thanks Steve.
> >>> The main change though was that part of AColour was unthemed for
> >>> Mac/Linux.  I hadn't noticed because only MixerBoard used that part.
> >>>
> >>> Slightly off topic: We create more Pens and Brushes than we need to, and
> >>> code could be cleaned up quite a bit by not doing so.  I think the reason
> >>> it was done is because of mistaken past belief about drawing speed.
> >>> Creating Pens and Brushes IS very slow, and too slow to do in an inner
> >>> drawing loop.  However modifying the colour of an exisiting Pen or Brush is
> >>> quick, and so we could just use one pen and brush, the sparePen and
> >>> spareBrush, all the time and change their colour.  I.e. we could use the
> >>> function AColour::UseThemeColour() a lot more and dispense with the many
> >>> other pens and brushes.  Not keen on doing that for 2.2.0, since largely we
> >>> have the pens and brushes working fine.
> >>>
> >>>
> >> Not the same thing, but another thing that bothers me about much drawing
> >> code is carelessness about net side effects on the drawing context.  It
> >> would be nicer to use some RAII style to scope the changes in brushes and
> >> pens.
> >>
> >> PRL
> >>
> >>
> >>
> >>> --James.
> >>>
> >>>
> >>>
> >>>
> >>>
> >>> On 6/22/2017 2:31 PM, Paul Licameli wrote:
> >>>
> >>> On Thu, Jun 22, 2017 at 8:15 AM, Steve the Fiddle <stevethefiddle@... <mailto:stevethefiddle@...>> <stevethefiddle@... <mailto:stevethefiddle@...>>
> >>> wrote:
> >>>
> >>>
> >>> Testing on Linux (Xubuntu) debug buildhttps://github.com/audacity/audacity/commit/86901a00a1aa <http://github.com/audacity/audacity/commit/86901a00a1aa>;
> >>>
> >>> No I don't get duplicate audio tracks.
> >>>
> >>> Yes the text on the buttons is hard to read in Dark theme:
> >>>
> >>>
> >>> Enabling / disabling the Blend system does not affect the button text
> >>> contrast (it looks the same regardless).
> >>>
> >>> The Mixer board theme now updates when the theme is changed in preferences.
> >>>
> >>> There's an assert on changing the Theme when the Mixer board is open.
> >>> Backtrace attached.
> >>>
> >>> Steve
> >>>
> >>>
> >>> What I see on Mac is different.  The background is still a pale gray,
> >>> whatever the theme.  "Audio" and the numbers on the meter are hard to read.
> >>>
> >>> I have not tried latest head.
> >>>
> >>> PRL
> >>>
> >>>
> >>>
> >>> ​
> >>>
> >>> On 22 June 2017 at 12:55, Peter Sampson <petersampsonaudacity@... <mailto:petersampsonaudacity@...>> <petersampsonaudacity@... <mailto:petersampsonaudacity@...>>
> >>> wrote:
> >>>
> >>>
> >>> On Thu, Jun 22, 2017 at 12:37 PM, Peter Sampson <petersampsonaudacity@... <mailto:petersampsonaudacity@...>> wrote:
> >>>
> >>>
> >>> In general the Mixer Board has a lot of defects that need fixing.
> >>>
> >>>
> >>> And now I seem to have found another one - now when I turn on the Mixer
> >>> Board
> >>> I get not one but two instances of each audio track.
> >>>
> >>> Both instances respond to the signal levels in the track when playing.
> >>>
> >>> Anybody else seeing this ?
> >>>
> >>> I suspect that Gale will regard this as more than P4/P3 - it is a
> >>> regression on 2.1.3
> >>> Fo my money it would be a show-stopper P1 - it just looks darn silly -
> >>> and wastes
> >>> valuable Mixer Board screen real-estate.
> >>>
> >>> Peter.
> >>>
> >>>
> >>>
> >>>
> >>> See this page I put together on the Wiki a while back:http://wiki.audacityteam.org/wiki/User:PeterSampson/Mixer_Board_issues <http://wiki.audacityteam.org/wiki/User:PeterSampson/Mixer_Board_issues>;
> >>> Eight Bugzilla bugs, five of which are P3 release noted.
> >>>
> >>> Peter.
> >>>
> >>> On Thu, Jun 22, 2017 at 12:33 PM, Steve the Fiddle <stevethefiddle@... <mailto:stevethefiddle@...>> wrote:
> >>>
> >>>
> >>> On 22 June 2017 at 11:28, Paul Licameli <paul.licameli@... <mailto:paul.licameli@...>> <paul.licameli@... <mailto:paul.licameli@...>>
> >>> wrote:
> >>>
> >>>
> >>> On Thu, Jun 22, 2017 at 5:42 AM, Peter Sampson <petersampsonaudacity@... <mailto:petersampsonaudacity@...>> wrote:
> >>>
> >>>
> >>> I'm thinking here that a user deciding to switch themes in the middle
> >>> of a session with Mixer Board is unlikely to be switching themes - so
> >>> this is a bit of a fringe case.
> >>>
> >>> I'm suspecting that most users will select a theme and then stick
> >>> with it.
> >>> More than that I'm suspecting that most users will stick with the new
> >>> Light theme that we present them with as the default for 2.2.0.
> >>>
> >>> This does not mean that this would not be a "nice to fix" - but it
> >>> should be
> >>> logged on Bugzilla - and personally I can't see it rating more than
> >>> P4, maybe
> >>> P3 if we decide we want it release noted.
> >>>
> >>>
> >>> I tell you it's not a fringe case -- I say that if you start Audacity
> >>> in Dark or Hi Contrast theme, and open the mixer board, then the names and
> >>> numbers are illegible because they contrast too weakly with the
> >>> background.  Contrary to what James said, I see this problem even without
> >>> any change of themes during the session.  That part of the problem, at
> >>> least, needs a fix.
> >>>
> >>>
> >>> Mixer board on Linux the contrast between button and button text is
> >>> very low (hard to read "Mute" and  "Solo"). I agree that this part is not
> >>> "fringe".
> >>>
> >>> When changing themes, the Mixer board does not fully update until
> >>> Audacity is restarted. I agree with Peter that this part is closer to the
> >>> fringe, but would be good to fix for 2.2.0 if possible.
> >>>
> >>> Also, on opening the Mixer board the first time in a session, in Debug
> >>> build, there is an assert (see attached).
> >>>
> >>> Steve
> >>>
> >>>
> >>>
> >>> PRL
> >>>
> >>>
> >>>
> >>>
> >>> Peter.
> >>>
> >>> On Wed, Jun 21, 2017 at 11:23 PM, James Crook <crookj@... <mailto:crookj@...>> <crookj@... <mailto:crookj@...>>
> >>> wrote:
> >>>
> >>>
> >>> On 6/21/2017 10:23 PM, Paul Licameli wrote:
> >>>
> >>> I started Audacity in Hi Contrast theme.  I generated noise and opened the
> >>> Mixer board.
> >>>
> >>> No.  You started in classic theme and then switched to Hi Contrast.
> >>>
> >>>
> >>>    - The green text of "Audio Track" contrasts poorly with a gray
> >>>    background that is unchanged from Classic theme.  So it seems the
> >>>    repainting of Mixer Board was missed by the theming project.
> >>>
> >>> Correct.  Mixer board caches lots of its colours rather than
> >>> fetching them as needed.
> >>> I can go in and change that.  Not too hard to do.
> >>>
> >>>    - Then I changed theme back to Classic in preferences.  The still open
> >>>    Mixer board did not update, except for the numbers on the meter.
> >>>    - I made a new track.  Now I see two mixer sliders with different themes!
> >>>    - I close and reopen the Mixer board window, and I still see the same.
> >>>    - I can change theme, add a track, and then see the Mixer board again,
> >>>    and repeat, and so even make one slider in each of four themes.
> >>>
> >>> Oh, that's cute.  I hadn't realised quite how much caching of
> >>> pens/brushes Mixer board was doing.  Sounds like it is creating new brushes
> >>> for each track.
> >>>
> >>>
> >>>    - Light theme looks tolerable, but numbers and text in Dark are even
> >>>    less legible than for Hi Contrast.
> >>>
> >>> Well, yes, when you have a mix of themes in action.  If you select a
> >>> theme and restart Audacity it should look about as good/bad as the main
> >>> TrackPanel.
> >>>
> >>>
> >>>    - A general problem, with both Mixer boards and TCP, is that the little
> >>>    L and R appear with a small box of mis-matched background color when the
> >>>    track is selected.
> >>>
> >>> I don't see this on Windows, but yes, it is easy enough to fix.
> >>>
> >>> The + and - of gain don't do this.  (I see those are
> >>>    actually drawn differently, by actually stroking three little lines, not by
> >>>    use of fonts!)  Is there a simple way to get transparency for the
> >>>    background of text?  Was that neglected?
> >>>
> >>> You still need to set the right background colour to get the right
> >>> anti-aliassing of text, so it must be I didn't set the correct background
> >>> colour.   Will fix presently.
> >>>
> >>> --James.
> >>>
> >>>
> >>> PRL
> >
> >
> > ------------------------------------------------------------------------------
> > Check out the vibrant tech community on one of the world's most
> > engaging tech sites, Slashdot.org! http://sdm.link/slashdot <http://sdm.link/slashdot>;
> > _______________________________________________
> > Audacity-quality mailing list
> > Audacity-quality@... <mailto:Audacity-quality@...>
> > https://lists.sourceforge.net/lists/listinfo/audacity-quality <https://lists.sourceforge.net/lists/listinfo/audacity-quality>;
> 
> 
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot <http://sdm.link/slashdot>;
> _______________________________________________
> Audacity-quality mailing list
> Audacity-quality@... <mailto:Audacity-quality@...>
> https://lists.sourceforge.net/lists/listinfo/audacity-quality <https://lists.sourceforge.net/lists/listinfo/audacity-quality>;
> 
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot_______________________________________________
> Audacity-quality mailing list
> Audacity-quality@...
> https://lists.sourceforge.net/lists/listinfo/audacity-quality

Re: [Audacity-quality] Theming problems with Mixer board and pan sliders

[Paul Licameli <paul.licameli@gm...>]

On Thu, Jun 22, 2017 at 12:24 PM, Cliff Scott <flyer185@...> wrote:

> Just did a build and on my Mac the Mixer Board looks much better in Hi
> Contrast, but I noticed that the edit mouse cursor (vertical line with
> crosses top and bottom), which is normally black continues to be black and
> therefore is invisible unless it crosses an item that causes it to change
> shape then it can be seen for a moment until it get past that item. Seems
> as if the edit cursor color should change to have a contrasting color to
> the background or a white outline to make it visible. The other themes are
> ok, though the Dark theme doesn't have a lot of cursor contrast.
>
> Cliff
>

And I add, that on Mac, that minor problem of the background of 'L' and 'R'
remains.

PRL



> > On Jun 22, 2017, at 10:57 AM, James Crook <crookj@...> wrote:
> >
> > On 6/22/2017 4:42 PM, Paul Licameli wrote:
> >> On Thu, Jun 22, 2017 at 11:17 AM, James Crook <crookj@...> wrote:
> >>
> >>> Fixed?
> >>>
> >> It looks good to me now on Mac.
> >>
> >> And right on your heels, I have fixed the unrelated mixer board
> problem, of
> >> duplication of stereo tracks.
> >
> > Cool.
> > Could you look at http://bugzilla.audacityteam.org/show_bug.cgi?id=1665
> ?  It's a P1, and I'm not sure you know/knew about it.
> > --James.
> >
> >
> >>
> >>
> >>> Latest HEAD now themes MixerBoard OK for me on Mac, and should
> likewise be
> >>> OK on Linux too.  i.e. after commit:
> >>> https://github.com/audacity/audacity/commit/
> 389e286c78cecf8e232716f4704cf7
> >>> 081aa5a885
> >>>
> >>> The ASSERT was a helpful clue as to why a font colour was not 'taking'
> in
> >>> mute/solo buttons.  Thanks Steve.
> >>> The main change though was that part of AColour was unthemed for
> >>> Mac/Linux.  I hadn't noticed because only MixerBoard used that part.
> >>>
> >>> Slightly off topic: We create more Pens and Brushes than we need to,
> and
> >>> code could be cleaned up quite a bit by not doing so.  I think the
> reason
> >>> it was done is because of mistaken past belief about drawing speed.
> >>> Creating Pens and Brushes IS very slow, and too slow to do in an inner
> >>> drawing loop.  However modifying the colour of an exisiting Pen or
> Brush is
> >>> quick, and so we could just use one pen and brush, the sparePen and
> >>> spareBrush, all the time and change their colour.  I.e. we could use
> the
> >>> function AColour::UseThemeColour() a lot more and dispense with the
> many
> >>> other pens and brushes.  Not keen on doing that for 2.2.0, since
> largely we
> >>> have the pens and brushes working fine.
> >>>
> >>>
> >> Not the same thing, but another thing that bothers me about much drawing
> >> code is carelessness about net side effects on the drawing context.  It
> >> would be nicer to use some RAII style to scope the changes in brushes
> and
> >> pens.
> >>
> >> PRL
> >>
> >>
> >>
> >>> --James.
> >>>
> >>>
> >>>
> >>>
> >>>
> >>> On 6/22/2017 2:31 PM, Paul Licameli wrote:
> >>>
> >>> On Thu, Jun 22, 2017 at 8:15 AM, Steve the Fiddle <
> stevethefiddle@...> <stevethefiddle@...>
> >>> wrote:
> >>>
> >>>
> >>> Testing on Linux (Xubuntu) debug buildhttps://github.com/
> audacity/audacity/commit/86901a00a1aa
> >>>
> >>> No I don't get duplicate audio tracks.
> >>>
> >>> Yes the text on the buttons is hard to read in Dark theme:
> >>>
> >>>
> >>> Enabling / disabling the Blend system does not affect the button text
> >>> contrast (it looks the same regardless).
> >>>
> >>> The Mixer board theme now updates when the theme is changed in
> preferences.
> >>>
> >>> There's an assert on changing the Theme when the Mixer board is open.
> >>> Backtrace attached.
> >>>
> >>> Steve
> >>>
> >>>
> >>> What I see on Mac is different.  The background is still a pale gray,
> >>> whatever the theme.  "Audio" and the numbers on the meter are hard to
> read.
> >>>
> >>> I have not tried latest head.
> >>>
> >>> PRL
> >>>
> >>>
> >>>
> >>> ​
> >>>
> >>> On 22 June 2017 at 12:55, Peter Sampson <petersampsonaudacity@...
> com> <petersampsonaudacity@...>
> >>> wrote:
> >>>
> >>>
> >>> On Thu, Jun 22, 2017 at 12:37 PM, Peter Sampson <
> petersampsonaudacity@...> wrote:
> >>>
> >>>
> >>> In general the Mixer Board has a lot of defects that need fixing.
> >>>
> >>>
> >>> And now I seem to have found another one - now when I turn on the Mixer
> >>> Board
> >>> I get not one but two instances of each audio track.
> >>>
> >>> Both instances respond to the signal levels in the track when playing.
> >>>
> >>> Anybody else seeing this ?
> >>>
> >>> I suspect that Gale will regard this as more than P4/P3 - it is a
> >>> regression on 2.1.3
> >>> Fo my money it would be a show-stopper P1 - it just looks darn silly -
> >>> and wastes
> >>> valuable Mixer Board screen real-estate.
> >>>
> >>> Peter.
> >>>
> >>>
> >>>
> >>>
> >>> See this page I put together on the Wiki a while back:
> http://wiki.audacityteam.org/wiki/User:PeterSampson/Mixer_Board_issues
> >>> Eight Bugzilla bugs, five of which are P3 release noted.
> >>>
> >>> Peter.
> >>>
> >>> On Thu, Jun 22, 2017 at 12:33 PM, Steve the Fiddle <
> stevethefiddle@...> wrote:
> >>>
> >>>
> >>> On 22 June 2017 at 11:28, Paul Licameli <paul.licameli@...> <
> paul.licameli@...>
> >>> wrote:
> >>>
> >>>
> >>> On Thu, Jun 22, 2017 at 5:42 AM, Peter Sampson <
> petersampsonaudacity@...> wrote:
> >>>
> >>>
> >>> I'm thinking here that a user deciding to switch themes in the middle
> >>> of a session with Mixer Board is unlikely to be switching themes - so
> >>> this is a bit of a fringe case.
> >>>
> >>> I'm suspecting that most users will select a theme and then stick
> >>> with it.
> >>> More than that I'm suspecting that most users will stick with the new
> >>> Light theme that we present them with as the default for 2.2.0.
> >>>
> >>> This does not mean that this would not be a "nice to fix" - but it
> >>> should be
> >>> logged on Bugzilla - and personally I can't see it rating more than
> >>> P4, maybe
> >>> P3 if we decide we want it release noted.
> >>>
> >>>
> >>> I tell you it's not a fringe case -- I say that if you start Audacity
> >>> in Dark or Hi Contrast theme, and open the mixer board, then the names
> and
> >>> numbers are illegible because they contrast too weakly with the
> >>> background.  Contrary to what James said, I see this problem even
> without
> >>> any change of themes during the session.  That part of the problem, at
> >>> least, needs a fix.
> >>>
> >>>
> >>> Mixer board on Linux the contrast between button and button text is
> >>> very low (hard to read "Mute" and  "Solo"). I agree that this part is
> not
> >>> "fringe".
> >>>
> >>> When changing themes, the Mixer board does not fully update until
> >>> Audacity is restarted. I agree with Peter that this part is closer to
> the
> >>> fringe, but would be good to fix for 2.2.0 if possible.
> >>>
> >>> Also, on opening the Mixer board the first time in a session, in Debug
> >>> build, there is an assert (see attached).
> >>>
> >>> Steve
> >>>
> >>>
> >>>
> >>> PRL
> >>>
> >>>
> >>>
> >>>
> >>> Peter.
> >>>
> >>> On Wed, Jun 21, 2017 at 11:23 PM, James Crook <crookj@...> <
> crookj@...>
> >>> wrote:
> >>>
> >>>
> >>> On 6/21/2017 10:23 PM, Paul Licameli wrote:
> >>>
> >>> I started Audacity in Hi Contrast theme.  I generated noise and opened
> the
> >>> Mixer board.
> >>>
> >>> No.  You started in classic theme and then switched to Hi Contrast.
> >>>
> >>>
> >>>    - The green text of "Audio Track" contrasts poorly with a gray
> >>>    background that is unchanged from Classic theme.  So it seems the
> >>>    repainting of Mixer Board was missed by the theming project.
> >>>
> >>> Correct.  Mixer board caches lots of its colours rather than
> >>> fetching them as needed.
> >>> I can go in and change that.  Not too hard to do.
> >>>
> >>>    - Then I changed theme back to Classic in preferences.  The still
> open
> >>>    Mixer board did not update, except for the numbers on the meter.
> >>>    - I made a new track.  Now I see two mixer sliders with different
> themes!
> >>>    - I close and reopen the Mixer board window, and I still see the
> same.
> >>>    - I can change theme, add a track, and then see the Mixer board
> again,
> >>>    and repeat, and so even make one slider in each of four themes.
> >>>
> >>> Oh, that's cute.  I hadn't realised quite how much caching of
> >>> pens/brushes Mixer board was doing.  Sounds like it is creating new
> brushes
> >>> for each track.
> >>>
> >>>
> >>>    - Light theme looks tolerable, but numbers and text in Dark are even
> >>>    less legible than for Hi Contrast.
> >>>
> >>> Well, yes, when you have a mix of themes in action.  If you select a
> >>> theme and restart Audacity it should look about as good/bad as the main
> >>> TrackPanel.
> >>>
> >>>
> >>>    - A general problem, with both Mixer boards and TCP, is that the
> little
> >>>    L and R appear with a small box of mis-matched background color
> when the
> >>>    track is selected.
> >>>
> >>> I don't see this on Windows, but yes, it is easy enough to fix.
> >>>
> >>> The + and - of gain don't do this.  (I see those are
> >>>    actually drawn differently, by actually stroking three little
> lines, not by
> >>>    use of fonts!)  Is there a simple way to get transparency for the
> >>>    background of text?  Was that neglected?
> >>>
> >>> You still need to set the right background colour to get the right
> >>> anti-aliassing of text, so it must be I didn't set the correct
> background
> >>> colour.   Will fix presently.
> >>>
> >>> --James.
> >>>
> >>>
> >>> PRL
> >
> >
> > ------------------------------------------------------------
> ------------------
> > Check out the vibrant tech community on one of the world's most
> > engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> > _______________________________________________
> > Audacity-quality mailing list
> > Audacity-quality@...
> > https://lists.sourceforge.net/lists/listinfo/audacity-quality
>
>
> ------------------------------------------------------------
> ------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> Audacity-quality mailing list
> Audacity-quality@...
> https://lists.sourceforge.net/lists/listinfo/audacity-quality
>

Re: [Audacity-quality] Theming problems with Mixer board and pan sliders

[Cliff Scott <flyer185@gm...>]

Just did a build and on my Mac the Mixer Board looks much better in Hi Contrast, but I noticed that the edit mouse cursor (vertical line with crosses top and bottom), which is normally black continues to be black and therefore is invisible unless it crosses an item that causes it to change shape then it can be seen for a moment until it get past that item. Seems as if the edit cursor color should change to have a contrasting color to the background or a white outline to make it visible. The other themes are ok, though the Dark theme doesn't have a lot of cursor contrast.

Cliff
> On Jun 22, 2017, at 10:57 AM, James Crook <crookj@...> wrote:
> 
> On 6/22/2017 4:42 PM, Paul Licameli wrote:
>> On Thu, Jun 22, 2017 at 11:17 AM, James Crook <crookj@...> wrote:
>> 
>>> Fixed?
>>> 
>> It looks good to me now on Mac.
>> 
>> And right on your heels, I have fixed the unrelated mixer board problem, of
>> duplication of stereo tracks.
> 
> Cool.
> Could you look at http://bugzilla.audacityteam.org/show_bug.cgi?id=1665 ?  It's a P1, and I'm not sure you know/knew about it.
> --James.
> 
> 
>> 
>> 
>>> Latest HEAD now themes MixerBoard OK for me on Mac, and should likewise be
>>> OK on Linux too.  i.e. after commit:
>>> https://github.com/audacity/audacity/commit/389e286c78cecf8e232716f4704cf7
>>> 081aa5a885
>>> 
>>> The ASSERT was a helpful clue as to why a font colour was not 'taking' in
>>> mute/solo buttons.  Thanks Steve.
>>> The main change though was that part of AColour was unthemed for
>>> Mac/Linux.  I hadn't noticed because only MixerBoard used that part.
>>> 
>>> Slightly off topic: We create more Pens and Brushes than we need to, and
>>> code could be cleaned up quite a bit by not doing so.  I think the reason
>>> it was done is because of mistaken past belief about drawing speed.
>>> Creating Pens and Brushes IS very slow, and too slow to do in an inner
>>> drawing loop.  However modifying the colour of an exisiting Pen or Brush is
>>> quick, and so we could just use one pen and brush, the sparePen and
>>> spareBrush, all the time and change their colour.  I.e. we could use the
>>> function AColour::UseThemeColour() a lot more and dispense with the many
>>> other pens and brushes.  Not keen on doing that for 2.2.0, since largely we
>>> have the pens and brushes working fine.
>>> 
>>> 
>> Not the same thing, but another thing that bothers me about much drawing
>> code is carelessness about net side effects on the drawing context.  It
>> would be nicer to use some RAII style to scope the changes in brushes and
>> pens.
>> 
>> PRL
>> 
>> 
>> 
>>> --James.
>>> 
>>> 
>>> 
>>> 
>>> 
>>> On 6/22/2017 2:31 PM, Paul Licameli wrote:
>>> 
>>> On Thu, Jun 22, 2017 at 8:15 AM, Steve the Fiddle <stevethefiddle@...> <stevethefiddle@...>
>>> wrote:
>>> 
>>> 
>>> Testing on Linux (Xubuntu) debug buildhttps://github.com/audacity/audacity/commit/86901a00a1aa
>>> 
>>> No I don't get duplicate audio tracks.
>>> 
>>> Yes the text on the buttons is hard to read in Dark theme:
>>> 
>>> 
>>> Enabling / disabling the Blend system does not affect the button text
>>> contrast (it looks the same regardless).
>>> 
>>> The Mixer board theme now updates when the theme is changed in preferences.
>>> 
>>> There's an assert on changing the Theme when the Mixer board is open.
>>> Backtrace attached.
>>> 
>>> Steve
>>> 
>>> 
>>> What I see on Mac is different.  The background is still a pale gray,
>>> whatever the theme.  "Audio" and the numbers on the meter are hard to read.
>>> 
>>> I have not tried latest head.
>>> 
>>> PRL
>>> 
>>> 
>>> 
>>> ​
>>> 
>>> On 22 June 2017 at 12:55, Peter Sampson <petersampsonaudacity@...> <petersampsonaudacity@...>
>>> wrote:
>>> 
>>> 
>>> On Thu, Jun 22, 2017 at 12:37 PM, Peter Sampson <petersampsonaudacity@...> wrote:
>>> 
>>> 
>>> In general the Mixer Board has a lot of defects that need fixing.
>>> 
>>> 
>>> And now I seem to have found another one - now when I turn on the Mixer
>>> Board
>>> I get not one but two instances of each audio track.
>>> 
>>> Both instances respond to the signal levels in the track when playing.
>>> 
>>> Anybody else seeing this ?
>>> 
>>> I suspect that Gale will regard this as more than P4/P3 - it is a
>>> regression on 2.1.3
>>> Fo my money it would be a show-stopper P1 - it just looks darn silly -
>>> and wastes
>>> valuable Mixer Board screen real-estate.
>>> 
>>> Peter.
>>> 
>>> 
>>> 
>>> 
>>> See this page I put together on the Wiki a while back:http://wiki.audacityteam.org/wiki/User:PeterSampson/Mixer_Board_issues
>>> Eight Bugzilla bugs, five of which are P3 release noted.
>>> 
>>> Peter.
>>> 
>>> On Thu, Jun 22, 2017 at 12:33 PM, Steve the Fiddle <stevethefiddle@...> wrote:
>>> 
>>> 
>>> On 22 June 2017 at 11:28, Paul Licameli <paul.licameli@...> <paul.licameli@...>
>>> wrote:
>>> 
>>> 
>>> On Thu, Jun 22, 2017 at 5:42 AM, Peter Sampson <petersampsonaudacity@...> wrote:
>>> 
>>> 
>>> I'm thinking here that a user deciding to switch themes in the middle
>>> of a session with Mixer Board is unlikely to be switching themes - so
>>> this is a bit of a fringe case.
>>> 
>>> I'm suspecting that most users will select a theme and then stick
>>> with it.
>>> More than that I'm suspecting that most users will stick with the new
>>> Light theme that we present them with as the default for 2.2.0.
>>> 
>>> This does not mean that this would not be a "nice to fix" - but it
>>> should be
>>> logged on Bugzilla - and personally I can't see it rating more than
>>> P4, maybe
>>> P3 if we decide we want it release noted.
>>> 
>>> 
>>> I tell you it's not a fringe case -- I say that if you start Audacity
>>> in Dark or Hi Contrast theme, and open the mixer board, then the names and
>>> numbers are illegible because they contrast too weakly with the
>>> background.  Contrary to what James said, I see this problem even without
>>> any change of themes during the session.  That part of the problem, at
>>> least, needs a fix.
>>> 
>>> 
>>> Mixer board on Linux the contrast between button and button text is
>>> very low (hard to read "Mute" and  "Solo"). I agree that this part is not
>>> "fringe".
>>> 
>>> When changing themes, the Mixer board does not fully update until
>>> Audacity is restarted. I agree with Peter that this part is closer to the
>>> fringe, but would be good to fix for 2.2.0 if possible.
>>> 
>>> Also, on opening the Mixer board the first time in a session, in Debug
>>> build, there is an assert (see attached).
>>> 
>>> Steve
>>> 
>>> 
>>> 
>>> PRL
>>> 
>>> 
>>> 
>>> 
>>> Peter.
>>> 
>>> On Wed, Jun 21, 2017 at 11:23 PM, James Crook <crookj@...> <crookj@...>
>>> wrote:
>>> 
>>> 
>>> On 6/21/2017 10:23 PM, Paul Licameli wrote:
>>> 
>>> I started Audacity in Hi Contrast theme.  I generated noise and opened the
>>> Mixer board.
>>> 
>>> No.  You started in classic theme and then switched to Hi Contrast.
>>> 
>>> 
>>>    - The green text of "Audio Track" contrasts poorly with a gray
>>>    background that is unchanged from Classic theme.  So it seems the
>>>    repainting of Mixer Board was missed by the theming project.
>>> 
>>> Correct.  Mixer board caches lots of its colours rather than
>>> fetching them as needed.
>>> I can go in and change that.  Not too hard to do.
>>> 
>>>    - Then I changed theme back to Classic in preferences.  The still open
>>>    Mixer board did not update, except for the numbers on the meter.
>>>    - I made a new track.  Now I see two mixer sliders with different themes!
>>>    - I close and reopen the Mixer board window, and I still see the same.
>>>    - I can change theme, add a track, and then see the Mixer board again,
>>>    and repeat, and so even make one slider in each of four themes.
>>> 
>>> Oh, that's cute.  I hadn't realised quite how much caching of
>>> pens/brushes Mixer board was doing.  Sounds like it is creating new brushes
>>> for each track.
>>> 
>>> 
>>>    - Light theme looks tolerable, but numbers and text in Dark are even
>>>    less legible than for Hi Contrast.
>>> 
>>> Well, yes, when you have a mix of themes in action.  If you select a
>>> theme and restart Audacity it should look about as good/bad as the main
>>> TrackPanel.
>>> 
>>> 
>>>    - A general problem, with both Mixer boards and TCP, is that the little
>>>    L and R appear with a small box of mis-matched background color when the
>>>    track is selected.
>>> 
>>> I don't see this on Windows, but yes, it is easy enough to fix.
>>> 
>>> The + and - of gain don't do this.  (I see those are
>>>    actually drawn differently, by actually stroking three little lines, not by
>>>    use of fonts!)  Is there a simple way to get transparency for the
>>>    background of text?  Was that neglected?
>>> 
>>> You still need to set the right background colour to get the right
>>> anti-aliassing of text, so it must be I didn't set the correct background
>>> colour.   Will fix presently.
>>> 
>>> --James.
>>> 
>>> 
>>> PRL
> 
> 
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> Audacity-quality mailing list
> Audacity-quality@...
> https://lists.sourceforge.net/lists/listinfo/audacity-quality

Re: [Audacity-quality] Theming problems with Mixer board and pan sliders

[Paul Licameli <paul.licameli@gm...>]

On Thu, Jun 22, 2017 at 11:57 AM, James Crook <crookj@...> wrote:

> On 6/22/2017 4:42 PM, Paul Licameli wrote:
>
>> On Thu, Jun 22, 2017 at 11:17 AM, James Crook <crookj@...> wrote:
>>
>> Fixed?
>>>
>>> It looks good to me now on Mac.
>>
>> And right on your heels, I have fixed the unrelated mixer board problem,
>> of
>> duplication of stereo tracks.
>>
>
> Cool.
> Could you look at http://bugzilla.audacityteam.org/show_bug.cgi?id=1665
> ?  It's a P1, and I'm not sure you know/knew about it.
> --James.
>
>
I think I know what's up with that.

Meanwhile, there is yet another theming problem with Mixer board, probably
much less important.

If you press Mute or Solo buttons down, the appearance is not like that of
the corresponding TrackPanel buttons in all themes.

I see that MixerBoard draws these buttons by other means -- by making
actual wxButton objects, which TrackPanel doesn't do, but rather, paints
its own simulations of buttons.

I don't really know why TrackPanel reinvented button controls, but so it
did.

PRL


>
>>
>> Latest HEAD now themes MixerBoard OK for me on Mac, and should likewise be
>>> OK on Linux too.  i.e. after commit:
>>> https://github.com/audacity/audacity/commit/389e286c78cecf8e
>>> 232716f4704cf7
>>> 081aa5a885
>>>
>>> The ASSERT was a helpful clue as to why a font colour was not 'taking' in
>>> mute/solo buttons.  Thanks Steve.
>>> The main change though was that part of AColour was unthemed for
>>> Mac/Linux.  I hadn't noticed because only MixerBoard used that part.
>>>
>>> Slightly off topic: We create more Pens and Brushes than we need to, and
>>> code could be cleaned up quite a bit by not doing so.  I think the reason
>>> it was done is because of mistaken past belief about drawing speed.
>>> Creating Pens and Brushes IS very slow, and too slow to do in an inner
>>> drawing loop.  However modifying the colour of an exisiting Pen or Brush
>>> is
>>> quick, and so we could just use one pen and brush, the sparePen and
>>> spareBrush, all the time and change their colour.  I.e. we could use the
>>> function AColour::UseThemeColour() a lot more and dispense with the many
>>> other pens and brushes.  Not keen on doing that for 2.2.0, since largely
>>> we
>>> have the pens and brushes working fine.
>>>
>>>
>>> Not the same thing, but another thing that bothers me about much drawing
>> code is carelessness about net side effects on the drawing context.  It
>> would be nicer to use some RAII style to scope the changes in brushes and
>> pens.
>>
>> PRL
>>
>>
>>
>> --James.
>>>
>>>
>>>
>>>
>>>
>>> On 6/22/2017 2:31 PM, Paul Licameli wrote:
>>>
>>> On Thu, Jun 22, 2017 at 8:15 AM, Steve the Fiddle <
>>> stevethefiddle@...> <stevethefiddle@...>
>>> wrote:
>>>
>>>
>>> Testing on Linux (Xubuntu) debug buildhttps://github.com/audaci
>>> ty/audacity/commit/86901a00a1aa
>>>
>>> No I don't get duplicate audio tracks.
>>>
>>> Yes the text on the buttons is hard to read in Dark theme:
>>>
>>>
>>> Enabling / disabling the Blend system does not affect the button text
>>> contrast (it looks the same regardless).
>>>
>>> The Mixer board theme now updates when the theme is changed in
>>> preferences.
>>>
>>> There's an assert on changing the Theme when the Mixer board is open.
>>> Backtrace attached.
>>>
>>> Steve
>>>
>>>
>>> What I see on Mac is different.  The background is still a pale gray,
>>> whatever the theme.  "Audio" and the numbers on the meter are hard to
>>> read.
>>>
>>> I have not tried latest head.
>>>
>>> PRL
>>>
>>>
>>>
>>> ​
>>>
>>> On 22 June 2017 at 12:55, Peter Sampson <petersampsonaudacity@...>
>>> <petersampsonaudacity@...>
>>> wrote:
>>>
>>>
>>> On Thu, Jun 22, 2017 at 12:37 PM, Peter Sampson <
>>> petersampsonaudacity@...> wrote:
>>>
>>>
>>> In general the Mixer Board has a lot of defects that need fixing.
>>>
>>>
>>> And now I seem to have found another one - now when I turn on the Mixer
>>> Board
>>> I get not one but two instances of each audio track.
>>>
>>> Both instances respond to the signal levels in the track when playing.
>>>
>>> Anybody else seeing this ?
>>>
>>> I suspect that Gale will regard this as more than P4/P3 - it is a
>>> regression on 2.1.3
>>> Fo my money it would be a show-stopper P1 - it just looks darn silly -
>>> and wastes
>>> valuable Mixer Board screen real-estate.
>>>
>>> Peter.
>>>
>>>
>>>
>>>
>>> See this page I put together on the Wiki a while back:
>>> http://wiki.audacityteam.org/wiki/User:PeterSampson/Mixer_Board_issues
>>> Eight Bugzilla bugs, five of which are P3 release noted.
>>>
>>> Peter.
>>>
>>> On Thu, Jun 22, 2017 at 12:33 PM, Steve the Fiddle <
>>> stevethefiddle@...> wrote:
>>>
>>>
>>> On 22 June 2017 at 11:28, Paul Licameli <paul.licameli@...> <
>>> paul.licameli@...>
>>>
>>> wrote:
>>>
>>>
>>> On Thu, Jun 22, 2017 at 5:42 AM, Peter Sampson <
>>> petersampsonaudacity@...> wrote:
>>>
>>>
>>> I'm thinking here that a user deciding to switch themes in the middle
>>> of a session with Mixer Board is unlikely to be switching themes - so
>>> this is a bit of a fringe case.
>>>
>>> I'm suspecting that most users will select a theme and then stick
>>> with it.
>>> More than that I'm suspecting that most users will stick with the new
>>> Light theme that we present them with as the default for 2.2.0.
>>>
>>> This does not mean that this would not be a "nice to fix" - but it
>>> should be
>>> logged on Bugzilla - and personally I can't see it rating more than
>>> P4, maybe
>>> P3 if we decide we want it release noted.
>>>
>>>
>>> I tell you it's not a fringe case -- I say that if you start Audacity
>>> in Dark or Hi Contrast theme, and open the mixer board, then the names
>>> and
>>> numbers are illegible because they contrast too weakly with the
>>> background.  Contrary to what James said, I see this problem even without
>>> any change of themes during the session.  That part of the problem, at
>>> least, needs a fix.
>>>
>>>
>>> Mixer board on Linux the contrast between button and button text is
>>> very low (hard to read "Mute" and  "Solo"). I agree that this part is not
>>> "fringe".
>>>
>>> When changing themes, the Mixer board does not fully update until
>>> Audacity is restarted. I agree with Peter that this part is closer to the
>>> fringe, but would be good to fix for 2.2.0 if possible.
>>>
>>> Also, on opening the Mixer board the first time in a session, in Debug
>>> build, there is an assert (see attached).
>>>
>>> Steve
>>>
>>>
>>>
>>> PRL
>>>
>>>
>>>
>>>
>>> Peter.
>>>
>>> On Wed, Jun 21, 2017 at 11:23 PM, James Crook <crookj@...> <
>>> crookj@...>
>>>
>>> wrote:
>>>
>>>
>>> On 6/21/2017 10:23 PM, Paul Licameli wrote:
>>>
>>> I started Audacity in Hi Contrast theme.  I generated noise and opened
>>> the
>>> Mixer board.
>>>
>>> No.  You started in classic theme and then switched to Hi Contrast.
>>>
>>>
>>>     - The green text of "Audio Track" contrasts poorly with a gray
>>>     background that is unchanged from Classic theme.  So it seems the
>>>     repainting of Mixer Board was missed by the theming project.
>>>
>>> Correct.  Mixer board caches lots of its colours rather than
>>> fetching them as needed.
>>> I can go in and change that.  Not too hard to do.
>>>
>>>     - Then I changed theme back to Classic in preferences.  The still
>>> open
>>>     Mixer board did not update, except for the numbers on the meter.
>>>     - I made a new track.  Now I see two mixer sliders with different
>>> themes!
>>>     - I close and reopen the Mixer board window, and I still see the
>>> same.
>>>     - I can change theme, add a track, and then see the Mixer board
>>> again,
>>>     and repeat, and so even make one slider in each of four themes.
>>>
>>> Oh, that's cute.  I hadn't realised quite how much caching of
>>> pens/brushes Mixer board was doing.  Sounds like it is creating new
>>> brushes
>>> for each track.
>>>
>>>
>>>     - Light theme looks tolerable, but numbers and text in Dark are even
>>>     less legible than for Hi Contrast.
>>>
>>> Well, yes, when you have a mix of themes in action.  If you select a
>>> theme and restart Audacity it should look about as good/bad as the main
>>> TrackPanel.
>>>
>>>
>>>     - A general problem, with both Mixer boards and TCP, is that the
>>> little
>>>     L and R appear with a small box of mis-matched background color when
>>> the
>>>     track is selected.
>>>
>>> I don't see this on Windows, but yes, it is easy enough to fix.
>>>
>>> The + and - of gain don't do this.  (I see those are
>>>     actually drawn differently, by actually stroking three little lines,
>>> not by
>>>     use of fonts!)  Is there a simple way to get transparency for the
>>>     background of text?  Was that neglected?
>>>
>>> You still need to set the right background colour to get the right
>>> anti-aliassing of text, so it must be I didn't set the correct background
>>> colour.   Will fix presently.
>>>
>>> --James.
>>>
>>>
>>> PRL
>>>
>>
>
> ------------------------------------------------------------
> ------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> Audacity-quality mailing list
> Audacity-quality@...
> https://lists.sourceforge.net/lists/listinfo/audacity-quality
>

[Audacity-quality] HiliteButtonExpand.png in Classic theme looks wrong

[Paul Licameli <paul.licameli@gm...>]

This image looks like it was intended for Dark or High Contrast.

It is not used for anything, yet.  But if I make highlighting of track
control panel buttons a reality, then it will be.

Shall I copy the file from Light theme and fix it myself?  Or does James
have other ideas for the proper image?

PRL

[Audacity-quality] Screenshot tool does not wait

[Steve the Fiddle <stevethefiddle@gm...>]

When the "Wait 5 seconds...." checkbox is selected - it doesn't wait.

It would in fact be nice to wait a bit longer than 5 seconds sometimes - it
can require very nifty mouse / keyboard work to get screenshots of some
items.

Steve

Re: [Audacity-quality] Theming problems with Mixer board and pan sliders

[James Crook <crookj@in...>]

On 6/22/2017 4:42 PM, Paul Licameli wrote:
> On Thu, Jun 22, 2017 at 11:17 AM, James Crook <crookj@...> wrote:
>
>> Fixed?
>>
> It looks good to me now on Mac.
>
> And right on your heels, I have fixed the unrelated mixer board problem, of
> duplication of stereo tracks.

Cool.
Could you look at http://bugzilla.audacityteam.org/show_bug.cgi?id=1665 
?  It's a P1, and I'm not sure you know/knew about it.
--James.


>
>
>> Latest HEAD now themes MixerBoard OK for me on Mac, and should likewise be
>> OK on Linux too.  i.e. after commit:
>> https://github.com/audacity/audacity/commit/389e286c78cecf8e232716f4704cf7
>> 081aa5a885
>>
>> The ASSERT was a helpful clue as to why a font colour was not 'taking' in
>> mute/solo buttons.  Thanks Steve.
>> The main change though was that part of AColour was unthemed for
>> Mac/Linux.  I hadn't noticed because only MixerBoard used that part.
>>
>> Slightly off topic: We create more Pens and Brushes than we need to, and
>> code could be cleaned up quite a bit by not doing so.  I think the reason
>> it was done is because of mistaken past belief about drawing speed.
>> Creating Pens and Brushes IS very slow, and too slow to do in an inner
>> drawing loop.  However modifying the colour of an exisiting Pen or Brush is
>> quick, and so we could just use one pen and brush, the sparePen and
>> spareBrush, all the time and change their colour.  I.e. we could use the
>> function AColour::UseThemeColour() a lot more and dispense with the many
>> other pens and brushes.  Not keen on doing that for 2.2.0, since largely we
>> have the pens and brushes working fine.
>>
>>
> Not the same thing, but another thing that bothers me about much drawing
> code is carelessness about net side effects on the drawing context.  It
> would be nicer to use some RAII style to scope the changes in brushes and
> pens.
>
> PRL
>
>
>
>> --James.
>>
>>
>>
>>
>>
>> On 6/22/2017 2:31 PM, Paul Licameli wrote:
>>
>> On Thu, Jun 22, 2017 at 8:15 AM, Steve the Fiddle <stevethefiddle@...> <stevethefiddle@...>
>> wrote:
>>
>>
>> Testing on Linux (Xubuntu) debug buildhttps://github.com/audacity/audacity/commit/86901a00a1aa
>>
>> No I don't get duplicate audio tracks.
>>
>> Yes the text on the buttons is hard to read in Dark theme:
>>
>>
>> Enabling / disabling the Blend system does not affect the button text
>> contrast (it looks the same regardless).
>>
>> The Mixer board theme now updates when the theme is changed in preferences.
>>
>> There's an assert on changing the Theme when the Mixer board is open.
>> Backtrace attached.
>>
>> Steve
>>
>>
>> What I see on Mac is different.  The background is still a pale gray,
>> whatever the theme.  "Audio" and the numbers on the meter are hard to read.
>>
>> I have not tried latest head.
>>
>> PRL
>>
>>
>>
>> ​
>>
>> On 22 June 2017 at 12:55, Peter Sampson <petersampsonaudacity@...> <petersampsonaudacity@...>
>> wrote:
>>
>>
>> On Thu, Jun 22, 2017 at 12:37 PM, Peter Sampson <petersampsonaudacity@...> wrote:
>>
>>
>> In general the Mixer Board has a lot of defects that need fixing.
>>
>>
>> And now I seem to have found another one - now when I turn on the Mixer
>> Board
>> I get not one but two instances of each audio track.
>>
>> Both instances respond to the signal levels in the track when playing.
>>
>> Anybody else seeing this ?
>>
>> I suspect that Gale will regard this as more than P4/P3 - it is a
>> regression on 2.1.3
>> Fo my money it would be a show-stopper P1 - it just looks darn silly -
>> and wastes
>> valuable Mixer Board screen real-estate.
>>
>> Peter.
>>
>>
>>
>>
>> See this page I put together on the Wiki a while back:http://wiki.audacityteam.org/wiki/User:PeterSampson/Mixer_Board_issues
>> Eight Bugzilla bugs, five of which are P3 release noted.
>>
>> Peter.
>>
>> On Thu, Jun 22, 2017 at 12:33 PM, Steve the Fiddle <stevethefiddle@...> wrote:
>>
>>
>> On 22 June 2017 at 11:28, Paul Licameli <paul.licameli@...> <paul.licameli@...>
>> wrote:
>>
>>
>> On Thu, Jun 22, 2017 at 5:42 AM, Peter Sampson <petersampsonaudacity@...> wrote:
>>
>>
>> I'm thinking here that a user deciding to switch themes in the middle
>> of a session with Mixer Board is unlikely to be switching themes - so
>> this is a bit of a fringe case.
>>
>> I'm suspecting that most users will select a theme and then stick
>> with it.
>> More than that I'm suspecting that most users will stick with the new
>> Light theme that we present them with as the default for 2.2.0.
>>
>> This does not mean that this would not be a "nice to fix" - but it
>> should be
>> logged on Bugzilla - and personally I can't see it rating more than
>> P4, maybe
>> P3 if we decide we want it release noted.
>>
>>
>> I tell you it's not a fringe case -- I say that if you start Audacity
>> in Dark or Hi Contrast theme, and open the mixer board, then the names and
>> numbers are illegible because they contrast too weakly with the
>> background.  Contrary to what James said, I see this problem even without
>> any change of themes during the session.  That part of the problem, at
>> least, needs a fix.
>>
>>
>> Mixer board on Linux the contrast between button and button text is
>> very low (hard to read "Mute" and  "Solo"). I agree that this part is not
>> "fringe".
>>
>> When changing themes, the Mixer board does not fully update until
>> Audacity is restarted. I agree with Peter that this part is closer to the
>> fringe, but would be good to fix for 2.2.0 if possible.
>>
>> Also, on opening the Mixer board the first time in a session, in Debug
>> build, there is an assert (see attached).
>>
>> Steve
>>
>>
>>
>> PRL
>>
>>
>>
>>
>> Peter.
>>
>> On Wed, Jun 21, 2017 at 11:23 PM, James Crook <crookj@...> <crookj@...>
>> wrote:
>>
>>
>> On 6/21/2017 10:23 PM, Paul Licameli wrote:
>>
>> I started Audacity in Hi Contrast theme.  I generated noise and opened the
>> Mixer board.
>>
>> No.  You started in classic theme and then switched to Hi Contrast.
>>
>>
>>     - The green text of "Audio Track" contrasts poorly with a gray
>>     background that is unchanged from Classic theme.  So it seems the
>>     repainting of Mixer Board was missed by the theming project.
>>
>> Correct.  Mixer board caches lots of its colours rather than
>> fetching them as needed.
>> I can go in and change that.  Not too hard to do.
>>
>>     - Then I changed theme back to Classic in preferences.  The still open
>>     Mixer board did not update, except for the numbers on the meter.
>>     - I made a new track.  Now I see two mixer sliders with different themes!
>>     - I close and reopen the Mixer board window, and I still see the same.
>>     - I can change theme, add a track, and then see the Mixer board again,
>>     and repeat, and so even make one slider in each of four themes.
>>
>> Oh, that's cute.  I hadn't realised quite how much caching of
>> pens/brushes Mixer board was doing.  Sounds like it is creating new brushes
>> for each track.
>>
>>
>>     - Light theme looks tolerable, but numbers and text in Dark are even
>>     less legible than for Hi Contrast.
>>
>> Well, yes, when you have a mix of themes in action.  If you select a
>> theme and restart Audacity it should look about as good/bad as the main
>> TrackPanel.
>>
>>
>>     - A general problem, with both Mixer boards and TCP, is that the little
>>     L and R appear with a small box of mis-matched background color when the
>>     track is selected.
>>
>> I don't see this on Windows, but yes, it is easy enough to fix.
>>
>> The + and - of gain don't do this.  (I see those are
>>     actually drawn differently, by actually stroking three little lines, not by
>>     use of fonts!)  Is there a simple way to get transparency for the
>>     background of text?  Was that neglected?
>>
>> You still need to set the right background colour to get the right
>> anti-aliassing of text, so it must be I didn't set the correct background
>> colour.   Will fix presently.
>>
>> --James.
>>
>>
>> PRL

Re: [Audacity-quality] Theming problems with Mixer board and pan sliders

[Paul Licameli <paul.licameli@gm...>]

On Thu, Jun 22, 2017 at 11:17 AM, James Crook <crookj@...> wrote:

> Fixed?
>

It looks good to me now on Mac.

And right on your heels, I have fixed the unrelated mixer board problem, of
duplication of stereo tracks.


>
> Latest HEAD now themes MixerBoard OK for me on Mac, and should likewise be
> OK on Linux too.  i.e. after commit:
> https://github.com/audacity/audacity/commit/389e286c78cecf8e232716f4704cf7
> 081aa5a885
>
> The ASSERT was a helpful clue as to why a font colour was not 'taking' in
> mute/solo buttons.  Thanks Steve.
> The main change though was that part of AColour was unthemed for
> Mac/Linux.  I hadn't noticed because only MixerBoard used that part.
>
> Slightly off topic: We create more Pens and Brushes than we need to, and
> code could be cleaned up quite a bit by not doing so.  I think the reason
> it was done is because of mistaken past belief about drawing speed.
> Creating Pens and Brushes IS very slow, and too slow to do in an inner
> drawing loop.  However modifying the colour of an exisiting Pen or Brush is
> quick, and so we could just use one pen and brush, the sparePen and
> spareBrush, all the time and change their colour.  I.e. we could use the
> function AColour::UseThemeColour() a lot more and dispense with the many
> other pens and brushes.  Not keen on doing that for 2.2.0, since largely we
> have the pens and brushes working fine.
>
>
Not the same thing, but another thing that bothers me about much drawing
code is carelessness about net side effects on the drawing context.  It
would be nicer to use some RAII style to scope the changes in brushes and
pens.

PRL



> --James.
>
>
>
>
>
> On 6/22/2017 2:31 PM, Paul Licameli wrote:
>
> On Thu, Jun 22, 2017 at 8:15 AM, Steve the Fiddle <stevethefiddle@...> <stevethefiddle@...>
> wrote:
>
>
> Testing on Linux (Xubuntu) debug buildhttps://github.com/audacity/audacity/commit/86901a00a1aa
>
> No I don't get duplicate audio tracks.
>
> Yes the text on the buttons is hard to read in Dark theme:
>
>
> Enabling / disabling the Blend system does not affect the button text
> contrast (it looks the same regardless).
>
> The Mixer board theme now updates when the theme is changed in preferences.
>
> There's an assert on changing the Theme when the Mixer board is open.
> Backtrace attached.
>
> Steve
>
>
> What I see on Mac is different.  The background is still a pale gray,
> whatever the theme.  "Audio" and the numbers on the meter are hard to read.
>
> I have not tried latest head.
>
> PRL
>
>
>
> ​
>
> On 22 June 2017 at 12:55, Peter Sampson <petersampsonaudacity@...> <petersampsonaudacity@...>
> wrote:
>
>
> On Thu, Jun 22, 2017 at 12:37 PM, Peter Sampson <petersampsonaudacity@...> wrote:
>
>
> In general the Mixer Board has a lot of defects that need fixing.
>
>
> And now I seem to have found another one - now when I turn on the Mixer
> Board
> I get not one but two instances of each audio track.
>
> Both instances respond to the signal levels in the track when playing.
>
> Anybody else seeing this ?
>
> I suspect that Gale will regard this as more than P4/P3 - it is a
> regression on 2.1.3
> Fo my money it would be a show-stopper P1 - it just looks darn silly -
> and wastes
> valuable Mixer Board screen real-estate.
>
> Peter.
>
>
>
>
> See this page I put together on the Wiki a while back:http://wiki.audacityteam.org/wiki/User:PeterSampson/Mixer_Board_issues
> Eight Bugzilla bugs, five of which are P3 release noted.
>
> Peter.
>
> On Thu, Jun 22, 2017 at 12:33 PM, Steve the Fiddle <stevethefiddle@...> wrote:
>
>
> On 22 June 2017 at 11:28, Paul Licameli <paul.licameli@...> <paul.licameli@...>
> wrote:
>
>
> On Thu, Jun 22, 2017 at 5:42 AM, Peter Sampson <petersampsonaudacity@...> wrote:
>
>
> I'm thinking here that a user deciding to switch themes in the middle
> of a session with Mixer Board is unlikely to be switching themes - so
> this is a bit of a fringe case.
>
> I'm suspecting that most users will select a theme and then stick
> with it.
> More than that I'm suspecting that most users will stick with the new
> Light theme that we present them with as the default for 2.2.0.
>
> This does not mean that this would not be a "nice to fix" - but it
> should be
> logged on Bugzilla - and personally I can't see it rating more than
> P4, maybe
> P3 if we decide we want it release noted.
>
>
> I tell you it's not a fringe case -- I say that if you start Audacity
> in Dark or Hi Contrast theme, and open the mixer board, then the names and
> numbers are illegible because they contrast too weakly with the
> background.  Contrary to what James said, I see this problem even without
> any change of themes during the session.  That part of the problem, at
> least, needs a fix.
>
>
> Mixer board on Linux the contrast between button and button text is
> very low (hard to read "Mute" and  "Solo"). I agree that this part is not
> "fringe".
>
> When changing themes, the Mixer board does not fully update until
> Audacity is restarted. I agree with Peter that this part is closer to the
> fringe, but would be good to fix for 2.2.0 if possible.
>
> Also, on opening the Mixer board the first time in a session, in Debug
> build, there is an assert (see attached).
>
> Steve
>
>
>
> PRL
>
>
>
>
> Peter.
>
> On Wed, Jun 21, 2017 at 11:23 PM, James Crook <crookj@...> <crookj@...>
> wrote:
>
>
> On 6/21/2017 10:23 PM, Paul Licameli wrote:
>
> I started Audacity in Hi Contrast theme.  I generated noise and opened the
> Mixer board.
>
> No.  You started in classic theme and then switched to Hi Contrast.
>
>
>    - The green text of "Audio Track" contrasts poorly with a gray
>    background that is unchanged from Classic theme.  So it seems the
>    repainting of Mixer Board was missed by the theming project.
>
> Correct.  Mixer board caches lots of its colours rather than
> fetching them as needed.
> I can go in and change that.  Not too hard to do.
>
>    - Then I changed theme back to Classic in preferences.  The still open
>    Mixer board did not update, except for the numbers on the meter.
>    - I made a new track.  Now I see two mixer sliders with different themes!
>    - I close and reopen the Mixer board window, and I still see the same.
>    - I can change theme, add a track, and then see the Mixer board again,
>    and repeat, and so even make one slider in each of four themes.
>
> Oh, that's cute.  I hadn't realised quite how much caching of
> pens/brushes Mixer board was doing.  Sounds like it is creating new brushes
> for each track.
>
>
>    - Light theme looks tolerable, but numbers and text in Dark are even
>    less legible than for Hi Contrast.
>
> Well, yes, when you have a mix of themes in action.  If you select a
> theme and restart Audacity it should look about as good/bad as the main
> TrackPanel.
>
>
>    - A general problem, with both Mixer boards and TCP, is that the little
>    L and R appear with a small box of mis-matched background color when the
>    track is selected.
>
> I don't see this on Windows, but yes, it is easy enough to fix.
>
> The + and - of gain don't do this.  (I see those are
>    actually drawn differently, by actually stroking three little lines, not by
>    use of fonts!)  Is there a simple way to get transparency for the
>    background of text?  Was that neglected?
>
> You still need to set the right background colour to get the right
> anti-aliassing of text, so it must be I didn't set the correct background
> colour.   Will fix presently.
>
> --James.
>
>
> PRL
>
>
>
>
>
> ------------------------------------------------------------
> ------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> Audacity-quality mailing listAudacity-quality@...nethttps://lists.sourceforge.net/lists/listinfo/audacity-quality
>
>  ------------------------------------------------------------
> ------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> Audacity-quality mailing listAudacity-quality@...nethttps://lists.sourceforge.net/lists/listinfo/audacity-quality
>
>  ------------------------------------------------------------
> ------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> Audacity-quality mailing listAudacity-quality@...nethttps://lists.sourceforge.net/lists/listinfo/audacity-quality
>
>
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>
>
>
> _______________________________________________
> Audacity-quality mailing listAudacity-quality@...nethttps://lists.sourceforge.net/lists/listinfo/audacity-quality
>
>
>
> ------------------------------------------------------------
> ------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> Audacity-quality mailing list
> Audacity-quality@...
> https://lists.sourceforge.net/lists/listinfo/audacity-quality
>
>

Re: [Audacity-quality] Theming problems with Mixer board and pan sliders

[James Crook <crookj@in...>]

Fixed?

Latest HEAD now themes MixerBoard OK for me on Mac, and should likewise 
be OK on Linux too.  i.e. after commit:
https://github.com/audacity/audacity/commit/389e286c78cecf8e232716f4704cf7081aa5a885

The ASSERT was a helpful clue as to why a font colour was not 'taking' 
in mute/solo buttons.  Thanks Steve.
The main change though was that part of AColour was unthemed for 
Mac/Linux.  I hadn't noticed because only MixerBoard used that part.

Slightly off topic: We create more Pens and Brushes than we need to, and 
code could be cleaned up quite a bit by not doing so.  I think the 
reason it was done is because of mistaken past belief about drawing 
speed.  Creating Pens and Brushes IS very slow, and too slow to do in an 
inner drawing loop.  However modifying the colour of an exisiting Pen or 
Brush is quick, and so we could just use one pen and brush, the sparePen 
and spareBrush, all the time and change their colour.  I.e. we could use 
the function AColour::UseThemeColour() a lot more and dispense with the 
many other pens and brushes.  Not keen on doing that for 2.2.0, since 
largely we have the pens and brushes working fine.

--James.





On 6/22/2017 2:31 PM, Paul Licameli wrote:
> On Thu, Jun 22, 2017 at 8:15 AM, Steve the Fiddle <stevethefiddle@...>
> wrote:
>
>> Testing on Linux (Xubuntu) debug build
>> https://github.com/audacity/audacity/commit/86901a00a1aa
>>
>> No I don't get duplicate audio tracks.
>>
>> Yes the text on the buttons is hard to read in Dark theme:
>>
>>
>> Enabling / disabling the Blend system does not affect the button text
>> contrast (it looks the same regardless).
>>
>> The Mixer board theme now updates when the theme is changed in preferences.
>>
>> There's an assert on changing the Theme when the Mixer board is open.
>> Backtrace attached.
>>
>> Steve
>>
> What I see on Mac is different.  The background is still a pale gray,
> whatever the theme.  "Audio" and the numbers on the meter are hard to read.
>
> I have not tried latest head.
>
> PRL
>
>
>> ​
>>
>> On 22 June 2017 at 12:55, Peter Sampson <petersampsonaudacity@...>
>> wrote:
>>
>>>
>>> On Thu, Jun 22, 2017 at 12:37 PM, Peter Sampson <
>>> petersampsonaudacity@...> wrote:
>>>
>>>> In general the Mixer Board has a lot of defects that need fixing.
>>>>
>>> And now I seem to have found another one - now when I turn on the Mixer
>>> Board
>>> I get not one but two instances of each audio track.
>>>
>>> Both instances respond to the signal levels in the track when playing.
>>>
>>> Anybody else seeing this ?
>>>
>>> I suspect that Gale will regard this as more than P4/P3 - it is a
>>> regression on 2.1.3
>>> Fo my money it would be a show-stopper P1 - it just looks darn silly -
>>> and wastes
>>> valuable Mixer Board screen real-estate.
>>>
>>> Peter.
>>>
>>>
>>>
>>>> See this page I put together on the Wiki a while back:
>>>> http://wiki.audacityteam.org/wiki/User:PeterSampson/Mixer_Board_issues
>>>> Eight Bugzilla bugs, five of which are P3 release noted.
>>>>
>>>> Peter.
>>>>
>>>> On Thu, Jun 22, 2017 at 12:33 PM, Steve the Fiddle <
>>>> stevethefiddle@...> wrote:
>>>>
>>>>>
>>>>> On 22 June 2017 at 11:28, Paul Licameli <paul.licameli@...>
>>>>> wrote:
>>>>>
>>>>>>
>>>>>> On Thu, Jun 22, 2017 at 5:42 AM, Peter Sampson <
>>>>>> petersampsonaudacity@...> wrote:
>>>>>>
>>>>>>> I'm thinking here that a user deciding to switch themes in the middle
>>>>>>> of a session with Mixer Board is unlikely to be switching themes - so
>>>>>>> this is a bit of a fringe case.
>>>>>>>
>>>>>>> I'm suspecting that most users will select a theme and then stick
>>>>>>> with it.
>>>>>>> More than that I'm suspecting that most users will stick with the new
>>>>>>> Light theme that we present them with as the default for 2.2.0.
>>>>>>>
>>>>>>> This does not mean that this would not be a "nice to fix" - but it
>>>>>>> should be
>>>>>>> logged on Bugzilla - and personally I can't see it rating more than
>>>>>>> P4, maybe
>>>>>>> P3 if we decide we want it release noted.
>>>>>>>
>>>>>> I tell you it's not a fringe case -- I say that if you start Audacity
>>>>>> in Dark or Hi Contrast theme, and open the mixer board, then the names and
>>>>>> numbers are illegible because they contrast too weakly with the
>>>>>> background.  Contrary to what James said, I see this problem even without
>>>>>> any change of themes during the session.  That part of the problem, at
>>>>>> least, needs a fix.
>>>>>>
>>>>>
>>>>> Mixer board on Linux the contrast between button and button text is
>>>>> very low (hard to read "Mute" and  "Solo"). I agree that this part is not
>>>>> "fringe".
>>>>>
>>>>> When changing themes, the Mixer board does not fully update until
>>>>> Audacity is restarted. I agree with Peter that this part is closer to the
>>>>> fringe, but would be good to fix for 2.2.0 if possible.
>>>>>
>>>>> Also, on opening the Mixer board the first time in a session, in Debug
>>>>> build, there is an assert (see attached).
>>>>>
>>>>> Steve
>>>>>
>>>>>
>>>>>> PRL
>>>>>>
>>>>>>
>>>>>>
>>>>>>>
>>>>>>> Peter.
>>>>>>>
>>>>>>> On Wed, Jun 21, 2017 at 11:23 PM, James Crook <crookj@...>
>>>>>>> wrote:
>>>>>>>
>>>>>>>> On 6/21/2017 10:23 PM, Paul Licameli wrote:
>>>>>>>>
>>>>>>>> I started Audacity in Hi Contrast theme.  I generated noise and opened the
>>>>>>>> Mixer board.
>>>>>>>>
>>>>>>>> No.  You started in classic theme and then switched to Hi Contrast.
>>>>>>>>
>>>>>>>>
>>>>>>>>     - The green text of "Audio Track" contrasts poorly with a gray
>>>>>>>>     background that is unchanged from Classic theme.  So it seems the
>>>>>>>>     repainting of Mixer Board was missed by the theming project.
>>>>>>>>
>>>>>>>> Correct.  Mixer board caches lots of its colours rather than
>>>>>>>> fetching them as needed.
>>>>>>>> I can go in and change that.  Not too hard to do.
>>>>>>>>
>>>>>>>>     - Then I changed theme back to Classic in preferences.  The still open
>>>>>>>>     Mixer board did not update, except for the numbers on the meter.
>>>>>>>>     - I made a new track.  Now I see two mixer sliders with different themes!
>>>>>>>>     - I close and reopen the Mixer board window, and I still see the same.
>>>>>>>>     - I can change theme, add a track, and then see the Mixer board again,
>>>>>>>>     and repeat, and so even make one slider in each of four themes.
>>>>>>>>
>>>>>>>> Oh, that's cute.  I hadn't realised quite how much caching of
>>>>>>>> pens/brushes Mixer board was doing.  Sounds like it is creating new brushes
>>>>>>>> for each track.
>>>>>>>>
>>>>>>>>
>>>>>>>>     - Light theme looks tolerable, but numbers and text in Dark are even
>>>>>>>>     less legible than for Hi Contrast.
>>>>>>>>
>>>>>>>> Well, yes, when you have a mix of themes in action.  If you select a
>>>>>>>> theme and restart Audacity it should look about as good/bad as the main
>>>>>>>> TrackPanel.
>>>>>>>>
>>>>>>>>
>>>>>>>>     - A general problem, with both Mixer boards and TCP, is that the little
>>>>>>>>     L and R appear with a small box of mis-matched background color when the
>>>>>>>>     track is selected.
>>>>>>>>
>>>>>>>> I don't see this on Windows, but yes, it is easy enough to fix.
>>>>>>>>
>>>>>>>> The + and - of gain don't do this.  (I see those are
>>>>>>>>     actually drawn differently, by actually stroking three little lines, not by
>>>>>>>>     use of fonts!)  Is there a simple way to get transparency for the
>>>>>>>>     background of text?  Was that neglected?
>>>>>>>>
>>>>>>>> You still need to set the right background colour to get the right
>>>>>>>> anti-aliassing of text, so it must be I didn't set the correct background
>>>>>>>> colour.   Will fix presently.
>>>>>>>>
>>>>>>>> --James.
>>>>>>>>
>>>>>>>>
>>>>>>>> PRL
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>> ------------------------------------------------------------
>>>>> ------------------
>>>>> Check out the vibrant tech community on one of the world's most
>>>>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>>>>> _______________________________________________
>>>>> Audacity-quality mailing list
>>>>> Audacity-quality@...
>>>>> https://lists.sourceforge.net/lists/listinfo/audacity-quality
>>>>>
>>>>>
>>> ------------------------------------------------------------
>>> ------------------
>>> Check out the vibrant tech community on one of the world's most
>>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>>> _______________________________________________
>>> Audacity-quality mailing list
>>> Audacity-quality@...
>>> https://lists.sourceforge.net/lists/listinfo/audacity-quality
>>>
>>>
>> ------------------------------------------------------------
>> ------------------
>> Check out the vibrant tech community on one of the world's most
>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>> _______________________________________________
>> Audacity-quality mailing list
>> Audacity-quality@...
>> https://lists.sourceforge.net/lists/listinfo/audacity-quality
>>
>>
>
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>
>
> _______________________________________________
> Audacity-quality mailing list
> Audacity-quality@...
> https://lists.sourceforge.net/lists/listinfo/audacity-quality

[Audacity-quality] Envelope points mess up when 'cut line' is restored

[Steve the Fiddle <stevethefiddle@gm...>]

1) Enable cut lines in "Prefs > Tracks > Track Behaviors"
2) Generate a 30 second tone
3) Add a control point at 5 seconds, amplitude 1.0
4) Add a control point at 20 seconds, amplitude about 0.5
5) Select from 10 to 15 seconds and cut (Ctrl+X)

As expected, the waveform now shows:
* Full volume from 0 to 5 seconds
* Full to about 0.8 from 5 to 10 seconds
* A split line at 10 seconds
* About 0.6 to 0.5 from 10 to 15 seconds
* Constant 0.5 amplitude from 15 to 25 seconds

6) Click with the selection tool on the cut line to restore the cut.

The envelope points are wrong.

This is not a regression because 2.1.3 was also wrong, but 2.2.0 is wrong
in a different way to 2.1.3.

Steve

Re: [Audacity-quality] Theming problems with Mixer board and pan sliders

[Peter Sampson <petersampsonaudacity@gm...>]

On Thu, Jun 22, 2017 at 2:31 PM, Paul Licameli <paul.licameli@...>
wrote:

>
>
> On Thu, Jun 22, 2017 at 8:15 AM, Steve the Fiddle <
> stevethefiddle@...> wrote:
>
>> Testing on Linux (Xubuntu) debug build
>> https://github.com/audacity/audacity/commit/86901a00a1aa
>>
>> No I don't get duplicate audio tracks.
>>
>> Yes the text on the buttons is hard to read in Dark theme:
>>
>
On Dark and HiContrast themes on W10
audacity-win-r1c03eee-2.2.0-alpha-22-jun-17

the text on the buttons is the same colour as the track name and the numbers
and is easily legible.


>
>>
>> Enabling / disabling the Blend system does not affect the button text
>> contrast (it looks the same regardless).
>>
>> The Mixer board theme now updates when the theme is changed in
>> preferences.
>>
>> There's an assert on changing the Theme when the Mixer board is open.
>> Backtrace attached.
>>
>> Steve
>>
>
> What I see on Mac is different.  The background is still a pale gray,
> whatever the theme.  "Audio" and the numbers on the meter are hard to read.
>
> I have not tried latest head.
>
> PRL
>
>
>> ​
>>
>> On 22 June 2017 at 12:55, Peter Sampson <petersampsonaudacity@...>
>> wrote:
>>
>>>
>>>
>>> On Thu, Jun 22, 2017 at 12:37 PM, Peter Sampson <
>>> petersampsonaudacity@...> wrote:
>>>
>>>> In general the Mixer Board has a lot of defects that need fixing.
>>>>
>>>
>>> And now I seem to have found another one - now when I turn on the Mixer
>>> Board
>>> I get not one but two instances of each audio track.
>>>
>>> Both instances respond to the signal levels in the track when playing.
>>>
>>> Anybody else seeing this ?
>>>
>>> I suspect that Gale will regard this as more than P4/P3 - it is a
>>> regression on 2.1.3
>>> Fo my money it would be a show-stopper P1 - it just looks darn silly -
>>> and wastes
>>> valuable Mixer Board screen real-estate.
>>>
>>> Peter.
>>>
>>>
>>>
>>>>
>>>> See this page I put together on the Wiki a while back:
>>>> http://wiki.audacityteam.org/wiki/User:PeterSampson/Mixer_Board_issues
>>>> Eight Bugzilla bugs, five of which are P3 release noted.
>>>>
>>>> Peter.
>>>>
>>>> On Thu, Jun 22, 2017 at 12:33 PM, Steve the Fiddle <
>>>> stevethefiddle@...> wrote:
>>>>
>>>>>
>>>>>
>>>>> On 22 June 2017 at 11:28, Paul Licameli <paul.licameli@...>
>>>>> wrote:
>>>>>
>>>>>>
>>>>>>
>>>>>> On Thu, Jun 22, 2017 at 5:42 AM, Peter Sampson <
>>>>>> petersampsonaudacity@...> wrote:
>>>>>>
>>>>>>> I'm thinking here that a user deciding to switch themes in the middle
>>>>>>> of a session with Mixer Board is unlikely to be switching themes - so
>>>>>>> this is a bit of a fringe case.
>>>>>>>
>>>>>>> I'm suspecting that most users will select a theme and then stick
>>>>>>> with it.
>>>>>>> More than that I'm suspecting that most users will stick with the new
>>>>>>> Light theme that we present them with as the default for 2.2.0.
>>>>>>>
>>>>>>> This does not mean that this would not be a "nice to fix" - but it
>>>>>>> should be
>>>>>>> logged on Bugzilla - and personally I can't see it rating more than
>>>>>>> P4, maybe
>>>>>>> P3 if we decide we want it release noted.
>>>>>>>
>>>>>>
>>>>>> I tell you it's not a fringe case -- I say that if you start Audacity
>>>>>> in Dark or Hi Contrast theme, and open the mixer board, then the names and
>>>>>> numbers are illegible because they contrast too weakly with the
>>>>>> background.  Contrary to what James said, I see this problem even without
>>>>>> any change of themes during the session.  That part of the problem, at
>>>>>> least, needs a fix.
>>>>>>
>>>>>
>>>>>
>>>>> Mixer board on Linux the contrast between button and button text is
>>>>> very low (hard to read "Mute" and  "Solo"). I agree that this part is not
>>>>> "fringe".
>>>>>
>>>>> When changing themes, the Mixer board does not fully update until
>>>>> Audacity is restarted. I agree with Peter that this part is closer to the
>>>>> fringe, but would be good to fix for 2.2.0 if possible.
>>>>>
>>>>> Also, on opening the Mixer board the first time in a session, in Debug
>>>>> build, there is an assert (see attached).
>>>>>
>>>>> Steve
>>>>>
>>>>>
>>>>>>
>>>>>> PRL
>>>>>>
>>>>>>
>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> Peter.
>>>>>>>
>>>>>>> On Wed, Jun 21, 2017 at 11:23 PM, James Crook <crookj@...>
>>>>>>> wrote:
>>>>>>>
>>>>>>>> On 6/21/2017 10:23 PM, Paul Licameli wrote:
>>>>>>>>
>>>>>>>> I started Audacity in Hi Contrast theme.  I generated noise and opened the
>>>>>>>> Mixer board.
>>>>>>>>
>>>>>>>> No.  You started in classic theme and then switched to Hi Contrast.
>>>>>>>>
>>>>>>>>
>>>>>>>>    - The green text of "Audio Track" contrasts poorly with a gray
>>>>>>>>    background that is unchanged from Classic theme.  So it seems the
>>>>>>>>    repainting of Mixer Board was missed by the theming project.
>>>>>>>>
>>>>>>>> Correct.  Mixer board caches lots of its colours rather than
>>>>>>>> fetching them as needed.
>>>>>>>> I can go in and change that.  Not too hard to do.
>>>>>>>>
>>>>>>>>    - Then I changed theme back to Classic in preferences.  The still open
>>>>>>>>    Mixer board did not update, except for the numbers on the meter.
>>>>>>>>    - I made a new track.  Now I see two mixer sliders with different themes!
>>>>>>>>    - I close and reopen the Mixer board window, and I still see the same.
>>>>>>>>    - I can change theme, add a track, and then see the Mixer board again,
>>>>>>>>    and repeat, and so even make one slider in each of four themes.
>>>>>>>>
>>>>>>>> Oh, that's cute.  I hadn't realised quite how much caching of
>>>>>>>> pens/brushes Mixer board was doing.  Sounds like it is creating new brushes
>>>>>>>> for each track.
>>>>>>>>
>>>>>>>>
>>>>>>>>    - Light theme looks tolerable, but numbers and text in Dark are even
>>>>>>>>    less legible than for Hi Contrast.
>>>>>>>>
>>>>>>>> Well, yes, when you have a mix of themes in action.  If you select
>>>>>>>> a theme and restart Audacity it should look about as good/bad as the main
>>>>>>>> TrackPanel.
>>>>>>>>
>>>>>>>>
>>>>>>>>    - A general problem, with both Mixer boards and TCP, is that the little
>>>>>>>>    L and R appear with a small box of mis-matched background color when the
>>>>>>>>    track is selected.
>>>>>>>>
>>>>>>>> I don't see this on Windows, but yes, it is easy enough to fix.
>>>>>>>>
>>>>>>>> The + and - of gain don't do this.  (I see those are
>>>>>>>>    actually drawn differently, by actually stroking three little lines, not by
>>>>>>>>    use of fonts!)  Is there a simple way to get transparency for the
>>>>>>>>    background of text?  Was that neglected?
>>>>>>>>
>>>>>>>> You still need to set the right background colour to get the right
>>>>>>>> anti-aliassing of text, so it must be I didn't set the correct background
>>>>>>>> colour.   Will fix presently.
>>>>>>>>
>>>>>>>> --James.
>>>>>>>>
>>>>>>>>
>>>>>>>> PRL
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>
>>>>>
>>>>> ------------------------------------------------------------
>>>>> ------------------
>>>>> Check out the vibrant tech community on one of the world's most
>>>>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>>>>> _______________________________________________
>>>>> Audacity-quality mailing list
>>>>> Audacity-quality@...
>>>>> https://lists.sourceforge.net/lists/listinfo/audacity-quality
>>>>>
>>>>>
>>>>
>>>
>>> ------------------------------------------------------------
>>> ------------------
>>> Check out the vibrant tech community on one of the world's most
>>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>>> _______________________________________________
>>> Audacity-quality mailing list
>>> Audacity-quality@...
>>> https://lists.sourceforge.net/lists/listinfo/audacity-quality
>>>
>>>
>>
>> ------------------------------------------------------------
>> ------------------
>> Check out the vibrant tech community on one of the world's most
>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>> _______________________________________________
>> Audacity-quality mailing list
>> Audacity-quality@...
>> https://lists.sourceforge.net/lists/listinfo/audacity-quality
>>
>>
>
> ------------------------------------------------------------
> ------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> Audacity-quality mailing list
> Audacity-quality@...
> https://lists.sourceforge.net/lists/listinfo/audacity-quality
>
>

Re: [Audacity-quality] Theming problems with Mixer board and pan sliders

[Paul Licameli <paul.licameli@gm...>]

On Thu, Jun 22, 2017 at 8:15 AM, Steve the Fiddle <stevethefiddle@...>
wrote:

> Testing on Linux (Xubuntu) debug build
> https://github.com/audacity/audacity/commit/86901a00a1aa
>
> No I don't get duplicate audio tracks.
>
> Yes the text on the buttons is hard to read in Dark theme:
>
>
> Enabling / disabling the Blend system does not affect the button text
> contrast (it looks the same regardless).
>
> The Mixer board theme now updates when the theme is changed in preferences.
>
> There's an assert on changing the Theme when the Mixer board is open.
> Backtrace attached.
>
> Steve
>

What I see on Mac is different.  The background is still a pale gray,
whatever the theme.  "Audio" and the numbers on the meter are hard to read.

I have not tried latest head.

PRL


> ​
>
> On 22 June 2017 at 12:55, Peter Sampson <petersampsonaudacity@...>
> wrote:
>
>>
>>
>> On Thu, Jun 22, 2017 at 12:37 PM, Peter Sampson <
>> petersampsonaudacity@...> wrote:
>>
>>> In general the Mixer Board has a lot of defects that need fixing.
>>>
>>
>> And now I seem to have found another one - now when I turn on the Mixer
>> Board
>> I get not one but two instances of each audio track.
>>
>> Both instances respond to the signal levels in the track when playing.
>>
>> Anybody else seeing this ?
>>
>> I suspect that Gale will regard this as more than P4/P3 - it is a
>> regression on 2.1.3
>> Fo my money it would be a show-stopper P1 - it just looks darn silly -
>> and wastes
>> valuable Mixer Board screen real-estate.
>>
>> Peter.
>>
>>
>>
>>>
>>> See this page I put together on the Wiki a while back:
>>> http://wiki.audacityteam.org/wiki/User:PeterSampson/Mixer_Board_issues
>>> Eight Bugzilla bugs, five of which are P3 release noted.
>>>
>>> Peter.
>>>
>>> On Thu, Jun 22, 2017 at 12:33 PM, Steve the Fiddle <
>>> stevethefiddle@...> wrote:
>>>
>>>>
>>>>
>>>> On 22 June 2017 at 11:28, Paul Licameli <paul.licameli@...>
>>>> wrote:
>>>>
>>>>>
>>>>>
>>>>> On Thu, Jun 22, 2017 at 5:42 AM, Peter Sampson <
>>>>> petersampsonaudacity@...> wrote:
>>>>>
>>>>>> I'm thinking here that a user deciding to switch themes in the middle
>>>>>> of a session with Mixer Board is unlikely to be switching themes - so
>>>>>> this is a bit of a fringe case.
>>>>>>
>>>>>> I'm suspecting that most users will select a theme and then stick
>>>>>> with it.
>>>>>> More than that I'm suspecting that most users will stick with the new
>>>>>> Light theme that we present them with as the default for 2.2.0.
>>>>>>
>>>>>> This does not mean that this would not be a "nice to fix" - but it
>>>>>> should be
>>>>>> logged on Bugzilla - and personally I can't see it rating more than
>>>>>> P4, maybe
>>>>>> P3 if we decide we want it release noted.
>>>>>>
>>>>>
>>>>> I tell you it's not a fringe case -- I say that if you start Audacity
>>>>> in Dark or Hi Contrast theme, and open the mixer board, then the names and
>>>>> numbers are illegible because they contrast too weakly with the
>>>>> background.  Contrary to what James said, I see this problem even without
>>>>> any change of themes during the session.  That part of the problem, at
>>>>> least, needs a fix.
>>>>>
>>>>
>>>>
>>>> Mixer board on Linux the contrast between button and button text is
>>>> very low (hard to read "Mute" and  "Solo"). I agree that this part is not
>>>> "fringe".
>>>>
>>>> When changing themes, the Mixer board does not fully update until
>>>> Audacity is restarted. I agree with Peter that this part is closer to the
>>>> fringe, but would be good to fix for 2.2.0 if possible.
>>>>
>>>> Also, on opening the Mixer board the first time in a session, in Debug
>>>> build, there is an assert (see attached).
>>>>
>>>> Steve
>>>>
>>>>
>>>>>
>>>>> PRL
>>>>>
>>>>>
>>>>>
>>>>>>
>>>>>>
>>>>>> Peter.
>>>>>>
>>>>>> On Wed, Jun 21, 2017 at 11:23 PM, James Crook <crookj@...>
>>>>>> wrote:
>>>>>>
>>>>>>> On 6/21/2017 10:23 PM, Paul Licameli wrote:
>>>>>>>
>>>>>>> I started Audacity in Hi Contrast theme.  I generated noise and opened the
>>>>>>> Mixer board.
>>>>>>>
>>>>>>> No.  You started in classic theme and then switched to Hi Contrast.
>>>>>>>
>>>>>>>
>>>>>>>    - The green text of "Audio Track" contrasts poorly with a gray
>>>>>>>    background that is unchanged from Classic theme.  So it seems the
>>>>>>>    repainting of Mixer Board was missed by the theming project.
>>>>>>>
>>>>>>> Correct.  Mixer board caches lots of its colours rather than
>>>>>>> fetching them as needed.
>>>>>>> I can go in and change that.  Not too hard to do.
>>>>>>>
>>>>>>>    - Then I changed theme back to Classic in preferences.  The still open
>>>>>>>    Mixer board did not update, except for the numbers on the meter.
>>>>>>>    - I made a new track.  Now I see two mixer sliders with different themes!
>>>>>>>    - I close and reopen the Mixer board window, and I still see the same.
>>>>>>>    - I can change theme, add a track, and then see the Mixer board again,
>>>>>>>    and repeat, and so even make one slider in each of four themes.
>>>>>>>
>>>>>>> Oh, that's cute.  I hadn't realised quite how much caching of
>>>>>>> pens/brushes Mixer board was doing.  Sounds like it is creating new brushes
>>>>>>> for each track.
>>>>>>>
>>>>>>>
>>>>>>>    - Light theme looks tolerable, but numbers and text in Dark are even
>>>>>>>    less legible than for Hi Contrast.
>>>>>>>
>>>>>>> Well, yes, when you have a mix of themes in action.  If you select a
>>>>>>> theme and restart Audacity it should look about as good/bad as the main
>>>>>>> TrackPanel.
>>>>>>>
>>>>>>>
>>>>>>>    - A general problem, with both Mixer boards and TCP, is that the little
>>>>>>>    L and R appear with a small box of mis-matched background color when the
>>>>>>>    track is selected.
>>>>>>>
>>>>>>> I don't see this on Windows, but yes, it is easy enough to fix.
>>>>>>>
>>>>>>> The + and - of gain don't do this.  (I see those are
>>>>>>>    actually drawn differently, by actually stroking three little lines, not by
>>>>>>>    use of fonts!)  Is there a simple way to get transparency for the
>>>>>>>    background of text?  Was that neglected?
>>>>>>>
>>>>>>> You still need to set the right background colour to get the right
>>>>>>> anti-aliassing of text, so it must be I didn't set the correct background
>>>>>>> colour.   Will fix presently.
>>>>>>>
>>>>>>> --James.
>>>>>>>
>>>>>>>
>>>>>>> PRL
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>
>>>>
>>>> ------------------------------------------------------------
>>>> ------------------
>>>> Check out the vibrant tech community on one of the world's most
>>>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>>>> _______________________________________________
>>>> Audacity-quality mailing list
>>>> Audacity-quality@...
>>>> https://lists.sourceforge.net/lists/listinfo/audacity-quality
>>>>
>>>>
>>>
>>
>> ------------------------------------------------------------
>> ------------------
>> Check out the vibrant tech community on one of the world's most
>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>> _______________________________________________
>> Audacity-quality mailing list
>> Audacity-quality@...
>> https://lists.sourceforge.net/lists/listinfo/audacity-quality
>>
>>
>
> ------------------------------------------------------------
> ------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> Audacity-quality mailing list
> Audacity-quality@...
> https://lists.sourceforge.net/lists/listinfo/audacity-quality
>
>

Re: [Audacity-quality] zooming issue in Vertical Scale

[Peter Sampson <petersampsonaudacity@gm...>]

See: http://bugzilla.audacityteam.org/show_bug.cgi?id=1667

Peter.

On Thu, Jun 22, 2017 at 1:55 PM, Steve the Fiddle <stevethefiddle@...>
wrote:

> Confirmed. Vertical ruler zooming is broken on Linux too.
>
> Steve
>
> On 22 June 2017 at 13:47, Peter Sampson <petersampsonaudacity@...>
> wrote:
>
>> Now here's an interesting one ...
>>
>> On the latest Windows nightly build audacity-win-r1c03eee-2.2.0-alpha-22-jun-17
>> on W10
>>
>> 1) default settings - clear the .ffg files
>> 2) record some audio (Stereo or Mono)
>> 3) right click in the Vertical Scale
>> 4) VS shrinks to a thin band - looks as though there are no numbers to
>> display (at that zoom level) I'm thinking
>> 5) right click in VS again VS expands ok with numbers
>> 6) right click in VS again VS expands ok with numbers
>>
>> And then another odd thing
>>
>> 7) left click in VS
>> 8) returns immediately to default vertical zoom level
>> I thought it was supposed to step back up the zoom leveles one level at a
>> time ???
>>
>> Step 4 looks odd and unsettling - step 8 looks wrong
>>
>> On 2.1.3 you can't even do steps 5 & 6 as there appears to be only one
>> levele of zoom down.
>>
>> Peter.
>>
>> ------------------------------------------------------------
>> ------------------
>> Check out the vibrant tech community on one of the world's most
>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>> _______________________________________________
>> Audacity-quality mailing list
>> Audacity-quality@...
>> https://lists.sourceforge.net/lists/listinfo/audacity-quality
>>
>>
>
> ------------------------------------------------------------
> ------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> Audacity-quality mailing list
> Audacity-quality@...
> https://lists.sourceforge.net/lists/listinfo/audacity-quality
>
>

Re: [Audacity-quality] Theming problems with Mixer board and pan sliders

[Peter Sampson <petersampsonaudacity@gm...>]

On Thu, Jun 22, 2017 at 1:56 PM, Peter Sampson <
petersampsonaudacity@...> wrote:

>
>
> On Thu, Jun 22, 2017 at 1:39 PM, Steve the Fiddle <
> stevethefiddle@...> wrote:
>
>>
>>
>> On 22 June 2017 at 13:25, Peter Sampson <petersampsonaudacity@...>
>> wrote:
>>
>>>
>>>
>>> On Thu, Jun 22, 2017 at 1:15 PM, Steve the Fiddle <
>>> stevethefiddle@...> wrote:
>>>
>>>> Testing on Linux (Xubuntu) debug build
>>>> https://github.com/audacity/audacity/commit/86901a00a1aa
>>>>
>>>> No I don't get duplicate audio tracks.
>>>>
>>>
>>>
>>> Have you got two tracks in your project, both called "Audio"
>>>
>>
>> Yes, that's a project with two  mono tracks.
>>
>> With one stereo track, I see two sliders, one for each channel, which I
>> think is what you mean by duplicate tracks.
>>
>
> No I am definitely seeing duplicate tracks (very different to 2.1.3 and
> all earlier Audacities with MB)
>
> Both MB tracks have two sliders (as in 2.1.3 et al)
> a) a vertical one for gain
> b) a small horizontal for pan
> Move the slider in either of the duplicates and tou will notice that onec
> you release the
> mouse button, releasing the slider, the duplicate track springs to the
> same settings.
>
> This is definitely a bug and definitely a regression.
>

It's even more complex than that
1) The sliders mimic each other when not playing
2) now start playing ad move the sliders in one panel, the other panel
stays where it is
3) now stop playback - both  panels have different settings
4) now move one of the sliders in on panel - now the second panel snaps to
the same setting

But this is definitely vastly different from 2.2.3, try it there.
Also look at this page in the Manual:
http://alphamanual.audacityteam.org/man/Mixer_Board

:-///

Peter




>
> Peter.
>
>
>
>> This may be intentional, but I agree that it is not clear, and the pan
>> sliders behave a bit strangely in that moving one does not drag the other
>> (as I would expect for two linked channels), but the other does move to the
>> same position when the pan slider for the first channel is released.
>>
>> Steve
>>
>>
>>
>>
>>> If you only have one stereo track then you are getting a duplicate in MB
>>>
>>> Each pane has Left & Right channels - so you are exhibiting four
>>> channels in your image.
>>>
>>> In testing it will help if you name tracks differently.
>>>
>>> I am seeing exactly the same behavior on my Macbook - so I'm raising a
>>> bug on Bugzilla.
>>>
>>> Peter
>>>
>>>
>>>> Yes the text on the buttons is hard to read in Dark theme:
>>>>
>>>>
>>>> Enabling / disabling the Blend system does not affect the button text
>>>> contrast (it looks the same regardless).
>>>>
>>>> The Mixer board theme now updates when the theme is changed in
>>>> preferences.
>>>>
>>>> There's an assert on changing the Theme when the Mixer board is open.
>>>> Backtrace attached.
>>>>
>>>> Steve
>>>> ​
>>>>
>>>> On 22 June 2017 at 12:55, Peter Sampson <petersampsonaudacity@...
>>>> > wrote:
>>>>
>>>>>
>>>>>
>>>>> On Thu, Jun 22, 2017 at 12:37 PM, Peter Sampson <
>>>>> petersampsonaudacity@...> wrote:
>>>>>
>>>>>> In general the Mixer Board has a lot of defects that need fixing.
>>>>>>
>>>>>
>>>>> And now I seem to have found another one - now when I turn on the
>>>>> Mixer Board
>>>>> I get not one but two instances of each audio track.
>>>>>
>>>>> Both instances respond to the signal levels in the track when playing.
>>>>>
>>>>> Anybody else seeing this ?
>>>>>
>>>>> I suspect that Gale will regard this as more than P4/P3 - it is a
>>>>> regression on 2.1.3
>>>>> Fo my money it would be a show-stopper P1 - it just looks darn silly -
>>>>> and wastes
>>>>> valuable Mixer Board screen real-estate.
>>>>>
>>>>> Peter.
>>>>>
>>>>>
>>>>>
>>>>>>
>>>>>> See this page I put together on the Wiki a while back:
>>>>>> http://wiki.audacityteam.org/wiki/User:PeterSampson/Mixer_Bo
>>>>>> ard_issues
>>>>>> Eight Bugzilla bugs, five of which are P3 release noted.
>>>>>>
>>>>>> Peter.
>>>>>>
>>>>>> On Thu, Jun 22, 2017 at 12:33 PM, Steve the Fiddle <
>>>>>> stevethefiddle@...> wrote:
>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On 22 June 2017 at 11:28, Paul Licameli <paul.licameli@...>
>>>>>>> wrote:
>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> On Thu, Jun 22, 2017 at 5:42 AM, Peter Sampson <
>>>>>>>> petersampsonaudacity@...> wrote:
>>>>>>>>
>>>>>>>>> I'm thinking here that a user deciding to switch themes in the
>>>>>>>>> middle
>>>>>>>>> of a session with Mixer Board is unlikely to be switching themes -
>>>>>>>>> so
>>>>>>>>> this is a bit of a fringe case.
>>>>>>>>>
>>>>>>>>> I'm suspecting that most users will select a theme and then stick
>>>>>>>>> with it.
>>>>>>>>> More than that I'm suspecting that most users will stick with the
>>>>>>>>> new
>>>>>>>>> Light theme that we present them with as the default for 2.2.0.
>>>>>>>>>
>>>>>>>>> This does not mean that this would not be a "nice to fix" - but it
>>>>>>>>> should be
>>>>>>>>> logged on Bugzilla - and personally I can't see it rating more
>>>>>>>>> than P4, maybe
>>>>>>>>> P3 if we decide we want it release noted.
>>>>>>>>>
>>>>>>>>
>>>>>>>> I tell you it's not a fringe case -- I say that if you start
>>>>>>>> Audacity in Dark or Hi Contrast theme, and open the mixer board, then the
>>>>>>>> names and numbers are illegible because they contrast too weakly with the
>>>>>>>> background.  Contrary to what James said, I see this problem even without
>>>>>>>> any change of themes during the session.  That part of the problem, at
>>>>>>>> least, needs a fix.
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> Mixer board on Linux the contrast between button and button text is
>>>>>>> very low (hard to read "Mute" and  "Solo"). I agree that this part is not
>>>>>>> "fringe".
>>>>>>>
>>>>>>> When changing themes, the Mixer board does not fully update until
>>>>>>> Audacity is restarted. I agree with Peter that this part is closer to the
>>>>>>> fringe, but would be good to fix for 2.2.0 if possible.
>>>>>>>
>>>>>>> Also, on opening the Mixer board the first time in a session, in
>>>>>>> Debug build, there is an assert (see attached).
>>>>>>>
>>>>>>> Steve
>>>>>>>
>>>>>>>
>>>>>>>>
>>>>>>>> PRL
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Peter.
>>>>>>>>>
>>>>>>>>> On Wed, Jun 21, 2017 at 11:23 PM, James Crook <crookj@...>
>>>>>>>>> wrote:
>>>>>>>>>
>>>>>>>>>> On 6/21/2017 10:23 PM, Paul Licameli wrote:
>>>>>>>>>>
>>>>>>>>>> I started Audacity in Hi Contrast theme.  I generated noise and opened the
>>>>>>>>>> Mixer board.
>>>>>>>>>>
>>>>>>>>>> No.  You started in classic theme and then switched to Hi
>>>>>>>>>> Contrast.
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>    - The green text of "Audio Track" contrasts poorly with a gray
>>>>>>>>>>    background that is unchanged from Classic theme.  So it seems the
>>>>>>>>>>    repainting of Mixer Board was missed by the theming project.
>>>>>>>>>>
>>>>>>>>>> Correct.  Mixer board caches lots of its colours rather than
>>>>>>>>>> fetching them as needed.
>>>>>>>>>> I can go in and change that.  Not too hard to do.
>>>>>>>>>>
>>>>>>>>>>    - Then I changed theme back to Classic in preferences.  The still open
>>>>>>>>>>    Mixer board did not update, except for the numbers on the meter.
>>>>>>>>>>    - I made a new track.  Now I see two mixer sliders with different themes!
>>>>>>>>>>    - I close and reopen the Mixer board window, and I still see the same.
>>>>>>>>>>    - I can change theme, add a track, and then see the Mixer board again,
>>>>>>>>>>    and repeat, and so even make one slider in each of four themes.
>>>>>>>>>>
>>>>>>>>>> Oh, that's cute.  I hadn't realised quite how much caching of
>>>>>>>>>> pens/brushes Mixer board was doing.  Sounds like it is creating new brushes
>>>>>>>>>> for each track.
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>    - Light theme looks tolerable, but numbers and text in Dark are even
>>>>>>>>>>    less legible than for Hi Contrast.
>>>>>>>>>>
>>>>>>>>>> Well, yes, when you have a mix of themes in action.  If you
>>>>>>>>>> select a theme and restart Audacity it should look about as good/bad as the
>>>>>>>>>> main TrackPanel.
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>    - A general problem, with both Mixer boards and TCP, is that the little
>>>>>>>>>>    L and R appear with a small box of mis-matched background color when the
>>>>>>>>>>    track is selected.
>>>>>>>>>>
>>>>>>>>>> I don't see this on Windows, but yes, it is easy enough to fix.
>>>>>>>>>>
>>>>>>>>>> The + and - of gain don't do this.  (I see those are
>>>>>>>>>>    actually drawn differently, by actually stroking three little lines, not by
>>>>>>>>>>    use of fonts!)  Is there a simple way to get transparency for the
>>>>>>>>>>    background of text?  Was that neglected?
>>>>>>>>>>
>>>>>>>>>> You still need to set the right background colour to get the
>>>>>>>>>> right anti-aliassing of text, so it must be I didn't set the correct
>>>>>>>>>> background colour.   Will fix presently.
>>>>>>>>>>
>>>>>>>>>> --James.
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> PRL
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>> ------------------------------------------------------------
>>>>>>> ------------------
>>>>>>> Check out the vibrant tech community on one of the world's most
>>>>>>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>>>>>>> _______________________________________________
>>>>>>> Audacity-quality mailing list
>>>>>>> Audacity-quality@...
>>>>>>> https://lists.sourceforge.net/lists/listinfo/audacity-quality
>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>> ------------------------------------------------------------
>>>>> ------------------
>>>>> Check out the vibrant tech community on one of the world's most
>>>>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>>>>> _______________________________________________
>>>>> Audacity-quality mailing list
>>>>> Audacity-quality@...
>>>>> https://lists.sourceforge.net/lists/listinfo/audacity-quality
>>>>>
>>>>>
>>>>
>>>
>>
>> ------------------------------------------------------------
>> ------------------
>> Check out the vibrant tech community on one of the world's most
>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>> _______________________________________________
>> Audacity-quality mailing list
>> Audacity-quality@...
>> https://lists.sourceforge.net/lists/listinfo/audacity-quality
>>
>>
>

Re: [Audacity-quality] Theming problems with Mixer board and pan sliders

[Peter Sampson <petersampsonaudacity@gm...>]

On Thu, Jun 22, 2017 at 1:39 PM, Steve the Fiddle <stevethefiddle@...>
wrote:

>
>
> On 22 June 2017 at 13:25, Peter Sampson <petersampsonaudacity@...>
> wrote:
>
>>
>>
>> On Thu, Jun 22, 2017 at 1:15 PM, Steve the Fiddle <
>> stevethefiddle@...> wrote:
>>
>>> Testing on Linux (Xubuntu) debug build
>>> https://github.com/audacity/audacity/commit/86901a00a1aa
>>>
>>> No I don't get duplicate audio tracks.
>>>
>>
>>
>> Have you got two tracks in your project, both called "Audio"
>>
>
> Yes, that's a project with two  mono tracks.
>
> With one stereo track, I see two sliders, one for each channel, which I
> think is what you mean by duplicate tracks.
>

No I am definitely seeing duplicate tracks (very different to 2.1.3 and all
earlier Audacities with MB)

Both MB tracks have two sliders (as in 2.1.3 et al)
a) a vertical one for gain
b) a small horizontal for pan
Move the slider in either of the duplicates and tou will notice that onec
you release the
mouse button, releasing the slider, the duplicate track springs to the same
settings.

This is definitely a bug and definitely a regression.

Peter.



> This may be intentional, but I agree that it is not clear, and the pan
> sliders behave a bit strangely in that moving one does not drag the other
> (as I would expect for two linked channels), but the other does move to the
> same position when the pan slider for the first channel is released.
>
> Steve
>
>
>
>
>> If you only have one stereo track then you are getting a duplicate in MB
>>
>> Each pane has Left & Right channels - so you are exhibiting four channels
>> in your image.
>>
>> In testing it will help if you name tracks differently.
>>
>> I am seeing exactly the same behavior on my Macbook - so I'm raising a
>> bug on Bugzilla.
>>
>> Peter
>>
>>
>>> Yes the text on the buttons is hard to read in Dark theme:
>>>
>>>
>>> Enabling / disabling the Blend system does not affect the button text
>>> contrast (it looks the same regardless).
>>>
>>> The Mixer board theme now updates when the theme is changed in
>>> preferences.
>>>
>>> There's an assert on changing the Theme when the Mixer board is open.
>>> Backtrace attached.
>>>
>>> Steve
>>> ​
>>>
>>> On 22 June 2017 at 12:55, Peter Sampson <petersampsonaudacity@...>
>>> wrote:
>>>
>>>>
>>>>
>>>> On Thu, Jun 22, 2017 at 12:37 PM, Peter Sampson <
>>>> petersampsonaudacity@...> wrote:
>>>>
>>>>> In general the Mixer Board has a lot of defects that need fixing.
>>>>>
>>>>
>>>> And now I seem to have found another one - now when I turn on the Mixer
>>>> Board
>>>> I get not one but two instances of each audio track.
>>>>
>>>> Both instances respond to the signal levels in the track when playing.
>>>>
>>>> Anybody else seeing this ?
>>>>
>>>> I suspect that Gale will regard this as more than P4/P3 - it is a
>>>> regression on 2.1.3
>>>> Fo my money it would be a show-stopper P1 - it just looks darn silly -
>>>> and wastes
>>>> valuable Mixer Board screen real-estate.
>>>>
>>>> Peter.
>>>>
>>>>
>>>>
>>>>>
>>>>> See this page I put together on the Wiki a while back:
>>>>> http://wiki.audacityteam.org/wiki/User:PeterSampson/Mixer_Board_issues
>>>>> Eight Bugzilla bugs, five of which are P3 release noted.
>>>>>
>>>>> Peter.
>>>>>
>>>>> On Thu, Jun 22, 2017 at 12:33 PM, Steve the Fiddle <
>>>>> stevethefiddle@...> wrote:
>>>>>
>>>>>>
>>>>>>
>>>>>> On 22 June 2017 at 11:28, Paul Licameli <paul.licameli@...>
>>>>>> wrote:
>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On Thu, Jun 22, 2017 at 5:42 AM, Peter Sampson <
>>>>>>> petersampsonaudacity@...> wrote:
>>>>>>>
>>>>>>>> I'm thinking here that a user deciding to switch themes in the
>>>>>>>> middle
>>>>>>>> of a session with Mixer Board is unlikely to be switching themes -
>>>>>>>> so
>>>>>>>> this is a bit of a fringe case.
>>>>>>>>
>>>>>>>> I'm suspecting that most users will select a theme and then stick
>>>>>>>> with it.
>>>>>>>> More than that I'm suspecting that most users will stick with the
>>>>>>>> new
>>>>>>>> Light theme that we present them with as the default for 2.2.0.
>>>>>>>>
>>>>>>>> This does not mean that this would not be a "nice to fix" - but it
>>>>>>>> should be
>>>>>>>> logged on Bugzilla - and personally I can't see it rating more than
>>>>>>>> P4, maybe
>>>>>>>> P3 if we decide we want it release noted.
>>>>>>>>
>>>>>>>
>>>>>>> I tell you it's not a fringe case -- I say that if you start
>>>>>>> Audacity in Dark or Hi Contrast theme, and open the mixer board, then the
>>>>>>> names and numbers are illegible because they contrast too weakly with the
>>>>>>> background.  Contrary to what James said, I see this problem even without
>>>>>>> any change of themes during the session.  That part of the problem, at
>>>>>>> least, needs a fix.
>>>>>>>
>>>>>>
>>>>>>
>>>>>> Mixer board on Linux the contrast between button and button text is
>>>>>> very low (hard to read "Mute" and  "Solo"). I agree that this part is not
>>>>>> "fringe".
>>>>>>
>>>>>> When changing themes, the Mixer board does not fully update until
>>>>>> Audacity is restarted. I agree with Peter that this part is closer to the
>>>>>> fringe, but would be good to fix for 2.2.0 if possible.
>>>>>>
>>>>>> Also, on opening the Mixer board the first time in a session, in
>>>>>> Debug build, there is an assert (see attached).
>>>>>>
>>>>>> Steve
>>>>>>
>>>>>>
>>>>>>>
>>>>>>> PRL
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> Peter.
>>>>>>>>
>>>>>>>> On Wed, Jun 21, 2017 at 11:23 PM, James Crook <crookj@...>
>>>>>>>> wrote:
>>>>>>>>
>>>>>>>>> On 6/21/2017 10:23 PM, Paul Licameli wrote:
>>>>>>>>>
>>>>>>>>> I started Audacity in Hi Contrast theme.  I generated noise and opened the
>>>>>>>>> Mixer board.
>>>>>>>>>
>>>>>>>>> No.  You started in classic theme and then switched to Hi Contrast.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>    - The green text of "Audio Track" contrasts poorly with a gray
>>>>>>>>>    background that is unchanged from Classic theme.  So it seems the
>>>>>>>>>    repainting of Mixer Board was missed by the theming project.
>>>>>>>>>
>>>>>>>>> Correct.  Mixer board caches lots of its colours rather than
>>>>>>>>> fetching them as needed.
>>>>>>>>> I can go in and change that.  Not too hard to do.
>>>>>>>>>
>>>>>>>>>    - Then I changed theme back to Classic in preferences.  The still open
>>>>>>>>>    Mixer board did not update, except for the numbers on the meter.
>>>>>>>>>    - I made a new track.  Now I see two mixer sliders with different themes!
>>>>>>>>>    - I close and reopen the Mixer board window, and I still see the same.
>>>>>>>>>    - I can change theme, add a track, and then see the Mixer board again,
>>>>>>>>>    and repeat, and so even make one slider in each of four themes.
>>>>>>>>>
>>>>>>>>> Oh, that's cute.  I hadn't realised quite how much caching of
>>>>>>>>> pens/brushes Mixer board was doing.  Sounds like it is creating new brushes
>>>>>>>>> for each track.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>    - Light theme looks tolerable, but numbers and text in Dark are even
>>>>>>>>>    less legible than for Hi Contrast.
>>>>>>>>>
>>>>>>>>> Well, yes, when you have a mix of themes in action.  If you select
>>>>>>>>> a theme and restart Audacity it should look about as good/bad as the main
>>>>>>>>> TrackPanel.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>    - A general problem, with both Mixer boards and TCP, is that the little
>>>>>>>>>    L and R appear with a small box of mis-matched background color when the
>>>>>>>>>    track is selected.
>>>>>>>>>
>>>>>>>>> I don't see this on Windows, but yes, it is easy enough to fix.
>>>>>>>>>
>>>>>>>>> The + and - of gain don't do this.  (I see those are
>>>>>>>>>    actually drawn differently, by actually stroking three little lines, not by
>>>>>>>>>    use of fonts!)  Is there a simple way to get transparency for the
>>>>>>>>>    background of text?  Was that neglected?
>>>>>>>>>
>>>>>>>>> You still need to set the right background colour to get the right
>>>>>>>>> anti-aliassing of text, so it must be I didn't set the correct background
>>>>>>>>> colour.   Will fix presently.
>>>>>>>>>
>>>>>>>>> --James.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> PRL
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>
>>>>>>
>>>>>> ------------------------------------------------------------
>>>>>> ------------------
>>>>>> Check out the vibrant tech community on one of the world's most
>>>>>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>>>>>> _______________________________________________
>>>>>> Audacity-quality mailing list
>>>>>> Audacity-quality@...
>>>>>> https://lists.sourceforge.net/lists/listinfo/audacity-quality
>>>>>>
>>>>>>
>>>>>
>>>>
>>>> ------------------------------------------------------------
>>>> ------------------
>>>> Check out the vibrant tech community on one of the world's most
>>>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>>>> _______________________________________________
>>>> Audacity-quality mailing list
>>>> Audacity-quality@...
>>>> https://lists.sourceforge.net/lists/listinfo/audacity-quality
>>>>
>>>>
>>>
>>
>
> ------------------------------------------------------------
> ------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> Audacity-quality mailing list
> Audacity-quality@...
> https://lists.sourceforge.net/lists/listinfo/audacity-quality
>
>

Re: [Audacity-quality] zooming issue in Vertical Scale

[Steve the Fiddle <stevethefiddle@gm...>]

Confirmed. Vertical ruler zooming is broken on Linux too.

Steve

On 22 June 2017 at 13:47, Peter Sampson <petersampsonaudacity@...>
wrote:

> Now here's an interesting one ...
>
> On the latest Windows nightly build audacity-win-r1c03eee-2.2.0-alpha-22-jun-17
> on W10
>
> 1) default settings - clear the .ffg files
> 2) record some audio (Stereo or Mono)
> 3) right click in the Vertical Scale
> 4) VS shrinks to a thin band - looks as though there are no numbers to
> display (at that zoom level) I'm thinking
> 5) right click in VS again VS expands ok with numbers
> 6) right click in VS again VS expands ok with numbers
>
> And then another odd thing
>
> 7) left click in VS
> 8) returns immediately to default vertical zoom level
> I thought it was supposed to step back up the zoom leveles one level at a
> time ???
>
> Step 4 looks odd and unsettling - step 8 looks wrong
>
> On 2.1.3 you can't even do steps 5 & 6 as there appears to be only one
> levele of zoom down.
>
> Peter.
>
> ------------------------------------------------------------
> ------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> Audacity-quality mailing list
> Audacity-quality@...
> https://lists.sourceforge.net/lists/listinfo/audacity-quality
>
>

Re: [Audacity-quality] Theming problems with Mixer board and pan sliders

[Peter Sampson <petersampsonaudacity@gm...>]

On Thu, Jun 22, 2017 at 1:39 PM, Steve the Fiddle <stevethefiddle@...>
wrote:

>
>
> On 22 June 2017 at 13:25, Peter Sampson <petersampsonaudacity@...>
> wrote:
>
>>
>>
>> On Thu, Jun 22, 2017 at 1:15 PM, Steve the Fiddle <
>> stevethefiddle@...> wrote:
>>
>>> Testing on Linux (Xubuntu) debug build
>>> https://github.com/audacity/audacity/commit/86901a00a1aa
>>>
>>> No I don't get duplicate audio tracks.
>>>
>>
>>
>> Have you got two tracks in your project, both called "Audio"
>>
>
> Yes, that's a project with two  mono tracks.
>

"Aye, ther's the rub..."  -  this bug does not affect mono tracks

Peter


>
> With one stereo track, I see two sliders, one for each channel, which I
> think is what you mean by duplicate tracks. This may be intentional, but I
> agree that it is not clear, and the pan sliders behave a bit strangely in
> that moving one does not drag the other (as I would expect for two linked
> channels), but the other does move to the same position when the pan slider
> for the first channel is released.
>
> Steve
>
>
>
>
>> If you only have one stereo track then you are getting a duplicate in MB
>>
>> Each pane has Left & Right channels - so you are exhibiting four channels
>> in your image.
>>
>> In testing it will help if you name tracks differently.
>>
>> I am seeing exactly the same behavior on my Macbook - so I'm raising a
>> bug on Bugzilla.
>>
>> Peter
>>
>>
>>> Yes the text on the buttons is hard to read in Dark theme:
>>>
>>>
>>> Enabling / disabling the Blend system does not affect the button text
>>> contrast (it looks the same regardless).
>>>
>>> The Mixer board theme now updates when the theme is changed in
>>> preferences.
>>>
>>> There's an assert on changing the Theme when the Mixer board is open.
>>> Backtrace attached.
>>>
>>> Steve
>>> ​
>>>
>>> On 22 June 2017 at 12:55, Peter Sampson <petersampsonaudacity@...>
>>> wrote:
>>>
>>>>
>>>>
>>>> On Thu, Jun 22, 2017 at 12:37 PM, Peter Sampson <
>>>> petersampsonaudacity@...> wrote:
>>>>
>>>>> In general the Mixer Board has a lot of defects that need fixing.
>>>>>
>>>>
>>>> And now I seem to have found another one - now when I turn on the Mixer
>>>> Board
>>>> I get not one but two instances of each audio track.
>>>>
>>>> Both instances respond to the signal levels in the track when playing.
>>>>
>>>> Anybody else seeing this ?
>>>>
>>>> I suspect that Gale will regard this as more than P4/P3 - it is a
>>>> regression on 2.1.3
>>>> Fo my money it would be a show-stopper P1 - it just looks darn silly -
>>>> and wastes
>>>> valuable Mixer Board screen real-estate.
>>>>
>>>> Peter.
>>>>
>>>>
>>>>
>>>>>
>>>>> See this page I put together on the Wiki a while back:
>>>>> http://wiki.audacityteam.org/wiki/User:PeterSampson/Mixer_Board_issues
>>>>> Eight Bugzilla bugs, five of which are P3 release noted.
>>>>>
>>>>> Peter.
>>>>>
>>>>> On Thu, Jun 22, 2017 at 12:33 PM, Steve the Fiddle <
>>>>> stevethefiddle@...> wrote:
>>>>>
>>>>>>
>>>>>>
>>>>>> On 22 June 2017 at 11:28, Paul Licameli <paul.licameli@...>
>>>>>> wrote:
>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On Thu, Jun 22, 2017 at 5:42 AM, Peter Sampson <
>>>>>>> petersampsonaudacity@...> wrote:
>>>>>>>
>>>>>>>> I'm thinking here that a user deciding to switch themes in the
>>>>>>>> middle
>>>>>>>> of a session with Mixer Board is unlikely to be switching themes -
>>>>>>>> so
>>>>>>>> this is a bit of a fringe case.
>>>>>>>>
>>>>>>>> I'm suspecting that most users will select a theme and then stick
>>>>>>>> with it.
>>>>>>>> More than that I'm suspecting that most users will stick with the
>>>>>>>> new
>>>>>>>> Light theme that we present them with as the default for 2.2.0.
>>>>>>>>
>>>>>>>> This does not mean that this would not be a "nice to fix" - but it
>>>>>>>> should be
>>>>>>>> logged on Bugzilla - and personally I can't see it rating more than
>>>>>>>> P4, maybe
>>>>>>>> P3 if we decide we want it release noted.
>>>>>>>>
>>>>>>>
>>>>>>> I tell you it's not a fringe case -- I say that if you start
>>>>>>> Audacity in Dark or Hi Contrast theme, and open the mixer board, then the
>>>>>>> names and numbers are illegible because they contrast too weakly with the
>>>>>>> background.  Contrary to what James said, I see this problem even without
>>>>>>> any change of themes during the session.  That part of the problem, at
>>>>>>> least, needs a fix.
>>>>>>>
>>>>>>
>>>>>>
>>>>>> Mixer board on Linux the contrast between button and button text is
>>>>>> very low (hard to read "Mute" and  "Solo"). I agree that this part is not
>>>>>> "fringe".
>>>>>>
>>>>>> When changing themes, the Mixer board does not fully update until
>>>>>> Audacity is restarted. I agree with Peter that this part is closer to the
>>>>>> fringe, but would be good to fix for 2.2.0 if possible.
>>>>>>
>>>>>> Also, on opening the Mixer board the first time in a session, in
>>>>>> Debug build, there is an assert (see attached).
>>>>>>
>>>>>> Steve
>>>>>>
>>>>>>
>>>>>>>
>>>>>>> PRL
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> Peter.
>>>>>>>>
>>>>>>>> On Wed, Jun 21, 2017 at 11:23 PM, James Crook <crookj@...>
>>>>>>>> wrote:
>>>>>>>>
>>>>>>>>> On 6/21/2017 10:23 PM, Paul Licameli wrote:
>>>>>>>>>
>>>>>>>>> I started Audacity in Hi Contrast theme.  I generated noise and opened the
>>>>>>>>> Mixer board.
>>>>>>>>>
>>>>>>>>> No.  You started in classic theme and then switched to Hi Contrast.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>    - The green text of "Audio Track" contrasts poorly with a gray
>>>>>>>>>    background that is unchanged from Classic theme.  So it seems the
>>>>>>>>>    repainting of Mixer Board was missed by the theming project.
>>>>>>>>>
>>>>>>>>> Correct.  Mixer board caches lots of its colours rather than
>>>>>>>>> fetching them as needed.
>>>>>>>>> I can go in and change that.  Not too hard to do.
>>>>>>>>>
>>>>>>>>>    - Then I changed theme back to Classic in preferences.  The still open
>>>>>>>>>    Mixer board did not update, except for the numbers on the meter.
>>>>>>>>>    - I made a new track.  Now I see two mixer sliders with different themes!
>>>>>>>>>    - I close and reopen the Mixer board window, and I still see the same.
>>>>>>>>>    - I can change theme, add a track, and then see the Mixer board again,
>>>>>>>>>    and repeat, and so even make one slider in each of four themes.
>>>>>>>>>
>>>>>>>>> Oh, that's cute.  I hadn't realised quite how much caching of
>>>>>>>>> pens/brushes Mixer board was doing.  Sounds like it is creating new brushes
>>>>>>>>> for each track.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>    - Light theme looks tolerable, but numbers and text in Dark are even
>>>>>>>>>    less legible than for Hi Contrast.
>>>>>>>>>
>>>>>>>>> Well, yes, when you have a mix of themes in action.  If you select
>>>>>>>>> a theme and restart Audacity it should look about as good/bad as the main
>>>>>>>>> TrackPanel.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>    - A general problem, with both Mixer boards and TCP, is that the little
>>>>>>>>>    L and R appear with a small box of mis-matched background color when the
>>>>>>>>>    track is selected.
>>>>>>>>>
>>>>>>>>> I don't see this on Windows, but yes, it is easy enough to fix.
>>>>>>>>>
>>>>>>>>> The + and - of gain don't do this.  (I see those are
>>>>>>>>>    actually drawn differently, by actually stroking three little lines, not by
>>>>>>>>>    use of fonts!)  Is there a simple way to get transparency for the
>>>>>>>>>    background of text?  Was that neglected?
>>>>>>>>>
>>>>>>>>> You still need to set the right background colour to get the right
>>>>>>>>> anti-aliassing of text, so it must be I didn't set the correct background
>>>>>>>>> colour.   Will fix presently.
>>>>>>>>>
>>>>>>>>> --James.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> PRL
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>
>>>>>>
>>>>>> ------------------------------------------------------------
>>>>>> ------------------
>>>>>> Check out the vibrant tech community on one of the world's most
>>>>>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>>>>>> _______________________________________________
>>>>>> Audacity-quality mailing list
>>>>>> Audacity-quality@...
>>>>>> https://lists.sourceforge.net/lists/listinfo/audacity-quality
>>>>>>
>>>>>>
>>>>>
>>>>
>>>> ------------------------------------------------------------
>>>> ------------------
>>>> Check out the vibrant tech community on one of the world's most
>>>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>>>> _______________________________________________
>>>> Audacity-quality mailing list
>>>> Audacity-quality@...
>>>> https://lists.sourceforge.net/lists/listinfo/audacity-quality
>>>>
>>>>
>>>
>>
>
> ------------------------------------------------------------
> ------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> Audacity-quality mailing list
> Audacity-quality@...
> https://lists.sourceforge.net/lists/listinfo/audacity-quality
>
>