Thread: [Audacity-devel] Pull Request #252
A free multi-track audio editor and recorder
Brought to you by:
aosiniao
From: andheh <an...@po...> - 2018-02-10 13:58:58
|
Hello audacity-developers! I'm andheh. I submitted this pull request https://github.com/audacity/audacity/pull/252 on github last week. It enables to switch the vertical ruler of the spectrogram display of an audio track from showing frequencies in Hz to showing musical note names. The changes include: * The new ruler mode. * Extended the spectrogram settings to switch between Hz and note display and to set the tuning of "a4" (default: 440Hz). * Added a Clamp function. * Removed an old, unused "CustomMode" of the Ruler class and added a function to add custom ticks * Added generalized versions of FreqToMIDInote() and MIDInoteToFreq() which include the tuning frequency of "a4". I just read on the wiki that you prefer to discuss larger changes/additions on the mailinglist, so I write this mail to get the discussion started. :) Has anyone had a look at my proposed changes already? I welcome more feedback on the changes! Best, andheh |
From: Paul L. <pau...@gm...> - 2018-02-10 17:50:15
|
Hello andheh, This looks like an interesting project, but you propose the changes at an inopportune time. Our code is feature-frozen and we are in the process of releasing. I know I will give this more attention when we thaw, and perhaps James is interested too, as one who most lately made improvements for the vertical rulers of tracks. PRL On Sat, Feb 10, 2018 at 8:58 AM, andheh <an...@po...> wrote: > Hello audacity-developers! > > I'm andheh. I submitted this pull request > https://github.com/audacity/audacity/pull/252 > on github last week. > It enables to switch the vertical ruler of the spectrogram display of an > audio track from showing frequencies in Hz to showing musical note names. > > The changes include: > * The new ruler mode. > * Extended the spectrogram settings to switch between Hz and > note display and to set the tuning of "a4" (default: 440Hz). > * Added a Clamp function. > * Removed an old, unused "CustomMode" of the Ruler class and added > a function to add custom ticks > * Added generalized versions of FreqToMIDInote() and MIDInoteToFreq() > which include the tuning frequency of "a4". > > I just read on the wiki that you prefer to discuss larger > changes/additions on the mailinglist, so I write this mail to get the > discussion started. :) > > Has anyone had a look at my proposed changes already? > I welcome more feedback on the changes! > > Best, > andheh > > > > ------------------------------------------------------------ > ------------------ > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > _______________________________________________ > audacity-devel mailing list > aud...@li... > https://lists.sourceforge.net/lists/listinfo/audacity-devel > |
From: andheh <an...@po...> - 2018-02-11 20:36:13
|
Hi Paul, thanks for your mail! Sure, an approaching release is really not a good time to merge a new feature. I guess I'll drop another mail once this is done. :) Good luck with the release! Best, andheh |
From: andheh <an...@po...> - 2018-02-26 18:53:47
|
Hi audacity-developers, congratulations on the new release! For the next release cycle I would like to propose pull request https://github.com/audacity/audacity/pull/252 again. It adds a vertical ruler mode for the spectrogram display showing names of musical notes instead of frequencies in Hz. Please have a look and let me know if you have any comments. :) Best, andheh On 02/10/2018 06:50 PM, Paul Licameli wrote: > Hello andheh, > > This looks like an interesting project, but you propose the changes at > an inopportune time. Our code is feature-frozen and we are in the > process of releasing. > > I know I will give this more attention when we thaw, and perhaps James > is interested too, as one who most lately made improvements for the > vertical rulers of tracks. > > PRL > > > > On Sat, Feb 10, 2018 at 8:58 AM, andheh <an...@po... > <mailto:an...@po...>> wrote: > > Hello audacity-developers! > > I'm andheh. I submitted this pull request > https://github.com/audacity/audacity/pull/252 > <https://github.com/audacity/audacity/pull/252> > on github last week. > It enables to switch the vertical ruler of the spectrogram display of an > audio track from showing frequencies in Hz to showing musical note > names. > > The changes include: > * The new ruler mode. > * Extended the spectrogram settings to switch between Hz and > note display and to set the tuning of "a4" (default: 440Hz). > * Added a Clamp function. > * Removed an old, unused "CustomMode" of the Ruler class and added > a function to add custom ticks > * Added generalized versions of FreqToMIDInote() and MIDInoteToFreq() > which include the tuning frequency of "a4". > > I just read on the wiki that you prefer to discuss larger > changes/additions on the mailinglist, so I write this mail to get the > discussion started. :) > > Has anyone had a look at my proposed changes already? > I welcome more feedback on the changes! > > Best, > andheh > > > > ------------------------------------------------------------------------------ > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > _______________________________________________ > audacity-devel mailing list > aud...@li... > <mailto:aud...@li...> > https://lists.sourceforge.net/lists/listinfo/audacity-devel > <https://lists.sourceforge.net/lists/listinfo/audacity-devel> > > > > > ------------------------------------------------------------------------------ > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > > > > _______________________________________________ > audacity-devel mailing list > aud...@li... > https://lists.sourceforge.net/lists/listinfo/audacity-devel > |
From: andheh <an...@po...> - 2018-03-21 10:53:28
|
Hi, > congratulations on the new release! > For the next release cycle I would like to propose pull request > https://github.com/audacity/audacity/pull/252 again. > It adds a vertical ruler mode for the spectrogram display showing names > of musical notes instead of frequencies in Hz. > Please have a look and let me know if you have any comments. :) James suggested I should add a screenshot to show what I propose in https://github.com/audacity/audacity/pull/252 new_spectrogram_ruler_screenshot.jpg shows the new ruler and the additional spectrogram settings I propose. spectrogram_ruler_default.jpg shows the ruler as it was before. This mode is still available in my version by setting "Frequency Labels" to "Hertz" instead of "Notes (Equal Temperament)". I created this feature, because I had single instrument recordings and had to write comments in music sheets. With the ruler it is significantly easier to see which notes are played and where you are in the sheets just by looking at the spectrogram. I'm also working on a series of changes (which are not part of this pull request) to enable horizontal lines on the spectrum for each of the ruler's tics. I noticed there was a previous attempt to do this: EXPERIMENTAL_FFT_Y_GRID in TrackArtist.cpp, but this only creates the horizontal grid and does not add labels to the musical notes. I'll write about the grid in a separate mail. Best, andy |
From: James C. <cr...@in...> - 2018-03-21 13:44:28
|
On 3/21/2018 10:53 AM, andheh wrote: > Hi, > > James suggested I should add a screenshot to show what I propose in > https://github.com/audacity/audacity/pull/252 > > new_spectrogram_ruler_screenshot.jpg shows the new ruler and the > additional spectrogram settings I propose. > spectrogram_ruler_default.jpg shows the ruler as it was before. This > mode is still available in my version by setting "Frequency Labels" to > "Hertz" instead of "Notes (Equal Temperament)". I like the idea, but not the presentation. The frequencies in brackets don't look great. They are too cluttered. I think I'd like this feature, if you use 'scientific notation', i.e. a subscript of 0, 1, 2, 3... for the different octaves. Also please support MIDI note numbers too, and change the 'Frequency Labels' drop down to be: Hertz, Notes (Scientific), Notes (MIDI). Here 440 Hz is A subscript 4 is MIDI note 69. > I created this feature, because I had single instrument recordings and > had to write comments in music sheets. With the ruler it is > significantly easier to see which notes are played and where you are in > the sheets just by looking at the spectrogram. > > I'm also working on a series of changes (which are not part of this pull > request) to enable horizontal lines on the spectrum for each of the > ruler's tics. Mmm. Would need to see a screenshot. Possibly zebra-striping, centred on the notes, would help. Possibly useful in wave view too. > I noticed there was a previous attempt to do this: > EXPERIMENTAL_FFT_Y_GRID in TrackArtist.cpp, but this only creates the > horizontal grid and does not add labels to the musical notes. > I'll write about the grid in a separate mail. > > Best, > andy |
From: andheh <an...@po...> - 2018-03-21 22:15:45
|
On 03/21/2018 02:44 PM, James Crook wrote: > > I like the idea, but not the presentation. The frequencies in brackets > don't look great. They are too cluttered. I think I'd like this > feature, if you use 'scientific notation', i.e. a subscript of 0, 1, 2, > 3... for the different octaves. Also please support MIDI note numbers > too, and change the 'Frequency Labels' drop down to be: > > Hertz, Notes (Scientific), Notes (MIDI). > > Here 440 Hz is A subscript 4 is MIDI note 69. Sounds good, I'll change/add that. However, I would also like to have a "Notes + Hertz" mode as an option. If you work with modular synths this is helpful every now and then. :) > >> I created this feature, because I had single instrument recordings and >> had to write comments in music sheets. With the ruler it is >> significantly easier to see which notes are played and where you are in >> the sheets just by looking at the spectrogram. >> >> I'm also working on a series of changes (which are not part of this pull >> request) to enable horizontal lines on the spectrum for each of the >> ruler's tics. > > Mmm. Would need to see a screenshot. > Possibly zebra-striping, centred on the notes, would help. > Possibly useful in wave view too. > Yes, I guess zebra-striping would be better, but would also require significantly more changes. My guess is that the DrawGrid method provided by the ruler widget should already be pretty good. I'll send a screenshot as soon as I have something working (see my "Spectrogram horizontal grid, TrackPanel/TrackArtist refactor" mail). Best, andy |
From: Federico M. <fm...@fc...> - 2018-03-22 05:08:27
|
This would be an interesting feature. If finally added to Audacity, please notice that the notes names should be localizable since there are at least three styles: English (C, D, E, F, G, A, B...), German (C, D, E, F, G, A, H) and Italian / Spanish / French (Do, Re, Mi, Fa, Sol, La, Si). In the latter case there are also differences in diacritics. Federico On 21/03/2018 7:53, andheh wrote: > Hi, > >> congratulations on the new release! >> For the next release cycle I would like to propose pull request >> https://github.com/audacity/audacity/pull/252 again. >> It adds a vertical ruler mode for the spectrogram display showing names >> of musical notes instead of frequencies in Hz. >> Please have a look and let me know if you have any comments. :) > James suggested I should add a screenshot to show what I propose in > https://github.com/audacity/audacity/pull/252 > > new_spectrogram_ruler_screenshot.jpg shows the new ruler and the > additional spectrogram settings I propose. > spectrogram_ruler_default.jpg shows the ruler as it was before. This > mode is still available in my version by setting "Frequency Labels" to > "Hertz" instead of "Notes (Equal Temperament)". > > I created this feature, because I had single instrument recordings and > had to write comments in music sheets. With the ruler it is > significantly easier to see which notes are played and where you are in > the sheets just by looking at the spectrogram. > > I'm also working on a series of changes (which are not part of this pull > request) to enable horizontal lines on the spectrum for each of the > ruler's tics. > I noticed there was a previous attempt to do this: > EXPERIMENTAL_FFT_Y_GRID in TrackArtist.cpp, but this only creates the > horizontal grid and does not add labels to the musical notes. > I'll write about the grid in a separate mail. > > Best, > andy --- El software de antivirus Avast ha analizado este correo electrónico en busca de virus. https://www.avast.com/antivirus |
From: andheh <an...@po...> - 2018-03-22 10:46:26
|
On 03/22/2018 06:07 AM, Federico Miyara wrote: > This would be an interesting feature. If finally added to Audacity, > please notice that the notes names should be localizable since there are > at least three styles: English (C, D, E, F, G, A, B...), German (C, D, > E, F, G, A, H) and Italian / Spanish / French (Do, Re, Mi, Fa, Sol, La, > Si). In the latter case there are also differences in diacritics. I just reused the note name functions provided by PitchNames.cpp. If they have been translated already, it should work out of the box. A question though: I guess the English/international scientific notation with octave subscripts (e.g. B_4) works the same way in German (H_4), but how do you add the octave in the Romance languages? Is Si_4 ("Si" subscript "4") commonly used? Cheers, andy |
From: Steve t. F. <ste...@gm...> - 2018-03-22 11:15:50
|
On 22 March 2018 at 10:46, andheh <an...@po...> wrote: > > > On 03/22/2018 06:07 AM, Federico Miyara wrote: >> This would be an interesting feature. If finally added to Audacity, >> please notice that the notes names should be localizable since there are >> at least three styles: English (C, D, E, F, G, A, B...), German (C, D, >> E, F, G, A, H) and Italian / Spanish / French (Do, Re, Mi, Fa, Sol, La, >> Si). In the latter case there are also differences in diacritics. > > I just reused the note name functions provided by PitchNames.cpp. If > they have been translated already, it should work out of the box. > > A question though: I guess the English/international scientific notation > with octave subscripts (e.g. B_4) works the same way in German (H_4), > but how do you add the octave in the Romance languages? > Is Si_4 ("Si" subscript "4") commonly used? My personal view is that when there is an "International" notation (such as "IPN"), it's better to use the international notation rather than localised variants that may have limitations or subtleties that are incompatible with the international version. For example, while it may be possible to translate IPN note names into Gongchi character notation (as used in Chinese opera), the Chinese scale is based on natural harmonics rather than equal temperament, so the frequencies of some notes are different. Steve > > Cheers, > andy > |
From: andheh <an...@po...> - 2018-03-22 13:11:11
Attachments:
ruler_scientific_notes.jpg
|
On 03/21/2018 02:44 PM, James Crook wrote: > I like the idea, but not the presentation. The frequencies in brackets > don't look great. They are too cluttered. I think I'd like this > feature, if you use 'scientific notation', i.e. a subscript of 0, 1, 2, > 3... for the different octaves. Also please support MIDI note numbers > too, and change the 'Frequency Labels' drop down to be: > > Hertz, Notes (Scientific), Notes (MIDI). > > Here 440 Hz is A subscript 4 is MIDI note 69. > I tried the scientific subscript notation, but I'm not quite happy with the outcome. The subscripts are pretty hard to read on my machine. Here's a screenshot at full resolution. I think there are two solutions to this: a) increase font size b) don't use subscripts, just append the octave (e.g. "A4") I don't like a) because that would reduce the number of visible labels and ticks. In the example shown in the screenshot, the labels of "F" and "B" were already omitted. While b) is not the official scientific notation, it still seems pretty common. So that's my preferred solution. Any other ideas? Best, andy |
From: David B. <drb...@gm...> - 2018-03-22 15:12:27
|
On 22 March 2018 at 13:10, andheh <an...@po...> wrote: > > > On 03/21/2018 02:44 PM, James Crook wrote: > > I like the idea, but not the presentation. The frequencies in brackets > > don't look great. They are too cluttered. I think I'd like this > > feature, if you use 'scientific notation', i.e. a subscript of 0, 1, 2, > > 3... for the different octaves. Also please support MIDI note numbers > > too, and change the 'Frequency Labels' drop down to be: > > > > Hertz, Notes (Scientific), Notes (MIDI). > > > > Here 440 Hz is A subscript 4 is MIDI note 69. > > > > I tried the scientific subscript notation, but I'm not quite happy with > the outcome. The subscripts are pretty hard to read on my machine. > Here's a screenshot at full resolution. > > I think there are two solutions to this: > a) increase font size > b) don't use subscripts, just append the octave (e.g. "A4") > > I don't like a) because that would reduce the number of visible labels > and ticks. In the example shown in the screenshot, the labels of "F" and > "B" were already omitted. > > While b) is not the official scientific notation, it still seems pretty > common. So that's my preferred solution. > Any other ideas? > I would second option b). Easier to read, especially for those with less than perfect eyesight. David. > > Best, > andy > > > ------------------------------------------------------------ > ------------------ > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > _______________________________________________ > audacity-devel mailing list > aud...@li... > https://lists.sourceforge.net/lists/listinfo/audacity-devel > > |
From: James C. <cr...@in...> - 2018-03-22 13:52:58
|
I'm suggesting: 1) Make all notes bold, not just A and C, and make the subscript not bold. 2) Increase the size of the subscript by 60% 3) Displace the subscript downwards by half its height. My expectation is that this will make the subscript readable, whilst still making it clear that the subscript is a subscript. ----- About translation of subscripts... You should offer the string "%s_%i" for translation. It might become "C_5" after translation. Provide a translation hint explaining what it is. If subscripts on notes don't work in some language, the translator can translate "%s_%i" to "%s" to just get the note. --James. On 3/22/2018 1:10 PM, andheh wrote: > > On 03/21/2018 02:44 PM, James Crook wrote: >> I like the idea, but not the presentation. The frequencies in brackets >> don't look great. They are too cluttered. I think I'd like this >> feature, if you use 'scientific notation', i.e. a subscript of 0, 1, 2, >> 3... for the different octaves. Also please support MIDI note numbers >> too, and change the 'Frequency Labels' drop down to be: >> >> Hertz, Notes (Scientific), Notes (MIDI). >> >> Here 440 Hz is A subscript 4 is MIDI note 69. >> > I tried the scientific subscript notation, but I'm not quite happy with > the outcome. The subscripts are pretty hard to read on my machine. > Here's a screenshot at full resolution. > > I think there are two solutions to this: > a) increase font size > b) don't use subscripts, just append the octave (e.g. "A4") > > I don't like a) because that would reduce the number of visible labels > and ticks. In the example shown in the screenshot, the labels of "F" and > "B" were already omitted. > > While b) is not the official scientific notation, it still seems pretty > common. So that's my preferred solution. > Any other ideas? > > Best, > andy > > > > ------------------------------------------------------------------------------ > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > > > _______________________________________________ > audacity-devel mailing list > aud...@li... > https://lists.sourceforge.net/lists/listinfo/audacity-devel |
From: Federico M. <fm...@fc...> - 2018-03-22 15:19:06
|
Andy, Yes. However, here is a second problem, since three standards are in use, calling C3, C4 and C5 to the central C (262 Hz). However the "scientfic" or "international" one, C4, is the most used one, but C3 is used in France, Spain and Belgium. Perhaps this would also need to be localized. Federico On 22/03/2018 07:46, andheh wrote: > > On 03/22/2018 06:07 AM, Federico Miyara wrote: >> This would be an interesting feature. If finally added to Audacity, >> please notice that the notes names should be localizable since there are >> at least three styles: English (C, D, E, F, G, A, B...), German (C, D, >> E, F, G, A, H) and Italian / Spanish / French (Do, Re, Mi, Fa, Sol, La, >> Si). In the latter case there are also differences in diacritics. > I just reused the note name functions provided by PitchNames.cpp. If > they have been translated already, it should work out of the box. > > A question though: I guess the English/international scientific notation > with octave subscripts (e.g. B_4) works the same way in German (H_4), > but how do you add the octave in the Romance languages? > Is Si_4 ("Si" subscript "4") commonly used? > > Cheers, > andy > > ------------------------------------------------------------------------------ > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > _______________________________________________ > audacity-devel mailing list > aud...@li... > https://lists.sourceforge.net/lists/listinfo/audacity-devel > --- El software de antivirus Avast ha analizado este correo electrónico en busca de virus. https://www.avast.com/antivirus |
From: andheh <an...@po...> - 2018-03-22 17:26:37
|
Hi James, On 03/22/2018 02:52 PM, James Crook wrote: > I'm suggesting: > > 1) Make all notes bold, not just A and C, and make the subscript not bold. > 2) Increase the size of the subscript by 60% > 3) Displace the subscript downwards by half its height. > > My expectation is that this will make the subscript readable, whilst > still making it clear that the subscript is a subscript. hm, alright, that would mean I have write a separate label renderer or something, right? At the moment I just pass wxStrings with utf8 subscript characters to the ruler widget and leave all the rendering magic to the existing widget. A and C are bold because I pass them as major ticks. They should be the ones visible if there is not enough space to display more ticks. Next are all other natural notes (passed as minor ticks) and then the flat/sharp notes (minor minor ticks). It should be easy to modify the ruler widget to make all ticks bold in this case. Actually one note per octave would be sufficient as major ticks for broad spectrograms. I picked A and C, because they seem to be the most common reference points. We could also add a setting to choose the major tick note, but I would like to keep the settings minimal. > > About translation of subscripts... > You should offer the string "%s_%i" for translation. It might become > "C_5" after translation. Provide a translation hint explaining what it > is. If subscripts on notes don't work in some language, the translator > can translate "%s_%i" to "%s" to just get the note. I don't quite see how you would render the subscript if you allow for translations like that. Are you suggesting a function that parses a wxString "x_y" and renders it as label with subscript to allow for the translation? Best, andy |
From: James C. <cr...@in...> - 2018-03-22 18:36:48
|
On 3/22/2018 5:26 PM, andheh wrote: > I don't quite see how you would render the subscript if you allow for > translations like that. Are you suggesting a function that parses a > wxString "x_y" and renders it as label with subscript to allow for the > translation? Yes. > Best, > andy |
From: Roger D. <rb...@cs...> - 2018-03-22 18:01:57
|
"The great thing about standards is there are so many to choose from" I think C4 is middle C is an ISO standard and we should stick to it -- if everyone followed interntional standards, problems would be reduced, and we should promote ISO rather than local "non"standards. -Roger On 3/22/18 11:18 AM, Federico Miyara wrote: > > Andy, > > Yes. However, here is a second problem, since three standards are in > use, calling C3, C4 and C5 to the central C (262 Hz). However the > "scientfic" or "international" one, C4, is the most used one, but C3 > is used in France, Spain and Belgium. Perhaps this would also need to > be localized. > > Federico > > > On 22/03/2018 07:46, andheh wrote: >> On 03/22/2018 06:07 AM, Federico Miyara wrote: >>> This would be an interesting feature. If finally added to Audacity, >>> please notice that the notes names should be localizable since there are >>> at least three styles: English (C, D, E, F, G, A, B...), German (C, D, >>> E, F, G, A, H) and Italian / Spanish / French (Do, Re, Mi, Fa, Sol, La, >>> Si). In the latter case there are also differences in diacritics. >> I just reused the note name functions provided by PitchNames.cpp. If >> they have been translated already, it should work out of the box. >> >> A question though: I guess the English/international scientific notation >> with octave subscripts (e.g. B_4) works the same way in German (H_4), >> but how do you add the octave in the Romance languages? >> Is Si_4 ("Si" subscript "4") commonly used? >> >> Cheers, >> andy >> >> ------------------------------------------------------------------------------ >> Check out the vibrant tech community on one of the world's most >> engaging tech sites, Slashdot.org! http://sdm.link/slashdot >> _______________________________________________ >> audacity-devel mailing list >> aud...@li... >> https://lists.sourceforge.net/lists/listinfo/audacity-devel >> > > > <https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=emailclient> > Libre de virus. www.avast.com > <https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=emailclient> > > > <#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2> > > > ------------------------------------------------------------------------------ > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > > > _______________________________________________ > audacity-devel mailing list > aud...@li... > https://lists.sourceforge.net/lists/listinfo/audacity-devel |
From: Vaughan J. <v.a...@gm...> - 2018-04-02 04:45:00
|
On Thu, Mar 22, 2018 at 11:01 AM, Roger Dannenberg <rb...@cs...> wrote: > "The great thing about standards is there are so many to choose from" > +1. I first heard that from the guy who started much of Computer Graphics, *Ivan Sutherland.* > I think C4 is middle C is an ISO standard and we should stick to it -- if > everyone followed interntional standards, problems would be reduced, and we > should promote ISO rather than local "non"standards. > Amen. And never mind that 443 thing. ;-)) - Vaughan > -Roger > > On 3/22/18 11:18 AM, Federico Miyara wrote: > > > Andy, > > Yes. However, here is a second problem, since three standards are in use, > calling C3, C4 and C5 to the central C (262 Hz). However the "scientfic" or > "international" one, C4, is the most used one, but C3 is used in France, > Spain and Belgium. Perhaps this would also need to be localized. > > Federico > > > On 22/03/2018 07:46, andheh wrote: > > On 03/22/2018 06:07 AM, Federico Miyara wrote: > > This would be an interesting feature. If finally added to Audacity, > please notice that the notes names should be localizable since there are > at least three styles: English (C, D, E, F, G, A, B...), German (C, D, > E, F, G, A, H) and Italian / Spanish / French (Do, Re, Mi, Fa, Sol, La, > Si). In the latter case there are also differences in diacritics. > > I just reused the note name functions provided by PitchNames.cpp. If > they have been translated already, it should work out of the box. > > A question though: I guess the English/international scientific notation > with octave subscripts (e.g. B_4) works the same way in German (H_4), > but how do you add the octave in the Romance languages? > Is Si_4 ("Si" subscript "4") commonly used? > > Cheers, > andy > > ------------------------------------------------------------------------------ > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > _______________________________________________ > audacity-devel mailing lis...@li...https://lists.sourceforge.net/lists/listinfo/audacity-devel > > > > > <https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=emailclient> Libre > de virus. www.avast.com > <https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=emailclient> > <#m_3084484998137864985_DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2> > > > ------------------------------------------------------------------------------ > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > > > > _______________________________________________ > audacity-devel mailing lis...@li...https://lists.sourceforge.net/lists/listinfo/audacity-devel > > > > ------------------------------------------------------------ > ------------------ > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > _______________________________________________ > audacity-devel mailing list > aud...@li... > https://lists.sourceforge.net/lists/listinfo/audacity-devel > > |
From: andheh <an...@po...> - 2018-03-24 18:56:12
|
On 03/22/2018 02:52 PM, James Crook wrote: > About translation of subscripts... > You should offer the string "%s_%i" for translation. It might become > "C_5" after translation. Provide a translation hint explaining what it > is. If subscripts on notes don't work in some language, the translator > can translate "%s_%i" to "%s" to just get the note. I'm not sure how the translation works. I guess it needs fixed strings to translate be able to translate them, so that would require a table listing all 127 MIDI notes, right? Or can I still rely on the 12 pitch names in PitchNames.cpp and add the octave somehow? andy |
From: James C. <cr...@in...> - 2018-03-24 19:33:23
|
On 3/24/2018 6:55 PM, andheh wrote: > > On 03/22/2018 02:52 PM, James Crook wrote: >> About translation of subscripts... >> You should offer the string "%s_%i" for translation. It might become >> "C_5" after translation. Provide a translation hint explaining what it >> is. If subscripts on notes don't work in some language, the translator >> can translate "%s_%i" to "%s" to just get the note. > I'm not sure how the translation works. I guess it needs fixed strings > to translate be able to translate them, so that would require a table > listing all 127 MIDI notes, right? > Or can I still rely on the 12 pitch names in PitchNames.cpp and add the > octave somehow? > > andy Something like this: // i18n-hint: These are musical notes used in the vertical ruler. The ':OOO:' will be // i18n-hint: replaced by an octave number. Leave the ':OOO:' out in your translation if // i18n-hint: you do not want that. wxString notes[] = { _("A:OOO:"), _("B:OOO:"), _("C:OOO:"), _("D:OOO:"), _("E:OOO:"), _("F:OOO:"), _("G:OOO:"), _("H:OOO:") }; wxString Note= notes[ noteNumber]; int finds = Note.Replace(":OOO:",""); DrawNoteName( Note); if( finds > 0 ) DrawOctaveNumber( octaveNumber ); > > ------------------------------------------------------------------------------ > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > _______________________________________________ > audacity-devel mailing list > aud...@li... > https://lists.sourceforge.net/lists/listinfo/audacity-devel |
From: Steve t. F. <ste...@gm...> - 2018-03-24 20:43:59
|
On 24 March 2018 at 19:33, James Crook <cr...@in...> wrote: > On 3/24/2018 6:55 PM, andheh wrote: > >> >> On 03/22/2018 02:52 PM, James Crook wrote: >> >>> About translation of subscripts... >>> You should offer the string "%s_%i" for translation. It might become >>> "C_5" after translation. Provide a translation hint explaining what it >>> is. If subscripts on notes don't work in some language, the translator >>> can translate "%s_%i" to "%s" to just get the note. >>> >> I'm not sure how the translation works. I guess it needs fixed strings >> to translate be able to translate them, so that would require a table >> listing all 127 MIDI notes, right? >> Or can I still rely on the 12 pitch names in PitchNames.cpp and add the >> octave somehow? >> >> andy >> > > > Something like this: > > // i18n-hint: These are musical notes used in the vertical ruler. The > ':OOO:' will be > // i18n-hint: replaced by an octave number. Leave the ':OOO:' out in your > translation if > // i18n-hint: you do not want that. > wxString notes[] = { _("A:OOO:"), _("B:OOO:"), _("C:OOO:"), _("D:OOO:"), > _("E:OOO:"), _("F:OOO:"), _("G:OOO:"), _("H:OOO:") }; > wxString Note= notes[ noteNumber]; > int finds = Note.Replace(":OOO:",""); > DrawNoteName( Note); > if( finds > 0 ) > DrawOctaveNumber( octaveNumber ); In French, when note names Do, Re, Mi... are used, the octave number is as a subscript number. Steve > > > > > > >> ------------------------------------------------------------ >> ------------------ >> Check out the vibrant tech community on one of the world's most >> engaging tech sites, Slashdot.org! http://sdm.link/slashdot >> _______________________________________________ >> audacity-devel mailing list >> aud...@li... >> https://lists.sourceforge.net/lists/listinfo/audacity-devel >> > > > > ------------------------------------------------------------ > ------------------ > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > _______________________________________________ > audacity-devel mailing list > aud...@li... > https://lists.sourceforge.net/lists/listinfo/audacity-devel > |
From: Federico M. <fm...@fc...> - 2018-03-24 20:29:34
|
I think the subscript style is not necessarily mandatory. In a case as the present one where the subscript could even be illegible in some screens, it seems preferable to prioritize readability, especially considering that the subscript style is not used consistently. See for instance https://en.wikipedia.org/wiki/Scientific_pitch_notation where in the figure showing the octaves on a staff the subscript is not used while in the text it is used. The following reference http://www.dolmetsch.com/musictheory1.htm#uspitch includes both styles plus a few more. The original reference from the Acoustical Society of America https://asa.scitation.org/doi/pdf/10.1121/1.1902141 (abstract 28) uses indeed subscripts, an so does the Music Notation handbook by Gardener Read. I don't have access to the ISO 16 Standard (if it is this the one Roger was referring to), so I cannot ascertain whether it specifies the subscript style. It is almost certain that no user would stop understanding the non-subscipt version, and very few would even notice the difference, let alone complaining for it. Federico On 24/03/2018 15:55, andheh wrote: > > On 03/22/2018 02:52 PM, James Crook wrote: >> About translation of subscripts... >> You should offer the string "%s_%i" for translation. It might become >> "C_5" after translation. Provide a translation hint explaining what it >> is. If subscripts on notes don't work in some language, the translator >> can translate "%s_%i" to "%s" to just get the note. > I'm not sure how the translation works. I guess it needs fixed strings > to translate be able to translate them, so that would require a table > listing all 127 MIDI notes, right? > Or can I still rely on the 12 pitch names in PitchNames.cpp and add the > octave somehow? > > andy > > ------------------------------------------------------------------------------ > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > _______________________________________________ > audacity-devel mailing list > aud...@li... > https://lists.sourceforge.net/lists/listinfo/audacity-devel > > --- El software de antivirus Avast ha analizado este correo electrónico en busca de virus. https://www.avast.com/antivirus |
From: Roger D. <rb...@cs...> - 2018-03-24 20:37:30
|
On 3/24/18 4:29 PM, Federico Miyara wrote: > > I think the subscript style is not necessarily mandatory. In a case as > the present one where the subscript could even be illegible in some > screens, it seems preferable to prioritize readability, especially > considering that the subscript style is not used consistently. See for > instance > > https://en.wikipedia.org/wiki/Scientific_pitch_notation > > where in the figure showing the octaves on a staff the subscript is > not used while in the text it is used. > > The following reference > > http://www.dolmetsch.com/musictheory1.htm#uspitch > > includes both styles plus a few more. > > The original reference from the Acoustical Society of America > > https://asa.scitation.org/doi/pdf/10.1121/1.1902141 > > (abstract 28) uses indeed subscripts, an so does the Music Notation > handbook by Gardener Read. > > I don't have access to the ISO 16 Standard (if it is this the one > Roger was referring to), so I cannot ascertain whether it specifies > the subscript style. > > It is almost certain that no user would stop understanding the > non-subscipt version, and very few would even notice the difference, > let alone complaining for it. > > Federico I agree. It's a good point that (as far as I know) ISO notation uses subscripts, and I should have remembered and mentioned that earlier, but I think C4 is more readable and not a problem for a GUI. -Roger > > On 24/03/2018 15:55, andheh wrote: >> On 03/22/2018 02:52 PM, James Crook wrote: >>> About translation of subscripts... >>> You should offer the string "%s_%i" for translation. It might become >>> "C_5" after translation. Provide a translation hint explaining what it >>> is. If subscripts on notes don't work in some language, the translator >>> can translate "%s_%i" to "%s" to just get the note. >> I'm not sure how the translation works. I guess it needs fixed strings >> to translate be able to translate them, so that would require a table >> listing all 127 MIDI notes, right? >> Or can I still rely on the 12 pitch names in PitchNames.cpp and add the >> octave somehow? >> >> andy >> >> ------------------------------------------------------------------------------ >> Check out the vibrant tech community on one of the world's most >> engaging tech sites, Slashdot.org! http://sdm.link/slashdot >> _______________________________________________ >> audacity-devel mailing list >> aud...@li... >> https://lists.sourceforge.net/lists/listinfo/audacity-devel >> >> > > > <https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=emailclient> > Libre de virus. www.avast.com > <https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=emailclient> > > > <#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2> > > > ------------------------------------------------------------------------------ > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > > > _______________________________________________ > audacity-devel mailing list > aud...@li... > https://lists.sourceforge.net/lists/listinfo/audacity-devel |