audacity-devel — Discussion among Audacity developers

Re: [Audacity-devel] Excessive slowness for some users

[Peter S. <pet...@gm...>]

And this user seems to have got faster again...    :-//

https://forum.audacityteam.org/viewtopic.php?f=46&t=118101&p=425721#p425721

Peter

On Thu, May 13, 2021 at 11:13 PM Steve Fiddle <ste...@gm...>
wrote:

>
>
> On Thu, 13 May 2021 at 22:16, James Crook <jam...@gm...> wrote:
>
>> The slow appearance of the problem possibly fits with checkpointing.
>>
>> Planned changes, to use more standard max .wal size (i.e. block-size x
>> checkpoint-block-count-threshold )  may both make the slowdown smaller and
>> more even, if it is the cause.  It may also eliminate it, if it is related
>> to exceeding some in-memory cache size and so thrashing.
>>
>> I would say the fastest way is to get some test builds out that do this,
>> and get feedback from such users.
>> Things that may also help confirm/contradict this are asking about total
>> RAM and about other programs running - especially browsers with many tabs
>> open.  Perhaps closing browsers so freeing up RAM will alleviate??
>>
>> How many are 'worrying numbers'?
>>
>
> This latest one makes 5 separate reports that I've noticed in the last
> couple of weeks.
> There's also a couple of others that may or may not be the same issue.
>
> Actual Audacity bugs make up a small proportion of forum issues, so
> although it's not a big number, it's a significantly large proportion of
> actual bugs.
>
> Steve
>
>
>
>>
>>
>>
>>
>> On Thu, 13 May 2021 at 21:23, Cliff <fly...@gm...> wrote:
>>
>>> I have not seen that on Mac Mojave. The only things that at times seem
>>> slow is saving after a lot of editing. Initial project is usually 2+ hours
>>> and the final project is an hour or 1:15 or so. Compressor is normally
>>> quick, but I’m using the old one and not the new one. Basic operations are
>>> all very normal speeds.
>>>
>>> Cliff
>>>
>>> On May 13, 2021, at 13:51, Steve Fiddle <ste...@gm...>
>>> wrote:
>>>
>>> We're getting a worrying number of reports of Audacity 3.x being
>>> excessively slow for some users. The common factor being that the projects
>>> are longer than about 30 minutes.
>>>
>>> Most of the reports have been on Windows, but so are most of our users,
>>> so that may not be significant.
>>>
>>> On Linux, when working with project of an hour or more I have also
>>> experienced some long waits, especially when closing the project (though  I
>>> rarely work on projects that are more than a few minutes long).
>>>
>>> A peculiarity is that the slowness may not appear immediately. It seems
>>> to happen after working on the project for a while, and may be related to
>>> using "Undo".
>>>
>>> Below is the latest report that came in a few minutes ago.
>>>
>>> Steve
>>>
>>>
>>> ---------- Forwarded message ---------
>>> From: [redacted]
>>> Date: Thu, 13 May 2021 at 19:26
>>> Subject: Audacity 3.02
>>>
>>>
>>> I appreciate the work you do and you making it available free to the
>>> user. It has helped me for years.
>>>
>>>
>>>
>>> I do not want to complain but I am having some issues that I feel you
>>> should be made aware of.
>>>
>>>
>>>
>>> I am using a Windows 10 Computer. All of my recordings are voice only
>>> and range from 30 to 60 minutes. Over the years I have made many recording
>>> using audacity. I average 2-3 recordings a week and have used audacity
>>> since one of your earliest versions.
>>>
>>>
>>>
>>> A few weeks ago I upgraded to Audacity 3.0. With great expectation, I
>>> loaded it, expecting my “wait” time to be reduced. The reverse happened on
>>> nearly everything I do. It was so bad, I went back to my older version.
>>> Today, I saw 3.02 was out and downloaded it. I recorded a 48 minute audio
>>> without issue. However, When it came to editing, it was a different story.
>>> Below are a few of the “wait times” I experienced.
>>>
>>>
>>>
>>> ·        Sound Finder took a long time but I did not time it.
>>>
>>> ·        Label Audio Split took over 20 minutes
>>>
>>> ·        Compressor took over 40 minutes.
>>>
>>> ·        Truncate Silence took a long time.
>>>
>>> ·        Saving the file also took an extremely long time.
>>>
>>> ·        Closing Audacity took over 21 minutes.
>>>
>>> I hope this information helps resolve some issues. If I can be of help
>>> in evaluating, I would be happy to do so.
>>>
>>>
>>>
>>> Sincerely,
>>>
>>> [redacted]
>>> _______________________________________________
>>> audacity-devel mailing list
>>> aud...@li...
>>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>>
>>>
>>> _______________________________________________
>>> audacity-devel mailing list
>>> aud...@li...
>>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>>
>> _______________________________________________
>> audacity-devel mailing list
>> aud...@li...
>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>
> _______________________________________________
> audacity-devel mailing list
> aud...@li...
> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>

Re: [Audacity-devel] Excessive slowness for some users

[Steve F. <ste...@gm...>]

On Thu, 13 May 2021 at 22:16, James Crook <jam...@gm...> wrote:

> The slow appearance of the problem possibly fits with checkpointing.
>
> Planned changes, to use more standard max .wal size (i.e. block-size x
> checkpoint-block-count-threshold )  may both make the slowdown smaller and
> more even, if it is the cause.  It may also eliminate it, if it is related
> to exceeding some in-memory cache size and so thrashing.
>
> I would say the fastest way is to get some test builds out that do this,
> and get feedback from such users.
> Things that may also help confirm/contradict this are asking about total
> RAM and about other programs running - especially browsers with many tabs
> open.  Perhaps closing browsers so freeing up RAM will alleviate??
>
> How many are 'worrying numbers'?
>

This latest one makes 5 separate reports that I've noticed in the last
couple of weeks.
There's also a couple of others that may or may not be the same issue.

Actual Audacity bugs make up a small proportion of forum issues, so
although it's not a big number, it's a significantly large proportion of
actual bugs.

Steve



>
>
>
>
> On Thu, 13 May 2021 at 21:23, Cliff <fly...@gm...> wrote:
>
>> I have not seen that on Mac Mojave. The only things that at times seem
>> slow is saving after a lot of editing. Initial project is usually 2+ hours
>> and the final project is an hour or 1:15 or so. Compressor is normally
>> quick, but I’m using the old one and not the new one. Basic operations are
>> all very normal speeds.
>>
>> Cliff
>>
>> On May 13, 2021, at 13:51, Steve Fiddle <ste...@gm...> wrote:
>>
>> We're getting a worrying number of reports of Audacity 3.x being
>> excessively slow for some users. The common factor being that the projects
>> are longer than about 30 minutes.
>>
>> Most of the reports have been on Windows, but so are most of our users,
>> so that may not be significant.
>>
>> On Linux, when working with project of an hour or more I have also
>> experienced some long waits, especially when closing the project (though  I
>> rarely work on projects that are more than a few minutes long).
>>
>> A peculiarity is that the slowness may not appear immediately. It seems
>> to happen after working on the project for a while, and may be related to
>> using "Undo".
>>
>> Below is the latest report that came in a few minutes ago.
>>
>> Steve
>>
>>
>> ---------- Forwarded message ---------
>> From: [redacted]
>> Date: Thu, 13 May 2021 at 19:26
>> Subject: Audacity 3.02
>>
>>
>> I appreciate the work you do and you making it available free to the
>> user. It has helped me for years.
>>
>>
>>
>> I do not want to complain but I am having some issues that I feel you
>> should be made aware of.
>>
>>
>>
>> I am using a Windows 10 Computer. All of my recordings are voice only and
>> range from 30 to 60 minutes. Over the years I have made many recording
>> using audacity. I average 2-3 recordings a week and have used audacity
>> since one of your earliest versions.
>>
>>
>>
>> A few weeks ago I upgraded to Audacity 3.0. With great expectation, I
>> loaded it, expecting my “wait” time to be reduced. The reverse happened on
>> nearly everything I do. It was so bad, I went back to my older version.
>> Today, I saw 3.02 was out and downloaded it. I recorded a 48 minute audio
>> without issue. However, When it came to editing, it was a different story.
>> Below are a few of the “wait times” I experienced.
>>
>>
>>
>> ·        Sound Finder took a long time but I did not time it.
>>
>> ·        Label Audio Split took over 20 minutes
>>
>> ·        Compressor took over 40 minutes.
>>
>> ·        Truncate Silence took a long time.
>>
>> ·        Saving the file also took an extremely long time.
>>
>> ·        Closing Audacity took over 21 minutes.
>>
>> I hope this information helps resolve some issues. If I can be of help in
>> evaluating, I would be happy to do so.
>>
>>
>>
>> Sincerely,
>>
>> [redacted]
>> _______________________________________________
>> audacity-devel mailing list
>> aud...@li...
>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>
>>
>> _______________________________________________
>> audacity-devel mailing list
>> aud...@li...
>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>
> _______________________________________________
> audacity-devel mailing list
> aud...@li...
> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>

Re: [Audacity-devel] Excessive slowness for some users

[Leland <ll...@ho...>]

It’s certainly worth trying, but be cautious about changing the block size.  When we first started aup3, we tested several block sizes and the 64KB size worked the best.  But, I’m pretty sure that was on machines that were lightly loaded.

 

From: James Crook <jam...@gm...> 
Sent: Thursday, May 13, 2021 4:14 PM
To: audacity-devel <aud...@li...>
Subject: Re: [Audacity-devel] Excessive slowness for some users

 

The slow appearance of the problem possibly fits with checkpointing.

Planned changes, to use more standard max .wal size (i.e. block-size x checkpoint-block-count-threshold )  may both make the slowdown smaller and more even, if it is the cause.  It may also eliminate it, if it is related to exceeding some in-memory cache size and so thrashing.

I would say the fastest way is to get some test builds out that do this, and get feedback from such users.
Things that may also help confirm/contradict this are asking about total RAM and about other programs running - especially browsers with many tabs open.  Perhaps closing browsers so freeing up RAM will alleviate??

How many are 'worrying numbers'?




 

On Thu, 13 May 2021 at 21:23, Cliff <fly...@gm... <mailto:fly...@gm...> > wrote:

I have not seen that on Mac Mojave. The only things that at times seem slow is saving after a lot of editing. Initial project is usually 2+ hours and the final project is an hour or 1:15 or so. Compressor is normally quick, but I’m using the old one and not the new one. Basic operations are all very normal speeds.

 

Cliff





On May 13, 2021, at 13:51, Steve Fiddle <ste...@gm... <mailto:ste...@gm...> > wrote:

 

We're getting a worrying number of reports of Audacity 3.x being excessively slow for some users. The common factor being that the projects are longer than about 30 minutes.

 

Most of the reports have been on Windows, but so are most of our users, so that may not be significant.

 

On Linux, when working with project of an hour or more I have also experienced some long waits, especially when closing the project (though  I rarely work on projects that are more than a few minutes long). 

 

A peculiarity is that the slowness may not appear immediately. It seems to happen after working on the project for a while, and may be related to using "Undo".

 

Below is the latest report that came in a few minutes ago.

 

Steve

 

 

---------- Forwarded message ---------
From: [redacted]
Date: Thu, 13 May 2021 at 19:26
Subject: Audacity 3.02

 

I appreciate the work you do and you making it available free to the user. It has helped me for years. 

 

I do not want to complain but I am having some issues that I feel you should be made aware of. 

 

I am using a Windows 10 Computer. All of my recordings are voice only and range from 30 to 60 minutes. Over the years I have made many recording using audacity. I average 2-3 recordings a week and have used audacity since one of your earliest versions. 

 

A few weeks ago I upgraded to Audacity 3.0. With great expectation, I loaded it, expecting my “wait” time to be reduced. The reverse happened on nearly everything I do. It was so bad, I went back to my older version. Today, I saw 3.02 was out and downloaded it. I recorded a 48 minute audio without issue. However, When it came to editing, it was a different story. Below are a few of the “wait times” I experienced.

 

*        Sound Finder took a long time but I did not time it.

*        Label Audio Split took over 20 minutes

*        Compressor took over 40 minutes.  

*        Truncate Silence took a long time.

*        Saving the file also took an extremely long time.

*        Closing Audacity took over 21 minutes.

I hope this information helps resolve some issues. If I can be of help in evaluating, I would be happy to do so.

 

Sincerely, 

[redacted]

_______________________________________________
audacity-devel mailing list
aud...@li... <mailto:aud...@li...> 
https://lists.sourceforge.net/lists/listinfo/audacity-devel

 

_______________________________________________
audacity-devel mailing list
aud...@li... <mailto:aud...@li...> 
https://lists.sourceforge.net/lists/listinfo/audacity-devel

Re: [Audacity-devel] Excessive slowness for some users

[James C. <jam...@gm...>]

The slow appearance of the problem possibly fits with checkpointing.

Planned changes, to use more standard max .wal size (i.e. block-size x
checkpoint-block-count-threshold )  may both make the slowdown smaller and
more even, if it is the cause.  It may also eliminate it, if it is related
to exceeding some in-memory cache size and so thrashing.

I would say the fastest way is to get some test builds out that do this,
and get feedback from such users.
Things that may also help confirm/contradict this are asking about total
RAM and about other programs running - especially browsers with many tabs
open.  Perhaps closing browsers so freeing up RAM will alleviate??

How many are 'worrying numbers'?




On Thu, 13 May 2021 at 21:23, Cliff <fly...@gm...> wrote:

> I have not seen that on Mac Mojave. The only things that at times seem
> slow is saving after a lot of editing. Initial project is usually 2+ hours
> and the final project is an hour or 1:15 or so. Compressor is normally
> quick, but I’m using the old one and not the new one. Basic operations are
> all very normal speeds.
>
> Cliff
>
> On May 13, 2021, at 13:51, Steve Fiddle <ste...@gm...> wrote:
>
> We're getting a worrying number of reports of Audacity 3.x being
> excessively slow for some users. The common factor being that the projects
> are longer than about 30 minutes.
>
> Most of the reports have been on Windows, but so are most of our users, so
> that may not be significant.
>
> On Linux, when working with project of an hour or more I have also
> experienced some long waits, especially when closing the project (though  I
> rarely work on projects that are more than a few minutes long).
>
> A peculiarity is that the slowness may not appear immediately. It seems to
> happen after working on the project for a while, and may be related to
> using "Undo".
>
> Below is the latest report that came in a few minutes ago.
>
> Steve
>
>
> ---------- Forwarded message ---------
> From: [redacted]
> Date: Thu, 13 May 2021 at 19:26
> Subject: Audacity 3.02
>
>
> I appreciate the work you do and you making it available free to the user.
> It has helped me for years.
>
>
>
> I do not want to complain but I am having some issues that I feel you
> should be made aware of.
>
>
>
> I am using a Windows 10 Computer. All of my recordings are voice only and
> range from 30 to 60 minutes. Over the years I have made many recording
> using audacity. I average 2-3 recordings a week and have used audacity
> since one of your earliest versions.
>
>
>
> A few weeks ago I upgraded to Audacity 3.0. With great expectation, I
> loaded it, expecting my “wait” time to be reduced. The reverse happened on
> nearly everything I do. It was so bad, I went back to my older version.
> Today, I saw 3.02 was out and downloaded it. I recorded a 48 minute audio
> without issue. However, When it came to editing, it was a different story.
> Below are a few of the “wait times” I experienced.
>
>
>
> ·        Sound Finder took a long time but I did not time it.
>
> ·        Label Audio Split took over 20 minutes
>
> ·        Compressor took over 40 minutes.
>
> ·        Truncate Silence took a long time.
>
> ·        Saving the file also took an extremely long time.
>
> ·        Closing Audacity took over 21 minutes.
>
> I hope this information helps resolve some issues. If I can be of help in
> evaluating, I would be happy to do so.
>
>
>
> Sincerely,
>
> [redacted]
> _______________________________________________
> audacity-devel mailing list
> aud...@li...
> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>
>
> _______________________________________________
> audacity-devel mailing list
> aud...@li...
> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>

Re: [Audacity-devel] Excessive slowness for some users

[Cliff <fly...@gm...>]

I have not seen that on Mac Mojave. The only things that at times seem slow is saving after a lot of editing. Initial project is usually 2+ hours and the final project is an hour or 1:15 or so. Compressor is normally quick, but I’m using the old one and not the new one. Basic operations are all very normal speeds.

Cliff

> On May 13, 2021, at 13:51, Steve Fiddle <ste...@gm...> wrote:
> 
> We're getting a worrying number of reports of Audacity 3.x being excessively slow for some users. The common factor being that the projects are longer than about 30 minutes.
> 
> Most of the reports have been on Windows, but so are most of our users, so that may not be significant.
> 
> On Linux, when working with project of an hour or more I have also experienced some long waits, especially when closing the project (though  I rarely work on projects that are more than a few minutes long). 
> 
> A peculiarity is that the slowness may not appear immediately. It seems to happen after working on the project for a while, and may be related to using "Undo".
> 
> Below is the latest report that came in a few minutes ago.
> 
> Steve
> 
> 
> ---------- Forwarded message ---------
> From: [redacted]
> Date: Thu, 13 May 2021 at 19:26
> Subject: Audacity 3.02
> 
> 
> I appreciate the work you do and you making it available free to the user. It has helped me for years.
> 
>  
> 
> I do not want to complain but I am having some issues that I feel you should be made aware of.
> 
>  
> 
> I am using a Windows 10 Computer. All of my recordings are voice only and range from 30 to 60 minutes. Over the years I have made many recording using audacity. I average 2-3 recordings a week and have used audacity since one of your earliest versions.
> 
>  
> 
> A few weeks ago I upgraded to Audacity 3.0. With great expectation, I loaded it, expecting my “wait” time to be reduced. The reverse happened on nearly everything I do. It was so bad, I went back to my older version. Today, I saw 3.02 was out and downloaded it. I recorded a 48 minute audio without issue. However, When it came to editing, it was a different story. Below are a few of the “wait times” I experienced.
> 
>  
> 
> ·        Sound Finder took a long time but I did not time it.
> 
> ·        Label Audio Split took over 20 minutes
> 
> ·        Compressor took over 40 minutes.  
> 
> ·        Truncate Silence took a long time.
> 
> ·        Saving the file also took an extremely long time.
> 
> ·        Closing Audacity took over 21 minutes.
> 
> I hope this information helps resolve some issues. If I can be of help in evaluating, I would be happy to do so.
> 
>  
> 
> Sincerely,
> 
> [redacted]
> 
> _______________________________________________
> audacity-devel mailing list
> aud...@li...
> https://lists.sourceforge.net/lists/listinfo/audacity-devel

[Audacity-devel] Excessive slowness for some users

[Steve F. <ste...@gm...>]

We're getting a worrying number of reports of Audacity 3.x being
excessively slow for some users. The common factor being that the projects
are longer than about 30 minutes.

Most of the reports have been on Windows, but so are most of our users, so
that may not be significant.

On Linux, when working with project of an hour or more I have also
experienced some long waits, especially when closing the project (though  I
rarely work on projects that are more than a few minutes long).

A peculiarity is that the slowness may not appear immediately. It seems to
happen after working on the project for a while, and may be related to
using "Undo".

Below is the latest report that came in a few minutes ago.

Steve


---------- Forwarded message ---------
From: [redacted]
Date: Thu, 13 May 2021 at 19:26
Subject: Audacity 3.02


I appreciate the work you do and you making it available free to the user.
It has helped me for years.



I do not want to complain but I am having some issues that I feel you
should be made aware of.



I am using a Windows 10 Computer. All of my recordings are voice only and
range from 30 to 60 minutes. Over the years I have made many recording
using audacity. I average 2-3 recordings a week and have used audacity
since one of your earliest versions.



A few weeks ago I upgraded to Audacity 3.0. With great expectation, I
loaded it, expecting my “wait” time to be reduced. The reverse happened on
nearly everything I do. It was so bad, I went back to my older version.
Today, I saw 3.02 was out and downloaded it. I recorded a 48 minute audio
without issue. However, When it came to editing, it was a different story.
Below are a few of the “wait times” I experienced.



·        Sound Finder took a long time but I did not time it.

·        Label Audio Split took over 20 minutes

·        Compressor took over 40 minutes.

·        Truncate Silence took a long time.

·        Saving the file also took an extremely long time.

·        Closing Audacity took over 21 minutes.

I hope this information helps resolve some issues. If I can be of help in
evaluating, I would be happy to do so.



Sincerely,

[redacted]

Re: [Audacity-devel] local build problem on Windows

[Cliff <fly...@gm...>]

Thanks David. 

The first time I tried to compile it failed the same way as before, but now running again without pulling anything new, it worked. I’ve seen that several times with cmake, like it takes one try to build something then the second try to use it.

Cliff

> On May 13, 2021, at 10:12, David Bailes <drb...@gm...> wrote:
> 
> On Thu, 13 May 2021 at 15:50, Cliff <fly...@gm... <mailto:fly...@gm...>> wrote:
> Any idea of when this will get into Master?
> 
> It's already in:
> https://github.com/audacity/audacity/commit/b52192c4c4eec12a1b9fccac31d77fce6746bc52 <https://github.com/audacity/audacity/commit/b52192c4c4eec12a1b9fccac31d77fce6746bc52>
> 
> David.
>  
> 
> Cliff
> 
>> On May 12, 2021, at 11:33, Paul Licameli <pau...@gm... <mailto:pau...@gm...>> wrote:
>> 
>> I wrote a more general fix than Leland's that should be good on all platforms.  I have confirmed it fixes the Mac build with precompiled headers on.
>> 
>> Leland, please review and merge it.
>> 
>> https://github.com/audacity/audacity/pull/886 <https://github.com/audacity/audacity/pull/886>
>> 
>> PRL
>> 
>> 
>> 
>> On Wed, May 12, 2021 at 9:38 AM Paul Licameli <pau...@gm... <mailto:pau...@gm...>> wrote:
>> Mac needs fixing too.
>> 
>> I will figure it out and push.
>> 
>> PRL
>> 
>> 
>> On Wed, May 12, 2021 at 9:32 AM James Crook <jam...@gm... <mailto:jam...@gm...>> wrote:
>> Thanks for the quick confirmation of a fix.
>> 
>> On Wed, 12 May 2021 at 13:18, David Bailes <drb...@gm... <mailto:drb...@gm...>> wrote:
>> On Tue, 11 May 2021 at 21:02, Leland <ll...@ho... <mailto:ll...@ho...>> wrote:
>> Patch is attached.  I don’t feel like hassling with a pull request just for this…times are a changing.  😊
>> 
>> 
>> thanks, I can confirm that this fixes the problem on Windows,
>> David.
>>  
>>  
>> 
>> diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
>> 
>> index 3ff5911fb..e3443ce81 100644
>> 
>> --- a/src/CMakeLists.txt
>> 
>> +++ b/src/CMakeLists.txt
>> 
>> @@ -1316,7 +1316,15 @@ if( CMAKE_VERSION VERSION_GREATER_EQUAL "3.16" AND NOT CCACHE_PROGRAM )
>> 
>>  
>> 
>>     if( ${_OPT}use_pch )
>> 
>>        message( STATUS "Using precompiled headers" )
>> 
>> -      target_precompile_headers( ${TARGET} PRIVATE AudacityHeaders.h )
>> 
>> +      target_precompile_headers( ${TARGET}
>> 
>> +         PRIVATE
>> 
>> +            # The way CMake generates the project file on Windows, the normal
>> 
>> +            # "force include" of configwin.h will happen AFTER AudacityHeaders.h
>> 
>> +            # is included.  So, anything depending on the configwin.h variables
>> 
>> +            # will not be properly defined.
>> 
>> +            $<$<CXX_COMPILER_ID:MSVC>:"${CMAKE_BINARY_DIR}/src/private/configwin.h">
>> 
>> +            AudacityHeaders.h
>> 
>> +      )
>> 
>>     else()
>> 
>>        message( STATUS "Not using precompiled headers" )
>> 
>>     endif()
>> 
>>  
>> 
>>  
>> 
>>  
>> 
>> From: Leland <ll...@ho... <mailto:ll...@ho...>> 
>> Sent: Tuesday, May 11, 2021 1:12 PM
>> To: aud...@li... <mailto:aud...@li...>
>> Subject: Re: [Audacity-devel] local build problem on Windows
>> 
>>  
>> 
>> Honestly, I don’t know what’s going on.  It builds if I configure with:
>> 
>>  
>> 
>> cmake -Daudacity_use_pch=no
>> 
>>  
>> 
>> It doesn’t build if I configure with:
>> 
>>  
>> 
>> cmake -Daudacity_use_pch=yes
>> 
>>  
>> 
>> I thought I understood why, but every “workaround” I’ve tried so far has failed…grrrrrr
>> 
>>  
>> 
>> From: Leland <ll...@ho... <mailto:ll...@ho...>> 
>> Sent: Tuesday, May 11, 2021 1:02 PM
>> To: aud...@li... <mailto:aud...@li...>
>> Subject: Re: [Audacity-devel] local build problem on Windows
>> 
>>  
>> 
>> Hold off…this may be incorrect.  Still digging.
>> 
>>  
>> 
>> From: Leland <ll...@ho... <mailto:ll...@ho...>> 
>> Sent: Tuesday, May 11, 2021 12:44 PM
>> To: aud...@li... <mailto:aud...@li...>
>> Subject: Re: [Audacity-devel] local build problem on Windows
>> 
>>  
>> 
>> Paul, the problem is that using “/FI” to force include configwin.h overrides the method used by CMake to include the precompiled headers. I’m trying to devise some sort of workaround, but I don’t think it’s gonna be pretty.
>> 
>>  
>> 
>> From: Leland <ll...@ho... <mailto:ll...@ho...>> 
>> Sent: Tuesday, May 11, 2021 11:35 AM
>> To: aud...@li... <mailto:aud...@li...>
>> Subject: Re: [Audacity-devel] local build problem on Windows
>> 
>>  
>> 
>> Yea, it broke the use of precompiled headers on Windows.  Looking into it…
>> 
>>  
>> 
>> From: David Bailes <drb...@gm... <mailto:drb...@gm...>> 
>> Sent: Tuesday, May 11, 2021 3:50 AM
>> To: Audacity Development <aud...@li... <mailto:aud...@li...>>
>> Subject: [Audacity-devel] local build problem on Windows
>> 
>>  
>> 
>> Problems with my local build, using VS 2019, and using VS's cmake, as in the build instructions in win/build.txt.
>> 
>> Starting with the recent commit: 794f4e5877195e28afb230f2cdff166410fd5e37,
>> 
>> I'm getting the build errors shown below,
>> 
>> David.
>> 
>>  
>> 
>>     cmake_pch.cxx
>> U:\audacity\src\AudioIO.h(95,24): error C3646: 'midiTracks': unknown override specifier 
>> U:\audacity\src\AudioIO.h(95,34): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 
>> U:\audacity\src\AudioIO.h(270,16): error C3646: 'MidiTime': unknown override specifier 
>> U:\audacity\src\AudioIO.h(270,24): error C2059: syntax error: '(' 
>> U:\audacity\src\AudioIO.h(270,26): error C2238: unexpected token(s) preceding ';' 
>> U:\audacity\src\AudioIO.h(368,20): error C2143: syntax error: missing ';' before '*' 
>> U:\audacity\src\AudioIO.h(368,20): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 
>> U:\audacity\src\AudioIO.h(368,32): error C2238: unexpected token(s) preceding ';' 
>> U:\audacity\src\AudioIO.h(392,16): error C3646: 'mMaxMidiTimestamp': unknown override specifier 
>> U:\audacity\src\AudioIO.h(392,33): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 
>> U:\audacity\src\AudioIO.h(415,17): error C2143: syntax error: missing ';' before '*' 
>> U:\audacity\src\AudioIO.h(415,17): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 
>> U:\audacity\src\AudioIO.h(415,22): error C2238: unexpected token(s) preceding ';' 
>> U:\audacity\src\AudioIO.h(416,20): error C2065: 'Alg_iterator': undeclared identifier 
>> U:\audacity\src\AudioIO.h(416,9): error C2923: 'std::unique_ptr': 'Alg_iterator' is not a valid template type argument for parameter '_Ty' 
>> U:\audacity\src\AudioIO.h(416,9): error C2976: 'std::unique_ptr': too few template arguments 
>>   C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.28.29910\include\memory(3319): message : see declaration of 'std::unique_ptr' [U:\audacity\out\build\x86-Debug\src\Audacity.vcxproj]
>> U:\audacity\src\AudioIO.h(418,17): error C2143: syntax error: missing ';' before '*' 
>> U:\audacity\src\AudioIO.h(418,17): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 
>> U:\audacity\src\AudioIO.h(418,28): error C2238: unexpected token(s) preceding ';' 
>> U:\audacity\src\AudioIO.h(428,21): error C2143: syntax error: missing ';' before '*' 
>> U:\audacity\src\AudioIO.h(428,21): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 
>> U:\audacity\src\AudioIO.h(428,37): error C2238: unexpected token(s) preceding ';' 
>> U:\audacity\src\AudioIO.h(434,24): error C3646: 'mMidiPlaybackTracks': unknown override specifier 
>> U:\audacity\src\AudioIO.h(434,43): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 
>> 
>> Build All failed. 
>> 
>> _______________________________________________
>> audacity-devel mailing list
>> aud...@li... <mailto:aud...@li...>
>> https://lists.sourceforge.net/lists/listinfo/audacity-devel <https://lists.sourceforge.net/lists/listinfo/audacity-devel>
>> _______________________________________________
>> audacity-devel mailing list
>> aud...@li... <mailto:aud...@li...>
>> https://lists.sourceforge.net/lists/listinfo/audacity-devel <https://lists.sourceforge.net/lists/listinfo/audacity-devel>
>> _______________________________________________
>> audacity-devel mailing list
>> aud...@li... <mailto:aud...@li...>
>> https://lists.sourceforge.net/lists/listinfo/audacity-devel <https://lists.sourceforge.net/lists/listinfo/audacity-devel>
>> _______________________________________________
>> audacity-devel mailing list
>> aud...@li... <mailto:aud...@li...>
>> https://lists.sourceforge.net/lists/listinfo/audacity-devel <https://lists.sourceforge.net/lists/listinfo/audacity-devel>
> 
> _______________________________________________
> audacity-devel mailing list
> aud...@li... <mailto:aud...@li...>
> https://lists.sourceforge.net/lists/listinfo/audacity-devel <https://lists.sourceforge.net/lists/listinfo/audacity-devel>
> _______________________________________________
> audacity-devel mailing list
> aud...@li... <mailto:aud...@li...>
> https://lists.sourceforge.net/lists/listinfo/audacity-devel <https://lists.sourceforge.net/lists/listinfo/audacity-devel>

Re: [Audacity-devel] local build problem on Windows

[David B. <drb...@gm...>]

On Thu, 13 May 2021 at 15:50, Cliff <fly...@gm...> wrote:

> Any idea of when this will get into Master?
>

It's already in:
https://github.com/audacity/audacity/commit/b52192c4c4eec12a1b9fccac31d77fce6746bc52

David.


>
> Cliff
>
> On May 12, 2021, at 11:33, Paul Licameli <pau...@gm...> wrote:
>
> I wrote a more general fix than Leland's that should be good on all
> platforms.  I have confirmed it fixes the Mac build with precompiled
> headers on.
>
> Leland, please review and merge it.
>
> https://github.com/audacity/audacity/pull/886
>
> PRL
>
>
>
> On Wed, May 12, 2021 at 9:38 AM Paul Licameli <pau...@gm...>
> wrote:
>
>> Mac needs fixing too.
>>
>> I will figure it out and push.
>>
>> PRL
>>
>>
>> On Wed, May 12, 2021 at 9:32 AM James Crook <jam...@gm...>
>> wrote:
>>
>>> Thanks for the quick confirmation of a fix.
>>>
>>> On Wed, 12 May 2021 at 13:18, David Bailes <drb...@gm...> wrote:
>>>
>>>> On Tue, 11 May 2021 at 21:02, Leland <ll...@ho...> wrote:
>>>>
>>>>> Patch is attached.  I don’t feel like hassling with a pull request
>>>>> just for this…times are a changing.  😊
>>>>>
>>>>
>>>> thanks, I can confirm that this fixes the problem on Windows,
>>>> David.
>>>>
>>>>
>>>>>
>>>>>
>>>>> diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
>>>>>
>>>>> index 3ff5911fb..e3443ce81 100644
>>>>>
>>>>> --- a/src/CMakeLists.txt
>>>>>
>>>>> +++ b/src/CMakeLists.txt
>>>>>
>>>>> @@ -1316,7 +1316,15 @@ if( CMAKE_VERSION VERSION_GREATER_EQUAL "3.16"
>>>>> AND NOT CCACHE_PROGRAM )
>>>>>
>>>>>
>>>>>
>>>>>     if( ${_OPT}use_pch )
>>>>>
>>>>>        message( STATUS "Using precompiled headers" )
>>>>>
>>>>> -      target_precompile_headers( ${TARGET} PRIVATE AudacityHeaders.h )
>>>>>
>>>>> +      target_precompile_headers( ${TARGET}
>>>>>
>>>>> +         PRIVATE
>>>>>
>>>>> +            # The way CMake generates the project file on Windows,
>>>>> the normal
>>>>>
>>>>> +            # "force include" of configwin.h will happen AFTER
>>>>> AudacityHeaders.h
>>>>>
>>>>> +            # is included.  So, anything depending on the configwin.h
>>>>> variables
>>>>>
>>>>> +            # will not be properly defined.
>>>>>
>>>>> +
>>>>> $<$<CXX_COMPILER_ID:MSVC>:"${CMAKE_BINARY_DIR}/src/private/configwin.h">
>>>>>
>>>>> +            AudacityHeaders.h
>>>>>
>>>>> +      )
>>>>>
>>>>>     else()
>>>>>
>>>>>        message( STATUS "Not using precompiled headers" )
>>>>>
>>>>>     endif()
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> *From:* Leland <ll...@ho...>
>>>>> *Sent:* Tuesday, May 11, 2021 1:12 PM
>>>>> *To:* aud...@li...
>>>>> *Subject:* Re: [Audacity-devel] local build problem on Windows
>>>>>
>>>>>
>>>>>
>>>>> Honestly, I don’t know what’s going on.  It builds if I configure with:
>>>>>
>>>>>
>>>>>
>>>>> cmake -Daudacity_use_pch=no
>>>>>
>>>>>
>>>>>
>>>>> It doesn’t build if I configure with:
>>>>>
>>>>>
>>>>>
>>>>> cmake -Daudacity_use_pch=yes
>>>>>
>>>>>
>>>>>
>>>>> I thought I understood why, but every “workaround” I’ve tried so far
>>>>> has failed…grrrrrr
>>>>>
>>>>>
>>>>>
>>>>> *From:* Leland <ll...@ho...>
>>>>> *Sent:* Tuesday, May 11, 2021 1:02 PM
>>>>> *To:* aud...@li...
>>>>> *Subject:* Re: [Audacity-devel] local build problem on Windows
>>>>>
>>>>>
>>>>>
>>>>> Hold off…this may be incorrect.  Still digging.
>>>>>
>>>>>
>>>>>
>>>>> *From:* Leland <ll...@ho...>
>>>>> *Sent:* Tuesday, May 11, 2021 12:44 PM
>>>>> *To:* aud...@li...
>>>>> *Subject:* Re: [Audacity-devel] local build problem on Windows
>>>>>
>>>>>
>>>>>
>>>>> Paul, the problem is that using “/FI” to force include configwin.h
>>>>> overrides the method used by CMake to include the precompiled headers. I’m
>>>>> trying to devise some sort of workaround, but I don’t think it’s gonna be
>>>>> pretty.
>>>>>
>>>>>
>>>>>
>>>>> *From:* Leland <ll...@ho...>
>>>>> *Sent:* Tuesday, May 11, 2021 11:35 AM
>>>>> *To:* aud...@li...
>>>>> *Subject:* Re: [Audacity-devel] local build problem on Windows
>>>>>
>>>>>
>>>>>
>>>>> Yea, it broke the use of precompiled headers on Windows.  Looking into
>>>>> it…
>>>>>
>>>>>
>>>>>
>>>>> *From:* David Bailes <drb...@gm...>
>>>>> *Sent:* Tuesday, May 11, 2021 3:50 AM
>>>>> *To:* Audacity Development <aud...@li...>
>>>>> *Subject:* [Audacity-devel] local build problem on Windows
>>>>>
>>>>>
>>>>>
>>>>> Problems with my local build, using VS 2019, and using VS's cmake, as
>>>>> in the build instructions in win/build.txt.
>>>>>
>>>>> Starting with the recent
>>>>> commit: 794f4e5877195e28afb230f2cdff166410fd5e37,
>>>>>
>>>>> I'm getting the build errors shown below,
>>>>>
>>>>> David.
>>>>>
>>>>>
>>>>>
>>>>>     cmake_pch.cxx
>>>>> U:\audacity\src\AudioIO.h(95,24): error C3646: 'midiTracks': unknown
>>>>> override specifier
>>>>> U:\audacity\src\AudioIO.h(95,34): error C4430: missing type specifier
>>>>> - int assumed. Note: C++ does not support default-int
>>>>> U:\audacity\src\AudioIO.h(270,16): error C3646: 'MidiTime': unknown
>>>>> override specifier
>>>>> U:\audacity\src\AudioIO.h(270,24): error C2059: syntax error: '('
>>>>> U:\audacity\src\AudioIO.h(270,26): error C2238: unexpected token(s)
>>>>> preceding ';'
>>>>> U:\audacity\src\AudioIO.h(368,20): error C2143: syntax error: missing
>>>>> ';' before '*'
>>>>> U:\audacity\src\AudioIO.h(368,20): error C4430: missing type specifier
>>>>> - int assumed. Note: C++ does not support default-int
>>>>> U:\audacity\src\AudioIO.h(368,32): error C2238: unexpected token(s)
>>>>> preceding ';'
>>>>> U:\audacity\src\AudioIO.h(392,16): error C3646: 'mMaxMidiTimestamp':
>>>>> unknown override specifier
>>>>> U:\audacity\src\AudioIO.h(392,33): error C4430: missing type specifier
>>>>> - int assumed. Note: C++ does not support default-int
>>>>> U:\audacity\src\AudioIO.h(415,17): error C2143: syntax error: missing
>>>>> ';' before '*'
>>>>> U:\audacity\src\AudioIO.h(415,17): error C4430: missing type specifier
>>>>> - int assumed. Note: C++ does not support default-int
>>>>> U:\audacity\src\AudioIO.h(415,22): error C2238: unexpected token(s)
>>>>> preceding ';'
>>>>> U:\audacity\src\AudioIO.h(416,20): error C2065: 'Alg_iterator':
>>>>> undeclared identifier
>>>>> U:\audacity\src\AudioIO.h(416,9): error C2923: 'std::unique_ptr':
>>>>> 'Alg_iterator' is not a valid template type argument for parameter '_Ty'
>>>>> U:\audacity\src\AudioIO.h(416,9): error C2976: 'std::unique_ptr': too
>>>>> few template arguments
>>>>>   C:\Program Files (x86)\Microsoft Visual
>>>>> Studio\2019\Community\VC\Tools\MSVC\14.28.29910\include\memory(3319):
>>>>> message : see declaration of 'std::unique_ptr'
>>>>> [U:\audacity\out\build\x86-Debug\src\Audacity.vcxproj]
>>>>> U:\audacity\src\AudioIO.h(418,17): error C2143: syntax error: missing
>>>>> ';' before '*'
>>>>> U:\audacity\src\AudioIO.h(418,17): error C4430: missing type specifier
>>>>> - int assumed. Note: C++ does not support default-int
>>>>> U:\audacity\src\AudioIO.h(418,28): error C2238: unexpected token(s)
>>>>> preceding ';'
>>>>> U:\audacity\src\AudioIO.h(428,21): error C2143: syntax error: missing
>>>>> ';' before '*'
>>>>> U:\audacity\src\AudioIO.h(428,21): error C4430: missing type specifier
>>>>> - int assumed. Note: C++ does not support default-int
>>>>> U:\audacity\src\AudioIO.h(428,37): error C2238: unexpected token(s)
>>>>> preceding ';'
>>>>> U:\audacity\src\AudioIO.h(434,24): error C3646: 'mMidiPlaybackTracks':
>>>>> unknown override specifier
>>>>> U:\audacity\src\AudioIO.h(434,43): error C4430: missing type specifier
>>>>> - int assumed. Note: C++ does not support default-int
>>>>>
>>>>> Build All failed.
>>>>> _______________________________________________
>>>>> audacity-devel mailing list
>>>>> aud...@li...
>>>>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>>>>
>>>> _______________________________________________
>>>> audacity-devel mailing list
>>>> aud...@li...
>>>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>>>
>>> _______________________________________________
>>> audacity-devel mailing list
>>> aud...@li...
>>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>>
>> _______________________________________________
> audacity-devel mailing list
> aud...@li...
> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>
>
> _______________________________________________
> audacity-devel mailing list
> aud...@li...
> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>

Re: [Audacity-devel] local build problem on Windows

[Cliff <fly...@gm...>]

Any idea of when this will get into Master?

Cliff

> On May 12, 2021, at 11:33, Paul Licameli <pau...@gm...> wrote:
> 
> I wrote a more general fix than Leland's that should be good on all platforms.  I have confirmed it fixes the Mac build with precompiled headers on.
> 
> Leland, please review and merge it.
> 
> https://github.com/audacity/audacity/pull/886 <https://github.com/audacity/audacity/pull/886>
> 
> PRL
> 
> 
> 
> On Wed, May 12, 2021 at 9:38 AM Paul Licameli <pau...@gm... <mailto:pau...@gm...>> wrote:
> Mac needs fixing too.
> 
> I will figure it out and push.
> 
> PRL
> 
> 
> On Wed, May 12, 2021 at 9:32 AM James Crook <jam...@gm... <mailto:jam...@gm...>> wrote:
> Thanks for the quick confirmation of a fix.
> 
> On Wed, 12 May 2021 at 13:18, David Bailes <drb...@gm... <mailto:drb...@gm...>> wrote:
> On Tue, 11 May 2021 at 21:02, Leland <ll...@ho... <mailto:ll...@ho...>> wrote:
> Patch is attached.  I don’t feel like hassling with a pull request just for this…times are a changing.  😊
> 
> 
> thanks, I can confirm that this fixes the problem on Windows,
> David.
>  
>  
> 
> diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
> 
> index 3ff5911fb..e3443ce81 100644
> 
> --- a/src/CMakeLists.txt
> 
> +++ b/src/CMakeLists.txt
> 
> @@ -1316,7 +1316,15 @@ if( CMAKE_VERSION VERSION_GREATER_EQUAL "3.16" AND NOT CCACHE_PROGRAM )
> 
>  
> 
>     if( ${_OPT}use_pch )
> 
>        message( STATUS "Using precompiled headers" )
> 
> -      target_precompile_headers( ${TARGET} PRIVATE AudacityHeaders.h )
> 
> +      target_precompile_headers( ${TARGET}
> 
> +         PRIVATE
> 
> +            # The way CMake generates the project file on Windows, the normal
> 
> +            # "force include" of configwin.h will happen AFTER AudacityHeaders.h
> 
> +            # is included.  So, anything depending on the configwin.h variables
> 
> +            # will not be properly defined.
> 
> +            $<$<CXX_COMPILER_ID:MSVC>:"${CMAKE_BINARY_DIR}/src/private/configwin.h">
> 
> +            AudacityHeaders.h
> 
> +      )
> 
>     else()
> 
>        message( STATUS "Not using precompiled headers" )
> 
>     endif()
> 
>  
> 
>  
> 
>  
> 
> From: Leland <ll...@ho... <mailto:ll...@ho...>> 
> Sent: Tuesday, May 11, 2021 1:12 PM
> To: aud...@li... <mailto:aud...@li...>
> Subject: Re: [Audacity-devel] local build problem on Windows
> 
>  
> 
> Honestly, I don’t know what’s going on.  It builds if I configure with:
> 
>  
> 
> cmake -Daudacity_use_pch=no
> 
>  
> 
> It doesn’t build if I configure with:
> 
>  
> 
> cmake -Daudacity_use_pch=yes
> 
>  
> 
> I thought I understood why, but every “workaround” I’ve tried so far has failed…grrrrrr
> 
>  
> 
> From: Leland <ll...@ho... <mailto:ll...@ho...>> 
> Sent: Tuesday, May 11, 2021 1:02 PM
> To: aud...@li... <mailto:aud...@li...>
> Subject: Re: [Audacity-devel] local build problem on Windows
> 
>  
> 
> Hold off…this may be incorrect.  Still digging.
> 
>  
> 
> From: Leland <ll...@ho... <mailto:ll...@ho...>> 
> Sent: Tuesday, May 11, 2021 12:44 PM
> To: aud...@li... <mailto:aud...@li...>
> Subject: Re: [Audacity-devel] local build problem on Windows
> 
>  
> 
> Paul, the problem is that using “/FI” to force include configwin.h overrides the method used by CMake to include the precompiled headers. I’m trying to devise some sort of workaround, but I don’t think it’s gonna be pretty.
> 
>  
> 
> From: Leland <ll...@ho... <mailto:ll...@ho...>> 
> Sent: Tuesday, May 11, 2021 11:35 AM
> To: aud...@li... <mailto:aud...@li...>
> Subject: Re: [Audacity-devel] local build problem on Windows
> 
>  
> 
> Yea, it broke the use of precompiled headers on Windows.  Looking into it…
> 
>  
> 
> From: David Bailes <drb...@gm... <mailto:drb...@gm...>> 
> Sent: Tuesday, May 11, 2021 3:50 AM
> To: Audacity Development <aud...@li... <mailto:aud...@li...>>
> Subject: [Audacity-devel] local build problem on Windows
> 
>  
> 
> Problems with my local build, using VS 2019, and using VS's cmake, as in the build instructions in win/build.txt.
> 
> Starting with the recent commit: 794f4e5877195e28afb230f2cdff166410fd5e37,
> 
> I'm getting the build errors shown below,
> 
> David.
> 
>  
> 
>     cmake_pch.cxx
> U:\audacity\src\AudioIO.h(95,24): error C3646: 'midiTracks': unknown override specifier 
> U:\audacity\src\AudioIO.h(95,34): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 
> U:\audacity\src\AudioIO.h(270,16): error C3646: 'MidiTime': unknown override specifier 
> U:\audacity\src\AudioIO.h(270,24): error C2059: syntax error: '(' 
> U:\audacity\src\AudioIO.h(270,26): error C2238: unexpected token(s) preceding ';' 
> U:\audacity\src\AudioIO.h(368,20): error C2143: syntax error: missing ';' before '*' 
> U:\audacity\src\AudioIO.h(368,20): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 
> U:\audacity\src\AudioIO.h(368,32): error C2238: unexpected token(s) preceding ';' 
> U:\audacity\src\AudioIO.h(392,16): error C3646: 'mMaxMidiTimestamp': unknown override specifier 
> U:\audacity\src\AudioIO.h(392,33): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 
> U:\audacity\src\AudioIO.h(415,17): error C2143: syntax error: missing ';' before '*' 
> U:\audacity\src\AudioIO.h(415,17): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 
> U:\audacity\src\AudioIO.h(415,22): error C2238: unexpected token(s) preceding ';' 
> U:\audacity\src\AudioIO.h(416,20): error C2065: 'Alg_iterator': undeclared identifier 
> U:\audacity\src\AudioIO.h(416,9): error C2923: 'std::unique_ptr': 'Alg_iterator' is not a valid template type argument for parameter '_Ty' 
> U:\audacity\src\AudioIO.h(416,9): error C2976: 'std::unique_ptr': too few template arguments 
>   C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.28.29910\include\memory(3319): message : see declaration of 'std::unique_ptr' [U:\audacity\out\build\x86-Debug\src\Audacity.vcxproj]
> U:\audacity\src\AudioIO.h(418,17): error C2143: syntax error: missing ';' before '*' 
> U:\audacity\src\AudioIO.h(418,17): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 
> U:\audacity\src\AudioIO.h(418,28): error C2238: unexpected token(s) preceding ';' 
> U:\audacity\src\AudioIO.h(428,21): error C2143: syntax error: missing ';' before '*' 
> U:\audacity\src\AudioIO.h(428,21): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 
> U:\audacity\src\AudioIO.h(428,37): error C2238: unexpected token(s) preceding ';' 
> U:\audacity\src\AudioIO.h(434,24): error C3646: 'mMidiPlaybackTracks': unknown override specifier 
> U:\audacity\src\AudioIO.h(434,43): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int
> 
> Build All failed. 
> 
> _______________________________________________
> audacity-devel mailing list
> aud...@li... <mailto:aud...@li...>
> https://lists.sourceforge.net/lists/listinfo/audacity-devel <https://lists.sourceforge.net/lists/listinfo/audacity-devel>
> _______________________________________________
> audacity-devel mailing list
> aud...@li... <mailto:aud...@li...>
> https://lists.sourceforge.net/lists/listinfo/audacity-devel <https://lists.sourceforge.net/lists/listinfo/audacity-devel>
> _______________________________________________
> audacity-devel mailing list
> aud...@li... <mailto:aud...@li...>
> https://lists.sourceforge.net/lists/listinfo/audacity-devel <https://lists.sourceforge.net/lists/listinfo/audacity-devel>
> _______________________________________________
> audacity-devel mailing list
> aud...@li...
> https://lists.sourceforge.net/lists/listinfo/audacity-devel

Re: [Audacity-devel] local build problem on Windows

[Paul L. <pau...@gm...>]

I wrote a more general fix than Leland's that should be good on all
platforms.  I have confirmed it fixes the Mac build with precompiled
headers on.

Leland, please review and merge it.

https://github.com/audacity/audacity/pull/886

PRL



On Wed, May 12, 2021 at 9:38 AM Paul Licameli <pau...@gm...>
wrote:

> Mac needs fixing too.
>
> I will figure it out and push.
>
> PRL
>
>
> On Wed, May 12, 2021 at 9:32 AM James Crook <jam...@gm...>
> wrote:
>
>> Thanks for the quick confirmation of a fix.
>>
>> On Wed, 12 May 2021 at 13:18, David Bailes <drb...@gm...> wrote:
>>
>>> On Tue, 11 May 2021 at 21:02, Leland <ll...@ho...> wrote:
>>>
>>>> Patch is attached.  I don’t feel like hassling with a pull request just
>>>> for this…times are a changing.  😊
>>>>
>>>
>>> thanks, I can confirm that this fixes the problem on Windows,
>>> David.
>>>
>>>
>>>>
>>>>
>>>> diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
>>>>
>>>> index 3ff5911fb..e3443ce81 100644
>>>>
>>>> --- a/src/CMakeLists.txt
>>>>
>>>> +++ b/src/CMakeLists.txt
>>>>
>>>> @@ -1316,7 +1316,15 @@ if( CMAKE_VERSION VERSION_GREATER_EQUAL "3.16"
>>>> AND NOT CCACHE_PROGRAM )
>>>>
>>>>
>>>>
>>>>     if( ${_OPT}use_pch )
>>>>
>>>>        message( STATUS "Using precompiled headers" )
>>>>
>>>> -      target_precompile_headers( ${TARGET} PRIVATE AudacityHeaders.h )
>>>>
>>>> +      target_precompile_headers( ${TARGET}
>>>>
>>>> +         PRIVATE
>>>>
>>>> +            # The way CMake generates the project file on Windows, the
>>>> normal
>>>>
>>>> +            # "force include" of configwin.h will happen AFTER
>>>> AudacityHeaders.h
>>>>
>>>> +            # is included.  So, anything depending on the configwin.h
>>>> variables
>>>>
>>>> +            # will not be properly defined.
>>>>
>>>> +
>>>> $<$<CXX_COMPILER_ID:MSVC>:"${CMAKE_BINARY_DIR}/src/private/configwin.h">
>>>>
>>>> +            AudacityHeaders.h
>>>>
>>>> +      )
>>>>
>>>>     else()
>>>>
>>>>        message( STATUS "Not using precompiled headers" )
>>>>
>>>>     endif()
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>> *From:* Leland <ll...@ho...>
>>>> *Sent:* Tuesday, May 11, 2021 1:12 PM
>>>> *To:* aud...@li...
>>>> *Subject:* Re: [Audacity-devel] local build problem on Windows
>>>>
>>>>
>>>>
>>>> Honestly, I don’t know what’s going on.  It builds if I configure with:
>>>>
>>>>
>>>>
>>>> cmake -Daudacity_use_pch=no
>>>>
>>>>
>>>>
>>>> It doesn’t build if I configure with:
>>>>
>>>>
>>>>
>>>> cmake -Daudacity_use_pch=yes
>>>>
>>>>
>>>>
>>>> I thought I understood why, but every “workaround” I’ve tried so far
>>>> has failed…grrrrrr
>>>>
>>>>
>>>>
>>>> *From:* Leland <ll...@ho...>
>>>> *Sent:* Tuesday, May 11, 2021 1:02 PM
>>>> *To:* aud...@li...
>>>> *Subject:* Re: [Audacity-devel] local build problem on Windows
>>>>
>>>>
>>>>
>>>> Hold off…this may be incorrect.  Still digging.
>>>>
>>>>
>>>>
>>>> *From:* Leland <ll...@ho...>
>>>> *Sent:* Tuesday, May 11, 2021 12:44 PM
>>>> *To:* aud...@li...
>>>> *Subject:* Re: [Audacity-devel] local build problem on Windows
>>>>
>>>>
>>>>
>>>> Paul, the problem is that using “/FI” to force include configwin.h
>>>> overrides the method used by CMake to include the precompiled headers. I’m
>>>> trying to devise some sort of workaround, but I don’t think it’s gonna be
>>>> pretty.
>>>>
>>>>
>>>>
>>>> *From:* Leland <ll...@ho...>
>>>> *Sent:* Tuesday, May 11, 2021 11:35 AM
>>>> *To:* aud...@li...
>>>> *Subject:* Re: [Audacity-devel] local build problem on Windows
>>>>
>>>>
>>>>
>>>> Yea, it broke the use of precompiled headers on Windows.  Looking into
>>>> it…
>>>>
>>>>
>>>>
>>>> *From:* David Bailes <drb...@gm...>
>>>> *Sent:* Tuesday, May 11, 2021 3:50 AM
>>>> *To:* Audacity Development <aud...@li...>
>>>> *Subject:* [Audacity-devel] local build problem on Windows
>>>>
>>>>
>>>>
>>>> Problems with my local build, using VS 2019, and using VS's cmake, as
>>>> in the build instructions in win/build.txt.
>>>>
>>>> Starting with the recent
>>>> commit: 794f4e5877195e28afb230f2cdff166410fd5e37,
>>>>
>>>> I'm getting the build errors shown below,
>>>>
>>>> David.
>>>>
>>>>
>>>>
>>>>     cmake_pch.cxx
>>>> U:\audacity\src\AudioIO.h(95,24): error C3646: 'midiTracks': unknown
>>>> override specifier
>>>> U:\audacity\src\AudioIO.h(95,34): error C4430: missing type specifier -
>>>> int assumed. Note: C++ does not support default-int
>>>> U:\audacity\src\AudioIO.h(270,16): error C3646: 'MidiTime': unknown
>>>> override specifier
>>>> U:\audacity\src\AudioIO.h(270,24): error C2059: syntax error: '('
>>>> U:\audacity\src\AudioIO.h(270,26): error C2238: unexpected token(s)
>>>> preceding ';'
>>>> U:\audacity\src\AudioIO.h(368,20): error C2143: syntax error: missing
>>>> ';' before '*'
>>>> U:\audacity\src\AudioIO.h(368,20): error C4430: missing type specifier
>>>> - int assumed. Note: C++ does not support default-int
>>>> U:\audacity\src\AudioIO.h(368,32): error C2238: unexpected token(s)
>>>> preceding ';'
>>>> U:\audacity\src\AudioIO.h(392,16): error C3646: 'mMaxMidiTimestamp':
>>>> unknown override specifier
>>>> U:\audacity\src\AudioIO.h(392,33): error C4430: missing type specifier
>>>> - int assumed. Note: C++ does not support default-int
>>>> U:\audacity\src\AudioIO.h(415,17): error C2143: syntax error: missing
>>>> ';' before '*'
>>>> U:\audacity\src\AudioIO.h(415,17): error C4430: missing type specifier
>>>> - int assumed. Note: C++ does not support default-int
>>>> U:\audacity\src\AudioIO.h(415,22): error C2238: unexpected token(s)
>>>> preceding ';'
>>>> U:\audacity\src\AudioIO.h(416,20): error C2065: 'Alg_iterator':
>>>> undeclared identifier
>>>> U:\audacity\src\AudioIO.h(416,9): error C2923: 'std::unique_ptr':
>>>> 'Alg_iterator' is not a valid template type argument for parameter '_Ty'
>>>> U:\audacity\src\AudioIO.h(416,9): error C2976: 'std::unique_ptr': too
>>>> few template arguments
>>>>   C:\Program Files (x86)\Microsoft Visual
>>>> Studio\2019\Community\VC\Tools\MSVC\14.28.29910\include\memory(3319):
>>>> message : see declaration of 'std::unique_ptr'
>>>> [U:\audacity\out\build\x86-Debug\src\Audacity.vcxproj]
>>>> U:\audacity\src\AudioIO.h(418,17): error C2143: syntax error: missing
>>>> ';' before '*'
>>>> U:\audacity\src\AudioIO.h(418,17): error C4430: missing type specifier
>>>> - int assumed. Note: C++ does not support default-int
>>>> U:\audacity\src\AudioIO.h(418,28): error C2238: unexpected token(s)
>>>> preceding ';'
>>>> U:\audacity\src\AudioIO.h(428,21): error C2143: syntax error: missing
>>>> ';' before '*'
>>>> U:\audacity\src\AudioIO.h(428,21): error C4430: missing type specifier
>>>> - int assumed. Note: C++ does not support default-int
>>>> U:\audacity\src\AudioIO.h(428,37): error C2238: unexpected token(s)
>>>> preceding ';'
>>>> U:\audacity\src\AudioIO.h(434,24): error C3646: 'mMidiPlaybackTracks':
>>>> unknown override specifier
>>>> U:\audacity\src\AudioIO.h(434,43): error C4430: missing type specifier
>>>> - int assumed. Note: C++ does not support default-int
>>>>
>>>> Build All failed.
>>>> _______________________________________________
>>>> audacity-devel mailing list
>>>> aud...@li...
>>>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>>>
>>> _______________________________________________
>>> audacity-devel mailing list
>>> aud...@li...
>>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>>
>> _______________________________________________
>> audacity-devel mailing list
>> aud...@li...
>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>
>

Re: [Audacity-devel] local build problem on Windows

[Paul L. <pau...@gm...>]

Mac needs fixing too.

I will figure it out and push.

PRL


On Wed, May 12, 2021 at 9:32 AM James Crook <jam...@gm...> wrote:

> Thanks for the quick confirmation of a fix.
>
> On Wed, 12 May 2021 at 13:18, David Bailes <drb...@gm...> wrote:
>
>> On Tue, 11 May 2021 at 21:02, Leland <ll...@ho...> wrote:
>>
>>> Patch is attached.  I don’t feel like hassling with a pull request just
>>> for this…times are a changing.  😊
>>>
>>
>> thanks, I can confirm that this fixes the problem on Windows,
>> David.
>>
>>
>>>
>>>
>>> diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
>>>
>>> index 3ff5911fb..e3443ce81 100644
>>>
>>> --- a/src/CMakeLists.txt
>>>
>>> +++ b/src/CMakeLists.txt
>>>
>>> @@ -1316,7 +1316,15 @@ if( CMAKE_VERSION VERSION_GREATER_EQUAL "3.16"
>>> AND NOT CCACHE_PROGRAM )
>>>
>>>
>>>
>>>     if( ${_OPT}use_pch )
>>>
>>>        message( STATUS "Using precompiled headers" )
>>>
>>> -      target_precompile_headers( ${TARGET} PRIVATE AudacityHeaders.h )
>>>
>>> +      target_precompile_headers( ${TARGET}
>>>
>>> +         PRIVATE
>>>
>>> +            # The way CMake generates the project file on Windows, the
>>> normal
>>>
>>> +            # "force include" of configwin.h will happen AFTER
>>> AudacityHeaders.h
>>>
>>> +            # is included.  So, anything depending on the configwin.h
>>> variables
>>>
>>> +            # will not be properly defined.
>>>
>>> +
>>> $<$<CXX_COMPILER_ID:MSVC>:"${CMAKE_BINARY_DIR}/src/private/configwin.h">
>>>
>>> +            AudacityHeaders.h
>>>
>>> +      )
>>>
>>>     else()
>>>
>>>        message( STATUS "Not using precompiled headers" )
>>>
>>>     endif()
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>> *From:* Leland <ll...@ho...>
>>> *Sent:* Tuesday, May 11, 2021 1:12 PM
>>> *To:* aud...@li...
>>> *Subject:* Re: [Audacity-devel] local build problem on Windows
>>>
>>>
>>>
>>> Honestly, I don’t know what’s going on.  It builds if I configure with:
>>>
>>>
>>>
>>> cmake -Daudacity_use_pch=no
>>>
>>>
>>>
>>> It doesn’t build if I configure with:
>>>
>>>
>>>
>>> cmake -Daudacity_use_pch=yes
>>>
>>>
>>>
>>> I thought I understood why, but every “workaround” I’ve tried so far has
>>> failed…grrrrrr
>>>
>>>
>>>
>>> *From:* Leland <ll...@ho...>
>>> *Sent:* Tuesday, May 11, 2021 1:02 PM
>>> *To:* aud...@li...
>>> *Subject:* Re: [Audacity-devel] local build problem on Windows
>>>
>>>
>>>
>>> Hold off…this may be incorrect.  Still digging.
>>>
>>>
>>>
>>> *From:* Leland <ll...@ho...>
>>> *Sent:* Tuesday, May 11, 2021 12:44 PM
>>> *To:* aud...@li...
>>> *Subject:* Re: [Audacity-devel] local build problem on Windows
>>>
>>>
>>>
>>> Paul, the problem is that using “/FI” to force include configwin.h
>>> overrides the method used by CMake to include the precompiled headers. I’m
>>> trying to devise some sort of workaround, but I don’t think it’s gonna be
>>> pretty.
>>>
>>>
>>>
>>> *From:* Leland <ll...@ho...>
>>> *Sent:* Tuesday, May 11, 2021 11:35 AM
>>> *To:* aud...@li...
>>> *Subject:* Re: [Audacity-devel] local build problem on Windows
>>>
>>>
>>>
>>> Yea, it broke the use of precompiled headers on Windows.  Looking into
>>> it…
>>>
>>>
>>>
>>> *From:* David Bailes <drb...@gm...>
>>> *Sent:* Tuesday, May 11, 2021 3:50 AM
>>> *To:* Audacity Development <aud...@li...>
>>> *Subject:* [Audacity-devel] local build problem on Windows
>>>
>>>
>>>
>>> Problems with my local build, using VS 2019, and using VS's cmake, as in
>>> the build instructions in win/build.txt.
>>>
>>> Starting with the recent
>>> commit: 794f4e5877195e28afb230f2cdff166410fd5e37,
>>>
>>> I'm getting the build errors shown below,
>>>
>>> David.
>>>
>>>
>>>
>>>     cmake_pch.cxx
>>> U:\audacity\src\AudioIO.h(95,24): error C3646: 'midiTracks': unknown
>>> override specifier
>>> U:\audacity\src\AudioIO.h(95,34): error C4430: missing type specifier -
>>> int assumed. Note: C++ does not support default-int
>>> U:\audacity\src\AudioIO.h(270,16): error C3646: 'MidiTime': unknown
>>> override specifier
>>> U:\audacity\src\AudioIO.h(270,24): error C2059: syntax error: '('
>>> U:\audacity\src\AudioIO.h(270,26): error C2238: unexpected token(s)
>>> preceding ';'
>>> U:\audacity\src\AudioIO.h(368,20): error C2143: syntax error: missing
>>> ';' before '*'
>>> U:\audacity\src\AudioIO.h(368,20): error C4430: missing type specifier -
>>> int assumed. Note: C++ does not support default-int
>>> U:\audacity\src\AudioIO.h(368,32): error C2238: unexpected token(s)
>>> preceding ';'
>>> U:\audacity\src\AudioIO.h(392,16): error C3646: 'mMaxMidiTimestamp':
>>> unknown override specifier
>>> U:\audacity\src\AudioIO.h(392,33): error C4430: missing type specifier -
>>> int assumed. Note: C++ does not support default-int
>>> U:\audacity\src\AudioIO.h(415,17): error C2143: syntax error: missing
>>> ';' before '*'
>>> U:\audacity\src\AudioIO.h(415,17): error C4430: missing type specifier -
>>> int assumed. Note: C++ does not support default-int
>>> U:\audacity\src\AudioIO.h(415,22): error C2238: unexpected token(s)
>>> preceding ';'
>>> U:\audacity\src\AudioIO.h(416,20): error C2065: 'Alg_iterator':
>>> undeclared identifier
>>> U:\audacity\src\AudioIO.h(416,9): error C2923: 'std::unique_ptr':
>>> 'Alg_iterator' is not a valid template type argument for parameter '_Ty'
>>> U:\audacity\src\AudioIO.h(416,9): error C2976: 'std::unique_ptr': too
>>> few template arguments
>>>   C:\Program Files (x86)\Microsoft Visual
>>> Studio\2019\Community\VC\Tools\MSVC\14.28.29910\include\memory(3319):
>>> message : see declaration of 'std::unique_ptr'
>>> [U:\audacity\out\build\x86-Debug\src\Audacity.vcxproj]
>>> U:\audacity\src\AudioIO.h(418,17): error C2143: syntax error: missing
>>> ';' before '*'
>>> U:\audacity\src\AudioIO.h(418,17): error C4430: missing type specifier -
>>> int assumed. Note: C++ does not support default-int
>>> U:\audacity\src\AudioIO.h(418,28): error C2238: unexpected token(s)
>>> preceding ';'
>>> U:\audacity\src\AudioIO.h(428,21): error C2143: syntax error: missing
>>> ';' before '*'
>>> U:\audacity\src\AudioIO.h(428,21): error C4430: missing type specifier -
>>> int assumed. Note: C++ does not support default-int
>>> U:\audacity\src\AudioIO.h(428,37): error C2238: unexpected token(s)
>>> preceding ';'
>>> U:\audacity\src\AudioIO.h(434,24): error C3646: 'mMidiPlaybackTracks':
>>> unknown override specifier
>>> U:\audacity\src\AudioIO.h(434,43): error C4430: missing type specifier -
>>> int assumed. Note: C++ does not support default-int
>>>
>>> Build All failed.
>>> _______________________________________________
>>> audacity-devel mailing list
>>> aud...@li...
>>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>>
>> _______________________________________________
>> audacity-devel mailing list
>> aud...@li...
>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>
> _______________________________________________
> audacity-devel mailing list
> aud...@li...
> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>

Re: [Audacity-devel] local build problem on Windows

[James C. <jam...@gm...>]

Thanks for the quick confirmation of a fix.

On Wed, 12 May 2021 at 13:18, David Bailes <drb...@gm...> wrote:

> On Tue, 11 May 2021 at 21:02, Leland <ll...@ho...> wrote:
>
>> Patch is attached.  I don’t feel like hassling with a pull request just
>> for this…times are a changing.  😊
>>
>
> thanks, I can confirm that this fixes the problem on Windows,
> David.
>
>
>>
>>
>> diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
>>
>> index 3ff5911fb..e3443ce81 100644
>>
>> --- a/src/CMakeLists.txt
>>
>> +++ b/src/CMakeLists.txt
>>
>> @@ -1316,7 +1316,15 @@ if( CMAKE_VERSION VERSION_GREATER_EQUAL "3.16" AND
>> NOT CCACHE_PROGRAM )
>>
>>
>>
>>     if( ${_OPT}use_pch )
>>
>>        message( STATUS "Using precompiled headers" )
>>
>> -      target_precompile_headers( ${TARGET} PRIVATE AudacityHeaders.h )
>>
>> +      target_precompile_headers( ${TARGET}
>>
>> +         PRIVATE
>>
>> +            # The way CMake generates the project file on Windows, the
>> normal
>>
>> +            # "force include" of configwin.h will happen AFTER
>> AudacityHeaders.h
>>
>> +            # is included.  So, anything depending on the configwin.h
>> variables
>>
>> +            # will not be properly defined.
>>
>> +
>> $<$<CXX_COMPILER_ID:MSVC>:"${CMAKE_BINARY_DIR}/src/private/configwin.h">
>>
>> +            AudacityHeaders.h
>>
>> +      )
>>
>>     else()
>>
>>        message( STATUS "Not using precompiled headers" )
>>
>>     endif()
>>
>>
>>
>>
>>
>>
>>
>> *From:* Leland <ll...@ho...>
>> *Sent:* Tuesday, May 11, 2021 1:12 PM
>> *To:* aud...@li...
>> *Subject:* Re: [Audacity-devel] local build problem on Windows
>>
>>
>>
>> Honestly, I don’t know what’s going on.  It builds if I configure with:
>>
>>
>>
>> cmake -Daudacity_use_pch=no
>>
>>
>>
>> It doesn’t build if I configure with:
>>
>>
>>
>> cmake -Daudacity_use_pch=yes
>>
>>
>>
>> I thought I understood why, but every “workaround” I’ve tried so far has
>> failed…grrrrrr
>>
>>
>>
>> *From:* Leland <ll...@ho...>
>> *Sent:* Tuesday, May 11, 2021 1:02 PM
>> *To:* aud...@li...
>> *Subject:* Re: [Audacity-devel] local build problem on Windows
>>
>>
>>
>> Hold off…this may be incorrect.  Still digging.
>>
>>
>>
>> *From:* Leland <ll...@ho...>
>> *Sent:* Tuesday, May 11, 2021 12:44 PM
>> *To:* aud...@li...
>> *Subject:* Re: [Audacity-devel] local build problem on Windows
>>
>>
>>
>> Paul, the problem is that using “/FI” to force include configwin.h
>> overrides the method used by CMake to include the precompiled headers. I’m
>> trying to devise some sort of workaround, but I don’t think it’s gonna be
>> pretty.
>>
>>
>>
>> *From:* Leland <ll...@ho...>
>> *Sent:* Tuesday, May 11, 2021 11:35 AM
>> *To:* aud...@li...
>> *Subject:* Re: [Audacity-devel] local build problem on Windows
>>
>>
>>
>> Yea, it broke the use of precompiled headers on Windows.  Looking into it…
>>
>>
>>
>> *From:* David Bailes <drb...@gm...>
>> *Sent:* Tuesday, May 11, 2021 3:50 AM
>> *To:* Audacity Development <aud...@li...>
>> *Subject:* [Audacity-devel] local build problem on Windows
>>
>>
>>
>> Problems with my local build, using VS 2019, and using VS's cmake, as in
>> the build instructions in win/build.txt.
>>
>> Starting with the recent commit: 794f4e5877195e28afb230f2cdff166410fd5e37,
>>
>> I'm getting the build errors shown below,
>>
>> David.
>>
>>
>>
>>     cmake_pch.cxx
>> U:\audacity\src\AudioIO.h(95,24): error C3646: 'midiTracks': unknown
>> override specifier
>> U:\audacity\src\AudioIO.h(95,34): error C4430: missing type specifier -
>> int assumed. Note: C++ does not support default-int
>> U:\audacity\src\AudioIO.h(270,16): error C3646: 'MidiTime': unknown
>> override specifier
>> U:\audacity\src\AudioIO.h(270,24): error C2059: syntax error: '('
>> U:\audacity\src\AudioIO.h(270,26): error C2238: unexpected token(s)
>> preceding ';'
>> U:\audacity\src\AudioIO.h(368,20): error C2143: syntax error: missing ';'
>> before '*'
>> U:\audacity\src\AudioIO.h(368,20): error C4430: missing type specifier -
>> int assumed. Note: C++ does not support default-int
>> U:\audacity\src\AudioIO.h(368,32): error C2238: unexpected token(s)
>> preceding ';'
>> U:\audacity\src\AudioIO.h(392,16): error C3646: 'mMaxMidiTimestamp':
>> unknown override specifier
>> U:\audacity\src\AudioIO.h(392,33): error C4430: missing type specifier -
>> int assumed. Note: C++ does not support default-int
>> U:\audacity\src\AudioIO.h(415,17): error C2143: syntax error: missing ';'
>> before '*'
>> U:\audacity\src\AudioIO.h(415,17): error C4430: missing type specifier -
>> int assumed. Note: C++ does not support default-int
>> U:\audacity\src\AudioIO.h(415,22): error C2238: unexpected token(s)
>> preceding ';'
>> U:\audacity\src\AudioIO.h(416,20): error C2065: 'Alg_iterator':
>> undeclared identifier
>> U:\audacity\src\AudioIO.h(416,9): error C2923: 'std::unique_ptr':
>> 'Alg_iterator' is not a valid template type argument for parameter '_Ty'
>> U:\audacity\src\AudioIO.h(416,9): error C2976: 'std::unique_ptr': too few
>> template arguments
>>   C:\Program Files (x86)\Microsoft Visual
>> Studio\2019\Community\VC\Tools\MSVC\14.28.29910\include\memory(3319):
>> message : see declaration of 'std::unique_ptr'
>> [U:\audacity\out\build\x86-Debug\src\Audacity.vcxproj]
>> U:\audacity\src\AudioIO.h(418,17): error C2143: syntax error: missing ';'
>> before '*'
>> U:\audacity\src\AudioIO.h(418,17): error C4430: missing type specifier -
>> int assumed. Note: C++ does not support default-int
>> U:\audacity\src\AudioIO.h(418,28): error C2238: unexpected token(s)
>> preceding ';'
>> U:\audacity\src\AudioIO.h(428,21): error C2143: syntax error: missing ';'
>> before '*'
>> U:\audacity\src\AudioIO.h(428,21): error C4430: missing type specifier -
>> int assumed. Note: C++ does not support default-int
>> U:\audacity\src\AudioIO.h(428,37): error C2238: unexpected token(s)
>> preceding ';'
>> U:\audacity\src\AudioIO.h(434,24): error C3646: 'mMidiPlaybackTracks':
>> unknown override specifier
>> U:\audacity\src\AudioIO.h(434,43): error C4430: missing type specifier -
>> int assumed. Note: C++ does not support default-int
>>
>> Build All failed.
>> _______________________________________________
>> audacity-devel mailing list
>> aud...@li...
>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>
> _______________________________________________
> audacity-devel mailing list
> aud...@li...
> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>

Re: [Audacity-devel] local build problem on Windows

[David B. <drb...@gm...>]

On Tue, 11 May 2021 at 21:02, Leland <ll...@ho...> wrote:

> Patch is attached.  I don’t feel like hassling with a pull request just
> for this…times are a changing.  😊
>

thanks, I can confirm that this fixes the problem on Windows,
David.


>
>
> diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
>
> index 3ff5911fb..e3443ce81 100644
>
> --- a/src/CMakeLists.txt
>
> +++ b/src/CMakeLists.txt
>
> @@ -1316,7 +1316,15 @@ if( CMAKE_VERSION VERSION_GREATER_EQUAL "3.16" AND
> NOT CCACHE_PROGRAM )
>
>
>
>     if( ${_OPT}use_pch )
>
>        message( STATUS "Using precompiled headers" )
>
> -      target_precompile_headers( ${TARGET} PRIVATE AudacityHeaders.h )
>
> +      target_precompile_headers( ${TARGET}
>
> +         PRIVATE
>
> +            # The way CMake generates the project file on Windows, the
> normal
>
> +            # "force include" of configwin.h will happen AFTER
> AudacityHeaders.h
>
> +            # is included.  So, anything depending on the configwin.h
> variables
>
> +            # will not be properly defined.
>
> +
> $<$<CXX_COMPILER_ID:MSVC>:"${CMAKE_BINARY_DIR}/src/private/configwin.h">
>
> +            AudacityHeaders.h
>
> +      )
>
>     else()
>
>        message( STATUS "Not using precompiled headers" )
>
>     endif()
>
>
>
>
>
>
>
> *From:* Leland <ll...@ho...>
> *Sent:* Tuesday, May 11, 2021 1:12 PM
> *To:* aud...@li...
> *Subject:* Re: [Audacity-devel] local build problem on Windows
>
>
>
> Honestly, I don’t know what’s going on.  It builds if I configure with:
>
>
>
> cmake -Daudacity_use_pch=no
>
>
>
> It doesn’t build if I configure with:
>
>
>
> cmake -Daudacity_use_pch=yes
>
>
>
> I thought I understood why, but every “workaround” I’ve tried so far has
> failed…grrrrrr
>
>
>
> *From:* Leland <ll...@ho...>
> *Sent:* Tuesday, May 11, 2021 1:02 PM
> *To:* aud...@li...
> *Subject:* Re: [Audacity-devel] local build problem on Windows
>
>
>
> Hold off…this may be incorrect.  Still digging.
>
>
>
> *From:* Leland <ll...@ho...>
> *Sent:* Tuesday, May 11, 2021 12:44 PM
> *To:* aud...@li...
> *Subject:* Re: [Audacity-devel] local build problem on Windows
>
>
>
> Paul, the problem is that using “/FI” to force include configwin.h
> overrides the method used by CMake to include the precompiled headers. I’m
> trying to devise some sort of workaround, but I don’t think it’s gonna be
> pretty.
>
>
>
> *From:* Leland <ll...@ho...>
> *Sent:* Tuesday, May 11, 2021 11:35 AM
> *To:* aud...@li...
> *Subject:* Re: [Audacity-devel] local build problem on Windows
>
>
>
> Yea, it broke the use of precompiled headers on Windows.  Looking into it…
>
>
>
> *From:* David Bailes <drb...@gm...>
> *Sent:* Tuesday, May 11, 2021 3:50 AM
> *To:* Audacity Development <aud...@li...>
> *Subject:* [Audacity-devel] local build problem on Windows
>
>
>
> Problems with my local build, using VS 2019, and using VS's cmake, as in
> the build instructions in win/build.txt.
>
> Starting with the recent commit: 794f4e5877195e28afb230f2cdff166410fd5e37,
>
> I'm getting the build errors shown below,
>
> David.
>
>
>
>     cmake_pch.cxx
> U:\audacity\src\AudioIO.h(95,24): error C3646: 'midiTracks': unknown
> override specifier
> U:\audacity\src\AudioIO.h(95,34): error C4430: missing type specifier -
> int assumed. Note: C++ does not support default-int
> U:\audacity\src\AudioIO.h(270,16): error C3646: 'MidiTime': unknown
> override specifier
> U:\audacity\src\AudioIO.h(270,24): error C2059: syntax error: '('
> U:\audacity\src\AudioIO.h(270,26): error C2238: unexpected token(s)
> preceding ';'
> U:\audacity\src\AudioIO.h(368,20): error C2143: syntax error: missing ';'
> before '*'
> U:\audacity\src\AudioIO.h(368,20): error C4430: missing type specifier -
> int assumed. Note: C++ does not support default-int
> U:\audacity\src\AudioIO.h(368,32): error C2238: unexpected token(s)
> preceding ';'
> U:\audacity\src\AudioIO.h(392,16): error C3646: 'mMaxMidiTimestamp':
> unknown override specifier
> U:\audacity\src\AudioIO.h(392,33): error C4430: missing type specifier -
> int assumed. Note: C++ does not support default-int
> U:\audacity\src\AudioIO.h(415,17): error C2143: syntax error: missing ';'
> before '*'
> U:\audacity\src\AudioIO.h(415,17): error C4430: missing type specifier -
> int assumed. Note: C++ does not support default-int
> U:\audacity\src\AudioIO.h(415,22): error C2238: unexpected token(s)
> preceding ';'
> U:\audacity\src\AudioIO.h(416,20): error C2065: 'Alg_iterator': undeclared
> identifier
> U:\audacity\src\AudioIO.h(416,9): error C2923: 'std::unique_ptr':
> 'Alg_iterator' is not a valid template type argument for parameter '_Ty'
> U:\audacity\src\AudioIO.h(416,9): error C2976: 'std::unique_ptr': too few
> template arguments
>   C:\Program Files (x86)\Microsoft Visual
> Studio\2019\Community\VC\Tools\MSVC\14.28.29910\include\memory(3319):
> message : see declaration of 'std::unique_ptr'
> [U:\audacity\out\build\x86-Debug\src\Audacity.vcxproj]
> U:\audacity\src\AudioIO.h(418,17): error C2143: syntax error: missing ';'
> before '*'
> U:\audacity\src\AudioIO.h(418,17): error C4430: missing type specifier -
> int assumed. Note: C++ does not support default-int
> U:\audacity\src\AudioIO.h(418,28): error C2238: unexpected token(s)
> preceding ';'
> U:\audacity\src\AudioIO.h(428,21): error C2143: syntax error: missing ';'
> before '*'
> U:\audacity\src\AudioIO.h(428,21): error C4430: missing type specifier -
> int assumed. Note: C++ does not support default-int
> U:\audacity\src\AudioIO.h(428,37): error C2238: unexpected token(s)
> preceding ';'
> U:\audacity\src\AudioIO.h(434,24): error C3646: 'mMidiPlaybackTracks':
> unknown override specifier
> U:\audacity\src\AudioIO.h(434,43): error C4430: missing type specifier -
> int assumed. Note: C++ does not support default-int
>
> Build All failed.
> _______________________________________________
> audacity-devel mailing list
> aud...@li...
> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>

Re: [Audacity-devel] local build problem on Windows

[Paul L. <pau...@gm...>]

It seems I broke builds with precompiled headers with commit 794f4e5, but
that did not break the automated builds.

This should not be too hard to figure out I hope.  I'll see if I can.

PRL


On Wed, May 12, 2021 at 2:48 AM Cliff <fly...@gm...> wrote:

> Yes, I did that.
>
> Cliff
>
> On May 11, 2021, at 23:10, Leland <ll...@ho...> wrote:
>
> Cliff, have you tried deleting your build directory and running cmake from
> scratch?
>
> *From:* Cliff <fly...@gm...>
> *Sent:* Tuesday, May 11, 2021 10:44 PM
> *To:* aud...@li...
> *Subject:* Re: [Audacity-devel] local build problem on Windows
>
> Build also fails on MacOS.
>
> fatal error:
> '/Users/CMac/Downloads/Audacity/BuildEnvironment/audacity/bld/src/SharedPrecompiledHeaders/cmake_pch-bhvpwdmrkbsbbhamvazvevthymfp/cmake_pch.hxx'
> file not found
> #include
> "/Users/CMac/Downloads/Audacity/BuildEnvironment/audacity/bld/src/SharedPrecompiledHeaders/cmake_pch-bhvpwdmrkbsbbhamvazvevthymfp/cmake_pch.hxx"
>
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> ** BUILD FAILED **
>
>
> The following build commands failed:
>                    CompileC
> bld/src/Audacity.build/Release/Audacity.build/Objects-normal/x86_64/AllThemeResources.o
> src/AllThemeResources.cpp normal x86_64 c++
> com.apple.compilers.llvm.clang.1_0.compiler
> (1 failure)
>
>
> Cliff
>
>
> On May 11, 2021, at 16:50, Paul Licameli <pau...@gm...> wrote:
>
>
>
> On Tue, May 11, 2021 at 2:13 PM Leland <ll...@ho...> wrote:
>
> Honestly, I don’t know what’s going on.  It builds if I configure with:
>
> cmake -Daudacity_use_pch=no
>
>
> That's how GitHub actions builds it, yes?
>
>
>
> It doesn’t build if I configure with:
>
> cmake -Daudacity_use_pch=yes
>
> I thought I understood why, but every “workaround” I’ve tried so far has
> failed…grrrrrr
>
>
> I'm sorry, then it was my doing when I tried to eliminate Audacity.h and
> needed another solution for inclusion of the config files.
>
> PRL
>
>
>
>
> *From:* Leland <ll...@ho...>
> *Sent:* Tuesday, May 11, 2021 1:02 PM
> *To:* aud...@li...
> *Subject:* Re: [Audacity-devel] local build problem on Windows
>
> Hold off…this may be incorrect.  Still digging.
>
> *From:* Leland <ll...@ho...>
> *Sent:* Tuesday, May 11, 2021 12:44 PM
> *To:* aud...@li...
> *Subject:* Re: [Audacity-devel] local build problem on Windows
>
> Paul, the problem is that using “/FI” to force include configwin.h
> overrides the method used by CMake to include the precompiled headers. I’m
> trying to devise some sort of workaround, but I don’t think it’s gonna be
> pretty.
>
> *From:* Leland <ll...@ho...>
> *Sent:* Tuesday, May 11, 2021 11:35 AM
> *To:* aud...@li...
> *Subject:* Re: [Audacity-devel] local build problem on Windows
>
> Yea, it broke the use of precompiled headers on Windows.  Looking into it…
>
> *From:* David Bailes <drb...@gm...>
> *Sent:* Tuesday, May 11, 2021 3:50 AM
> *To:* Audacity Development <aud...@li...>
> *Subject:* [Audacity-devel] local build problem on Windows
>
> Problems with my local build, using VS 2019, and using VS's cmake, as in
> the build instructions in win/build.txt.
> Starting with the recent commit: 794f4e5877195e28afb230f2cdff166410fd5e37,
> I'm getting the build errors shown below,
> David.
>
>
>     cmake_pch.cxx
> U:\audacity\src\AudioIO.h(95,24): error C3646: 'midiTracks': unknown
> override specifier
> U:\audacity\src\AudioIO.h(95,34): error C4430: missing type specifier -
> int assumed. Note: C++ does not support default-int
> U:\audacity\src\AudioIO.h(270,16): error C3646: 'MidiTime': unknown
> override specifier
> U:\audacity\src\AudioIO.h(270,24): error C2059: syntax error: '('
> U:\audacity\src\AudioIO.h(270,26): error C2238: unexpected token(s)
> preceding ';'
> U:\audacity\src\AudioIO.h(368,20): error C2143: syntax error: missing ';'
> before '*'
> U:\audacity\src\AudioIO.h(368,20): error C4430: missing type specifier -
> int assumed. Note: C++ does not support default-int
> U:\audacity\src\AudioIO.h(368,32): error C2238: unexpected token(s)
> preceding ';'
> U:\audacity\src\AudioIO.h(392,16): error C3646: 'mMaxMidiTimestamp':
> unknown override specifier
> U:\audacity\src\AudioIO.h(392,33): error C4430: missing type specifier -
> int assumed. Note: C++ does not support default-int
> U:\audacity\src\AudioIO.h(415,17): error C2143: syntax error: missing ';'
> before '*'
> U:\audacity\src\AudioIO.h(415,17): error C4430: missing type specifier -
> int assumed. Note: C++ does not support default-int
> U:\audacity\src\AudioIO.h(415,22): error C2238: unexpected token(s)
> preceding ';'
> U:\audacity\src\AudioIO.h(416,20): error C2065: 'Alg_iterator': undeclared
> identifier
> U:\audacity\src\AudioIO.h(416,9): error C2923: 'std::unique_ptr':
> 'Alg_iterator' is not a valid template type argument for parameter '_Ty'
> U:\audacity\src\AudioIO.h(416,9): error C2976: 'std::unique_ptr': too few
> template arguments
>   C:\Program Files (x86)\Microsoft Visual
> Studio\2019\Community\VC\Tools\MSVC\14.28.29910\include\memory(3319):
> message : see declaration of 'std::unique_ptr'
> [U:\audacity\out\build\x86-Debug\src\Audacity.vcxproj]
> U:\audacity\src\AudioIO.h(418,17): error C2143: syntax error: missing ';'
> before '*'
> U:\audacity\src\AudioIO.h(418,17): error C4430: missing type specifier -
> int assumed. Note: C++ does not support default-int
> U:\audacity\src\AudioIO.h(418,28): error C2238: unexpected token(s)
> preceding ';'
> U:\audacity\src\AudioIO.h(428,21): error C2143: syntax error: missing ';'
> before '*'
> U:\audacity\src\AudioIO.h(428,21): error C4430: missing type specifier -
> int assumed. Note: C++ does not support default-int
> U:\audacity\src\AudioIO.h(428,37): error C2238: unexpected token(s)
> preceding ';'
> U:\audacity\src\AudioIO.h(434,24): error C3646: 'mMidiPlaybackTracks':
> unknown override specifier
> U:\audacity\src\AudioIO.h(434,43): error C4430: missing type specifier -
> int assumed. Note: C++ does not support default-int
> Build All failed.
> _______________________________________________
> audacity-devel mailing list
> aud...@li...
> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>
> _______________________________________________
> audacity-devel mailing list
> aud...@li...
> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>
>
> _______________________________________________
> audacity-devel mailing list
> aud...@li...
> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>
>
> _______________________________________________
> audacity-devel mailing list
> aud...@li...
> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>

Re: [Audacity-devel] Some comments regardig https://github.com/audacity/audacity/pull/836

[Joost A. <Joo...@gm...>]

Hi James,

regarding the DB backend logics I cannot say anything as it doesn't 
exsist anymore and the Apache OpenOffice team decided to deactivate the 
feature. AFAIK LibreOffice still uses some sort of crash reporting 
functionality. I'm not sure if they use breakpad.

https://crashreport.libreoffice.org/stats/
https://github.com/mmohrhard/crash

I must warn about the overhead on server side, because each released 
build needs to be archived with debug information (that's very expensive 
!) because you need the debug information to attach library names to the 
stack IDs. For OpenOffice.org it ment to store massive GB locally for 
each build within the local server environment of the 
StarOffice/OpenOffice.org development team at Sun Microsystems in Hamburg.

Kind regards, Joost


Am 11.05.2021 um 17:18 schrieb James Crook:
> Thanks Joost!
> 
> That sounds good, and not a contentious use of TCP/IP at all,
> especially as explicit opt-in on each and every crash.
> 
> Can you say more about the processing at the receiving end??
> Lots of time and work on tools there??  My expectation is that
> some crashes will have very repeatable stack traces, often due
> to a recent change in our code, but some won't, and I wonder
> particularly how you dealt with those?
> 
> Is it one of those cases where 90% of the benefit comes easily, once
> set up, and that alone makes it worthwhile doing?
> 
> --James.
> 

Re: [Audacity-devel] local build problem on Windows

[Cliff <fly...@gm...>]

Yes, I did that.

Cliff

> On May 11, 2021, at 23:10, Leland <ll...@ho...> wrote:
> 
> Cliff, have you tried deleting your build directory and running cmake from scratch?
>  
> From: Cliff <fly...@gm...> 
> Sent: Tuesday, May 11, 2021 10:44 PM
> To: aud...@li...
> Subject: Re: [Audacity-devel] local build problem on Windows
>  
> Build also fails on MacOS.
>  
> fatal error: '/Users/CMac/Downloads/Audacity/BuildEnvironment/audacity/bld/src/SharedPrecompiledHeaders/cmake_pch-bhvpwdmrkbsbbhamvazvevthymfp/cmake_pch.hxx' file not found
> #include "/Users/CMac/Downloads/Audacity/BuildEnvironment/audacity/bld/src/SharedPrecompiledHeaders/cmake_pch-bhvpwdmrkbsbbhamvazvevthymfp/cmake_pch.hxx"
>          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>  
> ** BUILD FAILED **
>  
>  
> The following build commands failed:
>                    CompileC bld/src/Audacity.build/Release/Audacity.build/Objects-normal/x86_64/AllThemeResources.o src/AllThemeResources.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler
> (1 failure)
> 
> 
> Cliff
> 
> 
>> On May 11, 2021, at 16:50, Paul Licameli <pau...@gm... <mailto:pau...@gm...>> wrote:
>>  
>>  
>> 
>> On Tue, May 11, 2021 at 2:13 PM Leland <ll...@ho... <mailto:ll...@ho...>> wrote:
>>> Honestly, I don’t know what’s going on.  It builds if I configure with:
>>>  
>>> cmake -Daudacity_use_pch=no
>>  
>> That's how GitHub actions builds it, yes?
>>  
>>>  
>>> It doesn’t build if I configure with:
>>>  
>>> cmake -Daudacity_use_pch=yes
>>>  
>>> I thought I understood why, but every “workaround” I’ve tried so far has failed…grrrrrr
>>  
>> I'm sorry, then it was my doing when I tried to eliminate Audacity.h and needed another solution for inclusion of the config files.
>>  
>> PRL
>>  
>>  
>>>  
>>> From: Leland <ll...@ho... <mailto:ll...@ho...>> 
>>> Sent: Tuesday, May 11, 2021 1:02 PM
>>> To: aud...@li... <mailto:aud...@li...>
>>> Subject: Re: [Audacity-devel] local build problem on Windows
>>>  
>>> Hold off…this may be incorrect.  Still digging.
>>>  
>>> From: Leland <ll...@ho... <mailto:ll...@ho...>> 
>>> Sent: Tuesday, May 11, 2021 12:44 PM
>>> To: aud...@li... <mailto:aud...@li...>
>>> Subject: Re: [Audacity-devel] local build problem on Windows
>>>  
>>> Paul, the problem is that using “/FI” to force include configwin.h overrides the method used by CMake to include the precompiled headers. I’m trying to devise some sort of workaround, but I don’t think it’s gonna be pretty.
>>>  
>>> From: Leland <ll...@ho... <mailto:ll...@ho...>> 
>>> Sent: Tuesday, May 11, 2021 11:35 AM
>>> To: aud...@li... <mailto:aud...@li...>
>>> Subject: Re: [Audacity-devel] local build problem on Windows
>>>  
>>> Yea, it broke the use of precompiled headers on Windows.  Looking into it…
>>>  
>>> From: David Bailes <drb...@gm... <mailto:drb...@gm...>> 
>>> Sent: Tuesday, May 11, 2021 3:50 AM
>>> To: Audacity Development <aud...@li... <mailto:aud...@li...>>
>>> Subject: [Audacity-devel] local build problem on Windows
>>>  
>>> Problems with my local build, using VS 2019, and using VS's cmake, as in the build instructions in win/build.txt.
>>> Starting with the recent commit: 794f4e5877195e28afb230f2cdff166410fd5e37,
>>> I'm getting the build errors shown below,
>>> David.
>>>  
>>>     cmake_pch.cxx
>>> U:\audacity\src\AudioIO.h(95,24): error C3646: 'midiTracks': unknown override specifier 
>>> U:\audacity\src\AudioIO.h(95,34): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 
>>> U:\audacity\src\AudioIO.h(270,16): error C3646: 'MidiTime': unknown override specifier 
>>> U:\audacity\src\AudioIO.h(270,24): error C2059: syntax error: '(' 
>>> U:\audacity\src\AudioIO.h(270,26): error C2238: unexpected token(s) preceding ';' 
>>> U:\audacity\src\AudioIO.h(368,20): error C2143: syntax error: missing ';' before '*' 
>>> U:\audacity\src\AudioIO.h(368,20): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 
>>> U:\audacity\src\AudioIO.h(368,32): error C2238: unexpected token(s) preceding ';' 
>>> U:\audacity\src\AudioIO.h(392,16): error C3646: 'mMaxMidiTimestamp': unknown override specifier 
>>> U:\audacity\src\AudioIO.h(392,33): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 
>>> U:\audacity\src\AudioIO.h(415,17): error C2143: syntax error: missing ';' before '*' 
>>> U:\audacity\src\AudioIO.h(415,17): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 
>>> U:\audacity\src\AudioIO.h(415,22): error C2238: unexpected token(s) preceding ';' 
>>> U:\audacity\src\AudioIO.h(416,20): error C2065: 'Alg_iterator': undeclared identifier 
>>> U:\audacity\src\AudioIO.h(416,9): error C2923: 'std::unique_ptr': 'Alg_iterator' is not a valid template type argument for parameter '_Ty' 
>>> U:\audacity\src\AudioIO.h(416,9): error C2976: 'std::unique_ptr': too few template arguments 
>>>   C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.28.29910\include\memory(3319): message : see declaration of 'std::unique_ptr' [U:\audacity\out\build\x86-Debug\src\Audacity.vcxproj]
>>> U:\audacity\src\AudioIO.h(418,17): error C2143: syntax error: missing ';' before '*' 
>>> U:\audacity\src\AudioIO.h(418,17): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 
>>> U:\audacity\src\AudioIO.h(418,28): error C2238: unexpected token(s) preceding ';' 
>>> U:\audacity\src\AudioIO.h(428,21): error C2143: syntax error: missing ';' before '*' 
>>> U:\audacity\src\AudioIO.h(428,21): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 
>>> U:\audacity\src\AudioIO.h(428,37): error C2238: unexpected token(s) preceding ';' 
>>> U:\audacity\src\AudioIO.h(434,24): error C3646: 'mMidiPlaybackTracks': unknown override specifier 
>>> U:\audacity\src\AudioIO.h(434,43): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 
>>> 
>>> Build All failed. 
>>> _______________________________________________
>>> audacity-devel mailing list
>>> aud...@li... <mailto:aud...@li...>
>>> https://lists.sourceforge.net/lists/listinfo/audacity-devel <https://lists.sourceforge.net/lists/listinfo/audacity-devel>
>> _______________________________________________
>> audacity-devel mailing list
>> aud...@li... <mailto:aud...@li...>
>> https://lists.sourceforge.net/lists/listinfo/audacity-devel <https://lists.sourceforge.net/lists/listinfo/audacity-devel>
>  
> _______________________________________________
> audacity-devel mailing list
> aud...@li... <mailto:aud...@li...>
> https://lists.sourceforge.net/lists/listinfo/audacity-devel <https://lists.sourceforge.net/lists/listinfo/audacity-devel>

Re: [Audacity-devel] local build problem on Windows

[Leland <ll...@ho...>]

Cliff, have you tried deleting your build directory and running cmake from scratch?
 
From: Cliff <fly...@gm...> 
Sent: Tuesday, May 11, 2021 10:44 PM
To: aud...@li...
Subject: Re: [Audacity-devel] local build problem on Windows
 
Build also fails on MacOS.
 
fatal error: '/Users/CMac/Downloads/Audacity/BuildEnvironment/audacity/bld/src/SharedPrecompiledHeaders/cmake_pch-bhvpwdmrkbsbbhamvazvevthymfp/cmake_pch.hxx' file not found
#include "/Users/CMac/Downloads/Audacity/BuildEnvironment/audacity/bld/src/SharedPrecompiledHeaders/cmake_pch-bhvpwdmrkbsbbhamvazvevthymfp/cmake_pch.hxx"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 
** BUILD FAILED **
 
 
The following build commands failed:
                   CompileC bld/src/Audacity.build/Release/Audacity.build/Objects-normal/x86_64/AllThemeResources.o src/AllThemeResources.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler
(1 failure)



Cliff



On May 11, 2021, at 16:50, Paul Licameli <pau...@gm... <mailto:pau...@gm...> > wrote:
 
 
On Tue, May 11, 2021 at 2:13 PM Leland <ll...@ho... <mailto:ll...@ho...> > wrote:
Honestly, I don’t know what’s going on.  It builds if I configure with:
 
cmake -Daudacity_use_pch=no
 
That's how GitHub actions builds it, yes?
 
 
It doesn’t build if I configure with:
 
cmake -Daudacity_use_pch=yes
 
I thought I understood why, but every “workaround” I’ve tried so far has failed…grrrrrr
 
I'm sorry, then it was my doing when I tried to eliminate Audacity.h and needed another solution for inclusion of the config files.
 
PRL
 
 
 
From: Leland <ll...@ho... <mailto:ll...@ho...> > 
Sent: Tuesday, May 11, 2021 1:02 PM
To: aud...@li... <mailto:aud...@li...> 
Subject: Re: [Audacity-devel] local build problem on Windows
 
Hold off…this may be incorrect.  Still digging.
 
From: Leland <ll...@ho... <mailto:ll...@ho...> > 
Sent: Tuesday, May 11, 2021 12:44 PM
To: aud...@li... <mailto:aud...@li...> 
Subject: Re: [Audacity-devel] local build problem on Windows
 
Paul, the problem is that using “/FI” to force include configwin.h overrides the method used by CMake to include the precompiled headers. I’m trying to devise some sort of workaround, but I don’t think it’s gonna be pretty.
 
From: Leland <ll...@ho... <mailto:ll...@ho...> > 
Sent: Tuesday, May 11, 2021 11:35 AM
To: aud...@li... <mailto:aud...@li...> 
Subject: Re: [Audacity-devel] local build problem on Windows
 
Yea, it broke the use of precompiled headers on Windows.  Looking into it…
 
From: David Bailes <drb...@gm... <mailto:drb...@gm...> > 
Sent: Tuesday, May 11, 2021 3:50 AM
To: Audacity Development <aud...@li... <mailto:aud...@li...> >
Subject: [Audacity-devel] local build problem on Windows
 
Problems with my local build, using VS 2019, and using VS's cmake, as in the build instructions in win/build.txt.
Starting with the recent commit: 794f4e5877195e28afb230f2cdff166410fd5e37,
I'm getting the build errors shown below,
David.
 
    cmake_pch.cxx
U:\audacity\src\AudioIO.h(95,24): error C3646: 'midiTracks': unknown override specifier 
U:\audacity\src\AudioIO.h(95,34): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 
U:\audacity\src\AudioIO.h(270,16): error C3646: 'MidiTime': unknown override specifier 
U:\audacity\src\AudioIO.h(270,24): error C2059: syntax error: '(' 
U:\audacity\src\AudioIO.h(270,26): error C2238: unexpected token(s) preceding ';' 
U:\audacity\src\AudioIO.h(368,20): error C2143: syntax error: missing ';' before '*' 
U:\audacity\src\AudioIO.h(368,20): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 
U:\audacity\src\AudioIO.h(368,32): error C2238: unexpected token(s) preceding ';' 
U:\audacity\src\AudioIO.h(392,16): error C3646: 'mMaxMidiTimestamp': unknown override specifier 
U:\audacity\src\AudioIO.h(392,33): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 
U:\audacity\src\AudioIO.h(415,17): error C2143: syntax error: missing ';' before '*' 
U:\audacity\src\AudioIO.h(415,17): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 
U:\audacity\src\AudioIO.h(415,22): error C2238: unexpected token(s) preceding ';' 
U:\audacity\src\AudioIO.h(416,20): error C2065: 'Alg_iterator': undeclared identifier 
U:\audacity\src\AudioIO.h(416,9): error C2923: 'std::unique_ptr': 'Alg_iterator' is not a valid template type argument for parameter '_Ty' 
U:\audacity\src\AudioIO.h(416,9): error C2976: 'std::unique_ptr': too few template arguments 
  C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.28.29910\include\memory(3319): message : see declaration of 'std::unique_ptr' [U:\audacity\out\build\x86-Debug\src\Audacity.vcxproj]
U:\audacity\src\AudioIO.h(418,17): error C2143: syntax error: missing ';' before '*' 
U:\audacity\src\AudioIO.h(418,17): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 
U:\audacity\src\AudioIO.h(418,28): error C2238: unexpected token(s) preceding ';' 
U:\audacity\src\AudioIO.h(428,21): error C2143: syntax error: missing ';' before '*' 
U:\audacity\src\AudioIO.h(428,21): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 
U:\audacity\src\AudioIO.h(428,37): error C2238: unexpected token(s) preceding ';' 
U:\audacity\src\AudioIO.h(434,24): error C3646: 'mMidiPlaybackTracks': unknown override specifier 
U:\audacity\src\AudioIO.h(434,43): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 
Build All failed. 
_______________________________________________
audacity-devel mailing list
aud...@li... <mailto:aud...@li...> 
https://lists.sourceforge.net/lists/listinfo/audacity-devel
_______________________________________________
audacity-devel mailing list
 <mailto:aud...@li...> aud...@li...
 <https://lists.sourceforge.net/lists/listinfo/audacity-devel> https://lists.sourceforge.net/lists/listinfo/audacity-devel
 

Re: [Audacity-devel] local build problem on Windows

[Cliff <fly...@gm...>]

Build also fails on MacOS.

fatal error: '/Users/CMac/Downloads/Audacity/BuildEnvironment/audacity/bld/src/SharedPrecompiledHeaders/cmake_pch-bhvpwdmrkbsbbhamvazvevthymfp/cmake_pch.hxx' file not found
#include "/Users/CMac/Downloads/Audacity/BuildEnvironment/audacity/bld/src/SharedPrecompiledHeaders/cmake_pch-bhvpwdmrkbsbbhamvazvevthymfp/cmake_pch.hxx"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

** BUILD FAILED **


The following build commands failed:
	CompileC bld/src/Audacity.build/Release/Audacity.build/Objects-normal/x86_64/AllThemeResources.o src/AllThemeResources.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler
(1 failure)

Cliff

> On May 11, 2021, at 16:50, Paul Licameli <pau...@gm...> wrote:
> 
> 
> 
> On Tue, May 11, 2021 at 2:13 PM Leland <ll...@ho... <mailto:ll...@ho...>> wrote:
> Honestly, I don’t know what’s going on.  It builds if I configure with:
> 
>  
> 
> cmake -Daudacity_use_pch=no
> 
> 
> That's how GitHub actions builds it, yes?
>  
>  
> 
> It doesn’t build if I configure with:
> 
>  
> 
> cmake -Daudacity_use_pch=yes
> 
>  
> 
> I thought I understood why, but every “workaround” I’ve tried so far has failed…grrrrrr
> 
> 
> I'm sorry, then it was my doing when I tried to eliminate Audacity.h and needed another solution for inclusion of the config files.
> 
> PRL
> 
>  
>  
> 
> From: Leland <ll...@ho... <mailto:ll...@ho...>> 
> Sent: Tuesday, May 11, 2021 1:02 PM
> To: aud...@li... <mailto:aud...@li...>
> Subject: Re: [Audacity-devel] local build problem on Windows
> 
>  
> 
> Hold off…this may be incorrect.  Still digging.
> 
>  
> 
> From: Leland <ll...@ho... <mailto:ll...@ho...>> 
> Sent: Tuesday, May 11, 2021 12:44 PM
> To: aud...@li... <mailto:aud...@li...>
> Subject: Re: [Audacity-devel] local build problem on Windows
> 
>  
> 
> Paul, the problem is that using “/FI” to force include configwin.h overrides the method used by CMake to include the precompiled headers. I’m trying to devise some sort of workaround, but I don’t think it’s gonna be pretty.
> 
>  
> 
> From: Leland <ll...@ho... <mailto:ll...@ho...>> 
> Sent: Tuesday, May 11, 2021 11:35 AM
> To: aud...@li... <mailto:aud...@li...>
> Subject: Re: [Audacity-devel] local build problem on Windows
> 
>  
> 
> Yea, it broke the use of precompiled headers on Windows.  Looking into it…
> 
>  
> 
> From: David Bailes <drb...@gm... <mailto:drb...@gm...>> 
> Sent: Tuesday, May 11, 2021 3:50 AM
> To: Audacity Development <aud...@li... <mailto:aud...@li...>>
> Subject: [Audacity-devel] local build problem on Windows
> 
>  
> 
> Problems with my local build, using VS 2019, and using VS's cmake, as in the build instructions in win/build.txt.
> 
> Starting with the recent commit: 794f4e5877195e28afb230f2cdff166410fd5e37,
> 
> I'm getting the build errors shown below,
> 
> David.
> 
>  
> 
>     cmake_pch.cxx
> U:\audacity\src\AudioIO.h(95,24): error C3646: 'midiTracks': unknown override specifier 
> U:\audacity\src\AudioIO.h(95,34): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 
> U:\audacity\src\AudioIO.h(270,16): error C3646: 'MidiTime': unknown override specifier 
> U:\audacity\src\AudioIO.h(270,24): error C2059: syntax error: '(' 
> U:\audacity\src\AudioIO.h(270,26): error C2238: unexpected token(s) preceding ';' 
> U:\audacity\src\AudioIO.h(368,20): error C2143: syntax error: missing ';' before '*' 
> U:\audacity\src\AudioIO.h(368,20): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 
> U:\audacity\src\AudioIO.h(368,32): error C2238: unexpected token(s) preceding ';' 
> U:\audacity\src\AudioIO.h(392,16): error C3646: 'mMaxMidiTimestamp': unknown override specifier 
> U:\audacity\src\AudioIO.h(392,33): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 
> U:\audacity\src\AudioIO.h(415,17): error C2143: syntax error: missing ';' before '*' 
> U:\audacity\src\AudioIO.h(415,17): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 
> U:\audacity\src\AudioIO.h(415,22): error C2238: unexpected token(s) preceding ';' 
> U:\audacity\src\AudioIO.h(416,20): error C2065: 'Alg_iterator': undeclared identifier 
> U:\audacity\src\AudioIO.h(416,9): error C2923: 'std::unique_ptr': 'Alg_iterator' is not a valid template type argument for parameter '_Ty' 
> U:\audacity\src\AudioIO.h(416,9): error C2976: 'std::unique_ptr': too few template arguments 
>   C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.28.29910\include\memory(3319): message : see declaration of 'std::unique_ptr' [U:\audacity\out\build\x86-Debug\src\Audacity.vcxproj]
> U:\audacity\src\AudioIO.h(418,17): error C2143: syntax error: missing ';' before '*' 
> U:\audacity\src\AudioIO.h(418,17): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 
> U:\audacity\src\AudioIO.h(418,28): error C2238: unexpected token(s) preceding ';' 
> U:\audacity\src\AudioIO.h(428,21): error C2143: syntax error: missing ';' before '*' 
> U:\audacity\src\AudioIO.h(428,21): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 
> U:\audacity\src\AudioIO.h(428,37): error C2238: unexpected token(s) preceding ';' 
> U:\audacity\src\AudioIO.h(434,24): error C3646: 'mMidiPlaybackTracks': unknown override specifier 
> U:\audacity\src\AudioIO.h(434,43): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 
> 
> Build All failed. 
> 
> _______________________________________________
> audacity-devel mailing list
> aud...@li... <mailto:aud...@li...>
> https://lists.sourceforge.net/lists/listinfo/audacity-devel <https://lists.sourceforge.net/lists/listinfo/audacity-devel>
> _______________________________________________
> audacity-devel mailing list
> aud...@li... <mailto:aud...@li...>
> https://lists.sourceforge.net/lists/listinfo/audacity-devel <https://lists.sourceforge.net/lists/listinfo/audacity-devel>

Re: [Audacity-devel] local build problem on Windows

[Paul L. <pau...@gm...>]

On Tue, May 11, 2021 at 2:13 PM Leland <ll...@ho...> wrote:

> Honestly, I don’t know what’s going on.  It builds if I configure with:
>
>
>
> cmake -Daudacity_use_pch=no
>

That's how GitHub actions builds it, yes?


>
>
> It doesn’t build if I configure with:
>
>
>
> cmake -Daudacity_use_pch=yes
>
>
>
> I thought I understood why, but every “workaround” I’ve tried so far has
> failed…grrrrrr
>

I'm sorry, then it was my doing when I tried to eliminate Audacity.h and
needed another solution for inclusion of the config files.

PRL



>
>
> *From:* Leland <ll...@ho...>
> *Sent:* Tuesday, May 11, 2021 1:02 PM
> *To:* aud...@li...
> *Subject:* Re: [Audacity-devel] local build problem on Windows
>
>
>
> Hold off…this may be incorrect.  Still digging.
>
>
>
> *From:* Leland <ll...@ho...>
> *Sent:* Tuesday, May 11, 2021 12:44 PM
> *To:* aud...@li...
> *Subject:* Re: [Audacity-devel] local build problem on Windows
>
>
>
> Paul, the problem is that using “/FI” to force include configwin.h
> overrides the method used by CMake to include the precompiled headers. I’m
> trying to devise some sort of workaround, but I don’t think it’s gonna be
> pretty.
>
>
>
> *From:* Leland <ll...@ho...>
> *Sent:* Tuesday, May 11, 2021 11:35 AM
> *To:* aud...@li...
> *Subject:* Re: [Audacity-devel] local build problem on Windows
>
>
>
> Yea, it broke the use of precompiled headers on Windows.  Looking into it…
>
>
>
> *From:* David Bailes <drb...@gm...>
> *Sent:* Tuesday, May 11, 2021 3:50 AM
> *To:* Audacity Development <aud...@li...>
> *Subject:* [Audacity-devel] local build problem on Windows
>
>
>
> Problems with my local build, using VS 2019, and using VS's cmake, as in
> the build instructions in win/build.txt.
>
> Starting with the recent commit: 794f4e5877195e28afb230f2cdff166410fd5e37,
>
> I'm getting the build errors shown below,
>
> David.
>
>
>
>     cmake_pch.cxx
> U:\audacity\src\AudioIO.h(95,24): error C3646: 'midiTracks': unknown
> override specifier
> U:\audacity\src\AudioIO.h(95,34): error C4430: missing type specifier -
> int assumed. Note: C++ does not support default-int
> U:\audacity\src\AudioIO.h(270,16): error C3646: 'MidiTime': unknown
> override specifier
> U:\audacity\src\AudioIO.h(270,24): error C2059: syntax error: '('
> U:\audacity\src\AudioIO.h(270,26): error C2238: unexpected token(s)
> preceding ';'
> U:\audacity\src\AudioIO.h(368,20): error C2143: syntax error: missing ';'
> before '*'
> U:\audacity\src\AudioIO.h(368,20): error C4430: missing type specifier -
> int assumed. Note: C++ does not support default-int
> U:\audacity\src\AudioIO.h(368,32): error C2238: unexpected token(s)
> preceding ';'
> U:\audacity\src\AudioIO.h(392,16): error C3646: 'mMaxMidiTimestamp':
> unknown override specifier
> U:\audacity\src\AudioIO.h(392,33): error C4430: missing type specifier -
> int assumed. Note: C++ does not support default-int
> U:\audacity\src\AudioIO.h(415,17): error C2143: syntax error: missing ';'
> before '*'
> U:\audacity\src\AudioIO.h(415,17): error C4430: missing type specifier -
> int assumed. Note: C++ does not support default-int
> U:\audacity\src\AudioIO.h(415,22): error C2238: unexpected token(s)
> preceding ';'
> U:\audacity\src\AudioIO.h(416,20): error C2065: 'Alg_iterator': undeclared
> identifier
> U:\audacity\src\AudioIO.h(416,9): error C2923: 'std::unique_ptr':
> 'Alg_iterator' is not a valid template type argument for parameter '_Ty'
> U:\audacity\src\AudioIO.h(416,9): error C2976: 'std::unique_ptr': too few
> template arguments
>   C:\Program Files (x86)\Microsoft Visual
> Studio\2019\Community\VC\Tools\MSVC\14.28.29910\include\memory(3319):
> message : see declaration of 'std::unique_ptr'
> [U:\audacity\out\build\x86-Debug\src\Audacity.vcxproj]
> U:\audacity\src\AudioIO.h(418,17): error C2143: syntax error: missing ';'
> before '*'
> U:\audacity\src\AudioIO.h(418,17): error C4430: missing type specifier -
> int assumed. Note: C++ does not support default-int
> U:\audacity\src\AudioIO.h(418,28): error C2238: unexpected token(s)
> preceding ';'
> U:\audacity\src\AudioIO.h(428,21): error C2143: syntax error: missing ';'
> before '*'
> U:\audacity\src\AudioIO.h(428,21): error C4430: missing type specifier -
> int assumed. Note: C++ does not support default-int
> U:\audacity\src\AudioIO.h(428,37): error C2238: unexpected token(s)
> preceding ';'
> U:\audacity\src\AudioIO.h(434,24): error C3646: 'mMidiPlaybackTracks':
> unknown override specifier
> U:\audacity\src\AudioIO.h(434,43): error C4430: missing type specifier -
> int assumed. Note: C++ does not support default-int
>
> Build All failed.
> _______________________________________________
> audacity-devel mailing list
> aud...@li...
> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>

Re: [Audacity-devel] local build problem on Windows

[Leland <ll...@ho...>]

Patch is attached.  I don’t feel like hassling with a pull request just for this…times are a changing.  😊

 

diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt

index 3ff5911fb..e3443ce81 100644

--- a/src/CMakeLists.txt

+++ b/src/CMakeLists.txt

@@ -1316,7 +1316,15 @@ if( CMAKE_VERSION VERSION_GREATER_EQUAL "3.16" AND NOT CCACHE_PROGRAM )

 

    if( ${_OPT}use_pch )

       message( STATUS "Using precompiled headers" )

-      target_precompile_headers( ${TARGET} PRIVATE AudacityHeaders.h )

+      target_precompile_headers( ${TARGET}

+         PRIVATE

+            # The way CMake generates the project file on Windows, the normal

+            # "force include" of configwin.h will happen AFTER AudacityHeaders.h

+            # is included.  So, anything depending on the configwin.h variables

+            # will not be properly defined.

+            $<$<CXX_COMPILER_ID:MSVC>:"${CMAKE_BINARY_DIR}/src/private/configwin.h">

+            AudacityHeaders.h

+      )

    else()

       message( STATUS "Not using precompiled headers" )

    endif()

 

 

 

From: Leland <ll...@ho...> 
Sent: Tuesday, May 11, 2021 1:12 PM
To: aud...@li...
Subject: Re: [Audacity-devel] local build problem on Windows

 

Honestly, I don’t know what’s going on.  It builds if I configure with:

 

cmake -Daudacity_use_pch=no

 

It doesn’t build if I configure with:

 

cmake -Daudacity_use_pch=yes

 

I thought I understood why, but every “workaround” I’ve tried so far has failed…grrrrrr

 

From: Leland <ll...@ho... <mailto:ll...@ho...> > 
Sent: Tuesday, May 11, 2021 1:02 PM
To: aud...@li... <mailto:aud...@li...> 
Subject: Re: [Audacity-devel] local build problem on Windows

 

Hold off…this may be incorrect.  Still digging.

 

From: Leland <ll...@ho... <mailto:ll...@ho...> > 
Sent: Tuesday, May 11, 2021 12:44 PM
To: aud...@li... <mailto:aud...@li...> 
Subject: Re: [Audacity-devel] local build problem on Windows

 

Paul, the problem is that using “/FI” to force include configwin.h overrides the method used by CMake to include the precompiled headers. I’m trying to devise some sort of workaround, but I don’t think it’s gonna be pretty.

 

From: Leland <ll...@ho... <mailto:ll...@ho...> > 
Sent: Tuesday, May 11, 2021 11:35 AM
To: aud...@li...
Subject: Re: [Audacity-devel] local build problem on Windows

 

Yea, it broke the use of precompiled headers on Windows.  Looking into it…

 

From: David Bailes <drb...@gm... <mailto:drb...@gm...> > 
Sent: Tuesday, May 11, 2021 3:50 AM
To: Audacity Development <aud...@li... <mailto:aud...@li...> >
Subject: [Audacity-devel] local build problem on Windows

 

Problems with my local build, using VS 2019, and using VS's cmake, as in the build instructions in win/build.txt.

Starting with the recent commit: 794f4e5877195e28afb230f2cdff166410fd5e37,

I'm getting the build errors shown below,

David.

 

    cmake_pch.cxx
U:\audacity\src\AudioIO.h(95,24): error C3646: 'midiTracks': unknown override specifier 
U:\audacity\src\AudioIO.h(95,34): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 
U:\audacity\src\AudioIO.h(270,16): error C3646: 'MidiTime': unknown override specifier 
U:\audacity\src\AudioIO.h(270,24): error C2059: syntax error: '(' 
U:\audacity\src\AudioIO.h(270,26): error C2238: unexpected token(s) preceding ';' 
U:\audacity\src\AudioIO.h(368,20): error C2143: syntax error: missing ';' before '*' 
U:\audacity\src\AudioIO.h(368,20): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 
U:\audacity\src\AudioIO.h(368,32): error C2238: unexpected token(s) preceding ';' 
U:\audacity\src\AudioIO.h(392,16): error C3646: 'mMaxMidiTimestamp': unknown override specifier 
U:\audacity\src\AudioIO.h(392,33): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 
U:\audacity\src\AudioIO.h(415,17): error C2143: syntax error: missing ';' before '*' 
U:\audacity\src\AudioIO.h(415,17): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 
U:\audacity\src\AudioIO.h(415,22): error C2238: unexpected token(s) preceding ';' 
U:\audacity\src\AudioIO.h(416,20): error C2065: 'Alg_iterator': undeclared identifier 
U:\audacity\src\AudioIO.h(416,9): error C2923: 'std::unique_ptr': 'Alg_iterator' is not a valid template type argument for parameter '_Ty' 
U:\audacity\src\AudioIO.h(416,9): error C2976: 'std::unique_ptr': too few template arguments 
  C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.28.29910\include\memory(3319): message : see declaration of 'std::unique_ptr' [U:\audacity\out\build\x86-Debug\src\Audacity.vcxproj]
U:\audacity\src\AudioIO.h(418,17): error C2143: syntax error: missing ';' before '*' 
U:\audacity\src\AudioIO.h(418,17): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 
U:\audacity\src\AudioIO.h(418,28): error C2238: unexpected token(s) preceding ';' 
U:\audacity\src\AudioIO.h(428,21): error C2143: syntax error: missing ';' before '*' 
U:\audacity\src\AudioIO.h(428,21): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 
U:\audacity\src\AudioIO.h(428,37): error C2238: unexpected token(s) preceding ';' 
U:\audacity\src\AudioIO.h(434,24): error C3646: 'mMidiPlaybackTracks': unknown override specifier 
U:\audacity\src\AudioIO.h(434,43): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 

Build All failed. 

Re: [Audacity-devel] local build problem on Windows

[Leland <ll...@ho...>]

Honestly, I don’t know what’s going on.  It builds if I configure with:

 

cmake -Daudacity_use_pch=no

 

It doesn’t build if I configure with:

 

cmake -Daudacity_use_pch=yes

 

I thought I understood why, but every “workaround” I’ve tried so far has failed…grrrrrr

 

From: Leland <ll...@ho...> 
Sent: Tuesday, May 11, 2021 1:02 PM
To: aud...@li...
Subject: Re: [Audacity-devel] local build problem on Windows

 

Hold off…this may be incorrect.  Still digging.

 

From: Leland <ll...@ho... <mailto:ll...@ho...> > 
Sent: Tuesday, May 11, 2021 12:44 PM
To: aud...@li... <mailto:aud...@li...> 
Subject: Re: [Audacity-devel] local build problem on Windows

 

Paul, the problem is that using “/FI” to force include configwin.h overrides the method used by CMake to include the precompiled headers. I’m trying to devise some sort of workaround, but I don’t think it’s gonna be pretty.

 

From: Leland <ll...@ho... <mailto:ll...@ho...> > 
Sent: Tuesday, May 11, 2021 11:35 AM
To: aud...@li... <mailto:aud...@li...> 
Subject: Re: [Audacity-devel] local build problem on Windows

 

Yea, it broke the use of precompiled headers on Windows.  Looking into it…

 

From: David Bailes <drb...@gm... <mailto:drb...@gm...> > 
Sent: Tuesday, May 11, 2021 3:50 AM
To: Audacity Development <aud...@li... <mailto:aud...@li...> >
Subject: [Audacity-devel] local build problem on Windows

 

Problems with my local build, using VS 2019, and using VS's cmake, as in the build instructions in win/build.txt.

Starting with the recent commit: 794f4e5877195e28afb230f2cdff166410fd5e37,

I'm getting the build errors shown below,

David.

 

    cmake_pch.cxx
U:\audacity\src\AudioIO.h(95,24): error C3646: 'midiTracks': unknown override specifier 
U:\audacity\src\AudioIO.h(95,34): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 
U:\audacity\src\AudioIO.h(270,16): error C3646: 'MidiTime': unknown override specifier 
U:\audacity\src\AudioIO.h(270,24): error C2059: syntax error: '(' 
U:\audacity\src\AudioIO.h(270,26): error C2238: unexpected token(s) preceding ';' 
U:\audacity\src\AudioIO.h(368,20): error C2143: syntax error: missing ';' before '*' 
U:\audacity\src\AudioIO.h(368,20): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 
U:\audacity\src\AudioIO.h(368,32): error C2238: unexpected token(s) preceding ';' 
U:\audacity\src\AudioIO.h(392,16): error C3646: 'mMaxMidiTimestamp': unknown override specifier 
U:\audacity\src\AudioIO.h(392,33): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 
U:\audacity\src\AudioIO.h(415,17): error C2143: syntax error: missing ';' before '*' 
U:\audacity\src\AudioIO.h(415,17): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 
U:\audacity\src\AudioIO.h(415,22): error C2238: unexpected token(s) preceding ';' 
U:\audacity\src\AudioIO.h(416,20): error C2065: 'Alg_iterator': undeclared identifier 
U:\audacity\src\AudioIO.h(416,9): error C2923: 'std::unique_ptr': 'Alg_iterator' is not a valid template type argument for parameter '_Ty' 
U:\audacity\src\AudioIO.h(416,9): error C2976: 'std::unique_ptr': too few template arguments 
  C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.28.29910\include\memory(3319): message : see declaration of 'std::unique_ptr' [U:\audacity\out\build\x86-Debug\src\Audacity.vcxproj]
U:\audacity\src\AudioIO.h(418,17): error C2143: syntax error: missing ';' before '*' 
U:\audacity\src\AudioIO.h(418,17): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 
U:\audacity\src\AudioIO.h(418,28): error C2238: unexpected token(s) preceding ';' 
U:\audacity\src\AudioIO.h(428,21): error C2143: syntax error: missing ';' before '*' 
U:\audacity\src\AudioIO.h(428,21): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 
U:\audacity\src\AudioIO.h(428,37): error C2238: unexpected token(s) preceding ';' 
U:\audacity\src\AudioIO.h(434,24): error C3646: 'mMidiPlaybackTracks': unknown override specifier 
U:\audacity\src\AudioIO.h(434,43): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 

Build All failed. 

Re: [Audacity-devel] local build problem on Windows

[Leland <ll...@ho...>]

Hold off…this may be incorrect.  Still digging.

 

From: Leland <ll...@ho...> 
Sent: Tuesday, May 11, 2021 12:44 PM
To: aud...@li...
Subject: Re: [Audacity-devel] local build problem on Windows

 

Paul, the problem is that using “/FI” to force include configwin.h overrides the method used by CMake to include the precompiled headers. I’m trying to devise some sort of workaround, but I don’t think it’s gonna be pretty.

 

From: Leland <ll...@ho... <mailto:ll...@ho...> > 
Sent: Tuesday, May 11, 2021 11:35 AM
To: aud...@li... <mailto:aud...@li...> 
Subject: Re: [Audacity-devel] local build problem on Windows

 

Yea, it broke the use of precompiled headers on Windows.  Looking into it…

 

From: David Bailes <drb...@gm... <mailto:drb...@gm...> > 
Sent: Tuesday, May 11, 2021 3:50 AM
To: Audacity Development <aud...@li... <mailto:aud...@li...> >
Subject: [Audacity-devel] local build problem on Windows

 

Problems with my local build, using VS 2019, and using VS's cmake, as in the build instructions in win/build.txt.

Starting with the recent commit: 794f4e5877195e28afb230f2cdff166410fd5e37,

I'm getting the build errors shown below,

David.

 

    cmake_pch.cxx
U:\audacity\src\AudioIO.h(95,24): error C3646: 'midiTracks': unknown override specifier 
U:\audacity\src\AudioIO.h(95,34): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 
U:\audacity\src\AudioIO.h(270,16): error C3646: 'MidiTime': unknown override specifier 
U:\audacity\src\AudioIO.h(270,24): error C2059: syntax error: '(' 
U:\audacity\src\AudioIO.h(270,26): error C2238: unexpected token(s) preceding ';' 
U:\audacity\src\AudioIO.h(368,20): error C2143: syntax error: missing ';' before '*' 
U:\audacity\src\AudioIO.h(368,20): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 
U:\audacity\src\AudioIO.h(368,32): error C2238: unexpected token(s) preceding ';' 
U:\audacity\src\AudioIO.h(392,16): error C3646: 'mMaxMidiTimestamp': unknown override specifier 
U:\audacity\src\AudioIO.h(392,33): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 
U:\audacity\src\AudioIO.h(415,17): error C2143: syntax error: missing ';' before '*' 
U:\audacity\src\AudioIO.h(415,17): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 
U:\audacity\src\AudioIO.h(415,22): error C2238: unexpected token(s) preceding ';' 
U:\audacity\src\AudioIO.h(416,20): error C2065: 'Alg_iterator': undeclared identifier 
U:\audacity\src\AudioIO.h(416,9): error C2923: 'std::unique_ptr': 'Alg_iterator' is not a valid template type argument for parameter '_Ty' 
U:\audacity\src\AudioIO.h(416,9): error C2976: 'std::unique_ptr': too few template arguments 
  C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.28.29910\include\memory(3319): message : see declaration of 'std::unique_ptr' [U:\audacity\out\build\x86-Debug\src\Audacity.vcxproj]
U:\audacity\src\AudioIO.h(418,17): error C2143: syntax error: missing ';' before '*' 
U:\audacity\src\AudioIO.h(418,17): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 
U:\audacity\src\AudioIO.h(418,28): error C2238: unexpected token(s) preceding ';' 
U:\audacity\src\AudioIO.h(428,21): error C2143: syntax error: missing ';' before '*' 
U:\audacity\src\AudioIO.h(428,21): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 
U:\audacity\src\AudioIO.h(428,37): error C2238: unexpected token(s) preceding ';' 
U:\audacity\src\AudioIO.h(434,24): error C3646: 'mMidiPlaybackTracks': unknown override specifier 
U:\audacity\src\AudioIO.h(434,43): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 

Build All failed. 

Re: [Audacity-devel] local build problem on Windows

[Leland <ll...@ho...>]

Paul, the problem is that using “/FI” to force include configwin.h overrides the method used by CMake to include the precompiled headers. I’m trying to devise some sort of workaround, but I don’t think it’s gonna be pretty.

 

From: Leland <ll...@ho...> 
Sent: Tuesday, May 11, 2021 11:35 AM
To: aud...@li...
Subject: Re: [Audacity-devel] local build problem on Windows

 

Yea, it broke the use of precompiled headers on Windows.  Looking into it…

 

From: David Bailes <drb...@gm... <mailto:drb...@gm...> > 
Sent: Tuesday, May 11, 2021 3:50 AM
To: Audacity Development <aud...@li... <mailto:aud...@li...> >
Subject: [Audacity-devel] local build problem on Windows

 

Problems with my local build, using VS 2019, and using VS's cmake, as in the build instructions in win/build.txt.

Starting with the recent commit: 794f4e5877195e28afb230f2cdff166410fd5e37,

I'm getting the build errors shown below,

David.

 

    cmake_pch.cxx
U:\audacity\src\AudioIO.h(95,24): error C3646: 'midiTracks': unknown override specifier 
U:\audacity\src\AudioIO.h(95,34): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 
U:\audacity\src\AudioIO.h(270,16): error C3646: 'MidiTime': unknown override specifier 
U:\audacity\src\AudioIO.h(270,24): error C2059: syntax error: '(' 
U:\audacity\src\AudioIO.h(270,26): error C2238: unexpected token(s) preceding ';' 
U:\audacity\src\AudioIO.h(368,20): error C2143: syntax error: missing ';' before '*' 
U:\audacity\src\AudioIO.h(368,20): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 
U:\audacity\src\AudioIO.h(368,32): error C2238: unexpected token(s) preceding ';' 
U:\audacity\src\AudioIO.h(392,16): error C3646: 'mMaxMidiTimestamp': unknown override specifier 
U:\audacity\src\AudioIO.h(392,33): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 
U:\audacity\src\AudioIO.h(415,17): error C2143: syntax error: missing ';' before '*' 
U:\audacity\src\AudioIO.h(415,17): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 
U:\audacity\src\AudioIO.h(415,22): error C2238: unexpected token(s) preceding ';' 
U:\audacity\src\AudioIO.h(416,20): error C2065: 'Alg_iterator': undeclared identifier 
U:\audacity\src\AudioIO.h(416,9): error C2923: 'std::unique_ptr': 'Alg_iterator' is not a valid template type argument for parameter '_Ty' 
U:\audacity\src\AudioIO.h(416,9): error C2976: 'std::unique_ptr': too few template arguments 
  C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.28.29910\include\memory(3319): message : see declaration of 'std::unique_ptr' [U:\audacity\out\build\x86-Debug\src\Audacity.vcxproj]
U:\audacity\src\AudioIO.h(418,17): error C2143: syntax error: missing ';' before '*' 
U:\audacity\src\AudioIO.h(418,17): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 
U:\audacity\src\AudioIO.h(418,28): error C2238: unexpected token(s) preceding ';' 
U:\audacity\src\AudioIO.h(428,21): error C2143: syntax error: missing ';' before '*' 
U:\audacity\src\AudioIO.h(428,21): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 
U:\audacity\src\AudioIO.h(428,37): error C2238: unexpected token(s) preceding ';' 
U:\audacity\src\AudioIO.h(434,24): error C3646: 'mMidiPlaybackTracks': unknown override specifier 
U:\audacity\src\AudioIO.h(434,43): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 

Build All failed. 

Re: [Audacity-devel] local build problem on Windows

[Leland <ll...@ho...>]

Yea, it broke the use of precompiled headers on Windows.  Looking into it…

 

From: David Bailes <drb...@gm...> 
Sent: Tuesday, May 11, 2021 3:50 AM
To: Audacity Development <aud...@li...>
Subject: [Audacity-devel] local build problem on Windows

 

Problems with my local build, using VS 2019, and using VS's cmake, as in the build instructions in win/build.txt.

Starting with the recent commit: 794f4e5877195e28afb230f2cdff166410fd5e37,

I'm getting the build errors shown below,

David.

 

    cmake_pch.cxx
U:\audacity\src\AudioIO.h(95,24): error C3646: 'midiTracks': unknown override specifier 
U:\audacity\src\AudioIO.h(95,34): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 
U:\audacity\src\AudioIO.h(270,16): error C3646: 'MidiTime': unknown override specifier 
U:\audacity\src\AudioIO.h(270,24): error C2059: syntax error: '(' 
U:\audacity\src\AudioIO.h(270,26): error C2238: unexpected token(s) preceding ';' 
U:\audacity\src\AudioIO.h(368,20): error C2143: syntax error: missing ';' before '*' 
U:\audacity\src\AudioIO.h(368,20): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 
U:\audacity\src\AudioIO.h(368,32): error C2238: unexpected token(s) preceding ';' 
U:\audacity\src\AudioIO.h(392,16): error C3646: 'mMaxMidiTimestamp': unknown override specifier 
U:\audacity\src\AudioIO.h(392,33): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 
U:\audacity\src\AudioIO.h(415,17): error C2143: syntax error: missing ';' before '*' 
U:\audacity\src\AudioIO.h(415,17): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 
U:\audacity\src\AudioIO.h(415,22): error C2238: unexpected token(s) preceding ';' 
U:\audacity\src\AudioIO.h(416,20): error C2065: 'Alg_iterator': undeclared identifier 
U:\audacity\src\AudioIO.h(416,9): error C2923: 'std::unique_ptr': 'Alg_iterator' is not a valid template type argument for parameter '_Ty' 
U:\audacity\src\AudioIO.h(416,9): error C2976: 'std::unique_ptr': too few template arguments 
  C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.28.29910\include\memory(3319): message : see declaration of 'std::unique_ptr' [U:\audacity\out\build\x86-Debug\src\Audacity.vcxproj]
U:\audacity\src\AudioIO.h(418,17): error C2143: syntax error: missing ';' before '*' 
U:\audacity\src\AudioIO.h(418,17): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 
U:\audacity\src\AudioIO.h(418,28): error C2238: unexpected token(s) preceding ';' 
U:\audacity\src\AudioIO.h(428,21): error C2143: syntax error: missing ';' before '*' 
U:\audacity\src\AudioIO.h(428,21): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 
U:\audacity\src\AudioIO.h(428,37): error C2238: unexpected token(s) preceding ';' 
U:\audacity\src\AudioIO.h(434,24): error C3646: 'mMidiPlaybackTracks': unknown override specifier 
U:\audacity\src\AudioIO.h(434,43): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 

Build All failed. 

Re: [Audacity-devel] Some comments regardig https://github.com/audacity/audacity/pull/836

[James C. <jam...@gm...>]

Thanks Joost!

That sounds good, and not a contentious use of TCP/IP at all,
especially as explicit opt-in on each and every crash.

Can you say more about the processing at the receiving end??
Lots of time and work on tools there??  My expectation is that
some crashes will have very repeatable stack traces, often due
to a recent change in our code, but some won't, and I wonder
particularly how you dealt with those?

Is it one of those cases where 90% of the benefit comes easily, once
set up, and that alone makes it worthwhile doing?

--James.

On Tue, 11 May 2021 at 15:36, Joost Andrae <Joo...@gm...> wrote:

> Hi,
>
> if you plan to integrate some kind of crash reporting functionality into
> Audacity then this could be integraded without dependencies to external
> libs (on unixoid systems, not on win32 where you might depend on WinDbg
> from MS).
> At OpenOffice.org/StarOffice we had such a functionality. Maybe a short
> look at the impl. might be helpful, just if you're interested into it.
>
> AOO Grok link:
> http://openoffice-vm1-he-de.apache.org/xref/aoo419/main/crashrep/source/
>
> The application implements an event handler to call the strace/pstack
> kernel function in case of a SEGV. Additionaly pmap is called to give
> additional information.
> If you want to have a readable call stack then you need to store the
> unstripped build with debug information to map the stack IDs to those
> from a build with debug information.
>
> Crash information was sent (opt-in at every crash of the application)
> via a soap interface to one server behind a firewall layer. Information
> is stored into a database.
>
> In this case it was possible to map the functional application areas /
> responsible developers to a stack via statistical db lookup on source
> code line level. At the end we defined thresholds on counts of similar
> call stacks to automatically submit a bugzilla bug.
>
> just my 2 EUR Cents....
>
> Kind regards, Joost
>
>
>
>
> _______________________________________________
> audacity-devel mailing list
> aud...@li...
> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>