Thread: Re: [Vym-devel] VYM on Windows
Brought to you by:
insilmaril
From: Dr. K. H. <ka...@gm...> - 2013-03-09 12:41:17
|
Hello Uwe, Thanks for your replay. I have started looking at VYM code and managed to build it on Windows after removing the dbus bits, I am aware that there is dbus support on Windows but not sure if it is needed for VYM (Windows). However, I don't think this is a major issue for now. I have also read Patrick post about using emerge to reproduce the Windows build, so I will follow that https://sourceforge.net/mailarchive/message.php?msg_id=29618892 Is Patrick still doing the Windows builds? I have looked at Clementine on Windows and they are using mingw, so I think you gut feeling is right J I will look more into quzip and there is also OSDaB, have you considered it? http://osdab.42cows.org/snippets/zip.php?mode=advanced Since, I depend on and love using VYM I am motivated to work on the Windows port. Best regards, Kais ------- Hi Kais, On Thu, Mar 07, Dr. Kais Hassan wrote: > I have create a guide to help people with using VYM on Windows. > > http://kaismh.wordpress.com/2013/03/07/view-your-mind-vym-2-2-4-windows-setu p-and-configuration/ > Thanks a lot!! > Also, I am interested in helping with the Windows port, fixing bugs, packaging and etc. > That's very much appreciated. In the past there have been several attempts, but so far there is no continuos maintenance of the windows port. While I wrote the very most of the vym code, I have no access to windows machines, so I cannot help here. > Which Qt for Windows should I use for the port (msvc or mingw)? My gut feeling is to use mingw, maybe we could even set up cross compiling. http://en.opensuse.org/openSUSE:Build_Service_Concept_Windows_Support I usually build vym in my home project for various platforms: https://build.opensuse.org/project/show?project=home%3Ainsilmaril The spaces in filenames seem to work for me in Linux, so probably related to executing zip/unzip. Btw. we probably could get rid of zip/unzip at least for Windows by using quzip. I also tried using qCompress, but that slowed down load/save of maps too much. Cheers Uwe -- mathematician, n: Someone who believes imaginary things appear right before your i's. |
From: Patrick S. <ps...@gm...> - 2013-03-09 22:46:09
|
Am 09.03.2013 13:40, schrieb Dr. Kais Hassan: > Hello Uwe, > > > > Thanks for your replay. > > > > I have started looking at VYM code and managed to build it on Windows after removing the dbus bits, I am aware that there is dbus support on Windows but not sure if it is needed for VYM (Windows). However, I don’t think this is a major issue for now. > > > > I have also read Patrick post about using emerge to reproduce the Windows build, so I will follow that > > > > https://sourceforge.net/mailarchive/message.php?msg_id=29618892 > > > > Is Patrick still doing the Windows builds? Yes, if I find some time, I can do some builds. > > > > I have looked at Clementine on Windows and they are using mingw, so I think you gut feeling is right J I normally prefer msvc for applications, since that makes debugging normally far easier (with smaller binaries & debug information files). > > > > I will look more into quzip and there is also OSDaB, have you considered it? > > > > http://osdab.42cows.org/snippets/zip.php?mode=advanced Since I know applications that use quazip, I would think this is not a bad idea. > > > > Since, I depend on and love using VYM I am motivated to work on the Windows port. I just read your blog post and have the following comments: zip/unzip required should of course either be changed via packaging (I can try and package a new version which removes that need, but personally I would prefer to have vym use quazip directly). The handling of spaces both in the installation directory path and the path of files should work imho, so I would prefer if these bugs get fixed rather than using workarounds. So if you are interested in working on the windows port, maybe we can get this done together? > > > > Best regards, > > Kais > regards, Patrick |
From: Dr. K. H. <ka...@gm...> - 2013-03-10 18:02:04
|
Hello Patrick, > I normally prefer msvc for applications, since that makes debugging normally far easier (with smaller binaries & debug information files). I don't have any preference for the compiler, I am sure both are good, and since you have more experience with Qt/KDE on Windows, we should go with msvc. > Since I know applications that use quazip, I would think this is not a bad idea. I will have a look at quazip and VYM open/save code >I just read your blog post and have the following comments: >zip/unzip required should of course either be changed via packaging (I can try and package a new version which removes that need, but personally I would prefer to have vym use quazip directly). >The handling of spaces both in the installation directory path and the path of files should work imho, so I would prefer if these bugs get fixed rather than using workarounds. The blog post was intended to give a solution to the existing setup/binaries, I agree with you we should fix these bugs instead of using workarounds. >So if you are interested in working on the windows port, maybe we can get this done together? I am very interested on working on VYM Windows, and it will great to work with you on in it. The following is the list of Windows main issues/bugs as far as I know: 1) Using quazip to handle opening/saving files, making sure it works with long file/folder names with spaces. Importance: High 2) Making cut, copy and paste work (it might be a simple bug, I have not looked at the code yet). Importance: High 3) Making undo/redo work. Importance: High 4) Saving settings files vym.ini inside %appdata%\vym folder, if it stayed under default "c:\program files\vym" the program can't save to the file unless it is run as an Administrator. Importance: High 5) Set application to open pdf files as explorer. Importance: medium 6) Package help file vym.pdf with setup. Importance: low 7) Remove dbus in Windows (is dbus really needed/useful under Windows?). Importance: low Are you aware of other bugs? I will start with issue one (zip/unzip), since it is the most important. Hopefully we can release a stable Windows version soon. Best regards, Kais -----Original Message----- From: Patrick Spendrin [mailto:ps...@gm...] Sent: Sunday, March 10, 2013 1:46 AM To: vym...@li... Subject: Re: [Vym-devel] VYM on Windows Am 09.03.2013 13:40, schrieb Dr. Kais Hassan: > Hello Uwe, > > > > Thanks for your replay. > > > > I have started looking at VYM code and managed to build it on Windows after removing the dbus bits, I am aware that there is dbus support on Windows but not sure if it is needed for VYM (Windows). However, I don't think this is a major issue for now. > > > > I have also read Patrick post about using emerge to reproduce the > Windows build, so I will follow that > > > > https://sourceforge.net/mailarchive/message.php?msg_id=29618892 > > > > Is Patrick still doing the Windows builds? Yes, if I find some time, I can do some builds. > > > > I have looked at Clementine on Windows and they are using mingw, so I > think you gut feeling is right J I normally prefer msvc for applications, since that makes debugging normally far easier (with smaller binaries & debug information files). > > > > I will look more into quzip and there is also OSDaB, have you considered it? > > > > http://osdab.42cows.org/snippets/zip.php?mode=advanced Since I know applications that use quazip, I would think this is not a bad idea. > > > > Since, I depend on and love using VYM I am motivated to work on the Windows port. I just read your blog post and have the following comments: zip/unzip required should of course either be changed via packaging (I can try and package a new version which removes that need, but personally I would prefer to have vym use quazip directly). The handling of spaces both in the installation directory path and the path of files should work imho, so I would prefer if these bugs get fixed rather than using workarounds. So if you are interested in working on the windows port, maybe we can get this done together? > > > > Best regards, > > Kais > regards, Patrick ---------------------------------------------------------------------------- -- Symantec Endpoint Protection 12 positioned as A LEADER in The Forrester Wave(TM): Endpoint Security, Q1 2013 and "remains a good choice" in the endpoint security space. For insight on selecting the right partner to tackle endpoint security challenges, access the full report. http://p.sf.net/sfu/symantec-dev2dev _______________________________________________ Vym-devel mailing list Vym...@li... https://lists.sourceforge.net/lists/listinfo/vym-devel |
From: Patrick S. <ps...@gm...> - 2013-03-11 13:54:43
|
Am 10.03.2013 19:01, schrieb Dr. Kais Hassan: Ok, I took some time and build vym from current git master. For the bugs you mentioned, I tried to find a bug report or create a new one. If we have fixes for those bug reports, maybe we can either somehow get access to the vym git repository, or we simply attach the patches to the bug reports. > > 1) Using quazip to handle opening/saving files, making sure it works with > long file/folder names with spaces. Importance: High https://sourceforge.net/p/vym/bugs/35/ > 2) Making cut, copy and paste work (it might be a simple bug, I have not > looked at the code yet). Importance: High https://sourceforge.net/p/vym/bugs/28/ > 3) Making undo/redo work. Importance: High Hm, seems to work for me (after I have zip/unzip installed). > 4) Saving settings files vym.ini inside %appdata%\vym folder, if it stayed > under default "c:\program files\vym" the program can't save to the file > unless it is run as an Administrator. Importance: High https://sourceforge.net/p/vym/bugs/53/ > 5) Set application to open pdf files as explorer. Importance: medium I don't know what you really mean by that, maybe you can make a bug report for it? > 6) Package help file vym.pdf with setup. Importance: low A bug report for the packager. > 7) Remove dbus in Windows (is dbus really needed/useful under Windows?). > Importance: low https://sourceforge.net/p/vym/bugs/54/ > > Are you aware of other bugs? > > I will start with issue one (zip/unzip), since it is the most important. > > Hopefully we can release a stable Windows version soon. > > Best regards, > Kais > regards, Patrick |
From: Dr. K. H. <ka...@gm...> - 2013-03-12 17:43:59
|
Hello Pattrick, >> 3) Making undo/redo work. Importance: High >>Hm, seems to work for me (after I have zip/unzip installed). Undo/redo does not work for me in the 2.2.4 build, however it works now with the latest compiled code. Maybe it was a VYM and not a Windows specific. >> 5) Set application to open pdf files as explorer. Importance: medium >>I don't know what you really mean by that, maybe you can make a bug report for it? VYM allows you to set the default program to open PDF files under menu->settings->) Set application to open pdf files. Currently, the default option under Windows is acrord32 (which I guess needed acrobat reader installed) setting it to explorer will make Windows launch the default program for opening pdf files. https://sourceforge.net/p/vym/bugs/56/ -----Original Message----- From: Patrick Spendrin [mailto:ps...@gm...] Sent: Monday, March 11, 2013 4:54 PM To: Dr. Kais Hassan Cc: vym...@li... Subject: Re: [Vym-devel] VYM on Windows Am 10.03.2013 19:01, schrieb Dr. Kais Hassan: Ok, I took some time and build vym from current git master. For the bugs you mentioned, I tried to find a bug report or create a new one. If we have fixes for those bug reports, maybe we can either somehow get access to the vym git repository, or we simply attach the patches to the bug reports. > > 1) Using quazip to handle opening/saving files, making sure it works > with long file/folder names with spaces. Importance: High https://sourceforge.net/p/vym/bugs/35/ > 2) Making cut, copy and paste work (it might be a simple bug, I have > not looked at the code yet). Importance: High https://sourceforge.net/p/vym/bugs/28/ > 3) Making undo/redo work. Importance: High Hm, seems to work for me (after I have zip/unzip installed). > 4) Saving settings files vym.ini inside %appdata%\vym folder, if it > stayed under default "c:\program files\vym" the program can't save to > the file unless it is run as an Administrator. Importance: High https://sourceforge.net/p/vym/bugs/53/ > 5) Set application to open pdf files as explorer. Importance: medium I don't know what you really mean by that, maybe you can make a bug report for it? > 6) Package help file vym.pdf with setup. Importance: low A bug report for the packager. > 7) Remove dbus in Windows (is dbus really needed/useful under Windows?). > Importance: low https://sourceforge.net/p/vym/bugs/54/ > > Are you aware of other bugs? > > I will start with issue one (zip/unzip), since it is the most important. > > Hopefully we can release a stable Windows version soon. > > Best regards, > Kais > regards, Patrick |
From: Uwe D. <vym@InSilmaril.de> - 2013-03-11 17:05:59
|
Hi guys, first: Thanks for all the interest in making windows really work! Maybe it's time I get back to my Mac port, which I had in the past ;-) On Sun, Mar 10, Dr. Kais Hassan wrote: > >I just read your blog post and have the following comments: > >zip/unzip required should of course either be changed via packaging (I can > try and package a new version which removes that need, but personally I > would prefer to have vym use quazip directly). > >The handling of spaces both in the installation directory path and the path Me too. At least on Windows. On Mac and Linux zip/unzip is available, though the current way to call it as extra process is probably not the most elegant solution ;-) > > I am very interested on working on VYM Windows, and it will great to work > with you on in it. > and I am glad that I don't have to do everything on my own :-) > The following is the list of Windows main issues/bugs as far as I know: > > 1) Using quazip to handle opening/saving files, making sure it works with > long file/folder names with spaces. Importance: High A while ago I started to play with quazip, I attach the draft I did. I also tried using Qt's internal compression, but that was way slower than zlib via quazip. > 2) Making cut, copy and paste work (it might be a simple bug, I have not > looked at the code yet). Importance: High cut&paste uses a temporary file, so I expect the problems gone, once the load/save works reliable. Likely a path problem. > 3) Making undo/redo work. Importance: High Same as above. > 4) Saving settings files vym.ini inside %appdata%\vym folder, if it stayed > under default "c:\program files\vym" the program can't save to the file > unless it is run as an Administrator. Importance: High Should be doable with a change of the global settings. > 5) Set application to open pdf files as explorer. Importance: medium Seems we are missing a default setting e.g. in Main::helpDoc(): 5351 if (!pdfProc->startDetached( settings.value("/mainwindow/readerPDF").toString(),args) ) 5352 { 5353 // error handling 5354 QMessageBox::warning(0, 5355 tr("Warning"), 5356 tr("Couldn't find a viewer to open %1.\n").arg(docfile.fileName())+ 5357 tr("Please use Settings->")+tr("Set application to open PDF files")); 5358 settingsPDF(); 5359 return; 5360 } I think a default should go into main.cpp together with the initialization of platform dependent paths. > 6) Package help file vym.pdf with setup. Importance: low see above. > 7) Remove dbus in Windows (is dbus really needed/useful under Windows?). > Importance: low > I think I used switches for the Mac port, need to check that again. Cheers Uwe -- mathematician, n: Someone who believes imaginary things appear right before your i's. |
From: Uwe D. <vym@InSilmaril.de> - 2013-03-11 20:26:29
|
On Mon, Mar 11, Uwe Drechsel (@vym) wrote: > > 1) Using quazip to handle opening/saving files, making sure it works with > > long file/folder names with spaces. Importance: High > > A while ago I started to play with quazip, I attach the draft I did. > Hrmpf. of course attachment was missing, sorry. Uwe -- mathematician, n: Someone who believes imaginary things appear right before your i's. |
From: Dr. K. H. <ka...@gm...> - 2013-03-12 17:58:28
|
Hello Uwe, >>first: Thanks for all the interest in making windows really work! >>Maybe it's time I get back to my Mac port, which I had in the past ;-) Thank you creating a great software, helping with the Windows port is the least we can do. -----Original Message----- From: Uwe Drechsel [mailto:vym@InSilmaril.de] Sent: Monday, March 11, 2013 8:06 PM To: vym...@li... Subject: Re: [Vym-devel] VYM on Windows Hi guys, first: Thanks for all the interest in making windows really work! Maybe it's time I get back to my Mac port, which I had in the past ;-) On Sun, Mar 10, Dr. Kais Hassan wrote: > >I just read your blog post and have the following comments: > >zip/unzip required should of course either be changed via packaging > >(I can > try and package a new version which removes that need, but personally > I would prefer to have vym use quazip directly). > >The handling of spaces both in the installation directory path and > >the path Me too. At least on Windows. On Mac and Linux zip/unzip is available, though the current way to call it as extra process is probably not the most elegant solution ;-) > > I am very interested on working on VYM Windows, and it will great to > work with you on in it. > and I am glad that I don't have to do everything on my own :-) > The following is the list of Windows main issues/bugs as far as I know: > > 1) Using quazip to handle opening/saving files, making sure it works > with long file/folder names with spaces. Importance: High A while ago I started to play with quazip, I attach the draft I did. I also tried using Qt's internal compression, but that was way slower than zlib via quazip. > 2) Making cut, copy and paste work (it might be a simple bug, I have > not looked at the code yet). Importance: High cut&paste uses a temporary file, so I expect the problems gone, once the load/save works reliable. Likely a path problem. > 3) Making undo/redo work. Importance: High Same as above. > 4) Saving settings files vym.ini inside %appdata%\vym folder, if it > stayed under default "c:\program files\vym" the program can't save to > the file unless it is run as an Administrator. Importance: High Should be doable with a change of the global settings. > 5) Set application to open pdf files as explorer. Importance: medium Seems we are missing a default setting e.g. in Main::helpDoc(): 5351 if (!pdfProc->startDetached( settings.value("/mainwindow/readerPDF").toString(),args) ) 5352 { 5353 // error handling 5354 QMessageBox::warning(0, 5355 tr("Warning"), 5356 tr("Couldn't find a viewer to open %1.\n").arg(docfile.fileName())+ 5357 tr("Please use Settings->")+tr("Set application to open PDF files")); 5358 settingsPDF(); 5359 return; 5360 } I think a default should go into main.cpp together with the initialization of platform dependent paths. > 6) Package help file vym.pdf with setup. Importance: low see above. > 7) Remove dbus in Windows (is dbus really needed/useful under Windows?). > Importance: low > I think I used switches for the Mac port, need to check that again. Cheers Uwe -- mathematician, n: Someone who believes imaginary things appear right before your i's. ---------------------------------------------------------------------------- -- Symantec Endpoint Protection 12 positioned as A LEADER in The Forrester Wave(TM): Endpoint Security, Q1 2013 and "remains a good choice" in the endpoint security space. For insight on selecting the right partner to tackle endpoint security challenges, access the full report. http://p.sf.net/sfu/symantec-dev2dev _______________________________________________ Vym-devel mailing list Vym...@li... https://lists.sourceforge.net/lists/listinfo/vym-devel |
From: Uwe D. <vym@InSilmaril.de> - 2013-03-11 20:28:38
|
Hi, On Mon, Mar 11, Patrick Spendrin wrote: > Am 10.03.2013 19:01, schrieb Dr. Kais Hassan: > Ok, I took some time and build vym from current git master. For the bugs > you mentioned, I tried to find a bug report or create a new one. > > If we have fixes for those bug reports, maybe we can either somehow get > access to the vym git repository, or we simply attach the patches to the > bug reports. > For the start, just send me the patches, please. Thanks Uwe -- mathematician, n: Someone who believes imaginary things appear right before your i's. |
From: Patrick S. <ps...@gm...> - 2013-03-11 21:31:41
Attachments:
buildfix-windows.diff
vym-use-settings-in-registry.diff
|
Am 11.03.2013 21:28, schrieb Uwe Drechsel: > Hi, > > On Mon, Mar 11, Patrick Spendrin wrote: > >> Am 10.03.2013 19:01, schrieb Dr. Kais Hassan: >> Ok, I took some time and build vym from current git master. For the bugs >> you mentioned, I tried to find a bug report or create a new one. >> >> If we have fixes for those bug reports, maybe we can either somehow get >> access to the vym git repository, or we simply attach the patches to the >> bug reports. >> > > For the start, just send me the patches, please. Ok, you asked for it ;-) Attached is a build fix for current master required for windows. Also attached is patch to use the registry again for settings. Settings will be stored in HKEY_CURRENT_USER\Software\InSilmaril\vym, which is ok and the standard location. I also attached this patch to the bug report. > > Thanks > Uwe > regards, Patrick |
From: Patrick S. <ps...@gm...> - 2013-03-11 23:10:54
|
Am 11.03.2013 21:28, schrieb Uwe Drechsel: > Hi, > > On Mon, Mar 11, Patrick Spendrin wrote: > >> Am 10.03.2013 19:01, schrieb Dr. Kais Hassan: >> Ok, I took some time and build vym from current git master. For the bugs >> you mentioned, I tried to find a bug report or create a new one. >> >> If we have fixes for those bug reports, maybe we can either somehow get >> access to the vym git repository, or we simply attach the patches to the >> bug reports. >> > > For the start, just send me the patches, please. Ok, and the last one from yesterday: the zip function works ok, the unzip function didn't. So I found out that there is a winapi implementation for unzip which was broken; The Qt implementation should be cross platform enough to get vym working, so unless there is a really hard reason for the other implementation I would rather remove the specific implementation. I checked the source code again, and apart from some path settings and one occurance of sleep (for which stupid Qt doesn't provide any function) there don't seem to be any Q_OS_WIN32 occurances anymore. > > Thanks > Uwe > regards, Patrick |
From: Uwe D. <vym@InSilmaril.de> - 2013-03-16 13:53:43
|
Hi, thanks a lot! I just pushed them to git. I will try to figure out how to give you write access with the new SF layout... -Uwe On Tue, Mar 12, Patrick Spendrin wrote: > Am 11.03.2013 21:28, schrieb Uwe Drechsel: > > Hi, > > > > On Mon, Mar 11, Patrick Spendrin wrote: > > > >> Am 10.03.2013 19:01, schrieb Dr. Kais Hassan: > >> Ok, I took some time and build vym from current git master. For the bugs > >> you mentioned, I tried to find a bug report or create a new one. > >> > >> If we have fixes for those bug reports, maybe we can either somehow get > >> access to the vym git repository, or we simply attach the patches to the > >> bug reports. > >> > > > > For the start, just send me the patches, please. > > Ok, and the last one from yesterday: > the zip function works ok, the unzip function didn't. So I found out > that there is a winapi implementation for unzip which was broken; The Qt > implementation should be cross platform enough to get vym working, so > unless there is a really hard reason for the other implementation I > would rather remove the specific implementation. > > I checked the source code again, and apart from some path settings and > one occurance of sleep (for which stupid Qt doesn't provide any > function) there don't seem to be any Q_OS_WIN32 occurances anymore. > > > > > Thanks > > Uwe > > > > regards, > Patrick |