Re: [Tuxpaint-devel] Puzzle, fisheye, toothpaste

[Andrew C. <aka...@gm...>]

With regards to the toothpaste tool cross over bug. The tool used to work
correctly and I must have forgotten to commit the correct version. I
currently dont have access to a nix install to test however I believe the
fix is to remove the !api->touched(xx, yy) check from line 137 in
toothpaste.c. I'm pretty much 100% sure this will fix the issue but I dont
think its a good idea to do a commit without testing.

If anyone is able to try removng that check and seeing if things work and if
so, commiting that would be great. If not I'll put it on my todo list and
check it out early next week when I can get access to a nix install.

Andrew

On Sun, Oct 5, 2008 at 4:50 PM, <
tux...@li...> wrote:

> Send Tuxpaint-devel mailing list submissions to
>        tux...@li...
>
> To subscribe or unsubscribe via the World Wide Web, visit
>        https://lists.sourceforge.net/lists/listinfo/tuxpaint-devel
> or, via email, send a message with subject or body 'help' to
>        tux...@li...
>
> You can reach the person managing the list at
>        tux...@li...
>
> When replying, please edit your Subject line so it is more specific
> than "Re: Contents of Tuxpaint-devel digest..."
>
>
> Today's Topics:
>
>   1. [SPAM] Re:  Puzzle, fisheye, toothpaste (Pere Pujal i Carabantes)
>   2. State of new Magic tools (Bill Kendrick)
>   3. Re: State of new Magic tools (Caroline Ford)
>   4. Re: State of new Magic tools (Caroline Ford)
>   5. Re: State of new Magic tools (Caroline Ford)
>   6. Re: State of new Magic tools (Caroline Ford)
>
>
> ----------------------------------------------------------------------
>
> Message: 1
> Date: Wed, 24 Sep 2008 18:17:56 +0200
> From: Pere Pujal i Carabantes <pe...@fo...>
> Subject: [Tuxpaint-devel] [SPAM] Re:  Puzzle, fisheye, toothpaste
> To: Discussion list for Tux Paint developers
>        <tux...@li...>
> Message-ID: <122...@ho...>
> Content-Type: text/plain
>
> Hi!
>
> El dt 23 de 09 de 2008 a les 21:24 +0100, en/na Caroline Ford va
> escriure:
> > 2008/9/22 Pere Pujal i Carabantes <pe...@fo...>:
>
> > >
> > > Puzzle, fisheye: Undo/Redo is inconsistent.
> >
> > How do you mean? You mean the tool doesn't undo properly?
>
> When clicking on Undo after using Puzzle, doesn't undo properly at all.
> When clicking on Undo after Fisheye if fisheye has been used by single
> clicks, the undo is handled properly.
> But if you do a click and drag on Fisheye, then undo is not handled
> correctly.
>
>
> > I'm not sure what to call fisheye. It doesn't (to me) obviously act as
> > a fisheye lens, but I'm not really sure what it's doing.
> >
> It seems to do some sort of magnification + barrel distortion.
>
> >From http://en.wikipedia.org/wiki/Image_distortion :
> barrel distortion, in which image magnification decreases with distance
> from the optical axis. The apparent effect is that of an image which has
> been mapped around a sphere. Fisheye lenses, which take hemispherical
> views, utilize this type of distortion as a way to map an infinitely
> wide object plane into a finite image area
>
>
> > > toothpaste:
> > > Maybe a better name is paint tube.
> > > Painting with it, the new goes down the old, wich seems illogic.
>
> To clarify: paint with it and do some crossing in the same pass.
> You will notice that the paste crosses under the yet drawed instead of
> draw over.
>
>
>
> This seems unrelated to toothpaste, but may help.
> Using toothpaste and the higher resolution you can have, instead of the
> paint tool, this bug is more easyly seen:
> http://www.nabble.com/mouse-paint-bug-td14565288.html
>
>
> Yours
> Pere
>
>
>
>
> ------------------------------
>
> Message: 2
> Date: Sat, 4 Oct 2008 18:50:36 -0700
> From: Bill Kendrick <nb...@so...>
> Subject: [Tuxpaint-devel] State of new Magic tools
> To: Tux Paint <tux...@li...>
> Message-ID: <200...@so...>
> Content-Type: text/plain; charset=us-ascii
>
>
> Here's a quick rundown of what I think the new Magic tools need before
> they're
> ready for prime-time:
>
>  Alien - Better name and description.
>          Sound effect.
>          Better icon.
>
>  Confetti - Merge with Rain.
>             Better shapes than just circles.
>             Sound effect.
>
>  Draw Text - (I still need to look into this; its codebase is
>              separate from Tux Paint and the core Magic tools)
>
>  Edges - Sound effect.
>
>  Fisheye - Icon.
>            Sound effect.
>
>  Fold - Better UI (click-and drag, to get longer folds?)
>         Better effect (gradient?)
>         Prevent from re-applying the effect in the same corner, unless
>           the tool has been changed (use switchin/switchout to capture an
>           image).  (Together with better UI, you'll be able to tweak a
>           corner to perfection.  Right now, you need to Undo, or you end
>           up with a weird pair of triangles in the corner of your picture.)
>
>  Mosaic - Consider rewriting to (1) be more CPU efficient, (2) work as
>             a paintable tool (see #1), and (3) have bigger 'glass' and
>             more obvious divisions between.  More of a stained-glass
> effect.
>           Icon.
>           Sound effect.
>
>  Picasso - Better description.  Maybe better name?
>            Icon.
>            Sound effect.
>
>  Puzzle - Complete rewrite.  The current code doesn't work at all, IMO,
>             even after fixing an issue with dragging.  (touched() scale
>             should've been on the grid, not at the pixel level.)
>             I'd like something that actually creates jigsaw-shaped pieces,
>             whereas this simply (tried to) scramble the image.
>
>  Rails - Icon should be greyscale.
>          Doesn't act properly when dragging (still!)
>          Sound effect.
>
>  Rain - Merge confetti, snowballs and snowflakes with this tool.
>         (I just added proper drag support, that in the end works a lot
>           like confetti, and a lot like I think snow* should work, if they
>           had paint mode support... which they should.)
>
>  Rosette - Icon.
>            Sound effect.
>
>  Sharpen - Icon.
>            Sound effect.
>
>  Silhouette - Icon.
>               Sound effect.
>
>  Snow Ball - Merge with rain. (See above)
>              Sound effect.
>
>  Snow flake - Merge with rain.  (See above)
>              Sound effect.
>
>  TV - Icon.
>       Sound effect.
>
>  Wavelets - Better icon.
>             Drag UI mode, like Waves _used_ to have (see below).
>             Sound effect.
>
>  Waves - Drag UI mode.  (Why was this removed?)
>          Sound effect.  (Why was this removed?)
>
>
> Thanks to all the students who produced these new tools, and their mentors,
> and thanks in advance to those of you who'll help me clean them up and
> make them shine. :)
>
> --
> -bill!
> "Tux Paint" - free children's drawing software for Windows / Mac OS X /
> Linux!
> Download it today!  http://www.tuxpaint.org/
>
>
>
> ------------------------------
>
> Message: 3
> Date: Sun, 5 Oct 2008 13:42:44 +0100
> From: "Caroline Ford" <car...@go...>
> Subject: Re: [Tuxpaint-devel] State of new Magic tools
> To: "Discussion list for Tux Paint developers"
>        <tux...@li...>
> Message-ID:
>        <cbc...@ma...>
> Content-Type: text/plain; charset=ISO-8859-1
>
> 2008/10/5 Bill Kendrick <nb...@so...>:
> >
> > Here's a quick rundown of what I think the new Magic tools need before
> they're
> > ready for prime-time:
> >
> >  Alien - Better name and description.
> >          Sound effect.
> >          Better icon.
>
> Bah - I liked my icon too ;)
>
> >  Confetti - Merge with Rain.
> >             Better shapes than just circles.
> >             Sound effect.
>
> If you know what kind of shapes you want I'll make some.
>
> >  Draw Text - (I still need to look into this; its codebase is
> >              separate from Tux Paint and the core Magic tools)
> >
> >  Edges - Sound effect.
> >
> >  Fisheye - Icon.
> >            Sound effect.
>
> I personally don't see this as very useful.
>
> >  Fold - Better UI (click-and drag, to get longer folds?)
> >         Better effect (gradient?)
> >         Prevent from re-applying the effect in the same corner, unless
> >           the tool has been changed (use switchin/switchout to capture an
> >           image).  (Together with better UI, you'll be able to tweak a
> >           corner to perfection.  Right now, you need to Undo, or you end
> >           up with a weird pair of triangles in the corner of your
> picture.)
>
> I think this looks a bit crap. I'm not sure what it needs.
> >
> >  Mosaic - Consider rewriting to (1) be more CPU efficient, (2) work as
> >             a paintable tool (see #1), and (3) have bigger 'glass' and
> >             more obvious divisions between.  More of a stained-glass
> effect.
> >           Icon.
> >           Sound effect.
>
> I really like this one, but I agree with the bigger glass. It runs
> fine on my netbook.
>
> >  Picasso - Better description.  Maybe better name?
> >            Icon.
> >            Sound effect.
> >
> >  Puzzle - Complete rewrite.  The current code doesn't work at all, IMO,
> >             even after fixing an issue with dragging.  (touched() scale
> >             should've been on the grid, not at the pixel level.)
> >             I'd like something that actually creates jigsaw-shaped
> pieces,
> >             whereas this simply (tried to) scramble the image.
> >
> >  Rails - Icon should be greyscale.
> >          Doesn't act properly when dragging (still!)
> >          Sound effect.
>
> Okay - all icons need to be greyscale?
>
> >  Rain - Merge confetti, snowballs and snowflakes with this tool.
> >         (I just added proper drag support, that in the end works a lot
> >           like confetti, and a lot like I think snow* should work, if
> they
> >           had paint mode support... which they should.)
> >
> >  Rosette - Icon.
> >            Sound effect.
>
> This needs a better name - and it's just a three pronged kaleidoscope.
> Merge them?
>
> >  Sharpen - Icon.
> >            Sound effect.
> >
> >  Silhouette - Icon.
> >               Sound effect.
> >
> >  Snow Ball - Merge with rain. (See above)
> >              Sound effect.
> >
> >  Snow flake - Merge with rain.  (See above)
> >              Sound effect.
> >
> >  TV - Icon.
> >       Sound effect.
> >
> >  Wavelets - Better icon.
> >             Drag UI mode, like Waves _used_ to have (see below).
> >             Sound effect.
> >
> >  Waves - Drag UI mode.  (Why was this removed?)
> >          Sound effect.  (Why was this removed?)
> >
> >
> > Thanks to all the students who produced these new tools, and their
> mentors,
> > and thanks in advance to those of you who'll help me clean them up and
> > make them shine. :)
>
> Let us know what you want.
>
> Caroline
>
>
>
> ------------------------------
>
> Message: 4
> Date: Sun, 5 Oct 2008 13:42:44 +0100
> From: "Caroline Ford" <car...@go...>
> Subject: Re: [Tuxpaint-devel] State of new Magic tools
> To: "Discussion list for Tux Paint developers"
>        <tux...@li...>
> Message-ID:
>        <cbc...@ma...>
> Content-Type: text/plain; charset=ISO-8859-1
>
> 2008/10/5 Bill Kendrick <nb...@so...>:
> >
> > Here's a quick rundown of what I think the new Magic tools need before
> they're
> > ready for prime-time:
> >
> >  Alien - Better name and description.
> >          Sound effect.
> >          Better icon.
>
> Bah - I liked my icon too ;)
>
> >  Confetti - Merge with Rain.
> >             Better shapes than just circles.
> >             Sound effect.
>
> If you know what kind of shapes you want I'll make some.
>
> >  Draw Text - (I still need to look into this; its codebase is
> >              separate from Tux Paint and the core Magic tools)
> >
> >  Edges - Sound effect.
> >
> >  Fisheye - Icon.
> >            Sound effect.
>
> I personally don't see this as very useful.
>
> >  Fold - Better UI (click-and drag, to get longer folds?)
> >         Better effect (gradient?)
> >         Prevent from re-applying the effect in the same corner, unless
> >           the tool has been changed (use switchin/switchout to capture an
> >           image).  (Together with better UI, you'll be able to tweak a
> >           corner to perfection.  Right now, you need to Undo, or you end
> >           up with a weird pair of triangles in the corner of your
> picture.)
>
> I think this looks a bit crap. I'm not sure what it needs.
> >
> >  Mosaic - Consider rewriting to (1) be more CPU efficient, (2) work as
> >             a paintable tool (see #1), and (3) have bigger 'glass' and
> >             more obvious divisions between.  More of a stained-glass
> effect.
> >           Icon.
> >           Sound effect.
>
> I really like this one, but I agree with the bigger glass. It runs
> fine on my netbook.
>
> >  Picasso - Better description.  Maybe better name?
> >            Icon.
> >            Sound effect.
> >
> >  Puzzle - Complete rewrite.  The current code doesn't work at all, IMO,
> >             even after fixing an issue with dragging.  (touched() scale
> >             should've been on the grid, not at the pixel level.)
> >             I'd like something that actually creates jigsaw-shaped
> pieces,
> >             whereas this simply (tried to) scramble the image.
> >
> >  Rails - Icon should be greyscale.
> >          Doesn't act properly when dragging (still!)
> >          Sound effect.
>
> Okay - all icons need to be greyscale?
>
> >  Rain - Merge confetti, snowballs and snowflakes with this tool.
> >         (I just added proper drag support, that in the end works a lot
> >           like confetti, and a lot like I think snow* should work, if
> they
> >           had paint mode support... which they should.)
> >
> >  Rosette - Icon.
> >            Sound effect.
>
> This needs a better name - and it's just a three pronged kaleidoscope.
> Merge them?
>
> >  Sharpen - Icon.
> >            Sound effect.
> >
> >  Silhouette - Icon.
> >               Sound effect.
> >
> >  Snow Ball - Merge with rain. (See above)
> >              Sound effect.
> >
> >  Snow flake - Merge with rain.  (See above)
> >              Sound effect.
> >
> >  TV - Icon.
> >       Sound effect.
> >
> >  Wavelets - Better icon.
> >             Drag UI mode, like Waves _used_ to have (see below).
> >             Sound effect.
> >
> >  Waves - Drag UI mode.  (Why was this removed?)
> >          Sound effect.  (Why was this removed?)
> >
> >
> > Thanks to all the students who produced these new tools, and their
> mentors,
> > and thanks in advance to those of you who'll help me clean them up and
> > make them shine. :)
>
> Let us know what you want.
>
> Caroline
>
>
>
> ------------------------------
>
> Message: 5
> Date: Sun, 5 Oct 2008 13:42:44 +0100
> From: "Caroline Ford" <car...@go...>
> Subject: Re: [Tuxpaint-devel] State of new Magic tools
> To: "Discussion list for Tux Paint developers"
>        <tux...@li...>
> Message-ID:
>        <cbc...@ma...>
> Content-Type: text/plain; charset=ISO-8859-1
>
> 2008/10/5 Bill Kendrick <nb...@so...>:
> >
> > Here's a quick rundown of what I think the new Magic tools need before
> they're
> > ready for prime-time:
> >
> >  Alien - Better name and description.
> >          Sound effect.
> >          Better icon.
>
> Bah - I liked my icon too ;)
>
> >  Confetti - Merge with Rain.
> >             Better shapes than just circles.
> >             Sound effect.
>
> If you know what kind of shapes you want I'll make some.
>
> >  Draw Text - (I still need to look into this; its codebase is
> >              separate from Tux Paint and the core Magic tools)
> >
> >  Edges - Sound effect.
> >
> >  Fisheye - Icon.
> >            Sound effect.
>
> I personally don't see this as very useful.
>
> >  Fold - Better UI (click-and drag, to get longer folds?)
> >         Better effect (gradient?)
> >         Prevent from re-applying the effect in the same corner, unless
> >           the tool has been changed (use switchin/switchout to capture an
> >           image).  (Together with better UI, you'll be able to tweak a
> >           corner to perfection.  Right now, you need to Undo, or you end
> >           up with a weird pair of triangles in the corner of your
> picture.)
>
> I think this looks a bit crap. I'm not sure what it needs.
> >
> >  Mosaic - Consider rewriting to (1) be more CPU efficient, (2) work as
> >             a paintable tool (see #1), and (3) have bigger 'glass' and
> >             more obvious divisions between.  More of a stained-glass
> effect.
> >           Icon.
> >           Sound effect.
>
> I really like this one, but I agree with the bigger glass. It runs
> fine on my netbook.
>
> >  Picasso - Better description.  Maybe better name?
> >            Icon.
> >            Sound effect.
> >
> >  Puzzle - Complete rewrite.  The current code doesn't work at all, IMO,
> >             even after fixing an issue with dragging.  (touched() scale
> >             should've been on the grid, not at the pixel level.)
> >             I'd like something that actually creates jigsaw-shaped
> pieces,
> >             whereas this simply (tried to) scramble the image.
> >
> >  Rails - Icon should be greyscale.
> >          Doesn't act properly when dragging (still!)
> >          Sound effect.
>
> Okay - all icons need to be greyscale?
>
> >  Rain - Merge confetti, snowballs and snowflakes with this tool.
> >         (I just added proper drag support, that in the end works a lot
> >           like confetti, and a lot like I think snow* should work, if
> they
> >           had paint mode support... which they should.)
> >
> >  Rosette - Icon.
> >            Sound effect.
>
> This needs a better name - and it's just a three pronged kaleidoscope.
> Merge them?
>
> >  Sharpen - Icon.
> >            Sound effect.
> >
> >  Silhouette - Icon.
> >               Sound effect.
> >
> >  Snow Ball - Merge with rain. (See above)
> >              Sound effect.
> >
> >  Snow flake - Merge with rain.  (See above)
> >              Sound effect.
> >
> >  TV - Icon.
> >       Sound effect.
> >
> >  Wavelets - Better icon.
> >             Drag UI mode, like Waves _used_ to have (see below).
> >             Sound effect.
> >
> >  Waves - Drag UI mode.  (Why was this removed?)
> >          Sound effect.  (Why was this removed?)
> >
> >
> > Thanks to all the students who produced these new tools, and their
> mentors,
> > and thanks in advance to those of you who'll help me clean them up and
> > make them shine. :)
>
> Let us know what you want.
>
> Caroline
>
>
>
> ------------------------------
>
> Message: 6
> Date: Sun, 5 Oct 2008 13:42:44 +0100
> From: "Caroline Ford" <car...@go...>
> Subject: Re: [Tuxpaint-devel] State of new Magic tools
> To: "Discussion list for Tux Paint developers"
>        <tux...@li...>
> Message-ID:
>        <cbc...@ma...>
> Content-Type: text/plain; charset=ISO-8859-1
>
> 2008/10/5 Bill Kendrick <nb...@so...>:
> >
> > Here's a quick rundown of what I think the new Magic tools need before
> they're
> > ready for prime-time:
> >
> >  Alien - Better name and description.
> >          Sound effect.
> >          Better icon.
>
> Bah - I liked my icon too ;)
>
> >  Confetti - Merge with Rain.
> >             Better shapes than just circles.
> >             Sound effect.
>
> If you know what kind of shapes you want I'll make some.
>
> >  Draw Text - (I still need to look into this; its codebase is
> >              separate from Tux Paint and the core Magic tools)
> >
> >  Edges - Sound effect.
> >
> >  Fisheye - Icon.
> >            Sound effect.
>
> I personally don't see this as very useful.
>
> >  Fold - Better UI (click-and drag, to get longer folds?)
> >         Better effect (gradient?)
> >         Prevent from re-applying the effect in the same corner, unless
> >           the tool has been changed (use switchin/switchout to capture an
> >           image).  (Together with better UI, you'll be able to tweak a
> >           corner to perfection.  Right now, you need to Undo, or you end
> >           up with a weird pair of triangles in the corner of your
> picture.)
>
> I think this looks a bit crap. I'm not sure what it needs.
> >
> >  Mosaic - Consider rewriting to (1) be more CPU efficient, (2) work as
> >             a paintable tool (see #1), and (3) have bigger 'glass' and
> >             more obvious divisions between.  More of a stained-glass
> effect.
> >           Icon.
> >           Sound effect.
>
> I really like this one, but I agree with the bigger glass. It runs
> fine on my netbook.
>
> >  Picasso - Better description.  Maybe better name?
> >            Icon.
> >            Sound effect.
> >
> >  Puzzle - Complete rewrite.  The current code doesn't work at all, IMO,
> >             even after fixing an issue with dragging.  (touched() scale
> >             should've been on the grid, not at the pixel level.)
> >             I'd like something that actually creates jigsaw-shaped
> pieces,
> >             whereas this simply (tried to) scramble the image.
> >
> >  Rails - Icon should be greyscale.
> >          Doesn't act properly when dragging (still!)
> >          Sound effect.
>
> Okay - all icons need to be greyscale?
>
> >  Rain - Merge confetti, snowballs and snowflakes with this tool.
> >         (I just added proper drag support, that in the end works a lot
> >           like confetti, and a lot like I think snow* should work, if
> they
> >           had paint mode support... which they should.)
> >
> >  Rosette - Icon.
> >            Sound effect.
>
> This needs a better name - and it's just a three pronged kaleidoscope.
> Merge them?
>
> >  Sharpen - Icon.
> >            Sound effect.
> >
> >  Silhouette - Icon.
> >               Sound effect.
> >
> >  Snow Ball - Merge with rain. (See above)
> >              Sound effect.
> >
> >  Snow flake - Merge with rain.  (See above)
> >              Sound effect.
> >
> >  TV - Icon.
> >       Sound effect.
> >
> >  Wavelets - Better icon.
> >             Drag UI mode, like Waves _used_ to have (see below).
> >             Sound effect.
> >
> >  Waves - Drag UI mode.  (Why was this removed?)
> >          Sound effect.  (Why was this removed?)
> >
> >
> > Thanks to all the students who produced these new tools, and their
> mentors,
> > and thanks in advance to those of you who'll help me clean them up and
> > make them shine. :)
>
> Let us know what you want.
>
> Caroline
>
>
>
> ------------------------------
>
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's
> challenge
> Build the coolest Linux based applications with Moblin SDK & win great
> prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
>
> ------------------------------
>
> _______________________________________________
> Tuxpaint-devel mailing list
> Tux...@li...
> https://lists.sourceforge.net/lists/listinfo/tuxpaint-devel
>
>
> End of Tuxpaint-devel Digest, Vol 29, Issue 1
> *********************************************
>