From: SourceForge.net <no...@so...> - 2007-09-05 12:22:52
|
Bugs item #1673676, was opened at 2007-03-05 00:04 Message generated for change (Comment added) made by cpeus You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=381347&aid=1673676&group_id=24366 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Nobody/Anonymous (nobody) Assigned to: Nobody/Anonymous (nobody) Summary: W2003 explorer crash with long filenames Initial Comment: Hello, when using drive redirection from a linux host to a windows 2003 terminal server, the windows explorer crashes when files with names longer than approx. 128 chars are in a traversed directory. Simply skipping files with names longer than this solves the problem Example patch --- disk.c.orig 2007-01-08 05:47:05.000000000 +0100 +++ disk.c 2007-03-02 10:48:16.000000000 +0100 @@ -1135,8 +1135,9 @@ } /* find next dirent matching pattern */ + /* ignore files with filename too long */ pdirent = readdir(pdir); - while (pdirent && fnmatch(pfinfo->pattern, pdirent->d_name, 0) != 0) + while (pdirent && (fnmatch(pfinfo->pattern, pdirent->d_name, 0) != 0 || strlen(pdirent->d_name) > 118)) pdirent = readdir(pdir); if (pdirent == NULL) ---------------------------------------------------------------------- Comment By: Christoph Peus (cpeus) Date: 2007-09-05 14:22 Message: Logged In: YES user_id=958360 Originator: NO The problem occurs with file names longer than 126 characters to be precise. But simply skipping them is *not* a solution. Users expect USB-Sticks to behave always the same - no matter whether they are plugged into a Windows fat client or a Linux/rdesktop based thinclient device. One may think that it is not often that a user chooses a filename with more than 126 characters, but if users save documents with automatically generated filenames (e.g. when saving websites) this occurs quite frequently, at least in our public pc pools. Typical scanario: they save something to a USB-Stick at home (using standard Windows pc of course) plug that stick into one of our thinclient devices and cannot open the file because the connection crashes or - if above path would be applied - the saved file wouldn't be displayed - very annoying. Please please please fix that bug! Thanks. Regards Christoph ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=381347&aid=1673676&group_id=24366 |