[rdesktop-devel] [ rdesktop-Patches-1440499 ] Add _NET_WM_PID and WM_CLIENT_MACHINE window props

[SourceForge.net <no...@so...>]

Patches item #1440499, was opened at 2006-02-28 19:02
Message generated for change (Comment added) made by dannym
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=381349&aid=1440499&group_id=24366

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Danny Milosavljevic (dannym)
Assigned to: Nobody/Anonymous (nobody)
Summary: Add _NET_WM_PID and WM_CLIENT_MACHINE window props

Initial Comment:
adds _NET_WM_PID and WM_CLIENT_MACHINE X properties to
the window.

This aids panels and window managers in actually
_finding_ the process that 
displays a particular window.

Should have no side effects.


----------------------------------------------------------------------

>Comment By: Danny Milosavljevic (dannym)
Date: 2006-03-25 17:42

Message:
Logged In: YES 
user_id=765110

> 1. Why hostname[90]? Where's the 90 from? Why not
HOST_NAME_MAX?

random value from my magic hat? Using the HOST_NAME_MAX is 
better, yes :)

> 2. This comment is unclear:
+/* XSetWMProperties(g_dislpay, g_wnd, window_name, 
icon_name,
+    argv, argc, normal_hints, wm_hints, class_hints); also
does the
+    XSetWMClientMachine bit too */

This notes an alternative way of doing more things (window 
title, iconified title, hints *and* WM_MACHINE_NAME) in one 
function call (in case you want to coalesce it more). Can 
be removed :)

> 3. In the error message, "Error: ..." should begin
with a capital letter.

No objections :)

> 4. No need for the 'pid' variable really. Just trying
to reduce clutter.

Agreed 


----------------------------------------------------------------------

Comment By: Ilya Konstantinov (ikonst)
Date: 2006-03-01 14:05

Message:
Logged In: YES 
user_id=335423

The idea of the patch is great and it's about time someone
added it.

Few comments:
1. Why hostname[90]? Where's the 90 from? Why not HOST_NAME_MAX?
2. This comment is unclear:

+	/* XSetWMProperties(g_dislpay, g_wnd, window_name, icon_name,
+	    argv, argc, normal_hints, wm_hints, class_hints); also
does the
+	    XSetWMClientMachine bit too */

3. In the error message, "Error: ..." should begin with a
capital letter.
4. No need for the 'pid' variable really. Just trying to
reduce clutter.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=381349&aid=1440499&group_id=24366