[rdesktop-devel] bug in bitmap decompression algorithm

[Chris J. <ch...@at...>]

There appears to be a bug in the bitmap decompression algorithm with bpp >
8:

Using 24bpp, the first 16 bytes of a bitmap with width 1 once decompressed
are as follows:
116,111,102,0,0,0,0,0,0,0,0,0,116,111,102,0
The same bitmap using 8bpp decompresses as:
247,0,0,0,247,0,0,0,247,0,0,0,247,0,0,0

At 24bpp, the bitmap_decompress function seems to be inserting too many zero
bytes. I believe there should only be one zero between each pixel for
padding, i.e.
116,111,102,0,116,112,102,0,116,112,102,0,...

Chris

---
Christopher January www.atomice.com