Menu
▾
▴
[Pcgen-trackers] [ pcgen-Bugs-1045173 ] CHOOSE Single choice behavior
|
From: SourceForge.net <no...@so...> - 2004-12-30 00:18:24
|
Bugs item #1045173, was opened at 2004-10-12 19:40 Message generated for change (Comment added) made by jdempsey You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=384719&aid=1045173&group_id=25576 Category: None Group: None >Status: Closed >Resolution: Fixed Priority: 5 Submitted By: Paul W. King (kingpaul) Assigned to: James Dempsey (jdempsey) Summary: CHOOSE Single choice behavior Initial Comment: Per http://groups.yahoo.com/group/pcgen/message/80243 This is more of a glitch or an unintended behavior than a bug as the feature is working, its just working in a place it shouldn't. In the preferences when the CHOOSE Single choice behavior is set to 'Add the single choice and close' when adding a feat such as toughness where there is only one choice the program will add that choice as many times as it can until the feat pool is spent. Further more if you open it back up and try to remove the choices you cannot, it adds them all back and if you have added more feat points it will take that too. While this is the expected behavior when this preference is active it did take me awhile to realize what was happening. There are some other feats which use this setup and if a simple way could be found to block this behavior for these feats that would be great. Otherwise a word of caution can be added to the docs in the entry for this preference. Oh, and behavior is spelled in the British fashion (behaviour) in that preference pane if anyone cares :) -- ~ Eddy Anthony (MoSaT) ~ PCGen Content Silverback === Paul W. King TM SB, OGL/PL Chimp, Data Tamarin, BoD ---------------------------------------------------------------------- >Comment By: James Dempsey (jdempsey) Date: 2004-12-30 11:18 Message: Logged In: YES user_id=558288 It turns out that the choice was being added twice, once when the dialog is being initialised and once when the chooser is being closed. I have corrected it so that it now only adds the choice when the chooser is being set-up. Files changed: java/pcgen/gui/utils/SwingChooser.java new revision: 1.21 test/pcgen/core/PlayerCharacterTest.java new revision: 1.11 I have left my change #2 for another time when it can be discussed properly. It is probably at post 5.8 issue. James. ---------------------------------------------------------------------- Comment By: James Dempsey (jdempsey) Date: 2004-12-14 08:48 Message: Logged In: YES user_id=558288 Agreed, this really isn't how it should work. I'll check into it before changing anything, but two changes seem to be in order: 1. 'Add the single choice and close' should only select one option and move on. If there is more than one slot to fill with a single option, the auto-close code should not be being triggered. 2. Change calls for things like Toughness to only allow a single choice, and not allow all of the remaining feats to be spent. This will avoid the bug reports we get regularly that the chooser is offering too many selections. If you want more than one it is easy enough to add it again. Thoughts? James. ---------------------------------------------------------------------- Comment By: Reed Thornton (rthornton13) Date: 2004-12-14 08:14 Message: Logged In: YES user_id=1001978 Do we really want to let the chooser add a single choice as many times as it can? It would seem to me that it isn't really closing after adding the one choice in a proper fashion, and is doing it recursively instead. Reed QA SB ---------------------------------------------------------------------- Comment By: Eddy Anthony (eddyanthony) Date: 2004-10-13 12:22 Message: Logged In: YES user_id=886893 I've added a warning in the docs about this issue. This may be enough to deal with it if there is no easy code fix. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=384719&aid=1045173&group_id=25576 |