Menu
▾
▴
[Pcgen-trackers_new_tag] [JIRA] (NEWTAG-388) Add SOURCEWEB to the SPELLMEM tag
|
From: JIRA (f. H. S. ) <ji...@pc...> - 2013-10-20 14:04:12
|
<style>
/* Changing the layout to use less space for mobiles */
@media screen and (max-device-width: 480px), screen and (-webkit-min-device-pixel-ratio: 2) {
#email-body { min-width: 30em !important; }
#email-page { padding: 8px !important; }
#email-banner { padding: 8px 8px 0 8px !important; }
#email-avatar { margin: 1px 8px 8px 0 !important; padding: 0 !important; }
#email-fields { padding: 0 8px 8px 8px !important; }
#email-gutter { width: 0 !important; }
}
</style>
<div id="email-body">
<table id="email-wrap" align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#f0f0f0;color:#000000;width:100%;">
<tr valign="top">
<td id="email-page" style="padding:16px !important;">
<table align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#ffffff;border:1px solid #bbbbbb;color:#000000;width:100%;">
<tr valign="top">
<td bgcolor="#205081" style="background-color:#205081;color:#ffffff;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;line-height:1;"><img src="http://jira.pcgen.org/s/en_US-2ipeo2-1988229788/6102/6/_/images/icon-jira-logo.png" alt="" style="vertical-align:top;" /></td>
</tr><tr valign="top">
<td id="email-banner" style="padding:32px 32px 0 32px;">
<table align="left" border="0" cellpadding="0" cellspacing="0" width="100%" style="width:100%;">
<tr valign="top">
<td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;padding:0;">
<img id="email-avatar" src="http://jira.pcgen.org/secure/useravatar?avatarId=10142" alt="" height="48" width="48" border="0" align="left" style="padding:0;margin: 0 16px 16px 0;" />
<div id="email-action" style="padding: 0 0 8px 0;font-size:12px;line-height:18px;">
<a class="user-hover" rel="henkslaaf" id="email_henkslaaf" href="http://jira.pcgen.org/secure/ViewProfile.jspa?name=henkslaaf" style="color:#3b73af;">Henk Slaaf</a>
commented on <img src="http://jira.pcgen.org/images/icons/issuetypes/genericissue.png" height="16" width="16" border="0" align="absmiddle" alt="New Token"> <a style='color:#3b73af;text-decoration:none;' href='http://jira.pcgen.org/browse/NEWTAG-388'>NEWTAG-388</a>
</div>
<div id="email-summary" style="font-size:16px;line-height:20px;padding:2px 0 16px 0;">
<a style='color:#3b73af;text-decoration:none;' href='http://jira.pcgen.org/browse/NEWTAG-388'><strong>Add SOURCEWEB to the SPELLMEM tag</strong></a>
</div>
</td>
</tr>
</table>
</td>
</tr>
<tr valign="top">
<td id="email-fields" style="padding:0 32px 32px 32px;">
<table border="0" cellpadding="0" cellspacing="0" style="padding:0;text-align:left;width:100%;" width="100%">
<tr valign="top">
<td id="email-gutter" style="width:64px;white-space:nowrap;"></td>
<td>
<table border="0" cellpadding="0" cellspacing="0" width="100%">
<tr valign="top">
<td colspan="2" style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 16px 0;width:100%;">
<div class="comment-block" style="background-color:#edf5ff;border:1px solid #dddddd;color:#000000;padding:12px;"><p>When SOURCEWEB is not set, the value of the token in the OS is set to null. This makes the link go to "http://localhost/null", meh. The string is set to null, in other words.</p>
<p>How can I make sure the value matches None is the outputsheets?</p>
<div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent">
<pre class="code-java">|IIF(SPELLMEM.%class.%spellbook.%level.%spell.SOURCEWEB:None)|
</pre>
</div></div>
<p>I thought of something like:</p>
<div class="code panel" style="border-width: 1px;"><div class="codeHeader panelHeader" style="border-bottom-width: 1px;"><b>b/pcgen/code/src/java/plugin/exporttokens/SpellMemToken.java</b></div><div class="codeContent panelContent">
<pre class="code-java">+ <span class="code-keyword">else</span> <span class="code-keyword">if</span> (<span class="code-quote">"SOURCEWEB"</span>.equals(aLabel))
+ {
+ <span class="code-object">String</span> aTemp = aSpell.get(StringKey.SOURCE_WEB);
+
+ <span class="code-keyword">if</span> (aTemp != <span class="code-keyword">null</span> && !aTemp.isEmptu()) {
+ retValue.append(aSpell.get(StringKey.SOURCE_WEB));
+ }
+ }
</pre>
</div></div>
<p>This works so far as not having a string null, but the output token is still not equal to None. The link is now empty href="", so it points to the current document. Better, but I'd rather have no link at all.</p>
<p>Is it best to test for an empty string in the output sheet? Or can this still be achieved?</p>
<p>Best.</p>
<p>Henk</p></div>
<div style="color:#505050;padding:4px 0 0 0;"> </div>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td><!-- End #email-page -->
</tr>
<tr valign="top">
<td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:10px;line-height:14px;padding: 0 16px 16px 16px;text-align:center;">
This message is automatically generated by JIRA.<br />
If you think it was sent incorrectly, please contact your JIRA administrators<br />
For more information on JIRA, see: <a style='color:#3b73af;' href='http://www.atlassian.com/software/jira'>http://www.atlassian.com/software/jira</a>
</td>
</tr>
</table><!-- End #email-wrap -->
</div><!-- End #email-body -->
|
![http://jira.pcgen.org/s/en_US-2ipeo2-1988229788/6102/6/_/images/icon-jira-logo.png"](http://jira.pcgen.org/s/en_US-2ipeo2-1988229788/6102/6/_/images/icon-jira-logo.png"){kind=link}
![http://jira.pcgen.org/images/icons/issuetypes/genericissue.png"](http://jira.pcgen.org/images/icons/issuetypes/genericissue.png"){kind=link}