From: JIRA (f. J. D. ) <ji...@pc...> - 2013-03-31 08:55:21
|
<style> /* Changing the layout to use less space for mobiles */ @media screen and (max-device-width: 480px), screen and (-webkit-min-device-pixel-ratio: 2) { #email-body { min-width: 30em !important; } #email-page { padding: 8px !important; } #email-banner { padding: 8px 8px 0 8px !important; } #email-avatar { margin: 1px 8px 8px 0 !important; padding: 0 !important; } #email-fields { padding: 0 8px 8px 8px !important; } #email-gutter { width: 0 !important; } } </style> <div id="email-body"> <table id="email-wrap" align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#f0f0f0;color:#000000;width:100%;"> <tr valign="top"> <td id="email-page" style="padding:16px !important;"> <table align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#ffffff;border:1px solid #bbbbbb;color:#000000;width:100%;"> <tr valign="top"> <td bgcolor="#003366" style="background-color:#003366;color:#ffffff;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;line-height:1;"><img src="http://jira.pcgen.org/s/en_US7r5c5v-418945332/812/6/_/images/icon-jira-logo.png" alt="" style="vertical-align:top;" /></td> </tr><tr valign="top"> <td id="email-banner" style="padding:32px 32px 0 32px;"> <table align="left" border="0" cellpadding="0" cellspacing="0" width="100%" style="width:100%;"> <tr valign="top"> <td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;padding:0;"> <img id="email-avatar" src="http://jira.pcgen.org/secure/useravatar?avatarId=10142" alt="" height="48" width="48" border="0" align="left" style="padding:0;margin: 0 16px 16px 0;" /> <div id="email-action" style="padding: 0 0 8px 0;font-size:12px;line-height:18px;"> <a class="user-hover" rel="jamesd" id="email_jamesd" href="http://jira.pcgen.org/secure/ViewProfile.jspa?name=jamesd" style="color:#326ca6;">James Dempsey</a> updated <img src="http://jira.pcgen.org/images/icons/bug.gif" height="16" width="16" border="0" align="absmiddle" alt="Bug"> <a style='color:#326ca6;text-decoration:none;' href='http://jira.pcgen.org/browse/CODE-2000'>CODE-2000</a> </div> <div id="email-summary" style="font-size:16px;line-height:20px;padding:2px 0 16px 0;"> <a style='color:#326ca6;text-decoration:none;' href='http://jira.pcgen.org/browse/CODE-2000'><strong>[Pathfinder] Broken EQMOD - PRExxx is tested against PC not Armor</strong></a> </div> </td> </tr> </table> </td> </tr> <tr valign="top"> <td id="email-fields" style="padding:0 32px 32px 32px;"> <table border="0" cellpadding="0" cellspacing="0" style="padding:0;text-align:left;width:100%;" width="100%"> <tr valign="top"> <td id="email-gutter" style="width:64px;white-space:nowrap;"></td> <td> <table border="0" cellpadding="0" cellspacing="0" width="100%"> <tr valign="top"> <td colspan="2" style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 16px 0;width:100%;"> <div class="comment-block" style="background-color:#edf5ff;border:1px solid #dddddd;color:#000000;padding:12px;"><p>This is not an issue with the PRETYPE, but is an issue with how the stacking of bonuses is handled. </p> <p>The rule used for bonus stacking is that any negative bonus stacks with existing bonuses/penalties but a positive bonus does not stack by default (stacking bonus types are defined by the game mode).</p> <p>However, a negative bonus will be overwritten by a non stackable positive bonus if it is processed second. So -3+7 = 7 but 7+-3 = 4 in pcgen bonus math. Additionally the order in which the bonuses are calculated is random due to how they are stored.</p> <p>Relevant code is pcgen.core.BonusManager.setActiveBonusStack(double, String, Map<String, String><img class="emoticon" src="http://jira.pcgen.org/images/icons/emoticons/wink.gif" height="20" width="20" align="absmiddle" alt="" border="0"/></p> <p>To resolve this we will need to either total the negative bonuses separately from the positive ones and then add them together or ensure that the negative bonuses are always applied last.</p></div> <div style="color:#505050;padding:4px 0 0 0;"> </div> </td> </tr> <tr valign="top"> <td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;"> <strong style="font-weight:normal;color:#505050;">Change By:</strong> </td> <td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;"> <a class="user-hover" rel="jamesd" id="email_jamesd" href="http://jira.pcgen.org/secure/ViewProfile.jspa?name=jamesd" style="color:#326ca6;">James Dempsey</a> (31/Mar/13 7:54 PM) </td> </tr> <tr valign="top"> <td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;"> <strong style="font-weight:normal;color:#505050;">Status:</strong> </td> <td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;"> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;">Open</span> <span class="diffaddedchars" style="background-color:#ddfade;">Confirmed</span> </td> </tr> </table> </td> </tr> </table> </td> </tr> </table> </td><!-- End #email-page --> </tr> <tr valign="top"> <td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:10px;line-height:14px;padding: 0 16px 16px 16px;text-align:center;"> This message is automatically generated by JIRA.<br /> If you think it was sent incorrectly, please contact your JIRA administrators<br /> For more information on JIRA, see: <a style='color:#326ca6;' href='http://www.atlassian.com/software/jira'>http://www.atlassian.com/software/jira</a> </td> </tr> </table><!-- End #email-wrap --> </div><!-- End #email-body --> |