From: JIRA (f. T. P. ) <ji...@pc...> - 2012-12-18 04:59:21
|
<style> /* Changing the layout to use less space for mobiles */ @media screen and (max-device-width: 480px), screen and (-webkit-min-device-pixel-ratio: 2) { #email-body { min-width: 30em !important; } #email-page { padding: 8px !important; } #email-banner { padding: 8px 8px 0 8px !important; } #email-avatar { margin: 1px 8px 8px 0 !important; padding: 0 !important; } #email-fields { padding: 0 8px 8px 8px !important; } #email-gutter { width: 0 !important; } } </style> <div id="email-body"> <table id="email-wrap" align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#f0f0f0;color:#000000;width:100%;"> <tr valign="top"> <td id="email-page" style="padding:16px !important;"> <table align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#ffffff;border:1px solid #bbbbbb;color:#000000;width:100%;"> <tr valign="top"> <td bgcolor="#003366" style="background-color:#003366;color:#ffffff;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;line-height:1;"><img src="http://jira.pcgen.org/s/en_US7r5c5v-418945332/812/6/_/images/icon-jira-logo.png" alt="" style="vertical-align:top;" /></td> </tr><tr valign="top"> <td id="email-banner" style="padding:32px 32px 0 32px;"> <table align="left" border="0" cellpadding="0" cellspacing="0" width="100%" style="width:100%;"> <tr valign="top"> <td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;padding:0;"> <img id="email-avatar" src="http://jira.pcgen.org/secure/useravatar?avatarId=10142" alt="" height="48" width="48" border="0" align="left" style="padding:0;margin: 0 16px 16px 0;" /> <div id="email-action" style="padding: 0 0 8px 0;font-size:12px;line-height:18px;"> <a class="user-hover" rel="thpr" id="email_thpr" href="http://jira.pcgen.org/secure/ViewProfile.jspa?name=thpr" style="color:#326ca6;">Tom Parker</a> updated <img src="http://jira.pcgen.org/images/icons/genericissue.gif" height="16" width="16" border="0" align="absmiddle" alt="New Token"> <a style='color:#326ca6;text-decoration:none;' href='http://jira.pcgen.org/browse/NEWTAG-338'>NEWTAG-338</a> </div> <div id="email-summary" style="font-size:16px;line-height:20px;padding:2px 0 16px 0;"> <a style='color:#326ca6;text-decoration:none;' href='http://jira.pcgen.org/browse/NEWTAG-338'><strong>Isolate Temporary Bonuses</strong></a> </div> </td> </tr> </table> </td> </tr> <tr valign="top"> <td id="email-fields" style="padding:0 32px 32px 32px;"> <table border="0" cellpadding="0" cellspacing="0" style="padding:0;text-align:left;width:100%;" width="100%"> <tr valign="top"> <td id="email-gutter" style="width:64px;white-space:nowrap;"></td> <td> <table border="0" cellpadding="0" cellspacing="0" width="100%"> <tr valign="top"> <td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;"> <strong style="font-weight:normal;color:#505050;">Change By:</strong> </td> <td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;"> <a class="user-hover" rel="thpr" id="email_thpr" href="http://jira.pcgen.org/secure/ViewProfile.jspa?name=thpr" style="color:#326ca6;">Tom Parker</a> (18/Dec/12 3:58 PM) </td> </tr> <tr valign="top"> <td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;"> <strong style="font-weight:normal;color:#505050;">Description:</strong> </td> <td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;"> <span class="diffcontext">This is a proposal to make a significant change to how temporary bonuses are</span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"> done</span> <span class="diffaddedchars" style="background-color:#ddfade;"><br>coded in the LST</span> <span class="diffcontext">.<br><br></span> <span class="diffaddedchars" style="background-color:#ddfade;">This makes Temporary bonuses *explicit* by having a separate token, not<br>*implicit* by using a prerequisite to identify temporary bonuses.<br><br>This will:<br>(a) Make temporary bonuses much easier to find in the LST data<br>(b) Allow the temporary bonus code to be much cleaner (in not having to<br>decompose prerequisites at runtime)<br>(c) Facilitate larger Prerequisite changes (PRE/REQ proposal) as it eliminates a<br>"special case" in Prerequisite handling in the code.<br><br></span> <span class="diffcontext">Currently, we use:<br>BONUS:</span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"><blah></span> <span class="diffaddedchars" style="background-color:#ddfade;">A</span> <span class="diffcontext">|</span> <span class="diffaddedchars" style="background-color:#ddfade;">B|C|</span> <span class="diffcontext">PREAPPLY:PC<br>etc. <br>to define temporary bonuses.<br>The PC could also be ANYPC or some combination of Equipment types (see the docs</span> <span class="diffaddedchars" style="background-color:#ddfade;"><br></span> <span class="diffcontext"> for PREAPPLY)<br>Note that the Bonuses can have other PRExxx so this:<br>BONUS:</span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"><blah></span> <span class="diffaddedchars" style="background-color:#ddfade;">A</span> <span class="diffcontext">|</span> <span class="diffaddedchars" style="background-color:#ddfade;">B|C|</span> <span class="diffcontext">PREAPPLY:PC|PRELEVEL:5<br>is also legal.<br><br>This is a proposal to deprecate PREAPPLY: in all forms. It is replaced by a new</span> <span class="diffaddedchars" style="background-color:#ddfade;"><br></span> <span class="diffcontext"> token: TEMPBONUS<br><br>TEMPBONUS form:<br>TEMPBONUS:PC|w|x|y|z<br>TEMPBONUS:ANYPC|w|x|y|z<br>TEMPBONUS:EQ|v|w|x|y|z<br>v = Equipment Types as per PREAPPLY works today (with ; and , value as in</span> <span class="diffaddedchars" style="background-color:#ddfade;"><br></span> <span class="diffcontext"> PREAPPLY)<br>w, x, and y are equivalent to the 3 tags in BONUS (w=Category, x=Group,</span> <span class="diffaddedchars" style="background-color:#ddfade;"><br></span> <span class="diffcontext"> y=Formula)<br>z is one or more optional PRExxx<br><br></span> <span class="diffaddedchars" style="background-color:#ddfade;">Note: The proposal is that ONLY ONE of the subtokens (PC, ANYPC, EQ) can EVER be<br>placed onto a single object.<br><br>In the case v is used in TEMPBONUS:EQ|, then only one v is allowed (any<br>TEMPBONUS tokens applied to a single object must have matching items preceding<br>the w,x,y entries.<br><br>The above restriction is not a documented restriction on PREAPPLY, however, I<br>also will not guarantee that the behavior of the code is known if multiple<br>PREAPPLY tokens with different application types are on the same object... If<br>any data exists of that form, I would be very interested in seeing the data.<br><br><br><br></span> <span class="diffcontext">Since this is</span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"> effectively</span> <span class="diffaddedchars" style="background-color:#ddfade;"> mostly</span> <span class="diffcontext"> just reordering the information to make Temporary Bonuses</span> <span class="diffaddedchars" style="background-color:#ddfade;"><br></span> <span class="diffcontext"> explicit (rather than implicit based on a Prerequisite that later has to be</span> <span class="diffaddedchars" style="background-color:#ddfade;"><br></span> <span class="diffcontext"> decomposed to comprehend what is going on), the conversion of this can be done</span> <span class="diffaddedchars" style="background-color:#ddfade;"><br></span> <span class="diffcontext"> automatically</span> <span class="diffaddedchars" style="background-color:#ddfade;">.</span> <span class="diffcontext"><br></span> <span class="diffaddedchars" style="background-color:#ddfade;"><br>There is a small risk of running into data that has more than one type of<br>PREAPPLY that would cause data to be rebuilt by hand.<br></span> </td> </tr> </table> </td> </tr> </table> </td> </tr> </table> </td><!-- End #email-page --> </tr> <tr valign="top"> <td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:10px;line-height:14px;padding: 0 16px 16px 16px;text-align:center;"> This message is automatically generated by JIRA.<br /> If you think it was sent incorrectly, please contact your JIRA administrators<br /> For more information on JIRA, see: <a style='color:#326ca6;' href='http://www.atlassian.com/software/jira'>http://www.atlassian.com/software/jira</a> </td> </tr> </table><!-- End #email-wrap --> </div><!-- End #email-body --> |