[Pcgen-trackers_code] [JIRA] (CODE-1712) Automatic Granted Feat with Choices by %LIST fails to work for secondary CHOOSE: that try to add it.

[JIRA (f. J. D. ) <ji...@pc...>]

<style>
/* Changing the layout to use less space for mobiles */
@media screen and (max-device-width: 480px), screen and (-webkit-min-device-pixel-ratio: 2) {
    #email-body { min-width: 30em !important; }
    #email-page { padding: 8px !important; }
    #email-banner { padding: 8px 8px 0 8px !important; }
    #email-avatar { margin: 1px 8px 8px 0 !important; padding: 0 !important; }
    #email-fields { padding: 0 8px 8px 8px !important; }
    #email-gutter { width: 0 !important; }
}
</style>
<div id="email-body">
<table id="email-wrap" align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#f0f0f0;color:#000000;width:100%;">
    <tr valign="top">
        <td id="email-page" style="padding:16px !important;">
            <table align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#ffffff;border:1px solid #bbbbbb;color:#000000;width:100%;">
                <tr valign="top">
                    <td bgcolor="#114070" style="background-color:#114070;color:#ffffff;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;line-height:1;"><img src="http://jira.pcgen.org/s/en_US-w57ynr/664/4/_/images/jira111x30.png" alt="" style="vertical-align:top;" /></td>
                </tr><tr valign="top">
    <td id="email-banner" style="padding:32px 32px 0 32px;">

                
        
        
        <table align="left" border="0" cellpadding="0" cellspacing="0" width="100%" style="width:100%;">
    <tr valign="top">
        <td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;padding:0;">
                                            <img id="email-avatar" src="http://jira.pcgen.org/secure/useravatar?avatarId=10142" alt="" height="48" width="48" border="0" align="left" style="padding:0;margin: 0 16px 16px 0;" />
                        <div id="email-action" style="padding: 0 0 8px 0;font-size:12px;line-height:18px;">
                                    <a class="user-hover" rel="jamesd" id="email_jamesd" href="http://jira.pcgen.org/secure/ViewProfile.jspa?name=jamesd" style="color:#3c78b5;">James Dempsey</a>
     commented on <img src="http://jira.pcgen.org/images/icons/bug.gif" height="16" width="16" border="0" align="absmiddle" alt="Bug"> <a style='color:#3c78b5;text-decoration:none;' href='http://jira.pcgen.org/browse/CODE-1712'>CODE-1712</a>
            </div>
            <div id="email-summary" style="font-size:16px;line-height:20px;padding:2px 0 16px 0;">
                <a style="color:#3c78b5;text-decoration:none;" href="http://jira.pcgen.org/browse/CODE-1712"><strong>Automatic Granted Feat with Choices by %LIST fails to work for secondary CHOOSE: that try to add it.</strong></a>
            </div>
        </td>
    </tr>
</table>
    </td>
</tr>
<tr valign="top">
    <td id="email-fields" style="padding:0 32px 32px 32px;">
        <table border="0" cellpadding="0" cellspacing="0" style="padding:0;text-align:left;width:100%;" width="100%">
            <tr valign="top">
                <td id="email-gutter" style="width:64px;white-space:nowrap;"></td>
                <td>
                    <table border="0" cellpadding="0" cellspacing="0" width="100%">
                        <tr valign="top">
    <td colspan="2" style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 16px 0;width:100%;">
        <div class="comment-block" style="background-color:#edf5ff;border:1px solid #dddddd;color:#000000;padding:12px;">The root cause of this issue is that choices granted via AUTO:FEAT and ABILITY e.g. AUTO:FEAT|<a href="http://jira.pcgen.org/browse/CODE-1712" title="Automatic Granted Feat with Choices by %LIST fails to work for secondary CHOOSE: that try to add it.">CODE-1712</a>A (%LIST) are not being processed as true choices. The text association is being recorded but the links to the objects  (the skills in the case of CODE_1712AA) are not being properly created. Thus when the secondary choose looks at the granted feat it does not find the granted choices.
<br/>

<br/>
In code terms that means that the actor recorded in ObjectKey.CHOOSE_ACTOR is not being informed of the choices. A fix is made a little bit more complex as the LST format of the choice (e.g. Chooser ~ Choose ABILITY(Alertness) ) is not the same as the storage format for the choice CATEGORY=Special Ability|Alertness). The association (text only currently) is recorded by pcgen.cdom.facet.GrantedAbilityFacet.dataAdded(DataFacetChangeEvent&lt;CategorizedAbilitySelection&gt;)
<br/>

<br/>
PS: This issue could in turn cause other issues with granted ability choices such as missing bonuses etc.</div>
        <div style="color:#505050;padding:4px 0 0 0;">                </div>
    </td>
</tr>
                    </table>
                </td>
            </tr>
        </table>
    </td>
</tr>










            </table>
        </td><!-- End #email-page -->
    </tr>
    <tr valign="top">
        <td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:10px;line-height:14px;padding: 0 16px 16px 16px;text-align:center;">
            This message is automatically generated by JIRA.<br />
            If you think it was sent incorrectly, please contact your <a style='color:#3c78b5;' href='http://jira.pcgen.org/secure/ContactAdministrators!default.jspa'>JIRA administrators</a>.<br />
            For more information on JIRA, see: <a style='color:#3c78b5;' href='http://www.atlassian.com/software/jira'>http://www.atlassian.com/software/jira</a>
        </td>
    </tr>
</table><!-- End #email-wrap -->
</div><!-- End #email-body -->