From: JIRA (f. D. R. B. ) <ji...@pc...> - 2011-07-26 13:09:04
|
[ http://jira.pcgen.org/browse/CODE-1047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12510#action_12510 ] David R. Bender commented on CODE-1047: --------------------------------------- What I *think* he is saying is (using Pathfinder as example): In C:\PCGen\data\alpha\paizo\pathfinder_rpg\core_rulebook\pfcr_spells.lst there is this (abbreviated) entry for Bull's Strength: Bull's Strength CLASSES:Cleric,Druid,Paladin,Sorcerer,Wizard=2 DOMAINS:Strength=2 In C:\PCGen\data\alpha\paizo\pathfinder_rpg\core_rulebook\pfcr_domains.lst there is this (abbreviated) entry for Strength Domain: Strength SPELLLEVEL:DOMAIN|Strength=1|Enlarge Person|Strength=2|Bull's Strength|Strength=3|.... Notice that the spells list says that Bull's Strength is in the Strength Domain, and in the domains list, it says that Bull's Strength is one of it's spells. I believe he was saying that one of the two should be eliminated since it is duplicate effort to associate the domain / spell in two places. > Domain spells can be defined in two places at once > -------------------------------------------------- > > Key: CODE-1047 > URL: http://jira.pcgen.org/browse/CODE-1047 > Project: Code > Issue Type: New Feature > Components: Needs Verification Review > Reporter: David R. Bender > Assignee: James Dempsey > > SF - ID: 2835209 > Last Update: Tracker Item Submitted ( fluxxdog ) > Details: > > Hi folks, > > > > Should the association of spells with domains take place in the domain.lst > > file or in each individual domain spell's description? > > > > For example, I just noticed that the spell Clenched Fist has the > > DOMAINS:Strength=8 tag in its description. But the Strength domain also has > > the tag > > > > SPELLLEVEL:DOMAIN|Strength=1|Enlarge Person|Strength=2|Bull's > > Strength|Strength=3|Magic Vestment|Strength=4|Spell > > Immunity|Strength=5|Righteous > > Might|Strength=6|Stoneskin|Strength=7|Grasping Hand|Strength=8|Clenched > > Fist|Strength=9|Crushing Hand > > > > which seems like the same mapping is being specified in two different > > locations. When I set up my own custom domains, do I need to do the mapping > > in both? either? > Either. As it is right now, using one or the other will set up the spell to > work with a Domain. > > > Just out of curiosity...I'm no programmer, but isn't it sort of dangerous > > > to specify the same thing in two locations as has been done in the core > > > dataset? > > > > I'd think so, but the Code team seems to have a tight leash on it. I think it > > was designed this way because domain spells are listed in both the spell entry > > and the domain entry in sources, so if you enter one, the other, or both, you > > have no problem. > Actually, I'd think this is a bit screwy. Can we get a FREQ to catch this situation, please? > Submitted: > Fluxxdog ( fluxxdog ) - 2009-08-10 18:39:41 EDT -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.pcgen.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |