Menu
▾
▴
[Pcgen-trackers_code] [JIRA] Created: (CODE-698) Spells TYPE tag needs to be enhanced
|
From: JIRA (f. D. R. B. ) <ji...@pc...> - 2011-07-12 23:49:09
|
Spells TYPE tag needs to be enhanced
------------------------------------
Key: CODE-698
URL: http://jira.pcgen.org/browse/CODE-698
Project: Code
Issue Type: New Feature
Components: Needs Verification Review
Reporter: David R. Bender
SF - ID: 873085
Last Update: Comment added ( thpr )
Details:
The TYPE tag of spells needs the ability to allow for user
defined types. Currently it only allows for Divine,
Arcane, Psionic (or combos of these three).
The hardcoding needs to be removed to allow other
TYPE's such as "Weave" (wheel of time), "Power" (most
point buy systems), or any user defined TYPE.
This would also require an update to the
PRE/BONUS/ADD/CHOOSE code as well to allow for user
defined terms to use the PRE/BONUS code.
This would also require a modifiaction to the UI on the
spells tabs to sort by the type and/or populate the spell
list based on the TYPE of 'spells' the character is allowed
(much like it does already with the current Divine,
Arcane, and Psionic characters).
Sample (can't rem the exact BONUS/PRE tags offhand,
but the idea gets across)
Snarf's Evil Spell 'O Doom TYPE:Personal.Arcane.Spiffy
PRESPELLTYPE:1,Spiffy
CHOOSE:SPELL|TYPE.Personal|2
BONUS:SPELLDC|TYPE.Spiffy|3|TYPE=ExtraSpiffy
ADD:SPELL(TYPE.Spiffy)
Submitted:
Rob Reed ( mynex ) - 2004-01-08 08:52:53 EST
Priority:
Status:
Resolution:
Tracker:
Assigned:
(admin)
Category:
(admin)
Group:
(admin)
Visibility:
Private
Response:
(admin)
Comment:
Comments ( 9 )
Add a comment
Date: 2008-07-29 22:51:14 EDT
Sender: thprProject Admin & Donor
Hide
PRESPELLTYPE is PRE(SPELLTYPE) not PRE(SPELL)(TYPE).
we can't change that or the impact is huge.
potential architecture work to determine if we can remove the TYPE entires
from the Spell LST file
Date: 2006-08-29 04:46:46 EDT
Sender: kariannaSourceForge.net DonorProject Admin & DonorAccepting Donations
Hide
Logged In: YES
user_id=252169
experimental for this one as well..
Date: 2006-08-16 00:56:53 EDT
Sender: eddyanthonySourceForge.net Subscriber
Hide
Logged In: YES
user_id=886893
Tested, I've confirmed that spell types are not hard coded.. you can add a
spell type 'Spiffy' and bonus the DC as well as set a PRESPELLTYPE.
What is confusing is that the Spells TYPE tag is not what sets the spells
type
for the spell on the classes spell list, it the CLASSes SPELLTYPE tag
which does
that.
So when I change the Sorcerer to SPELLTYPE:Spiffy then he has Spiffy
spells
and can pass PRESPELLTYPE:Spiffy,1,1 once he adds a 1st level spell.
I'm not sure what the Spell TYPE tag is actually used for, perhaps it is
for the
spell chooser in the customizer when making spell based magic items.
I think I see what Rob is wanting, he wants PRESPELLTYPE and these other
tags to work of the Spells TYPE tag where currently it's type is set by
class. I
can see now why he thought it was hard coded and having these tags work
from the Spells TYPE would be much clearer but off hand I don't know the
impact changing these tags will have.
Problem: if a spell has TYPE:Acane.Divine (as many of them do and
PRESPELLTYPE is changed to look at the Spells TYPE tag then that means a
Wizard will be able to pass a PRESPELLTYPE:Divine,1,1 check.
Sorry I don't have a good answer here, I can see where he's going with
this
request but I see a lot of problems I don't know how to address. This
needs a
lot of thought before any implementation.
Date: 2006-08-14 09:35:05 EDT
Sender: kariannaSourceForge.net DonorProject Admin & DonorAccepting Donations
Hide
Logged In: YES
user_id=252169
Eddy, where did you get to with that? - K
Date: 2005-09-15 11:17:16 EDT
Sender: eddyanthonySourceForge.net Subscriber
Hide
Logged In: YES
user_id=886893
Somewhat related to the Spell Chooser enhancement, it looks like it is
basically done. Need to verify that PRESPELLTYPE works with custom
spell types, I'll look into that.
Date: 2005-09-15 11:05:33 EDT
Sender: kariannaSourceForge.net DonorProject Admin & DonorAccepting Donations
Hide
Logged In: YES
user_id=252169
Eddy, related to the Spell Chooser enhancement? Is this
still needed? - K
Date: 2004-02-08 18:00:20 EST
Sender: ericbeaudoin
Hide
Logged In: YES
user_id=324612
I'm happy to learn that there is no hardcoding but this is a
suprise. I certainly remember the time when the TYPE were
introduced in the SPELL and at that point, we needed to put
TYPE there otherwise the SPELL would not show up properly.
I just don't remember where they didn't show up properly.
The SPELL TYPEs as they are used right now in PCGEN are
completely wrong. There is no such thing as an Arcane or
Divine in D&D. What we have are spells that are on the list of
Arcane or Divine or Psi spellcasters. This means that the
spell "type" cannot be predetermine in the .lst files, it must
be found at run time by searching the classes spell lists for
the current PC.
The TYPE in spell should be used like Rob describes them. We
need to modify the PRESPELLTYPE tag.
I'll try to test the ADD and CHOOSE to see if that works.
Date: 2004-02-08 17:29:53 EST
Sender: kariannaSourceForge.net DonorProject Admin & DonorAccepting Donations
Hide
Logged In: YES
user_id=252169
Eric, can you try out the CHOOSE and ADD that Bryan
mentions below?
K
TM SB
Date: 2004-01-10 23:47:44 EST
Sender: merton_monkProject Admin & Donor
Hide
Logged In: YES
user_id=195874
There is no hardcoding of spelltypes, except as far as a
Domain's special relationship to Divine spellcasters, and even
Arcane spellcasters can have Domains. I added a spell with a
TYPE:Spiffy and added a class that had a spelltype of Spiffy
and it worked just fine.
BONUS:DC|TYPE.Spiffy|2 works as well, as does
PRESPELLTYPE:Spiffy,1,1
I haven't checked to see if CHOOSE:SPELL|TYPE.Spiffy| is
valid or ADD:SPELL(TYPE.Spiffy).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.pcgen.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
|