[Pcgen-trackers] [JIRA] Created: (CODE-670) [RSRD] Keen stacks with improved critical

[JIRA (f. D. R. B. ) <ji...@pc...>]

[RSRD] Keen stacks with improved critical
-----------------------------------------

                 Key: CODE-670
                 URL: http://jira.pcgen.org/browse/CODE-670
             Project: Code
          Issue Type: Bug
          Components: Needs Verification Review
            Reporter: David R. Bender
             Fix For: 6.0.x


SF ID: 1196094
Last Update: Settings changed ( thpr )
Details:

Moving from
[ 1196050 ] [RSRD] Keen stacks with improved critical
http://sourceforge.net/tracker/index.php?
func=detail&aid=1196050&group_id=36698&atid=417816

Per
http://groups.yahoo.com/group/pcgen/message/85250

Keen property of the weapon stacks with improved
critical.

Win2000
java version "1.5.0_02"
Java(TM) 2 Runtime Environment, Standard Edition
(build 1.5.0_02-b09)
Java HotSpot(TM) Client VM (build 1.5.0_02-b09, mixed
mode)

Thanks,
Andriy

===

Addiitional information from
http://groups.yahoo.com/group/pcgen/message/85254

This would appear to be happening because the critical
range weapon property is being bonuses by two different
bonuses

Improved critical does it with this tag:
BONUS:WEAPONPROF=%
LIST|CRITRANGEDOUBLE|1|Type=NonStackingCrit

And Keen does it with this:
BONUS:EQMWEAPON|CRITRANGEDOUBLE|1|Type=N
onStackingCrit

So while they are both adjusting the
CRITRANGEDOUBLE property and they are typed
PCGen is not comparing bonuses to properties when
they com from different bonuses.

The tracker was opened in data but maybe this should
be looked at code wise, there are quite a few weapon
properties which can be adjusted via three or four
different bonuses and maybe we should look at how
these all are stacking.
--
~ Eddy Anthony (MoSaT)
~ PCGen Content Silverback

===

Paul W. King
TM SB, OGL/PL Chimp, Data Gibbon, BoD
Submitted:

Paul W. King ( kingpaul ) - 2005-05-05 14:17:47 EDT
Priority:

Status:

Resolution:

Tracker:

Assigned:

 (admin)
Category:

 (admin)
Group:

 (admin)
Visibility:

Private
Response:

 (admin)
Comment:



Comments ( 10 )
Add a comment

Date: 2008-11-03 10:40:49 EST
Sender: kariannaSourceForge.net DonorProject Admin & DonorAccepting Donations
Hide

Hi Aaron, have you had a chance to look into this further?


Date: 2007-07-17 15:40:40 EDT
Sender: kariannaSourceForge.net DonorProject Admin & DonorAccepting Donations
Hide


I'll leave in your capable hands then :)


Date: 2007-07-17 15:07:25 EDT
Sender: boomer70
Hide


I am not sure there is that much to discuss on experimental. This is more
of a code issue. The underlying problem here is that bonuses to the same
property (in this case crit) should be added together first before they are
added to the property. This doesn't generally happen in the code. The
code more often than simply adds the various bonuses sequentially. This is
only a problem when there is more than one way to bonus the same property
but that is common when it comes to combat related stuff.


Date: 2007-07-17 11:43:47 EDT
Sender: kariannaSourceForge.net DonorProject Admin & DonorAccepting Donations
Hide


Hey Aaron, I know we spoke over email about the BONUS re-write, is that
something still to be attempted? Is it something that should be hashed out
on experimental?


Date: 2007-02-22 09:45:13 EST
Sender: kariannaSourceForge.net DonorProject Admin & DonorAccepting Donations
Hide


OK, I'll put this for 6.0 then (or 5.14 if we decide to go there), thanks
Aaron.


Date: 2007-02-22 09:13:41 EST
Sender: boomer70
Hide


This does not require CDOM but it does require a complete rewrite of the
bonus code. I had started this but got overwhelmed by the scope of the
changes so I backed it out. This rewrite is currently 3rd or 4th on my
TODO list so it is unlikely to make 5.12 but I would expect it to beat
CDOM.


Date: 2007-02-22 07:53:59 EST
Sender: kariannaSourceForge.net DonorProject Admin & DonorAccepting Donations
Hide


Hey Aaron, is this something that's fixable now, or wait until after CDOM?
- K


Date: 2007-01-12 13:27:21 EST
Sender: kingpaulProject AdminAccepting Donations
Hide


No comment on this tracker for almost 10 months. Just seeing where it
currently stands.

Paul W. King
PR SB, BoD


Date: 2006-03-27 09:52:41 EST
Sender: boomer70
Hide

Logged In: YES
user_id=1249558

This will require a large code change and likely can't be
done for 5.10.


Date: 2005-12-06 08:22:51 EST
Sender: kariannaSourceForge.net DonorProject Admin & DonorAccepting Donations
Hide

Logged In: YES
user_id=252169

Mailing dev list for CM - K

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.pcgen.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira