[Pcgen-trackers] [JIRA] Created: (CODE-660) BONUS weight needs clarification if SELECT is used

[JIRA (f. D. R. B. ) <ji...@pc...>]

BONUS weight needs clarification if SELECT is used
--------------------------------------------------

                 Key: CODE-660
                 URL: http://jira.pcgen.org/browse/CODE-660
             Project: Code
          Issue Type: Bug
          Components: Needs Verification Review
            Reporter: David R. Bender
             Fix For: 6.0.x


SF ID: 2002030
Last Update: Settings changed ( thpr )
Details:

This interacts with the use of %LIST, but for non-%LIST BONUSes, I believe the weight of application of the BONUS is incorrect
Submitted:

Tom Parker ( thpr ) - 2008-06-24 16:44:52 EDT
Priority:

Status:

Resolution:

Tracker:

Assigned:

 (admin)
Category:

 (admin)
Group:

 (admin)
Visibility:

Private
Response:

 (admin)
Comment:



Comment ( 1 )
Add a comment

Date: 2009-03-07 21:47:50 EST
Sender: jdempseyProject Admin & Donor
Hide

[13:37] thpr: BONUS:Foo|%LIST|1
[13:37] thpr: is given once per choice
[13:37] thpr: which may be more than once per point if SELECT:2
[13:37] thpr: whereas BONUS:Foo|Bar|1
[13:37] thpr: would only be given once per time the Ability is taken
[13:37] thpr: regardless of SELECT
[13:38] thpr: the overall intent really needs to be validated - I think
what I quoted above is what people would expect
[13:39] james_dempsey_au: So if I have a SELECT:2 and I choose Climb and
Jump for an ability whch has BONUS: SKILL|%LIST|1
[13:39] james_dempsey_au: Then both skills would get a bonus of 2?
[13:39] thpr: no
[13:39] thpr: both skills get a bonus of 1
[13:39] thpr: but one has to apply the BONUS twice even though the Ability
was taken once
[13:40] thpr: whereas a BONUS:CHECK|Will|1 on the same line would only be
applied once
[13:40] thpr: even though the Ability has two choices associated with it
[13:40] james_dempsey_au: Yeah that sounds fine to me then
[13:41] james_dempsey_au: I'd expect that behaviour as I wouldn't expect
the choices to affect anything that didn't have the %LIST
[13:41] thpr: correct
[13:42] thpr: that's the intent
[13:42] james_dempsey_au: and the bug is then...
[13:42] thpr: I don't think that behavior is universal
[13:42] thpr: there are are handful of ways BONUSes are calculated
[13:43] thpr: and I think one path is good, and others are bad
[13:43] james_dempsey_au: right
[13:43] james_dempsey_au: but we don;t have a failing case currently?
[13:44] thpr: that was probably from me reading the code
[13:44] james_dempsey_au: yeah
[13:44] james_dempsey_au: Given the lack of a problem 'in the wild' I'll
push this back to 5.16.1 if you are ok with that?
[13:45] thpr: fine by me


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.pcgen.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira