Menu
▾
▴
[Pcgen-trackers] [ pcgen-Bugs-2059135 ] ABILITY lost capability to use SUBSET Ability Categories
|
From: SourceForge.net <no...@so...> - 2008-09-06 23:31:04
|
Bugs item #2059135, was opened at 2008-08-19 16:40 Message generated for change (Settings changed) made by jdempsey You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=384719&aid=2059135&group_id=25576 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. >Category: Feat Support Group: To be fixed For 5.16.0 >Status: Closed Resolution: Fixed Priority: 8 Private: No Submitted By: LegacyKing (amaitland) Assigned to: James Dempsey (jdempsey) Summary: ABILITY lost capability to use SUBSET Ability Categories Initial Comment: I'm trying to tackle a 'false' report for an unconstructed reference that is displaying and appearing to work. My two cases: Deity Gifted Willow Blade Free Feat Both have an entry in abilitycategory file, which is correctly referenced by a pcc being loaded. Both used CATEGORY:FEAT since they tied to an actual feat. At first I thought the issue was the fact I called it from a template file. But I've debunked that when I moved the call to an ability (but called the ability from a template) ABILITY:Deity Gifted|VIRTUAL|Weapon Focus(Sword (Bastard))|Dodge|Skill Focus(Balance) The above is an example, not the actual feats chosen. So, I'm considering that the unconstructed reference issue may be the fact it's calling via VIRTUAL instead of AUTOMATIC. The message for the unconstructed reference is the ACTUAL feats being called. And I know it works cause they ALL appear in the correct pool in the feats section as virtual feats. So, I'm calling this a strange bug (Everything appears to work, but the bug is the 'false' error report). ---------------------------------------------------------------------- >Comment By: James Dempsey (jdempsey) Date: 2008-09-07 09:31 Message: Logged In: YES user_id=558288 Originator: NO Fixed in http://pcgen.svn.sourceforge.net/pcgen/?rev=7659&view=rev The reference resolution code now knows that ability categories can have parent categories. ---------------------------------------------------------------------- Comment By: LegacyKing (amaitland) Date: 2008-09-02 04:36 Message: Logged In: YES user_id=1286039 Originator: YES Hi James, no apparent change after a rebuild. ---------------------------------------------------------------------- Comment By: James Dempsey (jdempsey) Date: 2008-09-01 23:03 Message: Logged In: YES user_id=558288 Originator: NO Committed a fix and a unit test in http://pcgen.svn.sourceforge.net/pcgen/?rev=7638&view=rev Could you check if this has fixed your issue please? ---------------------------------------------------------------------- Comment By: Tom Parker (thpr) Date: 2008-08-21 23:46 Message: Logged In: YES user_id=1037926 Originator: NO Using the definitions from here: http://tech.groups.yahoo.com/group/pcgen_experimental/message/10147 In the conversion to the new token, ABILITY lost the ability to process non-UNIVERSALSET Ability Categories, thus things like: ABILITY:Deity Gifted|VIRTUAL|Weapon Focus(Sword (Bastard)) Doesn't work in the code today because WeaponFocus SUPERKEY is FEAT not Deity Gifted ---------------------------------------------------------------------- Comment By: LegacyKing (amaitland) Date: 2008-08-21 13:29 Message: Logged In: YES user_id=1286039 Originator: YES I sent Tom the requested files. ---------------------------------------------------------------------- Comment By: Tom Parker (thpr) Date: 2008-08-21 08:38 Message: Logged In: YES user_id=1037926 Originator: NO Need data to be able to evaluate the source of the issue ---------------------------------------------------------------------- Comment By: Tom Parker (thpr) Date: 2008-08-21 01:13 Message: Logged In: YES user_id=1037926 Originator: NO Actually, just email me the data, please. "I know it works cause they ALL appear in the correct pool in the feats section as virtual feats." implies to me that the error isn't in the ABILITY call above, but somewhere else in the data. I need to see where these are being referred to, and exactly how, to establish which token is a problem. ---------------------------------------------------------------------- Comment By: Tom Parker (thpr) Date: 2008-08-21 01:06 Message: Logged In: YES user_id=1037926 Originator: NO can you also plug in one of your relevant lines from the abilitycategory file? thanks ---------------------------------------------------------------------- Comment By: LegacyKing (amaitland) Date: 2008-08-20 13:40 Message: Logged In: YES user_id=1286039 Originator: YES SEVERE Unconstructed Reference: Ability Willow Blade Free Feat Exotic Weapon Proficiency(Sword (Bastard)) SEVERE Unconstructed Reference: Ability Willow Blade Free Feat Powerful Two Weapon Fighting SEVERE Unconstructed Reference: Ability Willow Blade Free Feat Sword Wind SEVERE Unconstructed Reference: Ability Willow Blade Free Feat Weapon Focus(Sword (Bastard)) SEVERE Unconstructed Reference: Ability Deity Gifted Exotic Weapon Proficiency(Sword (Bastard)) SEVERE Unconstructed Reference: Ability Deity Gifted Strong Ally SEVERE Unconstructed Reference: Ability Deity Gifted Two Weapon Defense ---------------------------------------------------------------------- Comment By: Tom Parker (thpr) Date: 2008-08-20 12:37 Message: Logged In: YES user_id=1037926 Originator: NO Can you please provide the text PCGen spits out, as that may help diagnose the problem (what's the name of the object it doesn't think it can find?) ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=384719&aid=2059135&group_id=25576 |