From: SourceForge.net <no...@so...> - 2007-03-19 02:38:02
|
Bugs item #1681152, was opened at 2007-03-15 05:04 Message generated for change (Comment added) made by frank_kliewe You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=384719&aid=1681152&group_id=25576 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Feat Support Group: To be fixed For 5.12 Status: Open Resolution: None Priority: 5 Private: No Submitted By: Frank Kliewe (frank_kliewe) Assigned to: Nobody/Anonymous (nobody) Summary: ADD:FEAT won't work with only 1 feat to add Initial Comment: > the new ADD:FEAT acting up when only allowed to add 1 featThat is a bug that should be trackered against the choosers. The new token only changes the syntax; it uses the old LevelAbility code, so there should not be a difference in operation. > > -- > Tom Parker > Well, I tested and ADD:FEAT(blah) as well as ADD:FEAT(Blah)1 do work, while ADD:FEAT|blah and ADD:FEAT|1|blah do not work. Anyway, I'll enter a Bug for that. Cheerio, Frank Kliewe PCGen Content Silverback ---------------------------------------------------------------------- >Comment By: Frank Kliewe (frank_kliewe) Date: 2007-03-19 03:38 Message: Logged In: YES user_id=1241568 Originator: YES I think I found it. It happens when I put BONUSFEATLEVELSTARTINTERVAL:1|0 into miscinfo, I also get the following messages: java.lang.ArithmeticException: / by zero at pcgen.core.PlayerCharacter.getBonusFeatPool(PlayerCharacter.java:1612) at pcgen.core.PlayerCharacter.getRawFeats(PlayerCharacter.java:16322) at pcgen.core.PlayerCharacter.getFeats(PlayerCharacter.java:16304) at pcgen.gui.tabs.InfoClasses.updateCharacterInfo(InfoClasses.java:1495) at pcgen.gui.tabs.InfoClasses.forceRefresh(InfoClasses.java:298) at pcgen.gui.tabs.InfoClasses.refreshFiltering(InfoClasses.java:353) at pcgen.gui.filter.FilterFactory.restoreFilterSettings(FilterFactory.java:545) at pcgen.gui.tabs.InfoClasses.initActionListeners(InfoClasses.java:921) at pcgen.gui.tabs.InfoClasses.access$100(InfoClasses.java:124) at pcgen.gui.tabs.InfoClasses$1.run(InfoClasses.java:227) at java.awt.event.InvocationEvent.dispatch(Unknown Source) at java.awt.EventQueue.dispatchEvent(Unknown Source) at pcgen.gui.PCGen_Frame1$WaitCursorEventQueue.dispatchEvent(PCGen_Frame1.java:3287) at java.awt.EventDispatchThread.pumpOneEventForHierarchy(Unknown Source) at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source) at java.awt.EventDispatchThread.pumpEvents(Unknown Source) at java.awt.EventDispatchThread.pumpEvents(Unknown Source) at java.awt.EventDispatchThread.run(Unknown Source) java.awt.event.InvocationEvent[INVOCATION_DEFAULT,runnable=pcgen.gui.tabs.InfoClasses$1@14a0fe1,notifier=null,catchExceptions=false,when=1174271604531] on sun.awt.windows.WToolkit@132be10 -- Frank ---------------------------------------------------------------------- Comment By: Tom Parker (thpr) Date: 2007-03-19 03:04 Message: Logged In: YES user_id=1037926 Originator: NO One other thought here... if you have any CATEGORY:Foo items in Abilities and the associated ABILITYCATEGORY is not defined in the Game Mode, then all kinds of wonky things may happen - I was getting crashes all over the place when I tested your earlier copy of True20, which is why I added the debugging message to indicate when that masmatch occurred. ---------------------------------------------------------------------- Comment By: Tom Parker (thpr) Date: 2007-03-19 03:02 Message: Logged In: YES user_id=1037926 Originator: NO The String you're seeing is an accidental logging message I was using for debugging, I removed that in 2479 There WERE some other problems with the new syntax I fixed about the same time, thanks to zaister pointing them out. Perhaps I caught the issue you're seeing, since I'm running off the current build, and you may be using 5.11.9? So I suspect the only remaning issue is a GUI issue with True20? ---------------------------------------------------------------------- Comment By: Frank Kliewe (frank_kliewe) Date: 2007-03-19 02:45 Message: Logged In: YES user_id=1241568 Originator: YES Hm. What I see when I try to recreate this with our normal data, is those messages like FEAT(TYPE=Strong)1 showing up, where I do not know why they are being displayed (I could understand showing them for reference when the deprecated form is used, but why also for the normal form?), but the adding of the feats itself does seem to work. Since I can't recreate what I first described using our official data, that probably means what I experienced is something in the True20 gamemode. So this seems to be a different bug. In True20 I currently have 3 ABILITYCATEGORYs that use the CATEGORY:FEAT, each using different TYPEs (though some overlap). The new ADD:FEAT seems to be working wonky there as described above, and the normal Feats subtab doesn't display anything (not only the feats are missing, but the subtab itself only shows the tab header and builds up nothing, no right side for selected feats, info section or anything. It just stays empty. -- Frank ---------------------------------------------------------------------- Comment By: Tom Parker (thpr) Date: 2007-03-18 19:05 Message: Logged In: YES user_id=1037926 Originator: NO Frank, please provide more information on your concern here. This works for me, regardless of format, with one quirk: it will prompt, even if there is only one choice available to the user. Is suppressing the prompt when there is only one choice your intended request here? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=384719&aid=1681152&group_id=25576 |