From: SourceForge.net <no...@so...> - 2006-03-29 21:27:18
|
Bugs item #1227266, was opened at 2005-06-24 17:09 Message generated for change (Settings changed) made by boomer70 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=384719&aid=1227266&group_id=25576 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Feat Support Group: To be fixed For 5.10 >Status: Closed >Resolution: Fixed Priority: 9 Submitted By: JadeSteele (jadesteele) Assigned to: Aaron Divinsky (boomer70) Summary: MSRD: Exotic Melee Proficiency not working. Initial Comment: In the MSRD when trying to use Exotic Melee Proficiency (specifically Three-Section Staff but it does the same thing with other weapons as well), the selected weapon does not register as proficient in the inventory tab. After allocating the feat then saving and reloading, an error pops up saying the character is no longer proficient with "LIST". The feat dissapears and the feat point is not reallocated as usable (the character effectively loses one feat). ---------------------------------------------------------------------- >Comment By: Aaron Divinsky (boomer70) Date: 2006-03-29 16:27 Message: Logged In: YES user_id=1249558 This was fixed in 5.9.7. ---------------------------------------------------------------------- Comment By: Martijn Verburg (karianna) Date: 2005-12-14 03:36 Message: Logged In: YES user_id=252169 Same as my comments further below, you can 'fix' most of it with data (I mucked about with a few files), but it still would give the warning message below. I can only look into it further in the new year as I'm about to head off to Egypt. I _think_ to fix it 'properly' we'd need to fix a good deal of the weapon prof typing code. - K ---------------------------------------------------------------------- Comment By: Devon Jones (soulcatcher) Date: 2005-12-13 21:04 Message: Logged In: YES user_id=107647 Not to be fixed in 5.8.1 - only 5.9 line - kar, whats the situation with this in 5.9.x? ---------------------------------------------------------------------- Comment By: Martijn Verburg (karianna) Date: 2005-10-13 05:04 Message: Logged In: YES user_id=252169 Oh bollocks, I've been working on the wrong branch and can't access the 5.8.x branch (stupid Eclipse). The comments below relate to the code on the HEAD (5.9.x), which I'm told would be quite different to the 5.8.x code. Many apologies! - K ---------------------------------------------------------------------- Comment By: Martijn Verburg (karianna) Date: 2005-10-05 09:46 Message: Logged In: YES user_id=252169 Right, same comment as below except now we have the slightly better Exotic Melee Weapon Proficiency (as oppsoed to ExoticMelee) - K ---------------------------------------------------------------------- Comment By: Martijn Verburg (karianna) Date: 2005-09-26 06:08 Message: Logged In: YES user_id=252169 OK, I've locally changed the weapon Kama to be of Type ExoticMelee (as opposed to Exotic) and renamed "Exotic Melee Weapon Proficiency" to "ExoticMelee Weapon Proficiency". This fixes the problem, but a warning is always thrown because the Feat ExoticMelee Weapon Proficiency" is not an Auto Feat. I'm assuming that the code that would add the auto feat isn't working in this case. Again I'm looking further and again more comments are always welcome! K ---------------------------------------------------------------------- Comment By: Martijn Verburg (karianna) Date: 2005-09-22 05:08 Message: Logged In: YES user_id=252169 OK, the simple renaming didn't work, I'm looking further into Nuance's suggestion on adding a TYPE of ExoticMelee - K ---------------------------------------------------------------------- Comment By: Martijn Verburg (karianna) Date: 2005-09-21 04:50 Message: Logged In: YES user_id=252169 OK, once the build gets fixed I'm going to remove the AUTO:WEAPONPROF|LIST and rename it to Exotic_Melee Weapon Proficiency, if that does the trick, I'll pass it over to Data as discussed. K ---------------------------------------------------------------------- Comment By: Andrew Wilson (nuance) Date: 2005-09-20 11:21 Message: Logged In: YES user_id=41667 Do we really need a code fix for this? We could call the proficiency "ExoticMelee Weapon Proficiency" give it an outputname of "Exotic Melee Weapon Proficiency" and then add the type exoticmelee to the types. Does that not fix it without hacking the TYPE code so that it returns types that aren't there. I haven't tested this, I'm just asking. This is already a mess because it's getting meta information from the name. That put nasty constraints on what you can call things. I really think the long term solution to this lies in making the weapon proficiencies a specific category of Ability, or adding a new Tag that marks it as a weapon proficiency, or something else clever. ---------------------------------------------------------------------- Comment By: Martijn Verburg (karianna) Date: 2005-09-20 09:35 Message: Logged In: YES user_id=252169 Thanks James, I see it now, hmm, that's a nasty one, it does a getType() on the WeaponProf and gets EXOTIC back. I'll have to try and fiddle with that so it returns EXOTIC MELEE and EXOTIC FIREARM as well, this will be another day or so - K ---------------------------------------------------------------------- Comment By: James Dempsey (jdempsey) Date: 2005-09-20 08:11 Message: Logged In: YES user_id=558288 The code expects a specific format feat name. This is [ProfType] Weapon Proficiency. So if you rename the feat to Exotic Weapon Proficiency, it all works perfectly. See PlayerCharacter.addWeaponProfToList() at about line 12165 Cheers, James. ---------------------------------------------------------------------- Comment By: Martijn Verburg (karianna) Date: 2005-09-20 06:51 Message: Logged In: YES user_id=252169 Quite a bit of weirdness going on here. 1.) When adding the weapon prof, it seems to add it to the weapon prof list of the PC OK, and it sets the dirty flag to true, yet the old Abilities tab, doesn't have the weapon listed in there. Some how is dirty is not taking affect? 2.) I still see a difference in the way that Exotic Weapon Profs are coded in the list files, in MSRD there is a AUTO:WEAPONPROF|LIST attached to the Exotic Melee Weapon Proficiency. That does not exist in RSRD, however removing that part did not fix the problem. Subsequently reading the docs and checking the ability tab AUTO:WEAPONPROF|LIST basically adds a Weapon Prof called LIST, so I think this should still be removed. 3.) The pcg file definitely has the three-section staff, with the line: FEAT:Exotic Melee Weapon Proficiency|APPLIEDTO:Three-Section Staff|TYPE:BATTLEMIND.GENERAL.SHADOWSLAYER.SOLDIER.MARTIALARTIST|DESC:Choose one exotic melee weapon from. The character is proficient with that melee weapon in combat 4.) As a complete side note. The code base tends to refer to things that end in "Weapon Proficiency", not "Proficiency", so other feats that give Weapon Profs may be acting strangely. Hmm, that's about as far as I'm gonig to get today - K ---------------------------------------------------------------------- Comment By: Andrew McDougall (tir-gwaith) Date: 2005-09-16 18:58 Message: Logged In: YES user_id=208239 I've adjusted the file in MSRD to follow RSRD. Doesn't change the lack of proficiency display on inventory tab. Code bug definitely. I still think it is linked to having "Exotic" and "ExoticFirearms" as proficiencies and the code not really checking fully. ---------------------------------------------------------------------- Comment By: Andrew McDougall (tir-gwaith) Date: 2005-09-12 04:08 Message: Logged In: YES user_id=208239 Hm.... Crap, I hate the CHOOSEr. I'll look at it from a data perspective first. I still think there might be an code issue. ---------------------------------------------------------------------- Comment By: Martijn Verburg (karianna) Date: 2005-09-08 11:53 Message: Logged In: YES user_id=252169 Hi Tir, ignore my comment below (I think I got it wrong). _But_ the Exotic Weapon Prof in MRSD and RSRD are coded slightly differently, surely they should be coded in the same way? - K ---------------------------------------------------------------------- Comment By: Martijn Verburg (karianna) Date: 2005-09-08 11:45 Message: Logged In: YES user_id=252169 Exotic Firearms prof does _not_ work. I will look @ the code later, I assume it should work similar to exotic wepaon prof in RSRD in that it gives a hidden proficiency - K ---------------------------------------------------------------------- Comment By: Eddy Anthony (eddyanthony) Date: 2005-08-24 09:10 Message: Logged In: YES user_id=886893 flaging for 5.8.1 ---------------------------------------------------------------------- Comment By: Eddy Anthony (eddyanthony) Date: 2005-08-15 22:24 Message: Logged In: YES user_id=886893 I've been through the LST looking for a data reason this is broken but I can't find one. This feat is coded exactly like the Exotic Firearms Proficiency feat and that one works ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=384719&aid=1227266&group_id=25576 |