[Pcgen-trackers] [ pcgen-Bugs-1304156 ] Unarmed Damage wrong for creatures with size increases

[SourceForge.net <no...@so...>]

Bugs item #1304156, was opened at 2005-09-25 19:16
Message generated for change (Comment added) made by nuance
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=384719&aid=1304156&group_id=25576

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Equipment/Weaponprof Support
Group: 5.8.0 Stable
Status: Open
>Resolution: Fixed
Priority: 7
Submitted By: Eddy Anthony (eddyanthony)
Assigned to: Nobody/Anonymous (nobody)
Summary: Unarmed Damage wrong for creatures with size increases

Initial Comment:
I recently found out that when a creatures size increases due to 
additional hit dice or the use of BONUS:SIZEMOD the damage dice 
for their natural attacks is also increased proportionally. This is great 
because I thought this was a problem but I did find an error. When a 
Medium creature's size is increased to Large their unarmed damage 
goes up 2 steps (to 1d6) instead of 1 (1d4). I'm not sure if this is only 
unarmed damage or if this effects other weapons, I can't locate 
where this stepping is defined and I think it must be hardcoded. I did 
find that the unarmed damage comes out correct in version 5.6.1 and 
earlier but in the 5.7 line and after it always comes out to 1d6

----------------------------------------------------------------------

>Comment By: Andrew Wilson (nuance)
Date: 2005-09-30 01:22

Message:
Logged In: YES 
user_id=41667

src/java/pcgen/core/PCClass.java               1.686
src/java/pcgen/core/PlayerCharacter.java       1.1553
src/java/pcgen/io/exporttoken/WeaponToken.java 1.37
src/java/plugin/exporttokens/DamageToken.java  1.2

Made the adjustment by the PCClass optional.  Apply it when
called from the DamageToken, but not when called from
WeaponToken.

----------------------------------------------------------------------

Comment By: Greg Bingleman (byngl)
Date: 2005-09-30 00:11

Message:
Logged In: YES 
user_id=328527

Summary for someone else to fix. I don't want to mess 
around in here if I can avoid it...

pcgen.io.exporttoken.WeaponToken.getDamage
gets the damage for the unarmed weapon as 1d1
Then, in WeaponToken.getMonkUnarmed, because the 
unarmed weapon is a monk weapon and is an unarmed 
weapon, it gets the unarmed damage from the character via 
PlayerCharacter.getUnarmedDamageString, which returns 
1d4. (this already has the size increase taken into account). 
Now, because a d4 is larger than a d1, the 1d4 is again 
resized to 1d6.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=384719&aid=1304156&group_id=25576