Menu
▾
▴
[Pcgen-trackers] [ pcgen-Bugs-1305420 ] PRESKILL fails when Skill name uses spaces
|
From: SourceForge.net <no...@so...> - 2005-09-28 14:18:46
|
Bugs item #1305420, was opened at 2005-09-26 22:53 Message generated for change (Comment added) made by byngl You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=384719&aid=1305420&group_id=25576 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Other Group: 5.8.0 Stable Status: Open Resolution: None Priority: 7 Submitted By: Eddy Anthony (eddyanthony) Assigned to: Devon Jones (soulcatcher) Summary: PRESKILL fails when Skill name uses spaces Initial Comment: I have the following in a template file: BONUS:SKILLRANK|MySkill|1|!PRESKILL:1,MyOtherSkill=1 It works fine as long as there is not a space in the name of MyOtherSkill. However, if I change the skill name to MyOtherSkill<space>(MyOtherSubSkill), it quits working. Normally, I would wait several days before seeming impatient and bumping this up, but the bod minutes indicate that the window of opportunity to get this into 5.8.1 is closing very quickly. In addition to needing this for my home campaign, this fix would solve some issues with the T20 PCGen data (which is being written to work with the stable release). It could also be used in the rsrd by creating a Craft (Alchemy/Untrained) with VISIBLE:EXPORT that would display on gnome characters who don't have any ranks in Craft (Alchemy). I tried substituting {} in place of (), but it didn't work. If anyone has a work around, then I'd really like to see it. If not, then *PLEASE* try to work this bug fix into the 5.8.1 scope. ---------------------------------------------------------------------- >Comment By: Greg Bingleman (byngl) Date: 2005-09-28 10:18 Message: Logged In: YES user_id=328527 All the prereq stuff should be going through the same code, irregardless of the BONUS. Just tried this in 5.9.3 (added to srd_equip.lst) _test1 KnolHist[tab]TYPE:Goods[tab] PRESKILL:1,Knowledge (History)=1 _test1 Climb[tab]TYPE:Goods[tab]PRESKILL:1,Climb=1 and the prereqs appear to be working properly I then added these: _test2 KnolHist[tab]TYPE:Goods[tab] BONUS:SKILLRANK|Spellcraft|1|PRESKILL:1,Knowledge (History)=1 _test2 Climb[tab]TYPE:Goods[tab] BONUS:SKILLRANK|Spellcraft|1|PRESKILL:1,Climb=1 and both give the bonus when equipped. I could not get the templates to grant the bonus. ---------------------------------------------------------------------- Comment By: Devon Jones (soulcatcher) Date: 2005-09-27 12:31 Message: Logged In: YES user_id=107647 what about the fact that the onest that work are BONUS: SKILL and the ones that are failing use BONUS:SKILLRANK? Devon ---------------------------------------------------------------------- Comment By: Andrew McDougall (tir-gwaith) Date: 2005-09-27 12:26 Message: Logged In: YES user_id=208239 Looks right to me. You don't think Synergy TYPE stuff runs through a different channel than normal, do you? That would just freak me out. ---------------------------------------------------------------------- Comment By: Eddy Anthony (eddyanthony) Date: 2005-09-27 11:59 Message: Logged In: YES user_id=886893 the Knowledge Synergies apear to be working. Not sure whats going on so I tested (in templates) some varients of the tags he presented: BONUS:SKILLRANK|Spellcraft|1 Works. BONUS:SKILLRANK|Spellcraft|1|!PRESKILL:1,Knowledge (History)=1 BONUS:SKILLRANK|Spellcraft|1|PRESKILL:1,Knowledge (History)=1 BONUS:SKILLRANK|Spellcraft|1|!PRESKILL:1,Hide=1 BONUS:SKILLRANK|Spellcraft|1|PRESKILL:1,Hide=1 All fail. however this (the standard synergy bonus) works in a template: BONUS:SKILL|Spellcraft|2|PRESKILL:1,Knowledge (Arcana)=5|TYPE=Synergy.STACK I did not see any syntax issues, Tir how about you. ---------------------------------------------------------------------- Comment By: Andrew McDougall (tir-gwaith) Date: 2005-09-27 11:24 Message: Logged In: YES user_id=208239 I guess this means the Knowledge Synergies are broken in 5.8.0? For example, Spellcraft gets a +2 bonus from 5 ranks in Knowledge (Arcana) If that is the case, then, yes, this is a problem, with no real workaround other than a PREVARGTEQ:var ("SKILL.RANK.Knowledge (Arcana)"),5 or whatever. I wish that had been caught in the RC phase. It is probably something really simple. I know it was working in 5.7.x, and I think it is working in 5.9.x, since my Transmuter is working fine. ---------------------------------------------------------------------- Comment By: Devon Jones (soulcatcher) Date: 2005-09-27 10:40 Message: Logged In: YES user_id=107647 If there is no workaround for this, I consider this a genuine, problematic bug, likely one that is easily solved. Eddy, Tir, Can you guys determine if there is some potential work around for this? ---------------------------------------------------------------------- Comment By: Eddy Anthony (eddyanthony) Date: 2005-09-27 08:52 Message: Logged In: YES user_id=886893 OK let me clarify, this was requested for 5.8.1 by one of our users. I've set it to P7 for the 5.9 line and flagged Devon so he can consider the possibility of including it in 5.8.1. It's his call just like all the code bugs are. ---------------------------------------------------------------------- Comment By: Andrew McDougall (tir-gwaith) Date: 2005-09-27 04:06 Message: Logged In: YES user_id=208239 Man, if we are going to keep adding stuff, why don't we just use the 5.9 line???? ---------------------------------------------------------------------- Comment By: Eddy Anthony (eddyanthony) Date: 2005-09-26 22:56 Message: Logged In: YES user_id=886893 Here is a request for 5.8.1 inclusion. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=384719&aid=1305420&group_id=25576 |