Re: [OpenOCD-user] samd20 flash write bug via olimex-arm-jtag-swd

[Paul F. <fer...@gm...>]

Hi,

Thank you for your interest in OpenOCD.

On Thu, Aug 07, 2014 at 11:43:00AM +0400, Казьмин Андрей wrote:
> From: Andrej Kazmin <fun...@fu...>
> Date: Thu, 7 Aug 2014 10:49:12 +0400
> Subject: [PATCH] Samd20 flash write bug fixed
> 
> On samd20 we should wait for a short delay before check nvm status.
> It's because access through AHB is stalled while flash is programming.

...

The best course of action here would be for you to post this patch for
review to Gerrit as per instructions in HACKING. There it won't be
lost and will hopefully be reviewed by the devs who have samd
equipment.

If this is not an option for you, please resend the mail to the -dev
mailing list.

> @@ -448,6 +450,7 @@ static struct flash_sector *samd_find_sector_by_address(struct flash_bank *bank,
>  	return NULL;
>  }
>  
> +

Unrelated whitespace change here.

>  /* Write an entire row (four pages) from host buffer 'buf' to row-aligned
>   * 'address' in the Flash. */
>  static int samd_write_row(struct flash_bank *bank, uint32_t address,
> @@ -487,6 +490,7 @@ static int samd_write_row(struct flash_bank *bank, uint32_t address,
>  			return res;
>  		}
>  
> +		usleep (200);

This (including unistd.h for usleep) is not portable, see how other
OpenOCD code does delays (basically, autoconf + replacements).

-- 
Be free, use free (http://www.gnu.org/philosophy/free-sw.html) software!
mailto:fer...@gm...