From: Clément B. d. R. <cle...@hi...> - 2011-09-27 18:19:02
|
Hello Øyvind, I've prepared a new patch, fixing the memory issues. Regards, Clément On 09/21/2011 01:24 PM, Øyvind Harboe wrote: > It is looking much better. Some more comments: > > 1. I'd remove comments such as the below though. > > > + // Create the bank structure > + stm32lx_info = malloc(sizeof(struct stm32lx_flash_bank)); > + > + // Check allocation > + if (stm32lx_info == NULL) > > 2. Missing error check: > > target_read_u32 > > 3. missing error check: > > stm32lx_wait_until_bsy_clear > > > 4. Resource leakage: > > + // Lock back program memory > + retval = stm32lx_lock_program_memory(bank); > + if (retval != ERROR_OK) > + return retval; > + > + // Free the working areas > + target_free_working_area(target, source); > + target_free_working_area(target, stm32lx_info->write_algorithm); > + > + // Destroy the registers > + destroy_reg_param(®_params[0]); > + destroy_reg_param(®_params[1]); > + destroy_reg_param(®_params[2]); > + destroy_reg_param(®_params[3]); > + > + return retval; > +} > > 5. Bug: > > > + // Wait for busy clear > + retval = stm32lx_wait_until_bsy_clear(bank); > + return retval; > > > > -- Clément Burin des Roziers HiKoB http://openlab.hikob.com |