Menu
▾
▴
[ omegat-Bugs-1664523 ] FF character in license.txt
|
From: SourceForge.net <no...@so...> - 2007-02-21 13:41:25
|
Bugs item #1664523, was opened at 2007-02-21 02:34 Message generated for change (Comment added) made by brandelune You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=520347&aid=1664523&group_id=68187 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: documentation Group: None Status: Open Resolution: Fixed Priority: 5 Private: No Submitted By: smolejv (vitosmolej) Assigned to: Henry Pijffers (henry_pijffers) Summary: FF character in license.txt Initial Comment: in the l10n download 1.6.2_L10N_full the GNU license.txt file includes improper (unexpected) FF character at line 6700: "the Program is not required to print an announcement.) <FF> These requirements apply to the modified work as a whole. If <CrLf>" Once this segment has been read in, the translation memory is busted starting at the position of this segment and the parser stops at this spot, disregarding the rest of the memory. Workaround: Edit the source file and replace the Form Feed with new line character. Editing TM is (of course) just a temporary measure, until the said segment is seen again and the same thing happens. alternative: eliminate license.txt from sources altogether - afaik it stays in english anyhow. Reporting Vito Smolej ---------------------------------------------------------------------- >Comment By: Jean-Christophe Helary (brandelune) Date: 2007-02-21 22:41 Message: Logged In: YES user_id=915082 Originator: NO Regarding the FF character: it is not the source text itself that causes the sax error, it is _after_ project_save.tmx has included it from a translated source segment and when the project is reloaded. Then, and only then does OmegaT choke on the character. The error messages says that the character is found at such line of the project memory and refuses to load it further, which creates, when the faulty project is later saved a drasting reduction of the project tmx since only the segments loaded and the segments later translated while in the faulty project (if any) will be taken into account. This behaviour regarding overwriting a project_save.tmx with a more recent but much smaller file after a problem is consistent with the following bugs: 1583560, 1594483, 1627589. ---------------------------------------------------------------------- Comment By: Henry Pijffers (henry_pijffers) Date: 2007-02-21 22:24 Message: Logged In: YES user_id=545103 Originator: NO The l10n packages are available for download by the general public, and are not used just by the OmegaT "team". Providing packages to external parties such as translators counts as distribution. We'll just have to play by the rules. Otherwise we might as well argue that OmegaT itself is only distributed within our organisation, and that all users are part of our organisation. As for the bug, I guess I"ll just have to try and load the license text myself, to see the real problem. ---------------------------------------------------------------------- Comment By: Jean-Christophe Helary (brandelune) Date: 2007-02-21 21:34 Message: Logged In: YES user_id=915082 Originator: NO Regarding the "distribution" of the l10n package I think we can easily argue against that. It is considered (by the FSF) that use on an organization wide basis of a GPL software does _not_ constitute distribution and does not come with the requirement linked to distributing such files (access to source amd license copy). The l10n packages are internal packages and can be considered as for use only by localizers. The fact that they are available does not mean that they are distributed. As for the XML thing, I am sorry it is a misunderstanding since the problem on my side was that the TMX created from the faulty source files would not open and generated a SAX error. I think that is the biggest problem: that OmegaT puts invalid characters in the TMX. OmegaT does not choke on loading the source files, but on loading the TMX. ---------------------------------------------------------------------- Comment By: Henry Pijffers (henry_pijffers) Date: 2007-02-21 21:23 Message: Logged In: YES user_id=545103 Originator: NO I've already thought about removing the license text from the full l10n pack. Just moving it out of /source is a good idea, so we still keep the license in it. Actually, we should also put the license in the minimal pack, because we are required to provide a copy of the license with whatever we distribute. Regarding the other point: It's not SAX that chokes on it, it's not XML. It's a .txt file, so I guess OmegaT assumes it to be in the platform's default encoding. Perhaps FF characters aren't allowed in that encoding. I don't know the plain text filter, so I'm not sure whether OmegaT could be prevented from choking on it. ---------------------------------------------------------------------- Comment By: Jean-Christophe Helary (brandelune) Date: 2007-02-21 16:43 Message: Logged In: YES user_id=915082 Originator: NO I agree with Maxym on both points, problem is that the error is triggered by sax and not by OmegaT proper. Regarding the second item, removing the license (which is per definition _not_ localizable) but making sure that the text that introduces it (with a link to an official translation) is in the localization package would be a solution. ---------------------------------------------------------------------- Comment By: Maxym Mykhalchuk (mihmax) Date: 2007-02-21 16:17 Message: Logged In: YES user_id=488500 Originator: NO Henry, don't you think OmegaT should not choke on the character in question at all? And what about removing the license from 1.6.2_L10N_full. I mean moving one level up from /sources subdirectory so that OmegaT doesn't load it when loading full l10n project? ---------------------------------------------------------------------- Comment By: Henry Pijffers (henry_pijffers) Date: 2007-02-21 03:39 Message: Logged In: YES user_id=545103 Originator: NO Fixed, in CVS. Problematic characters removed. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=520347&aid=1664523&group_id=68187 |