Re: [MinGW-dvlpr] [Fwd: compiler fixup patch for cinstall && mingw && w32api. (whew) (pt1)]

[<dan...@ya...>]

 --- Earnie Boyd <ear...@ya...> wrote: > Danny,
> 
> Are these acceptable patches?
> 
> -- 
> Earnie.

> ATTACHMENT part 2 message/rfc822 
> Subject: compiler fixup patch for cinstall && mingw && w32api. (whew)
> (pt1)
> From: Robert Collins <rob...@it...>
> To: cyg...@cy...
> Date: 06 Nov 2001 01:42:06 +1100
> 
> This is not final yet, which is why there is no changelog and it's not
> split up for the various different lists yet.
> 
> Firstly: the mingw stuff. The following function returned the error
> "Is not a prototype"
> 
> Index: include/errno.h
> ===================================================================
> RCS file: /cvs/src/src/winsup/mingw/include/errno.h,v
> retrieving revision 1.1.1.1
> diff -u -p -r1.1.1.1 errno.h
> --- errno.h 2000/02/17 19:38:31 1.1.1.1
> +++ errno.h 2001/11/05 14:30:07
> @@ -104,7 +104,7 @@ extern "C" {
> #undef errno
> extern int errno;
> #else
> -int* _errno();
> +int* _errno(void);
> #define errno (*_errno())
> #endif

No problem. That has already been reported and I was going to commit
anyway.

> 
> Now, w32api. This fixes two functions defined w/o prototype errors, and
> a "partially bracketed initializer" for the _AUTHORITITY constants.
> 
> Index: include/winnt.h
> ===================================================================
> RCS file: /cvs/src/src/winsup/w32api/include/winnt.h,v
> retrieving revision 1.31
> diff -u -p -r1.31 winnt.h
> --- winnt.h 2001/11/01 19:42:56 1.31
> +++ winnt.h 2001/11/05 14:31:29
> @@ -267,12 +267,12 @@ typedef BYTE BOOLEAN,*PBOOLEAN;
> #define THREAD_ALL_ACCESS (STANDARD_RIGHTS_REQUIRED|SYNCHRONIZE|0x3FF)
> #define EXCEPTION_NONCONTINUABLE 1
> #define EXCEPTION_MAXIMUM_PARAMETERS 15
> -#define SECURITY_NULL_SID_AUTHORITY {0,0,0,0,0,0}
> -#define SECURITY_WORLD_SID_AUTHORITY {0,0,0,0,0,1}
> -#define SECURITY_LOCAL_SID_AUTHORITY {0,0,0,0,0,2}
> -#define SECURITY_CREATOR_SID_AUTHORITY {0,0,0,0,0,3}
> -#define SECURITY_NON_UNIQUE_AUTHORITY {0,0,0,0,0,4}
> -#define SECURITY_NT_AUTHORITY {0,0,0,0,0,5}
> +#define SECURITY_NULL_SID_AUTHORITY {{0,0,0,0,0,0}}
> +#define SECURITY_WORLD_SID_AUTHORITY {{0,0,0,0,0,1}}
> +#define SECURITY_LOCAL_SID_AUTHORITY {{0,0,0,0,0,2}}
> +#define SECURITY_CREATOR_SID_AUTHORITY {{0,0,0,0,0,3}}
> +#define SECURITY_NON_UNIQUE_AUTHORITY {{0,0,0,0,0,4}}
> +#define SECURITY_NT_AUTHORITY {{0,0,0,0,0,5}}
> #define SECURITY_NULL_RID 0
> #define SECURITY_WORLD_RID 0
> #define SECURITY_LOCAL_RID 0


No problem.  


> @@ -2524,6 +2524,7 @@ typedef struct _REPARSE_POINT_INFORMATIO
> WORD   ReparseDataLength;
> WORD   UnparsedNameLength;
> } REPARSE_POINT_INFORMATION, *PREPARSE_POINT_INFORMATION;
> +PVOID GetCurrentFiber(void);
> extern __inline__ PVOID GetCurrentFiber(void)
> {
>      void* ret;
> @@ -2534,7 +2535,7 @@ extern __inline__ PVOID GetCurrentFiber(
> );
>      return ret;
> }
> -
> +PVOID GetFiberData(void);
> extern __inline__ PVOID GetFiberData(void)
> {
>      void* ret;
> 
> 

Already committed.


> and now for... cinstall ... evolution isn't letting me add all the
> files... so heres pt1
> 

The rest doesn't affect mingw.

http://briefcase.yahoo.com.au - Yahoo! Briefcase
- Manage your files online.