[MinGW-notify] [ mingw-Patches-3447137 ] lib/directx/Makefile.in

[SF/projects/mingw n. l. <min...@li...>]

Patches item #3447137, was opened at 2011-12-01 06:55
Message generated for change (Comment added) made by keithmarshall
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=302435&aid=3447137&group_id=2435

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: w32api
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Earnie Boyd (earnie)
Assigned to: Chris Sutcliffe (ir0nh34d)
Summary: lib/directx/Makefile.in

Initial Comment:
I was unable to build w32api from CVS without this attached patch.  The windows.h file was not found.  The patch adds $(srcdir)/../../include to the INCLUDES variable in lib/directx/Makefile.in file.

----------------------------------------------------------------------

>Comment By: Keith Marshall (keithmarshall)
Date: 2011-12-04 02:49

Message:
Hmm.  That doesn't look quite right.

I have a big hit list of issues which need addressing, for the build
systems of both mingwrt ans w32api; maybe I should take a brief rest from
mingw-get, and fix them?  Here's just the tip of the iceberg:--

1) I'm wondering if we need a --with-mingwrt-srcdir option to w32api's
configure, complementary to the --with-w32api-srcdir patch I posted
recently for mingwrt; the mingw case 'EXTRA_INCLUDES =
-I$(srcdir)/../../mingw/include' surely isn't correct.

2) In both INCLUDES and EXTRA_INCLUDES, surely those $(srcdir)/...
references should be resolved relative to $(top_srcdir)

3) w32api distributes a humongous aclocal.m4 file; not even a single line
of it is remotely relevant to the package.

and the list goes on...

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=302435&aid=3447137&group_id=2435