From: SF/projects/mingw n. l. <min...@li...> - 2011-11-14 20:50:59
|
Bugs item #3437558, was opened at 2011-11-13 15:23 Message generated for change (Comment added) made by earnie You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=102435&aid=3437558&group_id=2435 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: w32api Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Yuji Kuwabara (yujikuwabara) Assigned to: Chris Sutcliffe (ir0nh34d) Summary: Trivial error in amvideo.h Initial Comment: In amvideo.h, comma is used where semicolon should be used. typedef struct tagVIDEOINFO { RECT rcSource, RECT rcTarget, DWORD dwBitRate, DWORD dwBitErrorRate, REFERENCE_TIME AvgTimePerFrame; BITMAPINFOHEADER bmiHeader; union { RGBQUAD bmiColors[256]; DWORD dwBitMasks[3]; TRUECOLORINFO TrueColorInfo; }; } VIDEOINFO; ---------------------------------------------------------------------- >Comment By: Earnie Boyd (earnie) Date: 2011-11-14 12:50 Message: DirectDraw is a bit more difficult, i.e. there is more than one header needed. http://msdn.microsoft.com/en-us/library/windows/hardware/ff552933(v=vs.85).aspx In comparison to DirectSound http://msdn.microsoft.com/en-us/library/windows/desktop/ee416960(v=VS.85).aspx ---------------------------------------------------------------------- Comment By: Earnie Boyd (earnie) Date: 2011-11-14 12:45 Message: We have w32api/include/directx directory. Should dsound.h go there or in w32api/include? http://msdn.microsoft.com/en-us/library/windows/desktop/ee416976(v=VS.85).aspx ---------------------------------------------------------------------- Comment By: Chris Sutcliffe (ir0nh34d) Date: 2011-11-14 11:52 Message: Agreed. Unless someone is willing to provide a patch to include dsound.h and ddraw.h, I will pull this header file. ---------------------------------------------------------------------- Comment By: Earnie Boyd (earnie) Date: 2011-11-14 11:23 Message: And amaudio.h include dsound.h which also doesn't exist. What's the point of having an unusable header? ---------------------------------------------------------------------- Comment By: Earnie Boyd (earnie) Date: 2011-11-14 04:56 Message: Well, ddraw.h is included by amvideo.h so if it isn't provided we don't need to be providing amvideo.h. ---------------------------------------------------------------------- Comment By: Chris Sutcliffe (ir0nh34d) Date: 2011-11-14 04:51 Message: @Yuji, thank you for the heads up, I will fix the issue in CVS later this week. @Earnie, are you suggesting to add ddraw.h (as it is not in CVS currently)? ---------------------------------------------------------------------- Comment By: Earnie Boyd (earnie) Date: 2011-11-14 04:45 Message: And ddraw.h is missing from the current distribution. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=102435&aid=3437558&group_id=2435 |