From: Charles W. <cwi...@us...> - 2010-06-10 00:47:11
|
On 6/8/2010 2:22 AM, Erwin Waterlander wrote: > Erwin Waterlander schreef, Op 6-6-2010 21:51: >> Good point. I changed the script and uploaded new packages. >> I'm using the temp path directly in $prefix. PDCurses isn't using any >> prefix information. >> >> > I uploaded new files. The only thing that changed is the release notes file. Looks pretty good. I was able to rebuild from source and generate all the specified output files. The test programs all seemed to work (although -- and this is not something you need to fix -- CTRL-C couldn't kill them. I had to use 'kill' from another window). I'm impressed that you didn't need to patch PDCurses at all in order to build the mingw version. However...there are a few minor issues. Not that it matters on MinGW, but in general DLLs should be marked executable. So, I've modified your mingw-build.sh to do that. I also noticed that you are installing the DLL into both bin/ and lib/libfoo.dll.a. This mostly works, given GNU binutils' ability to link-directly-to-a-DLL. However, the "proper" way to do it is to generate an "import lib" and install THAT as lib/libfoo.dll.a. Fortunately, the build procedure already creates one. It's called "pdcurses.a" in all three DLL builds. I've patched your mingw-build.sh to take care of that. Also, I think it would be nice if the test/demo programs were included, so that people could verify that their DLL was working (and so you, when people inevitably ask questions, can have them attempt to run those test progs as part of assisting them). I've modified your mingw-build.sh to install the dynamically-linked versions of all of the test/demo programs into lib/pdcurses/test lib/pdcurses/testu lib/pdcurses/testw directories, and to package those as "PDCurses-3.4-1-mingw32-bin.tar.lzma" The patch is attached, and addresses all of the above. -- Chuck |