Menu
▾
▴
[Mingw-notify] [ mingw-Patches-2009559 ] @CFLAGS@ not substituted in Makefiles
|
From: SourceForge.net <no...@so...> - 2009-07-19 14:03:03
|
Patches item #2009559, was opened at 2008-07-03 09:43 Message generated for change (Comment added) made by keithmarshall You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=302435&aid=2009559&group_id=2435 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: runtime Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Gregory McGarry (gregorymcgarry) Assigned to: Keith Marshall (keithmarshall) Summary: @CFLAGS@ not substituted in Makefiles Initial Comment: This patch substitutes @CFLAGS@ in the Makefile, which otherwise doesn't work. This patch modifies: mingwex/configure.in profile/configure.in But it is probably easier to remove the configure scripts from these directories and update the makefiles using the master configure.in. ---------------------------------------------------------------------- >Comment By: Keith Marshall (keithmarshall) Date: 2009-07-19 14:03 Message: > Is this patch OK to commit to CVS? I don't know. I'm still waiting for confirmation that it doesn't break anything on the Cygwin side. That said, those who may care have had ample opportunity to respond, so maybe I should just go ahead regardless? ---------------------------------------------------------------------- Comment By: Chris Sutcliffe (ir0nh34d) Date: 2009-07-18 14:50 Message: Is this patch OK to commit to CVS? ---------------------------------------------------------------------- Comment By: Keith Marshall (keithmarshall) Date: 2008-10-31 20:26 Message: Alternative proposed patch attached for review. This works for me, but please check suitability when integrated into a Cygwin build. It is against CVS as of 30-Oct-2008, but excludes the regenerated configure script; please run autoconf, after applying. File Added: mingwrt-3.15.1-20081030-1.diff ---------------------------------------------------------------------- Comment By: Keith Marshall (keithmarshall) Date: 2008-10-25 22:59 Message: The defects are actually much more pervasive than just missing CFLAGS substitution. IMO, dispensing with separate configuration in the subdirectories is the right way to proceed. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=302435&aid=2009559&group_id=2435 |