From: JonY <10...@gm...> - 2009-03-06 10:35:57
|
On 3/6/2009 05:54, Nicola Di Nisio wrote: > On Thursday 05 March 2009 16:58:07 JonY wrote: >> On 3/5/2009 08:56, Nicola Di Nisio wrote: >>> On Thursday 05 March 2009 01:05:14 JonY wrote: >>>> Hi, >>>> Readline-6.0 works for me on MinGW and MSYS (yes, MSYS build). sgtty.h >>>> is now included optionally, only when NEW_TTY_DRIVER is defined. >>> Which version of MinGW have you used? >>> With the cross compiler (v3.4.5 and v4.2.1-sjlj) I get this error >>> >>> signals.c:595: error: `SIGQUIT' undeclared (first use in this >>> function) >>> >>> One strange thing I noted during configure time tough is that >>> cross-compilation is not detected, even though I have >>> specified --host=mingw32 and it detects it... >>> >>> checking for mingw32-gcc... mingw32-gcc >>> checking for C compiler default output file name... a.exe >>> checking whether the C compiler works... yes >>> checking whether we are cross compiling... no >> Hi, >> >> Sorry, I just remembered that I removed SIGQUIT line. IIRC, it was >> checking for that signal, its not needed on Windows. I also modified the >> headers to use dllimport. > > Is your patch planned for inclusion in next release of readline? > > > Hi, Unfortunately at its current state, no, sorry. This is due to 3 reasons: 1. Intrusive MinGW specific hacks. I prefer using dlls over static libs. This causes lots of auto-import warnings, fixed by adding some dllimport attribute and ifdefs. 2. Currently builds with minor code workarounds. Removing code that will not work under Win32 such as checking for SIGQUIT, I did not use any notable workarounds to replace them. 3. No formal testing has been done. Nearly all example apps build and run. That doesn't mean its safe for general consumption. I have yet to study readline due to time constraints. I'm sure I'll get a really long lecture if I posted such a carefree workaround patch to the readline devs list. |