From: Keith M. <kei...@us...> - 2008-09-02 19:50:39
|
On Tuesday 02 September 2008 16:18:01 Chris Sutcliffe wrote: > > Fair enough, seems like we have consensus on a new naming > > convention. I assume then, that w32api should become > > > > w32api-3.12-mingw32-dev.tar.gz? Yes, IMO it should. > I've locally modified the Makefile.in to include $(target_alias) as > part of the tarball name (using > $(PACKAGE)-$(VERSION)-$(target_alias)-dev.tar.gz) which gives: But you have no *legitimate* reason to expect that $(target_alias) would represent anything other than an empty string. Used correctly, $(target_anything) is relevant only when building a code generator; there is no code generator in w32api, (or in runtime). Existing use of $(target_anything) in the Makefiles of each of these is just plain wrong -- they need to be fixed. > w32api-3.12-i386-pc-mingw32-dev.tar.gz That is substituting the entire (inappropriately specified) target triplet; what is really required is $(host_os), which should resolve to `mingw32', for the mingw32 host. > Is this appropriate, No. > or do we want to hard code it to the proposed naming convention? For now, to get an immediate release out of the door, code it as $(PACKAGE)-$(VERSION)-$(host_os)-dev.tar.gz and, if it isn't already defined, (which it doesn't appear to be), add # FIXME: this needs an appropriate AC_SUBST host_os = mingw32 to Makefile.in, (and to your local working Makefile, if you don't want to reconfigure, or at least run config.status), and we'll try to fix it properly in time for the next release.[*] Regards, Keith. [*] I don't want to rush into this. There will inevitably be an impact on Cygwin, (which is probably broken itself, because AFAICT the inappropriate usage of $(target_alias) originates there), so we need to ensure that we DTRT wrt their build system. |