[Mingw-notify] [ mingw-Patches-2010966 ] Fix stdlib.h:strtod() definition for C89

[SourceForge.net <no...@so...>]

Patches item #2010966, was opened at 2008-07-04 18:30
Message generated for change (Comment added) made by gregorymcgarry
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=302435&aid=2010966&group_id=2435

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Danny Smith (dannysmith)
Assigned to: Nobody/Anonymous (nobody)
Summary: Fix stdlib.h:strtod() definition for C89 

Initial Comment:
With current CVS, the use of 'inline' function to define strtod() in stdlib.h causes failure with -ansi or -std=c89

 
> gcc -c -x c  -ansi stdlib.h

C:\develop\cvs\winsup\src\winsup\mingw\include>gcc -c -x c  -ansi stdlib.h 
stdlib.h:318: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'double'

'inline' is not a keyword in c89.

This fixes by replacing with gnu extension __inline__
OK to commit?

Danny

	* include.stdlib.h (strtod) [!__cplusplus]:  Replace 'inline'
	with '__inline__'

Index: include/stdlib.h
===================================================================
RCS file: /cvs/src/src/winsup/mingw/include/stdlib.h,v
retrieving revision 1.35
diff -r1.35 stdlib.h
313a314
> inline
315c316
< static
---
> static __inline__
317c318,319
< inline double __cdecl __MINGW_NOTHROW strtod (const char* __restrict__ __nptr, char** __restrict__ __endptr)
---
> double __cdecl __MINGW_NOTHROW strtod (const char* __restrict__ __nptr,
> 				       char** __restrict__ __endptr)

----------------------------------------------------------------------

Comment By: Gregory McGarry (gregorymcgarry)
Date: 2008-07-06 07:51

Message:
Logged In: YES 
user_id=2134462
Originator: NO

__inline__ is a gcc extension.  inline is c99 and not available in c89.

The proper solution is not to leak inline declarations on pre-c99 ansi
compilers.



----------------------------------------------------------------------

Comment By: Keith Marshall (keithmarshall)
Date: 2008-07-05 16:54

Message:
Logged In: YES 
user_id=823908
Originator: NO

Two comments:--

1) _mingw.h already has _CRT_INLINE.  Will that not suffice here?  If not,
it would make sense to #define say _STATIC_INLINE within the same #if block
as _CRT_INLINE, which is effectively `extern __inline__' for the GCC
non-c++ case.

2) Since MinGW headers are primarily intended for use with GCC, #defines
should favour GCC syntax, i.e. `__inline__' in this case; for support of
other compilers, would it not be better if _mingw.h conditionally #defines
`__inline__' using whatever idiom is appropriate, in each individual case?


----------------------------------------------------------------------

Comment By: Chris Sutcliffe (ir0nh34d)
Date: 2008-07-05 10:31

Message:
Logged In: YES 
user_id=570619
Originator: NO

I think that would work nicely.  For __GNUC__ shouldn't it be __inline__?

i.e.

...
#ifdef __GNUC__
#define __INLINE __inline__
#else
...


----------------------------------------------------------------------

Comment By: Danny Smith (dannysmith)
Date: 2008-07-05 05:29

Message:
Logged In: YES 
user_id=11494
Originator: YES

__inline__ is GCC-specific.  MSVCRT uses __inline spelling. I don't know
what PCC says about 'inline' or '__inline__' or __inline in strict C89
mode.

How about, in __mingw.h

#ifndef __INLINE
#if define __cplusplus \
   || (defined (__STDC_VERSION__) && __STDC_VERSION__ >= 199901L)
#define __INLINE inline
#else 
#ifdef __GNUC__
#define __INLINE __inline
#else
#define __INLINE inline
#endif   /* __GNUC__ */
#endif  /* __cplusplus  || __STDC_VERSION__ >= 199901L */ 
#endif  /*  __INLINE  */


and use __INLINE throughout for 'inline'

----------------------------------------------------------------------

Comment By: Chris Sutcliffe (ir0nh34d)
Date: 2008-07-04 20:05

Message:
Logged In: YES 
user_id=570619
Originator: NO

Looks fine to me.  Is __inline__ GCC specific?  The only reason I ask is
there are other patches (non-committed) to allow mingw-runtime to compile
with PCC.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=302435&aid=2010966&group_id=2435