Re: [Mingw-users] Porting texinfo-4.3 to MingW

[Earnie B. <ear...@ya...>]

Chris Marshall wrote:
> While trying to compile texinfo-4.3, I received the following error:
> 
> c:/src/texinfo-4.3/lib/tempname.c: In function `__gen_tempname':
> c:/src/texinfo-4.3/lib/tempname.c:308: too many arguments to function 
> `mkdir'
> 
> So, I looked into the definition of mkdir in io.h, and I decided to make 
> the following change to tempname.c of the texinfo-4.3:
> 
> -----------cut here----------cut here------------cut here------------
> 
> // Change added by Chris Marshall on 25 November 2002 to accomodate 
> MingW definition of mkdir
> #ifndef __MINGW_H
>       fd = __mkdir (tmpl, S_IRUSR | S_IWUSR | S_IXUSR);
> #else
>       fd = __mkdir (tmpl);
> #endif
> 
> -----------cut here----------cut here------------cut here------------
> 
> Can someone let me know if this is the correct way to make such a change?
> 

I prefer to do the following in a common header file:

#ifdef _WIN32
# define __mkdir(a,b) __mkdir(a)
#endif

Earnie.

P.S.: Your change doesn't need to be MinGW specific.
P.P.S.: You would use __MINGW32__ for MinGW specific filtering.