From: SourceForge.net <no...@so...> - 2007-06-04 21:46:53
|
Patches item #1729798, was opened at 2007-06-02 03:44 Message generated for change (Comment added) made by keithmarshall You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=302435&aid=1729798&group_id=2435 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: msys Group: Patch needs review Status: Open Resolution: None Priority: 5 Private: No Submitted By: James Darpinian (jdarpinian) >Assigned to: Cesar Strauss (cstrauss) Summary: fix fork() crash on Vista x64 Initial Comment: MSYS programs crash when calling fork() on Vista 64. This patch was posted by Oscar Bonilla and modified slightly by me to fix a problem with exceve(). It fixes the crash by filling out a size field in a structure passed to child processes. ---------------------------------------------------------------------- >Comment By: Keith Marshall (keithmarshall) Date: 2007-06-04 21:46 Message: Logged In: YES user_id=823908 Originator: NO This is effectively a duplicate of bug #1674783, which also has a similar patch attached. There are differences, however, particularly in the computation of the size field to be filled in for Vista. Given the level of discussion which has followed the #1674783 bug, I'd tend to favour its associated patch. In any case, the two should be rationalised into a single agreed solution. I would point out that neither patch could be considered `ready to commit', since neither is accompanied by a properly formatted ChangeLog; this needs to be provided, before any patch can be committed. ---------------------------------------------------------------------- Comment By: Earnie Boyd (earnie) Date: 2007-06-02 18:23 Message: Logged In: YES user_id=15438 Originator: NO You submit patches for reviewing. Once reviewed they can be mared for ready to be committed. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=302435&aid=1729798&group_id=2435 |