Menu
▾
▴
[Mingw-notify] [ mingw-Bugs-1685801 ] inline attributes are set incorrectly in _mingw.h
|
From: SourceForge.net <no...@so...> - 2007-03-22 09:41:53
|
Bugs item #1685801, was opened at 2007-03-22 20:17 Message generated for change (Comment added) made by dannysmith You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=102435&aid=1685801&group_id=2435 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: mingw runtime >Group: IINR - Include In Next Release >Status: Closed >Resolution: Fixed Priority: 5 Private: No Submitted By: Brian Ripley (ripleybd) Assigned to: Nobody/Anonymous (nobody) Summary: inline attributes are set incorrectly in _mingw.h Initial Comment: I believe the attached patch is needed to include/_mingw.h in mingw-runtine-3.11. This arose in testing the build of gcc (GCC) 4.3.0 20070315 (experimental) available from http://gcc.gnu.org/wiki/GFortranBinaries with -std=gnu99: any non-trivial project (e.g. R, www.r-project.org) gives rise to hundreds of multiple definitions. There are two issues: 1) the documented attribute in the .texi files is 'gnu_inline' and not '__gnu__inline__' (and the doubled middle underscore seems a typo). 2) One can modify the behaviour of gcc via flags such as -fgnu89-inline, so it is not sufficient to check the gcc version and C status. There is a gcc macro (said to be available from gcc 4.1.3) that is defined when C99 inline semantics are in force, and only then does mingw-runtime need switching to the older GNU semantics for inline. According to the .texi files, the macro is only defined when the attribute is available, so no other version test is needed. (We are talking about unreleased versions of gcc, though, but this seems unlikely to change.) ---------------------------------------------------------------------- >Comment By: Danny Smith (dannysmith) Date: 2007-03-22 21:41 Message: Logged In: YES user_id=11494 Originator: NO Thanks. The typo had already been corrected in CVS, but I've committed the second change ie, condition on #if __GNUC_STDC_INLINE__. Danny ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=102435&aid=1685801&group_id=2435 |