Re: [MinGW-dvlpr] [PATCH 0/4] Updates for cross-compiler build scripts

[Keith M. <kei...@us...>]

On Sat, 2007-10-27 at 13:18 +0200, Michael Gerdau wrote:
> I have prepared a couple of patches for xscripts which I'm mailing to
> you as answers to this email.

Michael,

I've granted you commit access for the xscripts module in CVS; with
minor reservations, I'm happy for you to check these in yourself.

My reservations?

[PATCH 2/4] defeats the logic already present in x86-mingw32-build.sh
to set the default `TARGET=i386-mingw32', which may be overridden by
specifying an alternative on the command line.  If a user wants to set a
different default in his local x86-mingw32-build.sh.conf, that's fine,
but I don't think it should be predefined in the downloadable copy.
Maybe add a commented-out `assume', with an explanatory comment?
Similarly for `TARGET_CPU'?

In [PATCH 4/4], you've introduced some very long lines of shell script.
Please fold these to a saner maximum limit.  (I like to try to keep line
length to 80 chars, or less; 85 chars is about the maximum which can be
comfortably accommodated within the width of an A4 page, when printing
at 12-CPI through `lpr', with `pr' as the output filter).

Thanks,
Keith.