From: Paul R. <pa...@ma...> - 2014-01-27 22:56:45
|
Following this commit, I've logged an issue into the bugtracker ( http://www.mantisbt.org/bugs/view.php?id=16894 ) We now accept an email address such as fred@localhost as a valid email address for users. TBH, we shouldn't accept non-routable email addresses if email validation is on. If a user wants/needs to allow non-routable email addresses they can always turn off the validation functionality. Given that PHP contains an api function to validate an email address, I believe we should make us of that function. If not, I suggest we make a config option to allow users to choose to use the functionality provided within php itself, as opposed to a custom implementation. ---------- Forwarded message ---------- From: GitHub <no...@gi...> Date: Mon, Jan 27, 2014 at 11:32 AM Subject: [mantisbt-commits] [mantisbt/mantisbt] 86d30e: Whitespace [skip ci] To: man...@li... Branch: refs/heads/master Home: https://github.com/mantisbt/mantisbt Commit: 86d30ed01e555ab108b7205f0ad67da1d70a4621 https://github.com/mantisbt/mantisbt/commit/86d30ed01e555ab108b7205f0ad67da1d70a4621 Author: Damien Regad <dr...@ma...> Date: 2014-01-27 (Mon, 27 Jan 2014) Changed paths: M core/print_api.php Log Message: ----------- Whitespace [skip ci] Remove blank lines added in a6a3a136bd05df52f1ea4dd906230ac9ae9d9cad Commit: 50d235ad101f61a6c6888316e827fd225ad4b9cd https://github.com/mantisbt/mantisbt/commit/50d235ad101f61a6c6888316e827fd225ad4b9cd Author: Damien Regad <dr...@ma...> Date: 2014-01-27 (Mon, 27 Jan 2014) Changed paths: M core/email_api.php Log Message: ----------- Revert of "Use PHP's own email validation routines" This partially reverts commit 4235a08618da1d66b44337867b72f4fdea633dc0 which introduced a regression. The PHP email validation rejects valid e-mail addresses with the form user@hostname [1]. The PHPMailer accepts these, and furthermore it makes sense to rely on the validation routine provided by the library we use to send our emails. [1] https://bugs.php.net/bug.php?id=49576 Compare: https://github.com/mantisbt/mantisbt/compare/4ef130e5e84f...50d235ad101f ------------------------------------------------------------------------------ CenturyLink Cloud: The Leader in Enterprise Cloud Services. Learn Why More Businesses Are Choosing CenturyLink Cloud For Critical Workloads, Development Environments & Everything In Between. Get a Quote or Start a Free Trial Today. http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk _______________________________________________ mantisbt-cvs mailing list man...@li... https://lists.sourceforge.net/lists/listinfo/mantisbt-cvs |
From: Damien R. <dr...@ma...> - 2014-01-28 09:51:28
|
Paul Richards <paul@...> writes: > > Following this commit, I've logged an issue into the bugtracker ( http://www.mantisbt.org/bugs/view.php?id=16894 ) I replied in the Mantis issue. |