jl...@us... wrote: > Update of /cvsroot/mantisbt/mantisbt > In directory sc8-pr-cvs1:/tmp/cvs-serv31428 > > Modified Files: > account_page.php bug_report_advanced_page.php > bug_report_page.php bug_update_advanced_page.php > bug_update_page.php bug_view_advanced_page.php > bug_view_inc.php bug_view_page.php bugnote_inc.php > manage_custom_field_edit_page.php manage_proj_edit_page.php > print_all_bug_options_inc.php print_all_bug_options_reset.php > print_all_bug_page.php print_all_bug_page_excel.php > print_all_bug_page_word.php print_bug_page.php > print_bugnote_inc.php proj_doc_add.php proj_doc_add_page.php > proj_doc_edit_page.php proj_doc_page.php proj_user_add.php > proj_user_copy.php proj_user_delete.php > proj_user_menu_page.php set_project.php signup.php > summary_graph_bycategory.php summary_graph_bycategory_pct.php > summary_graph_bydeveloper.php summary_graph_bypriority.php > summary_graph_bypriority_mix.php > summary_graph_bypriority_pct.php summary_graph_byreporter.php > summary_graph_byresolution.php > summary_graph_byresolution_mix.php > summary_graph_byresolution_pct.php > summary_graph_byseverity.php summary_graph_byseverity_mix.php > summary_graph_byseverity_pct.php summary_graph_bystatus.php > summary_graph_bystatus_pct.php > summary_graph_cumulative_bydate.php view_all_bug_page.php > view_all_inc.php > Log Message: > Two changes: > 1. Added require_once lines for files starting with p and higher. > 2. Reformatted the source for spacer TD cells, so that my editor won't mess them up again. > Ugh, I hate mixing formatting changes with code changes. These particular formatting changes revert changes I made when cleaning up those files to make the blank cells as clear as possible. I find <td class="spacer" colspan="2"> </td> looks significant during a quick visual scan whereas <td class="spacer" colspan="2"> </td> Is immediatley apparent as something to be skimmed over. Again, I don't mind discussing this and certainly won't force it if others disagree, but nobody complained at the time, and making changes just to suit an editor seems wrong (we could just leave some of the files in CR/LF since my editor likes to create new files that way). My main problem is that if we chose to revert these formatting changes, we can't easily do so because they are mixed in with a commit that made necessary code changes. So this both a friendly reminder about commiting formatting changes mixed with others and a question about whether we really think this format is more readable. Julian -- ju...@be... Beta4 Productions (http://www.beta4.com) |