From: Glenn H. <ghe...@al...> - 2004-09-16 16:02:48
|
I'd like to make the error handler a bit more configurable. This would help me (and maybe others) with debugging changes. I generally enable $g_show_detailed_errors, $g_show_notices, and $g_show_warnings when testing code. This works well, but I'd like to get tracebacks, and variable information to localize the problems. Currently, I have my own copy of error_api with all of the errors handled by 'halt'ing to see the debug information. My proposal is to change the fixed mapping of the error type to display to an array lookup. The default would be: $g_display_errors = array( E_WARNING => 'inline', E_NOTICE => 'inline', E_USER_ERROR => 'halt', E_USER_WARNING => 'inline', E_USER_NOTICE => 'inline' ); By changing this in config_inc.php, one can simply adjust the error display. Comments? -- Glenn Henshaw Altera Ottawa Technology Center Phone: (613) 591-6702 Email: ghe...@al... |
From: Victor B. <vi...@fu...> - 2004-09-16 22:32:07
|
Hi Glenn, > $g_display_errors = array( > E_WARNING => 'inline', > E_NOTICE => 'inline', > E_USER_ERROR => 'halt', > E_USER_WARNING => 'inline', > E_USER_NOTICE => 'inline' > ); I totally agree with the need for your change. I sometimes had to edit error api to make it half on notices in order to show the stack trace. I think at least all developers should have all of the error set to 'halt'. Regards, Victor. |
From: Paul R. <gra...@bl...> - 2004-09-17 21:12:06
|
> Hi Glenn, > > > $g_display_errors = array( > > E_WARNING => 'inline', > > E_NOTICE => 'inline', > > E_USER_ERROR => 'halt', > > E_USER_WARNING => 'inline', > > E_USER_NOTICE => 'inline' > > ); > > I totally agree with the need for your change. I sometimes > had to edit error api to make it half on notices in order to > show the stack trace. > > I think at least all developers should have all of the error > set to 'halt'. I personally run stuff with a custom error_api when doing dev work i.e. halt instead of inline. However, I'd be against adding a "g_display_errors" setting, for the following reasons: A) normal users shouldn't need to customise halt vs inline B) a 'release' version should not generate errors which we can handle internally. C) atm (at least) the number of 'config' settings is quite complex already, without adding more variables. I think there should be a $g_developer type setting (which could, amongst other things turn on halt > inline, query debug etc), but I'm not sure that we should have a display_errors settings. It is a bug in mantis if a user gets an E_WARNING or E_NOTICE message no? Paul |