[Lxr-dev] [ lxr-Bugs-3510741 ] diff in 'many variables' context: incorrect versions

[SourceForge.net <no...@so...>]

Bugs item #3510741, was opened at 2012-03-24 01:07
Message generated for change (Comment added) made by ajlittoz
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=390117&aid=3510741&group_id=27350

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Browsing
Group: current cvs
>Status: Closed
>Resolution: Fixed
Priority: 7
Private: No
Submitted By: Andre-Littoz (ajlittoz)
Assigned to: Andre-Littoz (ajlittoz)
Summary: diff in 'many variables' context: incorrect versions

Initial Comment:
If a diff markup is requested in a context where many variables can be selected (e.g. kernel browsing with architectures and sub-architectures enabled), the "version" selection step does not hand over the correct variable name/value to diff.

The final name/value retained may well be totally irrevelant to the architecture under scrutiny.

As a side-improvement, use the 'when' attributes to limit the number of proposed choices (in the message, since only the "active" variables are displayed in the header).

----------------------------------------------------------------------

>Comment By: Andre-Littoz (ajlittoz)
Date: 2012-03-27 10:01

Message:
Fix to this bug involved a redesign of the way the request is submitted to
diff. Formely, two argument variables were used: _diffvar contained the
name of the variable to compare to and _diffval the value.

To be able to handle an indefinite number of variables, the full reference
set of values is passed as argument ~xx=value where xx is the name of the
variable. The target set is defined through xx=value (link insterface which
can provide only one variable) or !xx=value (buttons-and-menus interface
where any number of variables can be clicked).

As a side-effect, argument variables _file and _dir are no longer used
since the reference set ~xx and new sub unmappath allow to reverse the
effects of 'maps' before reapplying the rules with the new set xx and/or
!xx.

The new cleaner design removed the need for $incargs{} marker in the
templates since everything needed is already in urlargs{}.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=390117&aid=3510741&group_id=27350