[ jEdit-devel ] [ jedit-Patches-3614699 ] HTML mode: Fix mode properties in <script> blocks.

[SourceForge.net <no...@so...>]

Patches item #3614699, was opened at 2013-07-13 12:00
Message generated for change (Comment added) made by marchaefner
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300588&aid=3614699&group_id=588

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Marc Häfner (marchaefner)
>Assigned to: Dale Anson (daleanson)
Summary: HTML mode: Fix mode properties in <script> blocks.

Initial Comment:
Fix #3614631 by delegating to script modes, instead of just importing their rules.

The indentation rules for the script mode are only applied if (real) delegation is used. (Some relevant code can be found in JEditBuffer.getIndentRules)

This patch also shortens and simplifies the file nicely, but for the price of reintroducing a corner-case bug: Closing </script> tags may be consumed by script comments, which is inconsistent with the XML plugin and most browsers.

Given that it seems impossible to fix this (in a mode file) while using (real) delegation, I'd say that having correct script mode properties is preferable to not having this bug.

(Thanks to Matthieu Casanova for pointing in the right direction.)

----------------------------------------------------------------------

>Comment By: Marc Häfner (marchaefner)
Date: 2013-11-08 05:05

Message:
Added new version, that also includes a fix for #3615189. (Also renames
STRING ruleset to ATTRIBUTE and removes an outdated comment.)

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300588&aid=3614699&group_id=588