[ jEdit-devel ] [ jedit-Patches-3594021 ] Fix setScreenLineCount in ScreenLineManager

[SourceForge.net <no...@so...>]

Patches item #3594021, was opened at 2012-12-08 10:28
Message generated for change (Comment added) made by ezust
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300588&aid=3594021&group_id=588

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Thomas Meyer (thomasmey)
Assigned to: Nobody/Anonymous (nobody)
Summary: Fix setScreenLineCount in ScreenLineManager

Initial Comment:
Change the bit fiddling of the LSB to use the sign bit of the short type. This leaves one more bit for the line count.

----------------------------------------------------------------------

>Comment By: Alan Ezust (ezust)
Date: 2012-12-28 09:06

Message:
I don't understand the documentation comment on line 153 of
ScreenLineManager:

         * x == 0 -> invalid entry
	 * x >= 0 -> valid entries

Are you referring to the value of screenLines[x] ? what is x?


----------------------------------------------------------------------

Comment By: Thomas Meyer (thomasmey)
Date: 2012-12-12 12:15

Message:
New patch attached. Use a char type for the screen line number count. This
patch fixes bug 3590540.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300588&aid=3594021&group_id=588