From: SourceForge.net <no...@so...> - 2012-07-31 19:09:27
|
Bugs item #3522497, was opened at 2012-04-29 23:52 Message generated for change (Comment added) made by jarekczek You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100588&aid=3522497&group_id=588 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: search and replace Group: None >Status: Closed >Resolution: Fixed Priority: 5 Private: No Submitted By: Shlomy Reinstein (shlomy) >Assigned to: Jarek Czekalski (jarekczek) Summary: "Whole word" option does not work in Replace Initial Comment: Trying to replace all occurrences of "debug_client" with "DebugClient", when the "Whole word" option is selected in the Search&Replace dialog, causes also partial word replacements. E.g. both of the following were replaced: genericapi: debug_client genericapi_all: debug_client_all Note that in the 2nd line, debug_client does not appear as a whole word. I use latest SVN development version of jEdit. ---------------------------------------------------------------------- >Comment By: Jarek Czekalski (jarekczek) Date: 2012-07-31 12:09 Message: Fixed by Malathi's patch, r21965. Will be in 5.1 and probably in 5.0, if #3552742 gets merged. ---------------------------------------------------------------------- Comment By: Malathi () Date: 2012-07-13 06:38 Message: hey i submitted a patch to this error. https://sourceforge.net/tracker/?func=detail&aid=3543524&group_id=588&atid=300588 ---------------------------------------------------------------------- Comment By: Shlomy Reinstein (shlomy) Date: 2012-04-30 03:02 Message: Examining the code, I've noticed a recursion in BoyerMooreSearchMatcher.nextMatch method, when the "whole word" option is used but the match found is not a whole word. I think this recursion is risky, as the depth of the recursion depends on the buffer text. The recursion can easily be replaced with a loop (unless I miss something). It's not worth an item of its own, so I wrote that here, for whoever will check this bug. ---------------------------------------------------------------------- Comment By: Shlomy Reinstein (shlomy) Date: 2012-04-30 02:58 Message: I don't understand your comment. However, I think that Replace should be consistent with Search. Search with "Whole word" option does not find the 2nd line, but Replace does... ---------------------------------------------------------------------- Comment By: Jarek Czekalski (jarekczek) Date: 2012-04-30 02:14 Message: This regards only to extra "non word characters", as specified in props. I guess if you try to replace "ebu", nothing will get replaced. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100588&aid=3522497&group_id=588 |