Re: [ jEdit-devel ] [ jEdit-commits ] SF.net SVN: jedit:[21890] plugins/Console/trunk/console

[<sul...@gm...>]

In my opinion initial code was not safe, because this is not completed and  
invokes NullPointer Exceptions.

I could not remove this functionality: probably somebody uses it (I did  
not know how).
I did not want to fix this code: it seems old and probably nobody uses it.
And I only disabled this functionality and created tickets at the tracker.


Kazutoshi Satoda <k_s...@f2...> писал(а) в своём письме Sat, 30  
Jun 2012 20:56:19 +0300:

> sy...@us... wrote:
>> Revision: 21890
>>            http://jedit.svn.sourceforge.net/jedit/?rev=21890&view=rev
>> Author:   synh
>> Date:     2012-06-30 10:03:36 +0000 (Sat, 30 Jun 2012)
>> Log Message:
>> -----------
>> #3539123 - Console: NPE when command starts in background.
>
>> -		if (foreground)
>> -		{
>> +		//if (foreground)
>> +		//{
>>   			this.output = output;
>>   			this.error = new ErrorOutput(console);
>>   			this.consoleState = consoleState;
>> -		}
>> +		//}
>
> Please remove them, or leave more comment why the code should be left as
> such.
>

-- 
Best regards, Artem Bryantsev