[ jEdit-devel ] [ jedit-Plugin Bugs-3493305 ] ProjectViewer ImportFilters list

[SourceForge.net <no...@so...>]

Plugin Bugs item #3493305, was opened at 2012-02-24 10:01
Message generated for change (Comment added) made by ezust
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=565475&aid=3493305&group_id=588

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Project Viewer
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Alan Ezust (ezust)
Assigned to: Jarek Czekalski (jarekczek)
Summary: ProjectViewer ImportFilters list

Initial Comment:
If I select "Subversion" as my version control service, and re-import my project, I see ALL of the other import filters,  as well as the SVN entries filter listed TWICE in my list of import filters (on re-import). 

I think it should ONLY show me the SVN entries filter and none of the others.






----------------------------------------------------------------------

>Comment By: Alan Ezust (ezust)
Date: 2012-03-11 12:09

Message:
At the very least, there should not be a duplicate entry in that list.
I am not 100% sure about removing all the other choices. But the duplicate
entry is definitely a bug.


----------------------------------------------------------------------

Comment By: Jarek Czekalski (jarekczek)
Date: 2012-03-11 11:29

Message:
I found missing docs. It's a commit message from
65d3c119ff88c559b4b3dad408c52c4ba6b3acfb

Allow VersionControlService to specify a file filter.
    
    Instead of having VC-specific file filters always show up (for lack
    of a better mechanism), allow the VersionControlService instance to
    provide a file filter instance if it wants to. This filter will only
    show up if the service is the one associated with the project on
    which action is being taken.

It means this should be solved on SVN plugin side. On PV side it should be
stated in javadoc for getFilter method. Would you agree Alan?

----------------------------------------------------------------------

Comment By: Jarek Czekalski (jarekczek)
Date: 2012-03-11 10:47

Message:
We really lack documentation here. SVN registers a filter as a service.
Looks like getFilter() method is redundant here.

I could write a plugin implementing a "better" importing filter for svn
projects. I would like to be able to use this "better" filter. In my
scenario I could choose it. In yours - I would not be allowed to do it. If
we take such freedom from the user, I really would like to know: why?

What could be that "better" filter? A filter which knows to omit all ".svn"
entries, but allowing to choose only a part of files from the tree, like
only java files.

----------------------------------------------------------------------

Comment By: Jarek Czekalski (jarekczek)
Date: 2012-03-11 10:24

Message:
Alan, I found a comment in projectviewer/importer/ImportUtils.getFilters:

Check if there's a version control-specific filter to *add* to the list for
the current project.

So we are changing Marcelo's intentions. Do we really want to do it? Sorry
for questioning again, but it's not my project and I don't know who should
I listen to, when there are different voices.

By the way: thanks for pointing to getFilter method. It allowed me to
quickly find the right place.

----------------------------------------------------------------------

Comment By: Jarek Czekalski (jarekczek)
Date: 2012-03-06 07:48

Message:
I still don't get the need of removing other options, but I'll do as you
reqest.

----------------------------------------------------------------------

Comment By: Alan Ezust (ezust)
Date: 2012-03-06 00:36

Message:
In answer to your questions.
1. Yes.
2. You can choose the version control service when you create the project
initially.  Or under teh Project: option pane. 
    See VersionControlState, method  public ImporterFileFilter getFilter()

3. Yes, I don't see the point of using a custom filter if you select a
version control service (which is not the same thing as selecting an import
filter).


----------------------------------------------------------------------

Comment By: Jarek Czekalski (jarekczek)
Date: 2012-02-25 01:34

Message:
Alan, why should it show you only "SVN entries filter". Because you chose
the version control? I don't know what's the version control. Nothing about
it in docs. Do you have an idea on what basis a version control could be
connected with a given import filter?

Another question. If other filters are missing, one will not be able to
import using a custom filter. Is this what you request?

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=565475&aid=3493305&group_id=588