From: SourceForge.net <no...@so...> - 2012-02-04 10:03:40
|
Plugin Patches item #3483876, was opened at 2012-02-03 06:05 Message generated for change (Comment added) made by jarekczek You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=997937&aid=3483876&group_id=588 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None >Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: jsot (jsot) Assigned to: Nobody/Anonymous (nobody) Summary: Whitespace plugin: Menu item for showing all whitespace Initial Comment: Enable showing of all whitespace characters as one item in plugin menu. Why one? Because then it be can switched on/off with one click/shortcut. Patch is against sources from http://prdownloads.sourceforge.net/jedit-plugins/WhiteSpace-1.0.1.zip because I didn't find sources in Git repo ---------------------------------------------------------------------- >Comment By: Jarek Czekalski (jarekczek) Date: 2012-02-04 02:03 Message: The feature sounds reasonable. About the assignment, thanks for pointing in right direction :) The description for the tracker was misleading. I changed it. ---------------------------------------------------------------------- Comment By: jsot (jsot) Date: 2012-02-04 01:07 Message: @feature: It's not the same. Proposed change also works for tabs (leading, inner, trailing) and other whitespace. So with single menu action you are able to switch on/off display of all whitespace characters - spaces, tabs and other whitespace. Just like it works in Eclipse for example. In the current state you have to use three menu action to get the same result: Show space, Show tabs, Show other whitespace @trunk: Aha, I somehow assumed that the same code would be in git repo. Thanks for the push in right direction. I'll make patch against svn trunk then. @assign to nathan: I'm not sure at all. I just don't know how it goes here so I assigned it to nathan as one of the authors. I will change it to "nobody" as suggested. ---------------------------------------------------------------------- Comment By: Jarek Czekalski (jarekczek) Date: 2012-02-03 11:55 Message: Significant interface changes have been done recently. They were only in svn: https://jedit.svn.sourceforge.net/svnroot/jedit/plugins/WhiteSpace/trunk You reminded me that these changes were staying in repository too long, so I applied for Whitespace 1.0.2 release. Seems to me that the change you suggest is not necessary. After you check leading, inner and trailing spaces you are able to switch it on and off with a single menu action. Isn't it the same? Anyway, patches must be made against trunk, at least in a case when the code changed. Are you sure nathanjones will take care of the patch? It's better to leave "nobody". ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=997937&aid=3483876&group_id=588 |