Menu
▾
▴
[ jEdit-devel ] [ jedit-Patches-3169868 ] patch for ID: 3136329
|
From: SourceForge.net <no...@so...> - 2011-08-30 05:57:33
|
Patches item #3169868, was opened at 2011-02-01 10:21 Message generated for change (Comment added) made by ezust You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300588&aid=3169868&group_id=588 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Pending >Resolution: Rejected Priority: 5 Private: No Submitted By: Greg Knittl (gknittl) Assigned to: Alan Ezust (ezust) Summary: patch for ID: 3136329 Initial Comment: This is the patch for ID: 3136329 no caret connecting to an existing file with -reuseview The trunk EditServer has additional code to try and bring jEdit to the foreground just after code this patch changes. On Ubuntu 10.04 this new code just flashes jEdit briefly but doesn't bring jEdit to the foreground. Conversely I hope that my patch doesn't affect Windows users and would encourage someone running Windows to test this. ---------------------------------------------------------------------- >Comment By: Alan Ezust (ezust) Date: 2011-08-29 22:57 Message: There is another issue that the jEdit window does not get raised to the top of the screen in reuseview from linux... That is quite annoying to me also. Your patch doesn't solve the issue described in 3136329, so I am not sure what it is supposed to do. I am marking it as rejected, but feel free to make another stab at it and I will review it. ---------------------------------------------------------------------- Comment By: Alan Ezust (ezust) Date: 2011-08-29 22:54 Message: I am testing this patch and I can still see the caret disappears when I do a jedit -reuseview on debian with a file that is already open in jEdit, so i am not sure if it is complete yet. ---------------------------------------------------------------------- Comment By: Alan Ezust (ezust) Date: 2011-08-29 13:40 Message: Shlomy please review? ---------------------------------------------------------------------- Comment By: Greg Knittl (gknittl) Date: 2011-02-08 09:11 Message: I've updated the patch to remove the changes to EditServer. Explanation in ID: 3136329. This is now hopefully a low risk patch. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300588&aid=3169868&group_id=588 |