Menu
▾
▴
[ jEdit-devel ] [ jedit-Patches-1969434 ] Added JSON functions into PHP.xml
|
From: SourceForge.net <no...@so...> - 2010-06-08 03:47:17
|
Patches item #1969434, was opened at 2008-05-22 01:51 Message generated for change (Comment added) made by ezust You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300588&aid=1969434&group_id=588 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Voituk Vadim (voituk) Assigned to: Nobody/Anonymous (nobody) Summary: Added JSON functions into PHP.xml Initial Comment: Please look in attachment. ---------------------------------------------------------------------- >Comment By: Alan Ezust (ezust) Date: 2010-06-07 20:47 Message: oops! Commented in wrong tab so ignore previous comment about the errors. I looked quickly at this new mode file. It is HUGE! the 2nd largest mode file in the directory. And since i don't use PHP, I want a 2nd person who uses PHP to test this and give it the go-ahead that it works better than the old mode for regular PHP users. Any volunteers? ---------------------------------------------------------------------- Comment By: Alan Ezust (ezust) Date: 2010-06-07 20:42 Message: Sorry, ignore previous comment, I was working in the wrong directory. There are 2 errors in this mode file: <MARK_PREVIOUS EXCLUDE_MATCH="FALSE" TYPE="KEYWORD3">=</MARK_PREVIOUS> <MARK_PREVIOUS EXCLUDE_MATCH="FALSE" TYPE="KEYWORD3">:</MARK_PREVIOUS> Attribute EXCLUDE_MATCH must be declared forf element MARK_PREVIOUS So this mode file needs to be updated to jEdit 4.3 ---------------------------------------------------------------------- Comment By: Dale Anson (daleanson) Date: 2010-06-07 19:36 Message: I'm not sure who should look at this from a php perspective, but it's not me. As far as the json stuff goes, the new json mode that I added deals with json files, as in those described at www.json.org. It looks like this php mode has some code to deal with php functions that would handle json files, so there is nothing to delegate that I can see. ---------------------------------------------------------------------- Comment By: Alan Ezust (ezust) Date: 2010-06-07 15:43 Message: This is a major change to the PHP edit mode, so I want someone else to review it. Also, we just added a json edit mode so perhaps we can delegate to that instead of adding json to php? [correct me if I am wrong, I don't know anything about json]. ---------------------------------------------------------------------- Comment By: Voituk Vadim (voituk) Date: 2008-05-22 01:51 Message: Logged In: YES user_id=1014847 Originator: YES File Added: php.xml ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300588&aid=1969434&group_id=588 |