From: Kazutoshi S. <k_s...@f2...> - 2010-04-15 16:15:36
|
Dale Anson wrote: > On Wed, Apr 14, 2010 at 5:19 AM, Kazutoshi Satoda<k_s...@f2...>wrote: >> Obviously, there was something wrong with encoding on your local. > Hmm, that is odd. Could you please fix them? >> Did you check the diff before commit? Have you subscribed to jedit-commits? > > Yes, and yes. Then why you dared to proceed the commit? >> public void setProperty(String key, Object value) >>> { >>> + String prefix = "mode." + name + '.'; >>> + jEdit.setProperty(prefix + key, value.toString()); >>> props.put(key,value); >>> } //}}} (snip) > The EditingOptionPane sets these properties as jEdit properties. Once set, > they need to be able to be set/unset when the mode file is edited and > reloaded. Is it a new feature? If not, where it was done before? >>> Modified: jEdit/trunk/org/gjt/sp/jedit/ModeCatalogHandler.java >> >> Comparing the resulting state against r12504 (the state which was before >> your fix), I can't see any change of behavior there. >> >> http://jedit.svn.sourceforge.net/viewvc/jedit/jEdit/trunk/org/gjt/sp/jedit/ModeCatalogHandler.java?r1=17631&r2=12504&pathrev=17631 >> >> But there is an entry about a change of behavior of ModeCatalogHandler, in >> CHANGES.txt. >> >> It seems that either ModeCatalogHandler.java or CHANGES.txt is wrong. How about this part? >> Modified: jEdit/trunk/org/gjt/sp/jedit/syntax/ModeProvider.java (snip) >> Because of this change, the resulting priority is reversed. I this this >> is not intended. > No, this is correct. Previously, the order here was important because a > List was being used. The List could have contained duplicates, so reading > the list in reverse order ensured the user mode was found first. This > change uses a map, so there are no longer duplicates. The loading of the > modes in jEdit.java loads global modes first, the user modes second, so user > modes replace global modes in the map. The order is still important for the final case where "..., so just return the first one". I have used some user modes which have filename globs included in the global (bundled) modes. They are prioritized, as I expected, before this change. -- k_satoda |